Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:  karsten  |Sponsor:
-+
Changes (by irl):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 For this ticket then, all is done. Remaining tasks are on #23518.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+-
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:  karsten  |Sponsor:
-+-
Changes (by karsten):

 * status:  needs_review => merge_ready


Comment:

 Merged and deployed! I also updated the link on the Services page. Is
 there anything else I should do? Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by irl):

 * status:  needs_revision => needs_review


Comment:

 Cool. I have merged the changes for Relay Search to master, updated the
 git submodule location, and rebased. This should now be ready for merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:  karsten  |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 irl]:
 > Please review my branches [[https://gitweb.torproject.org/user/irl
 /metrics-web.git/log/?h=task/25258|task/25258]] for metrics-web

 Looks good!

 > and
 
[[https://gitweb.torproject.org/user/irl/atlas.git/log/?h=task/25258|task/25258]]
 for Relay Search.

 Looks good, as far as I can tell.

 > This includes the changes from #25255 but does not include the changes
 for #25254 (so tooltips on SVGs will not be in the correct place
 currently).

 Including #25255 here sounds good. #25254 is merged by now.

 > Before merging to metrics-web the Relay Search branch should be merged
 and then the submodule in metrics-web updated to point to the primary
 repository, not my personal repository.

 Do you want to rebase your metrics-web branch to current master and change
 the submodule definition to point to the official repository? I can hold
 off pushing anything to metrics-web master for, say, 24 hours. Setting to
 needs_revision for these small changes only.

 > Relay Search is available at:
 >
 > http://localhost:8080/rs.html

 I didn't test it now, but the commits reads fine. I'll just assume you
 tested it, and if anything comes up after merging/deploying, we can fix
 that quickly.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by karsten):

 * reviewer:   => karsten


Comment:

 I'll take a look.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  accepted => needs_review
 * cc: metrics-team (added)


Comment:

 Please review my branches [[https://gitweb.torproject.org/user/irl
 /metrics-web.git/log/?h=task/25258|task/25258]] for metrics-web and
 
[[https://gitweb.torproject.org/user/irl/atlas.git/log/?h=task/25258|task/25258]]
 for Relay Search. This includes the changes from #25255 but does not
 include the changes for #25254 (so tooltips on SVGs will not be in the
 correct place currently).

 Before merging to metrics-web the Relay Search branch should be merged and
 then the submodule in metrics-web updated to point to the primary
 repository, not my personal repository.

 Relay Search is available at:

 http://localhost:8080/rs.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  new => accepted
 * owner:  metrics-team => irl


Comment:

 Looking at this now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

[Tor Bug Tracker & Wiki]

#25258: Include Relay Search in metrics-web
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * parent:   => #23518


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs