Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

[Tor Bug Tracker & Wiki]

#25399: mmap length doesn't need to be page-aligned
-+
 Reporter:  Hello71  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  review-group-34  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  ahf  |Sponsor:
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 okay; merging this to master.  I wonder if any of the mingw workarounds
 are still needed, but I guess we'll find out soon :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

[Tor Bug Tracker & Wiki]

#25399: mmap length doesn't need to be page-aligned
-+
 Reporter:  Hello71  |  Owner:  (none)
 Type:  defect   | Status:  merge_ready
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-34  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  ahf  |Sponsor:
-+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 As far as I can tell this looks good. Even the man pages mentions that
 `getpagesize()` is deprecated and `sysconf(_SC_PAGESIZE)` should be used
 instead.

 The interesting part from POSIX:

 {{{
 The off argument is constrained to be aligned and sized according to the
 value
 returned by sysconf() when passed _SC_PAGESIZE or _SC_PAGE_SIZE. When
 MAP_FIXED
 is specified, the argument addr must also meet these constraints. The
 implementation performs mapping operations over whole pages. Thus, while
 the
 argument len need not meet a size or alignment constraint, the
 implementation
 will include, in any mapping operation, any partial page specified by the
 range
 [pa, pa + len).
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

[Tor Bug Tracker & Wiki]

#25399: mmap length doesn't need to be page-aligned
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by Hello71):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

[Tor Bug Tracker & Wiki]

#25399: mmap length doesn't need to be page-aligned
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by Hello71):

 https://cgit.alxu.ca/tor.git/commit/?h=bug25399

 removes cruft, very slightly increases performance.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

[Tor Bug Tracker & Wiki]

#25399: mmap length doesn't need to be page-aligned
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * points:   => 0.5
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 Can you explain how this bug affects Tor?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs