Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  closed
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:  implemented
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer:  asn|Sponsor:
---+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 seems fine to me too.  merging to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  merge_ready
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer:  asn|Sponsor:
---+

Comment (by valentecaio):

 Thanks for the revision and the remarks, asn! I will mind this when
 working on future tickets.
 Have a nice day.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  merge_ready
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM! I pushed branch `t-25432` in my github repo (github.com/asn-d6/tor)
 with some basic fixes on the changefile, but other than that it's good!

 Just as a future suggestion, valentecaio, I would ideally make multiple
 commits for such a refactoring project to make review easier. In
 particular, here is how I would structure my branch so that it's easier
 for the reviewer:
 {{{
 Commit A: Refactor the 4 groupA functions into groupB.
 Commit B: Refactor directory_remove_invalid() to use router_describe().
 Commit C: Misc improvements (move NODE_DESC_BUF_LEN, add docs, etc.)
 }}}

 All in all, this was a good refactoring! Thanks for the code! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  needs_review
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer:  asn|Sponsor:
---+

Comment (by asn):

 I plan to review this tomorrow. Thanks for the code! :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  needs_review
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer:  asn|Sponsor:
---+
Changes (by dgoulet):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  needs_review
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by valentecaio):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  assigned
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by valentecaio):

 Ok!

 It's done. Please check it on this branch:
 https://github.com/valentecaio/torproject-tor/tree/t-25432

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  assigned
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 That plan seems reasonable to me, if the situation is the way you describe
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  assigned
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by valentecaio):

 Since each group A function would only be used once, by the respective
 group B function, I suggest that we suppress the group A.

 So, I would do the following:

 1- remove group A functions from header file.
 2- merge group A functions into group B functions (remove declarations of
 group A functions).
 3- remove format_node_description() declaration from header file.
 4- move NODE_DESC_BUF_LEN constant from header to source file.
 5- replace the external call (there is only one) to
 router_get_description() by a call to router_describe().

 What do you think about this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

[Tor Bug Tracker & Wiki]

#25432: remove router.c internal functions from router.h
---+
 Reporter:  valentecaio|  Owner:  valentecaio
 Type:  enhancement| Status:  assigned
 Priority:  Low|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Minor  | Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * version:  Tor: unspecified =>
 * component:  Core Tor => Core Tor/Tor
 * milestone:   => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs