Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:  closed
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  anti-censorship-roadmap-august,  |  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * keywords:  anti-censorship-roadmap-august => anti-censorship-roadmap-
 august, TorBrowserTeam201909R
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Alright, looks good now. I cherry-picked the commits to `tor-browser-
 build`'s `master` (commits 273e09799eb5b39f498de866a327c2c7b173b304,
 4ff2be0b02e322716f06829e49c50f39795bf43c, and
 52ebafd72bdbbd713d080a5a5828fefd2c6cf0d7) and added a reference to this
 ticket so it's easier to find the larger context if needed.

 All of this work will be available in 9.0a7 which is scheduled for next
 week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  project | Status:  needs_review
 Priority:  High|  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by cohosh):

 * status:  needs_revision => needs_review


Comment:

 Sorry about that, I went with the default appended squash messages.

 I applied the changes you mentioned. This should be cleaner:
 https://github.com/cohosh/tor-browser-build/compare/pion_squashedv2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  project | Status:
|  needs_revision
 Priority:  High|  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Okay, thanks. Let's look a bit closer now:

 commit 00ac64fb26121858a8e8fa0a6332508f0ae9fbdf

 The change in the `goxnet` project is
 {{{
 -git_hash: ed066c81e75eba56dd9bd2139ade88125b855585
 +git_hash: da137c7871d7
 }}}
 Could we get here the full hash here again? (Same goes for `goxsys`)

 Could you change the commit message so it shows what you are actually
 doing? Right now it is quite confusing and not really matching what is
 happening in the commit.

 commit 3ce20d5c5e013fb6e60492eb7fa601e36ca20098

 I think
 {{{
 -targets:
 -  linux-i686:
 -var:
 -  arch_deps:
 -- pkg-config
 -- libx11-dev:i386
 -  linux-x86_64:
 -var:
 -  arch_deps:
 -- pkg-config
 -- libx11-dev
 -  osx-x86_64:
 -var:
 -  arch_deps:
 -- pkg-config
 -- faketime
 }}}
 should already be in that commit, no? I mean that target clean-up is not
 needed just because you are removing the old WebRTC related projects but
 because you are switching snowflake over to `pion`.

 Please look over the commit message here again. There are redundancies in
 it.

 commit 3b96850779b25174429d15f2c301df6a2517ebd4

 see comment for previous comment "arch_deps no longer required for
 snowflake." needs to get moved to the previous commit's commit message,
 too, if you want to keep it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  project | Status:  needs_review
 Priority:  High|  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by cohosh):

 * status:  needs_revision => needs_review


Comment:

 Thanks! Here's a branch with squashed commits: https://github.com/cohosh
 /tor-browser-build/compare/pion-squashed

 I also made the change you suggested above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
+--
 Reporter:  arlolra |  Owner:  cohosh
 Type:  project | Status:
|  needs_revision
 Priority:  High|  Milestone:
Component:  Circumvention/Snowflake |Version:
 Severity:  Normal  | Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  #19001  | Points:
 Reviewer:  |Sponsor:
|  Sponsor28-must
+--
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam201909R, anti-censorship-roadmap-august => anti-
 censorship-roadmap-august


Comment:

 Okay, I looked over the changes. Overall, they are good, thanks! I get
 everything built and it's reproducible on all platforms on different
 machines. Nice work!

 I have one small thing an one request:

 Please squash the commits into fewer ones. I think it's reasonable to have
 essentially three commits: one for adding all the new
 dependencies/projects, one for making sure the snowflake projects gets
 adapted and it's available on Windows as well and finally one where all
 the old WebRTC related projects/code/documentation etc. gets removed.

 In commit 40d3220d300bd7c394b152becec73fbb77c3f6dd you have
 {{{
 -[% IF c("var/linux") || c("var/osx") -%]
 +[% IF c("var/linux") || c("var/osx") || c("var/windows") -%]
 }}}
 You can remove the whole IF-clause as Android is not using `build` but has
 its own script (`build.android` in `projects/tor-browser`).

 Regarding providing snowflake on Android, we probably need a different
 approach anyway, so #31293 is not so much an issue for that. We'll likely
 pick the work up in #28672 and #30318 again after we are good here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, anti- |  Actual Points:
  censorship-roadmap-august  |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by cohosh):

 Replying to [comment:65 gk]:
 > {{{
 > ./rbm/rbm build snowflake --target nightly --target torbrowser-
 linux-i686
 > Error: Cannot checkout e5040c70f9a4d8e47ed9e37b2f0c944859a9c56c:
 > fatal: reference is not a tree: e5040c70f9a4d8e47ed9e37b2f0c944859a9c56c
 > }}}
 > I don't mark this as `needs_revision` as I suspect you just forgot to
 commit something to your snowflake repo, right? If not, please make the
 necessary changes on the `tor-browser-build` side.

 Thanks, we did a rebase of that branch so that commit hash might not be
 valid. I updated the branch with a new commit hash.

 Note that this branch hasn't been merged to master yet (it's pending a
 review of #28942) so we'll want to update that hash again before we merge
 these changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, anti- |  Actual Points:
  censorship-roadmap-august  |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201805, anti-censorship-roadmap-august =>
 TorBrowserTeam201909R, anti-censorship-roadmap-august


Comment:

 {{{
 ./rbm/rbm build snowflake --target nightly --target torbrowser-linux-i686
 Error: Cannot checkout e5040c70f9a4d8e47ed9e37b2f0c944859a9c56c:
 fatal: reference is not a tree: e5040c70f9a4d8e47ed9e37b2f0c944859a9c56c
 }}}
 I don't mark this as `needs_revision` as I suspect you just forgot to
 commit something to your snowflake repo, right? If not, please make the
 necessary changes on the `tor-browser-build` side.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, anti-  |  Actual Points:
  censorship-roadmap-august  |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by cypherpunks):

 Go 1.13:
 > The Windows version specified by internally-linked Windows binaries is
 now Windows 7 rather than NT 4.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, anti-  |  Actual Points:
  censorship-roadmap-august  |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  accepted => needs_review


Comment:

 This build is now working as of
 https://trac.torproject.org/projects/tor/ticket/28942#comment:59

 I just added an extra commit on top of dcf's branch to bump the version of
 webrtc so we have the upstream fixes: https://github.com/cohosh/tor-
 browser-build/compare/pion2

 I haven't gotten it built on android yet due to #31293 but here are the
 sha256 sums for the rest of it:
 {{{
 f3fadbac79c94e22eacb5902582bec5dbd303862768fc07c8d4f1bba469a8c5c  tor-
 browser-9.0a4-windows-x86_64-264573/mar-tools-win64.zip
 ed2a538d8e4b1aecc555e6b1683a93f4096184015549ed9992526b43759f0c9c  tor-
 browser-9.0a4-windows-x86_64-264573/torbrowser-install-win64-9.0a4_en-
 US.exe

 7d5a8353bde39d0bafb40d9c03eb4f2b28cddd8306bf429e811f1caa9435189c  tor-
 browser-9.0a4-windows-i686-a3fd1d/mar-tools-win32.zip
 27bee134cf8f4c700729c6d4662bee2c23db3ddf27164e878592091e9c5d6fc8  tor-
 browser-9.0a4-windows-i686-a3fd1d/torbrowser-install-9.0a4_en-US.exe

 659e4e31ac2875ff24f667040f13a93caaddf2be73a742229bc64c6552af55dd  tor-
 browser-9.0a4-osx-x86_64-e53cb5/mar-tools-mac64.zip
 aaf162ecc77e214c04ce78c4eb68ed2f7d239efbc6ad61daeb8af9f9e8d41018  tor-
 browser-9.0a4-osx-x86_64-e53cb5/TorBrowser-9.0a4-osx64_en-US.dmg

 a95656c0a1d220f51ebb7c02264ca14a6dfcaf1f49f9c1eb2b100b8912202fbb  tor-
 browser-9.0a4-linux-x86_64-377cf5/mar-tools-linux64.zip
 313467567d9f85b11f9fc075f2a450d0fa5daa575a17635a0852fbdecbe7163f  tor-
 browser-9.0a4-linux-x86_64-377cf5/tor-browser-linux64-9.0a4_en-US.tar.xz
 f2e28bd473b7fc21dc3a4ce0b1c4931de1cc2bbba643cb790a94cd23b5f8a44f  tor-
 browser-9.0a4-linux-x86_64-377cf5/tor-browser-linux64-debug.tar.xz
 05be2469134ab700ff06a464eaef4c5ae95252810158c6490ab1830d65c1e5df  tor-
 browser-9.0a4-linux-x86_64-377cf5/tor-linux64-debug.tar.xz

 3c44f8039334230540ca09eeea7b478eb6d2b94186b4f15f65b39d5b5afa8654  tor-
 browser-9.0a4-linux-i686-4e5c2e/mar-tools-linux32.zip
 b154ec37b41f515a4618a4f2602c5fca082e7cbeb8c14ef6cc85788c156cd200  tor-
 browser-9.0a4-linux-i686-4e5c2e/tor-browser-linux32-9.0a4_en-US.tar.xz
 08d05d0573f41f55d95bcca4c61374491469ddde220ddd51d9f32e754c395a16  tor-
 browser-9.0a4-linux-i686-4e5c2e/tor-browser-linux32-debug.tar.xz
 0261e8109dc380f197a24e3e4799182916a060065a97bf66926f7e3f01a0523b  tor-
 browser-9.0a4-linux-i686-4e5c2e/tor-linux32-debug.tar.xz
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, anti-  |  Actual Points:
  censorship-roadmap-august  |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gaba):

 * cc: cohosh (added)
 * sponsor:  Sponsor28-can => Sponsor28-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, anti-  |  Actual Points:
  censorship-roadmap-august  |
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-can
-+-
Changes (by gaba):

 * keywords:  TorBrowserTeam201805, ex-sponsor-19, anti-censorship-roadmap
 => TorBrowserTeam201805, anti-censorship-roadmap-august


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, ex-|  Actual Points:
  sponsor-19, anti-censorship-roadmap|
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-can
-+-

Comment (by cmm323):

 Replying to [comment:55 cohosh]:
 > Okay I've been trying to use libc++ with mingw-w6 as described
 [https://libcxx.llvm.org/docs/UsingLibcxx.html#using-libc-on-linux here]
 but I can't get it to work. I'm not even sure it will solve all of the
 linking problems.
 >
 > It looks like there are three paths forward from here:
 > 1. Write C wrappers as described in comment:39, or
 The wrapper already exists: https://github.com/asicerik/go-webrtc

 The issue is that it should be build with the right toolchain (probably
 the same toolchain used to build `webrtc`) so that it can be linked with
 `webrtc` library.


 > 2. Find a different webrtc library

 There's a golang implementation of WebRTC here :
 https://github.com/pion/webrtc

 Wondering if we can replace the implementation we are using with this one?

 > 3. Get CGO to compile with mingw-w64/clang on windows

 As you mentioned, these issues have not been fixed in golang. This one is
 also related: https://github.com/golang/go/issues/20982

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, ex-|  Actual Points:
  sponsor-19, anti-censorship-roadmap|
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-can
-+-
Changes (by gaba):

 * keywords:  TorBrowserTeam201805, ex-sponsor-19 => TorBrowserTeam201805,
 ex-sponsor-19, anti-censorship-roadmap


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, ex-sponsor-19  |  Actual Points:
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-can
-+-

Comment (by cohosh):

 Ah I looked in the $GOPATH and it turns out these missing libraries are
 also mentioned in
 {{{
 Binary file ./dist/webrtc/lib/libwebrtc-windows-amd64-magic.lib matches
 }}}
 which is why we need them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, ex-sponsor-19  |  Actual Points:
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-can
-+-

Comment (by cohosh):

 I'm currently looking at compiling go-webrtc with mingw-w64/clang and I'm
 getting the following linking error:
 {{{
 # github.com/keroserene/go-webrtc
 lld-link: error: could not open liblibcmtd.a: No such file or directory
 lld-link: error: could not open liboldnames.a: No such file or directory
 lld-link: error: could not open liblibcpmtd.a: No such file or directory
 clang-8: error: linker command failed with exit code 1 (use -v to see
 invocation)
 }}}
 It looks like we're trying to link some windows sdk libraries we don't
 have. But upon searching for these libraries, the only references I can
 find are in the following files:
 {{{
 $ grep -r "oldnames" .
 Binary file ./mingw-w64-clang/bin/clang-refactor matches
 Binary file ./mingw-w64-clang/bin/x86_64-w64-mingw32-widl matches
 Binary file ./mingw-w64-clang/bin/clang-rename matches
 Binary file ./mingw-w64-clang/bin/clang-check matches
 Binary file ./mingw-w64-clang/bin/clang-8 matches
 Binary file ./mingw-w64-clang/bin/diagtool matches
 Binary file ./mingw-w64-clang/bin/c-index-test matches
 Binary file ./mingw-w64-clang/bin/clang-func-mapping matches
 Binary file ./mingw-w64-clang/lib/libclang.so.8 matches
 Binary file ./mingw-w64-clang/lib/libclangDriver.a matches
 }}}
 with lines like {{{--dependent-lib=oldnames}}}.

 Is this a bug in mingw-w64/clang? I can't find `oldnames.a` anywhere,
 though found `oldnames.lib` in the project `win_sdk`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+-
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:
 |  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805, ex-sponsor-19  |  Actual Points:
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by cohosh):

 Okay I've been trying to use libc++ with mingw-w6 as described
 [https://libcxx.llvm.org/docs/UsingLibcxx.html#using-libc-on-linux here]
 but I can't get it to work. I'm not even sure it will solve all of the
 linking problems.

 It looks like there are two main paths forward from here:
 1. Write C wrappers as described in comment:39, or
 2. Find a different webrtc library

 Both of these look like a significant amount of work. For (1) we'd have to
 write a wrapper for webrtc and for (2) it's possible that we'd have to
 rewrite a lot of go-webrtc.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+---
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805 |  Actual Points:
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+---

Comment (by cohosh):

 Okay I successfully compile libwebrtc with mingw-clang:
 https://github.com/cohosh/tor-browser-
 build/commit/565b482c9dcc35eefe6313938155898e93abed51

 Unfortunately I'm getting the same linking errors:
 {{{
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 /b001/_x006.o:ctestenums.cc:(.text+0x5b8): undefined reference to
 `cricket::AudioCodec::ToString() co
 nst'
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 /b001/_x006.o:ctestenums.cc:(.text+0x70b): undefined reference to
 `webrtc::RtpExtension::ToString() c
 onst'
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 /b001/_x006.o:ctestenums.cc:(.text+0x85e): undefined reference to
 `cricket::DataCodec::ToString() con
 st'
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 /b001/_x006.o:ctestenums.cc:(.text+0x956): undefined reference to
 `rtc::FatalMessage::FatalMessage(ch
 ar const*, int)'
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 /b001/_x006.o:ctestenums.cc:(.text+0x9d7): undefined reference to
 `rtc::FatalMessage::~FatalMessage()
 '
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 /b001/_x006.o:ctestenums.cc:(.text+0xa85): undefined reference to
 `rtc::FatalMessage::~FatalMessage()
 '
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 /b001/_x006.o:ctestenums.cc:(.text+0xc69): undefined reference to
 `rtc::FatalMessage::FatalMessage(ch
 ar const*, int)'
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+---
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805 |  Actual Points:
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+---

Comment (by cohosh):

 Replying to [comment:51 cohosh]:
 > Replying to [comment:50 cohosh]:
 > >
 > > I'm currently getting some new build errors in WebRTC:
 > > {{{
 > >
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 > >
 
/b001/_x008.o:peerconnection.cc:(.rdata$.refptr._ZN6webrtc25MediaConstraintsInterface15kEnableDtlsSrt
 > >
 pE[.refptr._ZN6webrtc25MediaConstraintsInterface15kEnableDtlsSrtpE]+0x0):
 undefined reference to `web
 > > rtc::MediaConstraintsInterface::kEnableDtlsSrtp'
 > > collect2: error: ld returned 1 exit status
 > > # github.com/keroserene/go-webrtc
 > > In file included from ./include/rtc_base/win32.h:42:0,
 > >  from ./include/rtc_base/event.h:16,
 > >  from ./include/rtc_base/thread.h:25,
 > >  from ./include/api/mediastreaminterface.h:36,
 > >  from ./include/api/dtmfsenderinterface.h:16,
 > >  from ./include/api/peerconnectioninterface.h:78,
 > >  from ctestenums.cc:2:
 > > ./include/rtc_base/stringutils.h:22:0: warning: "alloca" redefined
 > >  #define alloca _alloca
 > > }}}
 > It looks like `libwebrtc-windows-amd64-magic.lib` has a bunch of
 references to things like
 `rtc::MediaConstraintsInterface::kEnableDtlsSrtp` but they aren't in the
 include files...

 Nvm, this is the same linking error as comment:24 above ^_^. So the rebase
 brought us back to where we were before.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+---
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805 |  Actual Points:
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+---

Comment (by cohosh):

 Replying to [comment:50 cohosh]:
 >
 > I'm currently getting some new build errors in WebRTC:
 > {{{
 >
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 >
 
/b001/_x008.o:peerconnection.cc:(.rdata$.refptr._ZN6webrtc25MediaConstraintsInterface15kEnableDtlsSrt
 >
 pE[.refptr._ZN6webrtc25MediaConstraintsInterface15kEnableDtlsSrtpE]+0x0):
 undefined reference to `web
 > rtc::MediaConstraintsInterface::kEnableDtlsSrtp'
 > collect2: error: ld returned 1 exit status
 > # github.com/keroserene/go-webrtc
 > In file included from ./include/rtc_base/win32.h:42:0,
 >  from ./include/rtc_base/event.h:16,
 >  from ./include/rtc_base/thread.h:25,
 >  from ./include/api/mediastreaminterface.h:36,
 >  from ./include/api/dtmfsenderinterface.h:16,
 >  from ./include/api/peerconnectioninterface.h:78,
 >  from ctestenums.cc:2:
 > ./include/rtc_base/stringutils.h:22:0: warning: "alloca" redefined
 >  #define alloca _alloca
 > }}}
 It looks like `libwebrtc-windows-amd64-magic.lib` has a bunch of
 references to things like
 `rtc::MediaConstraintsInterface::kEnableDtlsSrtp` but they aren't in the
 include files...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

[Tor Bug Tracker & Wiki]

#25483: Windows reproducible build of snowflake
-+---
 Reporter:  arlolra  |  Owner:  cohosh
 Type:  project  | Status:  accepted
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201805 |  Actual Points:
Parent ID:  #19001   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+---

Comment (by cohosh):

 I rebased the changes made by sukhe and dcf onto a more recent version of
 Tor Browser: https://github.com/cohosh/tor-browser-build/tree/win-webrtc

 [https://github.com/cohosh/tor-browser-
 build/commit/6580d5b11809b1a29a4008a48dc48f9ca665cf42 This commit] fixes
 the error in comment:32. For some reason incremental builds of webrtc
 caused the video_capture module dependencies to be loaded, even though the
 module has been disabled in a previous patch.

 I'm currently getting some new build errors in WebRTC:
 {{{
 
/var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld:
 $WORK
 
/b001/_x008.o:peerconnection.cc:(.rdata$.refptr._ZN6webrtc25MediaConstraintsInterface15kEnableDtlsSrt
 pE[.refptr._ZN6webrtc25MediaConstraintsInterface15kEnableDtlsSrtpE]+0x0):
 undefined reference to `web
 rtc::MediaConstraintsInterface::kEnableDtlsSrtp'
 collect2: error: ld returned 1 exit status
 # github.com/keroserene/go-webrtc
 In file included from ./include/rtc_base/win32.h:42:0,
  from ./include/rtc_base/event.h:16,
  from ./include/rtc_base/thread.h:25,
  from ./include/api/mediastreaminterface.h:36,
  from ./include/api/dtmfsenderinterface.h:16,
  from ./include/api/peerconnectioninterface.h:78,
  from ctestenums.cc:2:
 ./include/rtc_base/stringutils.h:22:0: warning: "alloca" redefined
  #define alloca _alloca
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs