Re: [tor-bugs] #25766 [Core Tor/Tor]: Refactor token buckets to meet current coding standards

2018-04-13 Thread Tor Bug Tracker & Wiki
#25766: Refactor token buckets to meet current coding standards
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  implemented
  034-triage-20180328, 034-included-20180328 |  Actual Points:
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 squashed and merged to master, per discussion on ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25766 [Core Tor/Tor]: Refactor token buckets to meet current coding standards

2018-04-12 Thread Tor Bug Tracker & Wiki
#25766: Refactor token buckets to meet current coding standards
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8-can
-+-

Comment (by nickm):

 I had to make some additional changes there, since it turns out my initial
 approach wouldn't compile on OSX.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25766 [Core Tor/Tor]: Refactor token buckets to meet current coding standards

2018-04-12 Thread Tor Bug Tracker & Wiki
#25766: Refactor token buckets to meet current coding standards
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8-can
-+-

Comment (by nickm):

 I've responded to dgoulet's review of the initial PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25766 [Core Tor/Tor]: Refactor token buckets to meet current coding standards

2018-04-10 Thread Tor Bug Tracker & Wiki
#25766: Refactor token buckets to meet current coding standards
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8-can
-+-

Comment (by nickm):

 https://github.com/torproject/tor/pull/46 is a github pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25766 [Core Tor/Tor]: Refactor token buckets to meet current coding standards

2018-04-10 Thread Tor Bug Tracker & Wiki
#25766: Refactor token buckets to meet current coding standards
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8-can
-+-

Comment (by nickm):

 (This branch is based on the `remove_tb_empty` branch of #25760.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25766 [Core Tor/Tor]: Refactor token buckets to meet current coding standards

2018-04-10 Thread Tor Bug Tracker & Wiki
#25766: Refactor token buckets to meet current coding standards
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25373   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8-can
-+-
Changes (by nickm):

 * status:  assigned => needs_review
 * reviewer:   => dgoulet


Comment:

 Current branch is `token_bucket_refactor`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs