Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-06-05 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by mcs):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 I created https://bugzilla.mozilla.org/show_bug.cgi?id=1466857 to track
 this on the Mozilla side.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-06-04 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_information
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_revision => needs_information


Comment:

 This got actually applied to `tor-browser-60.0.1esr-8.0-1` (as commit
 7ca562c26856b7a413854600cd9ae44ddbaf3462). mcs/brade: Could you just open
 the Moz bug and then close this ticket?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-05-17 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by gk):

 Okay, makes sense.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-05-16 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by mcs):

 Replying to [comment:6 gk]:
 > It seems to me we don't need the `_enabled` check? Because you are
 setting Telemetry usage to `false` in the first patch, so we should we
 good without `_enabled` usage (in fact the latter makes the pref flip
 obsolete by never ever sending a ping). Or maybe I am missing something
 here?

 The `_enabled` check is not needed for Tor Browser, but since Firefox
 supports a separate `toolkit.telemetry.updatePing.enabled` pref we thought
 we should write the patch in the form Mozilla will want it. Kathy and I
 have not found time to file a Bugzilla bug yet though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-05-16 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  ff60-esr, TorBrowserTeam201805R => ff60-esr,
 TorBrowserTeam201805
 * status:  needs_review => needs_revision


Comment:

 It seems to me we don't need the `_enabled` check? Because you are setting
 Telemetry usage to `false` in the first patch, so we should we good
 without `_enabled` usage (in fact the latter makes the pref flip obsolete
 by never ever sending a ping). Or maybe I am missing something here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-05-02 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr,TorBrowserTeam201804R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by gk):

 Replying to [comment:2 mcs]:
 > We should probably ask for this to be upstreamed. The code that Kathy
 and I patched was added for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1380256

 Sounds good to me. Could you file an upstream report attaching your
 patch/getting it into a `needs_review` shape and into mozilla-central?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-04-25 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr,TorBrowserTeam201804R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by mcs):

 * keywords:  ff60-esr,TorBrowserTeam201804 =>
   ff60-esr,TorBrowserTeam201804R
 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-04-24 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
---+--
 Reporter:  mcs|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ff60-esr,TorBrowserTeam201804  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by mcs):

 We should probably ask for this to be upstreamed. The code that Kathy and
 I patched was added for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1380256

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-04-24 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
---+--
 Reporter:  mcs|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ff60-esr,TorBrowserTeam201804  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by mcs):

 The attached patches fix this issue. The 0001- patch is a fixup that sets
 `toolkit.telemetry.enabled` to false so that the 0002- patch can reference
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-04-24 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
---+--
 Reporter:  mcs|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ff60-esr,TorBrowserTeam201804  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by mcs):

 * Attachment "0002-Bug-25909-disable-updater-telemetry.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25909 [Applications/Tor Browser]: disable updater telemetry

2018-04-24 Thread Tor Bug Tracker & Wiki 
#25909: disable updater telemetry
---+--
 Reporter:  mcs|  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  ff60-esr,TorBrowserTeam201804  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by mcs):

 * Attachment "0001-fixup-TB4-Tor-Browser-s-Firefox-preference-
 overrides.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs