Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Also merged to 029 and forward. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 juga's branch `ticket26007_029_02` looks good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by juga):

 Thanks!, that was very useful.
 I changed the test following that, now in my branch `ticket26007_029_02`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by nickm):

 WRT the question of how to avoid adding an extra file: you can use the
 "get_fname()" function to get a temporary filename from within a unit
 test, and then use write_str_to_file() to write a string into that file.
 The file will be automatically cleaned up when the unit tests exit.

 For a very simple example, see test_util_listdir() in test_util.c .

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review
 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 Test only for this in my branch `ticket26007_01`.
 It's using the same approach as the test for `geoip`, which adds a new
 file to the filestystem.
 Nickm, would you have an idea on a different approach than adding a new
 file here?.
 Also, it's based on master and not 0.2.9 because is using `SRCDIR` was
 introduced by nickm for the `geoip` test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:   => #25925


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by juga):

 * cc: juga (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 I think juga is working on a whole bunch of bwfile tests.
 Let's make sure one of them is a regression test for this case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 lgtm, merging to 0.2.9 and forward

 Can we have a regression test for this case?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Oops, now it's force-pushed and based on 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26007 [Core Tor/Tor]: Stop logging stack contents when reading a zero-length bandwidth file

[Tor Bug Tracker & Wiki]

#26007: Stop logging stack contents when reading a zero-length bandwidth file
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  033-must-maybe security-low  |  Actual Points:
  032-backport 031-backport 029-backport fast-   |
  fix|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 Please see my branch bug26007_029 on https://github.com/teor2345/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs