Re: [tor-bugs] #26282 [Core Tor/Tor]: Smartlist index implicitly converted to int

[Tor Bug Tracker & Wiki]

#26282: Smartlist index implicitly converted to int
--+
 Reporter:  rl1987|  Owner:  rl1987
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:
Parent ID:  #26196| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged it!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26282 [Core Tor/Tor]: Smartlist index implicitly converted to int

[Tor Bug Tracker & Wiki]

#26282: Smartlist index implicitly converted to int
--+
 Reporter:  rl1987|  Owner:  rl1987
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #26196| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Patch looks good to me.

 I think it could make sense to switch the `idx` fields to be an unsigned
 type, but I think that would probably generate even more warnings in these
 smartlist debug builds, so I think this patch is good as it is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26282 [Core Tor/Tor]: Smartlist index implicitly converted to int

[Tor Bug Tracker & Wiki]

#26282: Smartlist index implicitly converted to int
--+
 Reporter:  rl1987|  Owner:  rl1987
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #26196| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * reviewer:  ahf => asn


Comment:

 Swapping 034 reviews with ahf since he is travelling.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26282 [Core Tor/Tor]: Smartlist index implicitly converted to int

[Tor Bug Tracker & Wiki]

#26282: Smartlist index implicitly converted to int
--+
 Reporter:  rl1987|  Owner:  rl1987
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #26196| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * status:  accepted => needs_review


Comment:

 https://github.com/torproject/tor/pull/135

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26282 [Core Tor/Tor]: Smartlist index implicitly converted to int

[Tor Bug Tracker & Wiki]

#26282: Smartlist index implicitly converted to int
--+
 Reporter:  rl1987|  Owner:  rl1987
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #26196| Points:
 Reviewer:|Sponsor:
--+
Changes (by rl1987):

 * owner:  (none) => rl1987
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs