Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:  1
  TorBrowserTeam201909R, BugSmashFund, tbb-no-   |
  uplift |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R,
 BugSmashFund =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R, BugSmashFund,
 tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:  1
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by ghfsdhsdgsdgs):

 Sorry. Since this is a software regression I though continuing the
 conversation in the original ticket was the right thing to do.

 Continued on #32330

 @cypherpunks @cypherpunks3 @gk @acat

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:  1
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Please don't reopen old tickets. This one *got* fixed in the sense that we
 disabled tracking protection. I've filed a new bug (#32330) for your UI
 request even though I don't think we should work on it anytime soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:  1
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by ghfsdhsdgsdgs):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 >With respect to that, Firefox moved the UI for changing cookie blocking
 preference (network.cookie.cookieBehavior) to the new content blocking
 section in about:preferences. If we hide that (as the patch currently
 does), there is no way that users can change it via UI. I'm not sure if
 that's so bad, since this would only be for advanced users that know what
 they are doing, and still is possible to modify it via about:config.

 Hello.

 As you know, the current patch makes it impossible for normal users to
 disable cookies.

 Disabling the tracking protection ui option is essential to prevent
 damaging fingerprinting.

 But forcing users to accept cookies on their computer by hiding the ui
 button is a breach of trust and depending on the user/website usage
 pattern could compromise a users privacy.

 There is legitimate reasons for users to want to block all cookies.
 There is legitimate reasons for users to want to
 manage/whitelist/blacklist cookies.

 Telling normal users to disable cookies via about:config is unrealistic.

 I do not ask for the patch that hides dangerous options to be reverted.
 But can you please move the cookie blocking preference back out of the
 hidden section?
 Or can you hide all other dangerous options in the new tracking protection
 section except the cookie blocking preference?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:  1
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * actualpoints:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:12 acat]:
 > I forgot the menu item in panelUI, fixup in
 https://github.com/acatarineu/tor-browser/commit/26345+1.

 Nice catch! Looks good and cherry-picked to `tor-browser-68.1.0esr-9.0-2`
 (commit ea79fd5825ed9ea4e148baa473da3b97356bb38f).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * status:  reopened => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I forgot the menu item in panelUI, fixup in https://github.com/acatarineu
 /tor-browser/commit/26345+1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:9 acat]:
 > Here is a patch for review: https://github.com/acatarineu/tor-
 browser/commit/26345
 >
 > I think with the current preferences we should not be blocking anything
 from the Firefox
 > Enhanced Tracking Protection/Content Blocking, other than the 3rd party
 cookies (which is the same as esr60).

 Yes (see my last comment).

 > With respect to that, Firefox moved the UI for changing cookie blocking
 preference (`network.cookie.cookieBehavior`) to the new content blocking
 section in `about:preferences`. If we hide that (as the patch currently
 does), there is no way that users can change it via UI. I'm not sure if
 that's so bad, since this would only be for advanced users that know what
 they are doing, and still is possible to modify it via `about:config`.

 Looking at the result of the hiding it seems this is okay. We want to
 avoid users shooting themselves in the foot by clicking on some of those
 options.

 > We currently block all 3rd party cookies (although there is #21905 to
 revise that), and this makes the "shield" icon in the siteIdentity UI
 appear, so that had to be hidden too.
 >
 > There are some requests because of this feature going in the background
 from time to time. The ones that I have checked are coming from
 [https://searchfox.org/mozilla-
 esr68/rev/b1a2c428a9125ade87001bb6b9e990c886dcfd31/netwerk/url-
 classifier/UrlClassifierSkipListService.jsm#106
 UrlClassifierSkipListService.jsm]. But I guess we can deal with that in a
 separate ticket together with some other background requests that are
 still happening.

 Yes, please file a new ticket for that if needed. The patch looks okay to
 me, especially as this is a temporary measure anyway given that we are
 interested tin using tracking protection for performance improvements
 later on.

 Cherry-picked to `tor-browser-68.1.0esr-9.0-2` (commit
 cbf4dfb66958590b64cf5b2fc63ff0ed9e2d7d0e).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by gk):

 FWIW: `populateCategoryContents()` (https://searchfox.org/mozilla-
 esr68/source/browser/components/preferences/in-content/privacy.js#691) is
 the important function here to see what actually got enabled. Due to a
 combination of us setting prefs
 (`privacy.trackingprotection.pbmode.enabled` to `false`) and defaults
 already set we seem indeed to land at the status quo compared to esr60
 modulo the UI changes (so I guess we should be good here with the second
 remaining item mentioned in comment:17:ticket:27601?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909 =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R
 * status:  new => needs_review


Comment:

 Here is a patch for review: https://github.com/acatarineu/tor-
 browser/commit/26345

 I think with the current preferences we should not be blocking anything
 from the Firefox
 Enhanced Tracking Protection/Content Blocking, other than the 3rd party
 cookies (which is the same as esr60).

 With respect to that, Firefox moved the UI for changing cookie blocking
 preference (`network.cookie.cookieBehavior`) to the new content blocking
 section in `about:preferences`. If we hide that (as the patch currently
 does), there is no way that users can change it via UI. I'm not sure if
 that's so bad, since this would only be for advanced users that know what
 they are doing, and still is possible to modify it via `about:config`.

 We currently block all 3rd party cookies (although there is #21905 to
 revise that), and this makes the "shield" icon in the siteIdentity UI
 appear, so that had to be hidden too.

 There are some requests because of this feature going in the background
 from time to time. The ones that I have checked are coming from
 [https://searchfox.org/mozilla-
 esr68/rev/b1a2c428a9125ade87001bb6b9e990c886dcfd31/netwerk/url-
 classifier/UrlClassifierSkipListService.jsm#106
 UrlClassifierSkipListService.jsm]. But I guess we can deal with that in a
 separate ticket together with some other background requests that are
 still happening.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by pili):

 * points:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-alpha-must, TorBrowserTeam201908 =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-alpha-must,|  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * keywords:  ff68-esr => ff68-esr, tbb-9.0-alpha-must, TorBrowserTeam201908


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff68-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks3):

 Official announcement: https://blog.mozilla.org/futurereleases/2018/08/30
 /changing-our-approach-to-anti-tracking/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr

[Tor Bug Tracker & Wiki]

#26345: Disable tracking protection UI in FF67-esr
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff67-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Oops, typo

 > thereby harming their fingerprint.*

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs