Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by cypherpunks):

 1:31 PM Ticket #26700 (Batch merge for Relay Search patches) closed by irl
 fixed: Thanks!
 1:31 PM Tickets #25199,25242,25533,25861,26518 batch updated by irl
 fixed: Merged in #26700.
 1:31 PM Ticket #26525 (Rename sandbox_getaddrinfo() functions.) closed by
 nickm
 fixed: merged!
 1:22 PM Ticket #25512 (Tor in-process restart fails to write auth cookie)
 closed by nickm
 fixed: Cherry-picked into 0.3.3; fix should be in the next maint-0.3.3
 release.
 1:22 PM Ticket #26700 (Batch merge for Relay Search patches) updated by
 karsten
 Merged, pushed to master, and deployed. Can't close because of child …
 1:21 PM Ticket #25512 (Tor in-process restart fails to write auth cookie)
 updated by nickm
 Milestone changed
 Hang on -- you said that you were testing 0.3.3.7; this bug has only …
 1:17 PM Ticket #25512 (Tor in-process restart fails to write auth cookie)
 updated by nickm
 Status changed
 1:15 PM Ticket #26455 (use correct CARGO_HOME in test_rust.sh) closed by

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the patches!  I made some review comments on the pull request.

 Would you be willing to write a changes file for this?  See
 doc/HACKING/CodingStandards.md for more details about how to do this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by catalyst):

 Replying to [comment:7 frewsxcv]:
 > Oh I opened a pull request a couple weeks ago:
 https://github.com/torproject/tor/pull/179
 >
 > I forgot to link it from here, sorry!
 Thanks for the link!  I found it earlier and have started reviewing
 already.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by frewsxcv):

 Oh I opened a pull request a couple weeks ago:
 https://github.com/torproject/tor/pull/179

 I forgot to link it from here, sorry!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by cypherpunks):

 * status:  needs_review => closed
 * resolution:   => duplicate


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by chelseakomlo):

 If this person isn't keeping up to date on this PR anymore, I can open a
 PR for them (or anyone else please feel free). This patch looks good other
 than what CI would catch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by asn):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by asn):

 * reviewer:  isis =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  isis  |Sponsor:
--+
Changes (by asn):

 * reviewer:   => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26492 [Core Tor/Tor]: Refactoring src/rust/protover/ffi.rs.

[Tor Bug Tracker & Wiki]

#26492: Refactoring src/rust/protover/ffi.rs.
--+
 Reporter:  frewsxcv  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review
 * version:  Tor: unspecified =>
 * component:  - Select a component => Core Tor/Tor
 * milestone:   => Tor: 0.3.5.x-final


Comment:

 Hi, thanks for this patch.

 Please open a pull request at https://github.com/torproject/tor so our
 automatic integration tests run on your branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs