Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-14 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.5
Parent ID: | Points:  3.0
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  accepted => closed
 * points:  3 => 3.0
 * resolution:   => implemented
 * actualpoints:  0.4 => 0.5


Comment:

 Made the [https://gitweb.torproject.org/metrics-
 lib.git/commit/?id=ba6c63a707ceb7acc6354f541a8efd9366842c53 metrics-lib
 changes] and pushed them to master.

 That concludes this ticket! Thanks, acute, for making this happen!
 Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID: | Points:  3
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  needs_review => accepted
 * owner:  metrics-team => karsten


Comment:

 Thanks for checking! Squashed my commit into yours and pushed to master.

 I'll now work on the metrics-lib side of this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID: | Points:  3
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 Replying to [comment:18 karsten]:
 > Those two patches look great and work as expected in a test instance! I
 added a
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-26673&id=747dd627fd05a85c69735ea09560258354c1a507
 third patch] with some minor fixes and pushed them all to my task-26673
 branch. If you like that branch, I'll squash and merge to master.
 The branch looks great, thank you for spotting the missing values and
 docs. It's good to go, thanks again for the very quick review!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.4
Parent ID: | Points:  3
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * reviewer:  karsten => acute
 * actualpoints:  0.2 => 0.4


Comment:

 Those two patches look great and work as expected in a test instance! I
 added a
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-26673&id=747dd627fd05a85c69735ea09560258354c1a507
 third patch] with some minor fixes and pushed them all to my task-26673
 branch. If you like that branch, I'll squash and merge to master. This was
 really quick, thanks for working on this so quickly! Adding my 0.2 actual
 points to yours. Leaving in needs_review for you to give the green light
 for merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.2
Parent ID: | Points:  3
 Reviewer:  karsten|Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * reviewer:   => karsten


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.2
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * status:  reopened => needs_review
 * actualpoints:   => 0.2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * Attachment "0001-Adds-support-for-recording-seconds-elapsed-before-
 do.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * Attachment "0002-Changes-digit-precision-for-payload_progress-and-
 pay.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 Replying to [comment:14 karsten]:
 > I started looking into this ticket. I need to take a break now, but
 before I do, here are my thoughts:
 >
 >  - We're about to stop generating .tpf files in OnionPerf. However,
 we're still using that format in metrics-lib. This means that we can very
 likely ignore generating these new timestamps for .tpf files in OnionPerf,
 but we should still think about doing it in metrics-lib.
 >  - We should try to generalize from our historic choice of downloading
 50 KiB, 1 MiB, and 5 MiB files by including some more timestamps in the
 middle. There exists something called 1-2-5 series, which could guide us
 here: 10 KiB, 20 KiB, 50 KiB, 100 KiB, 200 KiB, 1 MiB, 2 MiB, 5 MiB.
 >  - Looking at the .json format, maybe we can have another dict like
 `"payload_progress"` for progress by downloaded bytes: `"payload_bytes": {
 "10240": 0.689492, "20480": 0.949185, ..., "5242880": 2.141004 }"`. Note
 the 6 digits for microsecond precision, unlike the ~16 digits in
 `"payload_progress"`.
 >  - Maybe we can round `"payload_progress"` numbers to 6 digits for
 microsecond precision as part of this ticket, in a separate commit? It's a
 tiny change, but it makes .json files unnecessarily large.
 >  - Once this dict is in .json files, I'll have to update metrics-lib to
 parse it. That's going to be a tiny change, though.
 I already had some code to implement this, changed it to use the values
 you suggested (10 Kib, 20 Kib, ..., 5 Mib), and added another commit for
 the digit precision. Hope I haven't been duplicating some effort.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-13 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 I started looking into this ticket. I need to take a break now, but before
 I do, here are my thoughts:

  - We're about to stop generating .tpf files in OnionPerf. However, we're
 still using that format in metrics-lib. This means that we can very likely
 ignore generating these new timestamps for .tpf files in OnionPerf, but we
 should still think about doing it in metrics-lib.
  - We should try to generalize from our historic choice of downloading 50
 KiB, 1 MiB, and 5 MiB files by including some more timestamps in the
 middle. There exists something called 1-2-5 series, which could guide us
 here: 10 KiB, 20 KiB, 50 KiB, 100 KiB, 200 KiB, 1 MiB, 2 MiB, 5 MiB.
  - Looking at the .json format, maybe we can have another dict like
 `"payload_progress"` for progress by downloaded bytes: `"payload_bytes": {
 "10240": 0.689492, "20480": 0.949185, ..., "5242880": 2.141004 }"`. Note
 the 6 digits for microsecond precision, unlike the ~16 digits in
 `"payload_progress"`.
  - Maybe we can round `"payload_progress"` numbers to 6 digits for
 microsecond precision as part of this ticket, in a separate commit? It's a
 tiny change, but it makes .json files unnecessarily large.
  - Once this dict is in .json files, I'll have to update metrics-lib to
 parse it. That's going to be a tiny change, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2020-05-05 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  reopened
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor59
---+--
Changes (by gaba):

 * keywords:  user-experience, acute-2019-q1-planned, ex-sponsor-19, ex-
 sponsor19 => metrics-team-roadmap-2020
 * points:   => 3
 * sponsor:   => Sponsor59


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2019-05-16 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
-+-
 Reporter:  karsten  |  Owner:
 |  metrics-team
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  user-experience, |  Actual Points:
  acute-2019-q1-planned  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by acute):

 I've written a reprocessing module for onionperf, and have tested the
 reprocessing of 3 months' worth of files from op-ab. These files have the
 PARTIAL fields we discuss here as well as an optional ERRORCODE field
 where there were errors (as per #29787)

 The reprocessed files are here if you want to have a play:

 ​https://erg.abdn.ac.uk/~ana/reprocessing_test/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2019-05-02 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
-+-
 Reporter:  karsten  |  Owner:
 |  metrics-team
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  user-experience, |  Actual Points:
  acute-2019-q1-planned  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by acute):

 Replying to [comment:5 karsten]:

 >  1. Can we reprocess existing logs to include these partial completion
 timestamps for past measurements, maybe when we reprocess logs for #29787?
 (I'm happy to do the actual reprocessing, I'm just asking if you see any
 problems with that.)

 Yes, if we have all the logs reprocessing should be easy, I have some code
 to do this  already for testing the analysis changes - which can be
 bundled into a script!

 >  2. I think the goal is to change the weights for making 50k/1m/5m
 downloads towards making more 5m downloads and still obtaining 50k/1m
 results from these new timestamps. Should we change weights in several
 steps to ensure we're not overloading anything? Like, from 12/2/1 over
 6/2/1 and 2/1/1 to 0/0/1?
 This is the next step - following this week's metrics team meeting, this
 is ready to do whenever we're ready with the changes downstream.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2019-05-01 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
-+-
 Reporter:  karsten  |  Owner:
 |  metrics-team
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  user-experience, |  Actual Points:
  acute-2019-q1-planned  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by karsten):

 Sounds like a fine plan to me! I didn't read the code, but the design
 looks sane to me.

 I have two questions related deployment:

  1. Can we reprocess existing logs to include these partial completion
 timestamps for past measurements, maybe when we reprocess logs for #29787?
 (I'm happy to do the actual reprocessing, I'm just asking if you see any
 problems with that.)

  2. I think the goal is to change the weights for making 50k/1m/5m
 downloads towards making more 5m downloads and still obtaining 50k/1m
 results from these new timestamps. Should we change weights in several
 steps to ensure we're not overloading anything? Like, from 12/2/1 over
 6/2/1 and 2/1/1 to 0/0/1?

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2019-04-29 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
-+-
 Reporter:  karsten  |  Owner:
 |  metrics-team
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  user-experience, |  Actual Points:
  acute-2019-q1-planned  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor19
-+-

Comment (by acute):

 Some feedback required;
 I've made a pull request which adds support for recording partial
 completion timestamps, both in json and torperf produced analysis files.
 The data is recorded the same way as the percentile data, and only in case
 where there are no errors. An example of the resulting fields in the
 torperf file (in the case of a 5m download) are:
 PARTIAL1048576=1555678482.70 PARTIAL51200=1555678479.75
 PARTIAL5242880=1555678495.97

 For a 1m download, only values PARTIAL1048576 and PARTIAL51200 are
 recorded, and similarly, for a 50k download, only PARTIAL51200 will be
 recorded.
 We could only record PARTIAL values smaller than the total size of the
 download (we already record DATAPERC100, which is the same
 timestamp/value, equivalent to 100% download), however having the field
 might help process things in an automated fashion further down the
 pipeline - happy to make changes if this is not the case.

 Finally - the names of the fields may be changed to PARTIAL{50k,1m,5m}
 although I've noticed all the other fields in the tpf file use the value
 in bytes and not the human readable version. Suggestions welcome.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2018-12-20 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  user-experience|  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor19
---+--
Changes (by gaba):

 * keywords:   => user-experience
 * sponsor:   => Sponsor19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26673 [Metrics/Onionperf]: Record download times of smaller file sizes from partial completion times

2018-07-06 Thread Tor Bug Tracker & Wiki 
#26673: Record download times of smaller file sizes from partial completion 
times
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by cypherpunks):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs