Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Looks good now, thanks! I cherry-picked the patch to `master`
 (10c58d9a2f9fc37f7ba3e1b7028d2b5a730b1e6f).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Changes (android-1024)

  * Removed expect and openjdk dependencies
  * Removed arm64 and x86_64 NDK directories

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:27 gk]:
 > It seems to me `expect` and `openjdk-8-jdk` is not needed in the `deps:`
 part, is it?
 >> You are right. These were there when I was initially using sdkmanager
 and tools to pull the artifacts. Expect was for accepting licenses. I'll
 remove these.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:26 boklm]:


 > Replying to [comment:24 sisbell]:
 >
 > > * Create android toolchains version 26 for arm, arm64, x86_64 (for
 when we add support to these platforms)
 > >
 >
 > So this includes support for all architectures in one toolchain? Usually
 we build one toolchain for only one architecture. Maybe we can have one
 that supports all android architectures, but this can be decided when we
 add support for arm64 and x86_64. For now I think we should build only the
 architecture we use.
 >> The Android NDK has all the architectures prebuilt within its zip file.
 The make_standalone_toolchain.py scripts are just copying the prebuilt
 binaries from various locations into one usable location. Its easy enough
 to remove the script calls for arm64, x86_64 until we are ready to make a
 decision.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 It seems to me `expect` and `openjdk-8-jdk` is not needed in the `deps:`
 part, is it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:24 sisbell]:
 >  * Create android toolchains version 26 for arm, arm64, x86_64 (for when
 we add support to these platforms)

 So this includes support for all architectures in one toolchain? Usually
 we build one toolchain for only one architecture. Maybe we can have one
 that supports all android architectures, but this can be decided when we
 add support for arm64 and x86_64. For now I think we should build only the
 architecture we use.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Changes (android-1024)

  * Removed android platform 23 from config
  * Upgraded android-tools-linux to latest version
  * Create android toolchains version 26 for arm, arm64, x86_64 (for when
 we add support to these platforms)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201810R => tbb-rbm, tbb-
 mobile, TorBrowserTeam201810
 * status:  needs_information => needs_revision


Comment:

 I guess this needs revision...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Why do we still have API 23 bits in this patch (like `--api 23` and using
 23.0.3 build tools) if we are targetting API 26?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201810 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201810R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Changes (android-1017)

  * Removed reference to maven-repo archive. This is now handled within
 firefox project

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Changes (android-1017)

  * Removed README.ANDROID since it looks like we are going with a
 different approach
  * Switched to Android platform-26 to align with latest changes in tor-
 browser

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Updated:

  * Added README.ANDROID file that explains how to build the maven repo.
 Added comment in android-toolchain/config that references the readme file.


  * Changed the name of the repo to include a version: maven-
 repo-1.0.tar.gz


  * Removed trailing whitespaces


  * Created git repo for download artifact list: https://github.com/sisbell
 /tor-android-repo



 Changes are on android-1017 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:15 sisbell]:
 > Created a full maven-repo archive, rather than just sample.

 - could you add a comment giving instructions for generating the maven
 repo archive? (as said in
 https://trac.torproject.org/projects/tor/ticket/27438#comment:12)
 - I think the maven repo filename should include a version number, as we
 will probably need to update it a some point.
 - there are trailing whitespaces after the gradle_dependencies URL and
 sha256sum lines

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Created a full maven-repo archive, rather than just sample.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201810 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201810R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Made the following changes:

  * Added var/setup
  * Changed variable names
  * Downloading maven-repo archive instead of individual files (limited
 sample to keep size down during testing)
  * Added gradle tool as part of android-toolchain
  * Matched directory names to be closer to what Firefox expects for its
 build

 commit: !https://github.com/sisbell/tor-browser-
 build/commit/e00c5e4319e67f7d17ed737b0e0c87db27547e3d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 In commit `a5e531981d5b5182277596fce92b8b7936e505e1`, I think you don't
 need to define to define all the variables such as `platform_tools_26:
 platform-tools_r26.0.2-linux.zip`.

 You could just have an `input_files` entry like this:
 {{{
   - URL: '[% c("var/google_repo") %]/platform-tools_r26.0.2-linux.zip'
 name: platform_tools
 sha256sum:
 63b15a38c2b64e6ec8b54febe9f69fce5fe6c898c554c73b826b49daf7b52519
 }}}

 And use `c('input_files_by_name/platform_tools')` when you need to use the
 filename in the `build` script.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:8 sisbell]:
 > I removed the setup in config and now handle this in the build file. I
 cleaned up the naming of sdk.zip and ndk.zip as suggested.

 There should be a `var/setup` in android-toolchain. This `var/setup` will
 then be used in firefox (and other components we build with the toolchain)
 to extract and setup the toolchain before the build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 The rbm build now downloads the android platform and build tools  (these
 are different than the SDK/NDK). These were previously being downloaded by
 the sdkmanager.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I removed the setup in config and now handle this in the build file. I
 cleaned up the naming of sdk.zip and ndk.zip as suggested.

 In addition, I collapsed
 [https://trac.torproject.org/projects/tor/ticket/27438 issue #27438]
 Android Gradle Build Downloads into this same commit. I used the output
 from artc rust program to generate rbm config/build entries for each
 gradle artifact. This does lead to a large number of file entries in the
 config file.

 If the current approach does not look clean enough, artc program can
 package gradle dependencies as a tar file. So its little effort to go this
 route instead.

 The commits can be found at


 !https://github.com/sisbell/tor-browser-build/commits/android-rebased

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 The sdkmanager is downloading packages (platform and build tools) during
 the build so I will need to track and add those to the rbm config.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201809R => tbb-rbm, tbb-
 mobile, TorBrowserTeam201809


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 sisbell]:
 > commit: https://github.com/sisbell/tor-browser-
 build/commit/3ac1fe9c44a1ec20946896824cb06523e7370ef7

 I did not try a build yet with this commit, but here are some first
 comments:
 - the format of the commit subjects should be `Bug : description of
 the commit`. So in this case, it should be `Bug 26697: Add Android
 toolchain`
 - it seems the `var/setup` in `projects/android-toolchain/config` is
 wrong:
 {{{
   setup: |
 mkdir -p /var/tmp/dist
 unzip sdk.zip
 }}}
 The zip file will be extracted in the current directory instead of
 `/var/tmp/dist`. And `sdk.zip` is probably not the correct filename.
 Instead `$rootdir/[% c("compiler_tarfile") %]` should be used as the
 filename.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201808 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201809R
 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26697 [Applications/Tor Browser]: Add Android toolchain

[Tor Bug Tracker & Wiki]

#26697: Add Android toolchain
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 commit: https://github.com/sisbell/tor-browser-
 build/commit/3ac1fe9c44a1ec20946896824cb06523e7370ef7

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs