Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 All the child are closed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-

Comment (by juga):

 will update the spec, then close

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 (I don't know whether the child tickets here should be closed or
 unparented -- please do whatever is appropriate to them, and then close
 this ticket?  Thanks!)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Okay -- the commits look like what I read before, and chutney passes on
 the results.  Merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => merge_ready


Comment:

 I squashed it in https://github.com/torproject/tor/pull/699.

 I also had to rebase it, because i created the branch when appveyor was
 failing with openssl (see comment
 https://github.com/torproject/tor/pull/497#discussion_r248581721).
 I tried to rebase it to the commit in which i think the openssl was fixed,
 but then travis was failing cause not being able to write cargo.lock, so i
 just rebased to current master where CI doesn't fail.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This looks good to me now!  It gives me conflicts when I try to squash it,
 though.  Once there's a squashed branch, please put it into a PR and put
 the ticket into merge_ready?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 ok, more fixups

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I found out why your hashes weren't matching: see the pull request.

 Please be careful with sizeof() and strlen()!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:26 teor]:
 > I noticed some bugs that we need to fix before we merge.

 See new fixups and comments, not sure i'm calculating the digest
 correctly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I did a review on the pull request.

 I noticed some bugs that we need to fix before we merge.
 I also found some things that we could fix after we merge, so I opened
 child tickets for them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth|  Actual Points:
  041-proposed   |
Parent ID:  #27047   | Points:  0.5
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:  tor-crypto tor-dirauth tor-bwauth => tor-crypto tor-dirauth
 tor-bwauth 041-proposed
 * points:   => 0.5
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.4.1.x-final


Comment:

 The 0.4.0 code freeze is on, so this ticket should move to 0.4.1.
 The points estimate should be the remaining review time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Low|  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Nickm and teor reviews are not overlapping (except for the `255` typo).
 I made lot of fixups because i moved the hash calculation from the new
 function to `dirserv_read_measured_bandwidths` and i realized about more
 issues on the way.
 I explain each fixup in the PR.
 If you prefer to review a squashed version, see also the comment in the
 PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Low|  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer:  nickm  |Sponsor:
---+---

Comment (by teor):

 Oh, I also did a GitHub review a few weeks ago, but for some reason I
 never submitted it. I hope there's not too much overlap with Nick's
 review, or any changes since I did my review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Low|  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Low|  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * reviewer:  teor => nickm


Comment:

 Hm.  Looking at PR497, I see that it uses sha256.  That's good -- sha1
 would be a bad choice here.

 I've left a short review on the ticket -- it looks mostly good, but there
 are some points I think could use some changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Low|  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer:  teor   |Sponsor:
---+---

Comment (by teor):

 Mike, if I don't get to this review on Monday, I'm going to return it to
 you. Because I'm busy with PrivCount now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Low|  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer:  mikeperry  |Sponsor:
---+---
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.4.0.x-final


Comment:

 Putting this in 0.4.0, because it's a feature with code.

 Hey mikeperry, do you have time to review this ticket this week?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Low|  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer:  mikeperry  |Sponsor:
---+---
Changes (by asn):

 * reviewer:   => mikeperry


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Low|  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 https://github.com/torproject/tor/pull/497

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Low|  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Based on the conversation in
 https://trac.torproject.org/projects/tor/ticket/21378#comment:26 , let's
 use base64-encoded SHA256.

 I didn't review the code, but I did review the spec ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:
   |  needs_review
 Priority:  Low|  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by juga):

 * keywords:  tor-crypto tor-dirauth => tor-crypto tor-dirauth tor-bwauth
 * status:  needs_revision => needs_review


Comment:

 Using hex in https://github.com/torproject/tor/pull/492

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_revision
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Yes, let's use hex for the hash.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by juga):

 Should i then use hex? (and then change this ticket to revision)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 Karsten said that they don't mind.

 Since it's only in a vote, we might use hex, so humans can look at the
 vote, and find the bandwidth file for the vote.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 We typically use hexadecimal or base64 to encode raw bytes in directory
 documents.

 base64 is shorter, but it doesn't work in file names.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 Replying to [comment:8 juga]:
 > Replying to [comment:7 teor]:
 > > If collector is going to use hexadecimal for the bandwidth file hash,
 we should use hexadecimal in the votes. I asked karsten here:
 > > https://trac.torproject.org/projects/tor/ticket/21378#comment:17
 >
 > i asked in IRC why we would encode the hash of a file in base 64 in a
 vote and i was told that we don't use raw bytes anymore.

 Directory documents never contain raw bytes.

 > Searching for "base64" in dir-spec.txt, gives several results, though i
 couldn't find a paragraph that would confirm that.

 Directory documents only contain printing ASCII characters:
 https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n193

 Although we allow some other text encodings in the contact and platform
 lines.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by juga):

 Replying to [comment:7 teor]:
 > If collector is going to use hexadecimal for the bandwidth file hash, we
 should use hexadecimal in the votes. I asked karsten here:
 > https://trac.torproject.org/projects/tor/ticket/21378#comment:17

 i asked in IRC why we would encode the hash of a file in base 64 in a vote
 and i was told that we don't use raw bytes anymore.
 Searching for "base64" in dir-spec.txt, gives several results, though i
 couldn't find a paragraph that would confirm that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 If collector is going to use hexadecimal for the bandwidth file hash, we
 should use hexadecimal in the votes. I asked karsten here:
 https://trac.torproject.org/projects/tor/ticket/21378#comment:17

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by juga):

 Replying to [comment:4 teor]:
 > Replying to [comment:3 juga]:
 > > i wonder if we should add the hash to the bandwidth file name in
 `sbws`, similar to what is done with descriptors. Though then we would
 need to allow giving a directory or a file (to be compatible with older
 versions) in V3BandwidthsFile, and then adding (or resusing?) code to find
 the latest file parsing the date in it.
 >
 > We could add this feature if we want, but I think it would make the tor
 code much more complicated.

 i agree

 > If you want to add it, let's open a separate ticket.
 >
 > This ticket is about verifying the bandwidth file that was used in a
 vote.

 not doing it so far cause the reason above

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by juga):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/485

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by teor):

 Replying to [comment:3 juga]:
 > i wonder if we should add the hash to the bandwidth file name in `sbws`,
 similar to what is done with descriptors. Though then we would need to
 allow giving a directory or a file (to be compatible with older versions)
 in V3BandwidthsFile, and then adding (or resusing?) code to find the
 latest file parsing the date in it.

 We could add this feature if we want, but I think it would make the tor
 code much more complicated. If you want to add it, let's open a separate
 ticket.

 This ticket is about verifying the bandwidth file that was used in a vote.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by juga):

 i wonder if we should add the hash to the bandwidth file name in `sbws`,
 similar to what is done with descriptors. Though then we would need to
 allow giving a directory or a file (to be compatible with older versions)
 in V3BandwidthsFile, and then adding (or resusing?) code to find the
 latest file parsing the date in it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  #27047  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by teor):

 * parent:   => #27047


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by cypherpunks):

 12:34 PM Ticket #21377 (DirAuths should expose bwauth bandwidth files)
 updated by teor
 Parent ID changed
 12:34 PM Ticket #26692 (sbws must not overwrite the bandwidth file, to
 avoid race conditions) updated by teor
 Parent ID changed
 12:34 PM Ticket #26193 (Tarballs are not compressed in a run following an
 aborted run) closed by karsten
 fixed: Great! Fixed in master. Closing. Thanks!
 12:33 PM Ticket #26692 (sbws must not overwrite the bandwidth file, to
 avoid race conditions) updated by teor
 Parent ID changed
 12:24 PM Ticket #24291 (Rename CollecTor packages) closed by karsten
 fixed: Thanks for checking! Merged to master. Closing.
 12:20 PM Ticket #18342 (Provide more accurate reverse DNS results) updated
 by karsten
 Status changed
 Please find …
 12:19 PM Ticket #25164 (Reproducible Tor Browser for Android builds)
 updated by boklm
 Parent ID changed
 12:18 PM Ticket #26693 (Integrate Tor Browser for Android into tor-
 browser-build) updated by boklm
 Parent ID changed
 12:16 PM Ticket #26697 (Add Android toolchain) created by boklm
 We need to add a projects/android-toolchain directory which will …
 12:10 PM Ticket #26696 (Add definition for new platform in rbm.conf)
 created by boklm
 In order to be able to integrate Tor Browser for Android into …
 12:07 PM org/meetings/2018MexicoCity edited by karsten
 (diff)
 12:06 PM Ticket #25533 (Relay properties page: Link all properties and
 flags in page) updated by irl
 Status changed
 Fixed in f439a7dc in my relaysearch-dev branch.
 12:05 PM Ticket #26695 (List components required to build Tor Browser for
 Android) created by boklm
 In order to integrate Tor Browser for Android into tor-browser-build,
 …
 12:02 PM Ticket #21377 (DirAuths should expose bwauth bandwidth files)
 updated by juga
 Created #26694 for the spec changes.
 12:02 PM Ticket #26694 (dir-spec: DirAuths should expose bwauth bandwidth
 files) created by juga
 This ticket is for changing dir-spec to implement #21377

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

[Tor Bug Tracker & Wiki]

#26698: Authorities should put a hash of the bandwidth file in their votes
+--
 Reporter:  teor|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Low |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-crypto tor-dirauth  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by asn):

 * keywords:  tor-crypto => tor-crypto tor-dirauth


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs