Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
+
 Reporter:  chelseakomlo|  Owner:  teor
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, 036-proposed  |  Actual Points:
Parent ID:  #24629  | Points:
 Reviewer:  teor|Sponsor:
+
Changes (by teor):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
+
 Reporter:  chelseakomlo|  Owner:  teor
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, 036-proposed  |  Actual Points:
Parent ID:  #24629  | Points:
 Reviewer:  teor|Sponsor:
+

Comment (by teor):

 Please open a new ticket in 0.3.6 with a new branch containing the travis
 commit, so we remember to merge it when rustfmt 0.99.1 becomes stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
+
 Reporter:  chelseakomlo|  Owner:  teor
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, 036-proposed  |  Actual Points:
Parent ID:  #24629  | Points:
 Reviewer:  teor|Sponsor:
+

Comment (by cypherpunks3):

 Replying to [comment:14 teor]:

 I created a new branch 'rustfmt-notravis' at
 https://gitgud.io/onionk/tor.git with the only new changes being the
 removal of the Travis commit, and fixing a typo in CodingStandardsRust.md.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
+
 Reporter:  chelseakomlo|  Owner:  teor
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, 036-proposed  |  Actual Points:
Parent ID:  #24629  | Points:
 Reviewer:  teor|Sponsor:
+

Comment (by cypherpunks3):

 Since we won't be including the Travis check commit after all (for now),
 and that was the sole conflict with the branch in #24629, can this be
 merged immediately instead? All other Rust work has to be rebased on top
 of this one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
+
 Reporter:  chelseakomlo|  Owner:  teor
 Type:  enhancement | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, 036-proposed  |  Actual Points:
Parent ID:  #24629  | Points:
 Reviewer:  teor|Sponsor:
+
Changes (by teor):

 * keywords:  rust => rust, 036-proposed


Comment:

 Rust stable and beta disagree about some formatting. For example, see
 privcount_shamir's  #26973: https://travis-
 ci.org/teor2345/privcount_shamir/jobs/414426254#L1612

 We could merge this patch with the travis check disabled, because the rust
 code passes on rustfmt 0.99.1.

 Either way, we should defer the remaining tasks until Tor 0.3.6:
 * wait until rustfmt 0.99.1 hits stable
 * do a final format with rustfmt
 * activate the travis rustfmt check

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:  #24629| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * parent:   => #24629


Comment:

 I'm making #24629 the parent task, so I remember to do the merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 I'd like to merge this branch after #24629 merges.

 I'm happy to do the merge, it only affects 5d749e4bde:
 * install rustfmt in .travis.yml after the rewrite

 We should also:
 * print the rustfmt version, like we do for rustup in my 14ceee0fd1 in
 https://github.com/teor2345/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_revision => merge_ready
 * milestone:   => Tor: 0.3.5.x-final


Comment:

 Thanks, I reviewed the changes and made sure that "make rustfmt" produces
 commit 7fb342a716.

 Please merge the branch 'rustfmt-travis' from
 ​https://gitgud.io/onionk/tor.git , or the rustfmt-travis branch in my
 repository.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cypherpunks3):

 Sorry, fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Hi, it looks like you missed the following review comments:
 https://github.com/torproject/tor/pull/265#discussion_r208422091
 https://github.com/torproject/tor/pull/265#discussion_r208423211

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cypherpunks3):

 Rebased and reran with max_width=100. Also, `echo` prints a newline at the
 end, while `printf` doesn't.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Hi, the CI passed after merging the fix from master:
 https://travis-ci.org/teor2345/tor/builds/413363895

 I opened a GitHub pull request with my review on this branch:
 https://github.com/torproject/tor/pull/265#pullrequestreview-144228176

 Please see my comments on that pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Replying to [comment:3 teor]:
 > Replying to [comment:2 cypherpunks3]:
 > > But there's a bug upstream in rustfmt, which happens when it's
 configured with max_width=80 (like it is in `src/rust/.rustfmt.toml`).
 >
 > I'm not sure about the impact of the bug.
 > Does it produce ugly formatting, or is the syntax incorrect?
 >
 > Do you think we should give up on max_width=80?
 > We can reconsider wrapping to 80 characters when stable supports
 wrapping comments.
 >
 > If we want to match Tor's C files, we should be wrapping to 79
 characters:
 >
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n177

 I opened #27071 to deal with the max_width issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Replying to [comment:7 cypherpunks3]:
 > Replying to [comment:5 teor]:
 > > The travis build failed, due to old autoconf macros:
 > > https://travis-ci.org/teor2345/tor/builds/412925525
 > > Please fix
 >
 > Huh? According to the log, the source of the warning is a use of AC_WARN
 in configure.ac, and none of these patches added that, or even touched
 that file.

 Sorry, I didn't realise that CI was failing due to a bug in master.

 > It looks like a pre-existing condition. It seems to have already gotten
 fixed in
 
[https://gitweb.torproject.org/tor.git/commit/?id=f90c0533777f2220cd6fb5ed07a5b63cd9c3e881
 f90c0533777f2220cd6fb5ed07a5b63cd9c3e881]. (Although not sure what #23878
 has to do with it.)

 I've pushed your rebased branch to my github, and I'll see if CI works
 this time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cypherpunks3):

 Replying to [comment:5 teor]:
 > The travis build failed, due to old autoconf macros:
 > https://travis-ci.org/teor2345/tor/builds/412925525

 According to the log, the source of the warning is configure.ac, and use
 of AC_WARN which none of the patches touched, or used? How would you begin
 to fix that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 If you have GitHub, you can open a pull request at
 https://github.com/torproject/tor and Travis will run automatically.

 Or you can set up travis on your own GitHub using these instructions:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/HelpfulTools.md#n7

 If you're using Travis integration with another git repository, please let
 us know where it is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Hi,

 The travis build failed, due to old autoconf macros:
 https://travis-ci.org/teor2345/tor/builds/412925525

 Please fix the build, and check that it works on Travis.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by cypherpunks3):

 Replying to [comment:3 teor]:

 Rebased the branch and filed #27052.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  assigned => needs_revision
 * reviewer:   => teor
 * type:  task => enhancement


Comment:

 Replying to [comment:2 cypherpunks3]:
 > Can someone check out the branch 'rustfmt-travis' at
 https://gitgud.io/onionk/tor.git ?

 Thanks for this patch!

 The changes look like they should work, but we could tweak a few things to
 follow Tor's standards.

 Here are the changes I'd like to see:
 * open a separate ticket for deny(missing_docs), so we don't forget to fix
 the docs
 * make `cargo fmt --all -- --check` into `make check-rustfmt`. When tor is
 configured with Rust, and rustfmt-preview is installed, run `make check-
 rustfmt` during `make check-spaces`.
 * add a `make rustfmt` target, and tell developers about it if `make
 check-rustfmt` fails.

 (If we make these changes, we won't have to add a separate check to
 travis.)

 > But there's a bug upstream in rustfmt, which happens when it's
 configured with max_width=80 (like it is in `src/rust/.rustfmt.toml`).

 I'm not sure about the impact of the bug.
 Does it produce ugly formatting, or is the syntax incorrect?

 Do you think we should give up on max_width=80?
 We can reconsider wrapping to 80 characters when stable supports wrapping
 comments.

 If we want to match Tor's C files, we should be wrapping to 79 characters:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n177

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+--
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks3):

 Can someone test the branch 'rustfmt-travis' at
 https://gitgud.io/onionk/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+--
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by cypherpunks3):

 * Attachment "0001-rust-add-cargo-fmt-step-to-travis-CI.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

[Tor Bug Tracker & Wiki]

#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--+--
 Reporter:  chelseakomlo  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * status:  new => assigned
 * owner:  (none) => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs