Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  implemented
  -triaged-in-20180711, rust |  Actual Points:  0.5
Parent ID:  #25669   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorV
-+-
Changes (by teor):

 * actualpoints:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  implemented
  -triaged-in-20180711, rust |  Actual Points:
Parent ID:  #25669   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorV
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Okay -- merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorV
-+-

Comment (by teor):

 Hi nickm, now would be a good time to re-run rustfmt, and merge this
 ticket.

 No-one is working on PrivCount right now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorV
-+-

Comment (by nickm):

 Teor -- I'll do this once you say the time is ripe, or you can do it.  I'm
 not hacking on this repo for the next few days at least.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Sounds good.

 We should re-run **nightly** rustfmt, because nightly and stable format
 the files differently.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 This looks okay, except for the fact that the rustfmt commit itself will
 have conflicts with my patch series currently under review.

 So my current plan here is that, once that other patch series is merged,
 we should cherry-pick everything from this branch except for the rustfmt
 commit (`bdc2db60153ef9c3044b72309cc1b35f45f85618`), and then re-run
 rustfmt separately.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm


Comment:

 Please see my branch ticket26973 in
 https://github.com/teor2345/privcount_shamir.git

 I disabled the rustfmt check because rust stable and beta disagree about
 some formatting. For example, see:
 https://travis-ci.org/teor2345/privcount_shamir/jobs/414426254#L1612

 The passing build is:
 https://travis-ci.org/teor2345/privcount_shamir/builds/414430540

 I still think we should merge this patch, because the current code passes
 the rustfmt check with rustfmt 0.99.1.

 Then we should defer the remaining tasks until Tor 0.3.6:
 * wait until rustfmt 0.99.1 hits stable
 * do a final format with rustfmt
 * activate the travis rustfmt check

 Assigning to nickm, because he probably wants to merge the rustfmt changes
 before starting other rust tickets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 We can copy the code and configs from #26972, which does rustfmt checks
 for tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs