Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  juga
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by juga):

 * status:  accepted => closed
 * resolution:   => implemented


Comment:

 Removed child #27363 since it does not need to be implemented for the MVP

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  juga
 Type:  enhancement| Status:  accepted
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by juga):

 * status:  needs_review => accepted
 * owner:  (none) => juga


Comment:

 Implemented in https://github.com/torproject/sbws/pull/254.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by juga):

 * status:  new => needs_review


Comment:

 Blocked by #27398.
 Implementented in https://github.com/juga0/simple-bw-scanner/commits/dev

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by juga):

 Implementation is ready, but #27135, #27386 need to be fixed first and
 i'll wait for #27398 to be fixed too to make PRs

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by teor):

 Replying to [comment:1 teor]:
 > Since we're using observed bandwidths, we must limit the maximum node
 bandwidth.
 >
 > 5% is ok, but 1% might be better, because the largest relay is only
 0.5%.

 sbws needs to cap, so that relays can't gain too much bandwidth by
 changing their observed bandwidths.
 This is a security requirement. If torflow doesn't do it, that's a bug in
 torflow.

 Replying to [comment:3 juga]:
 > I think (but i'm not sure), that ``tot_net_bw`` [0] is not being
 applied.

 It looks like the NODE_CAP is applied unconditionally in torflow:
 
https://gitweb.torproject.org/torflow.git/tree/NetworkScanners/BwAuthority/aggregate.py#n778

 But from the graph, there doesn't seem to be a cap on torflow's
 bandwidths.

 > Also, since ``new_bw`` it's used in the non-pid part as the final value
 to write in the file, i thought ``tot_net_bw`` it just the sum of all the
 final relays' bandwidth that are going to be written in the file.
 >
 > In previous experiments, i capped to 0.05 * sum final bandwidths, and
 the result makes sense, see the attchemnt.

 Great!

 > [0]
 
https://gitweb.torproject.org/torflow.git/tree/NetworkScanners/BwAuthority/aggregate.py#n758

 The cap must be configurable, so that we can turn it off in test networks,
 or adjust it if it is a problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by pastly):

 Can you make the dots smaller please? I'd like to be able to at least
 somewhat see the blue dots behind the orange ones.

 `pyplot.scatter(..., s=5, ...)`

 https://matplotlib.org/api/_as_gen/matplotlib.pyplot.scatter.html

 (I don't know if 5 is a good size. Trial and error is required to find a
 good size)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-

Comment (by juga):

 I think (but i'm not sure), that ``tot_net_bw`` [0] is not being applied.
 Also, since ``new_bw`` it's used in the non-pid part as the final value to
 write in the file, i thought ``tot_net_bw`` it just the sum of all the
 final relays' bandwidth that are going to be written in the file.

 In previous experiments, i capped to 0.05 * sum final bandwidths, and the
 result makes sense, see the attchemnt.

 [0]
 
https://gitweb.torproject.org/torflow.git/tree/NetworkScanners/BwAuthority/aggregate.py#n758

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by juga):

 * Attachment "20180826_120539.png" added.

 sbws capped to 0.05 * sum all the relays' bandwidth

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+-
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #27107 | Points:
 Reviewer: |Sponsor:
---+-
Changes (by teor):

 * parent:   => #27107
 * milestone:  sbws 1.1 => sbws 1.0 (MVP must)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27336 [Core Tor/sbws]: Does sbws need a node cap?

[Tor Bug Tracker & Wiki]

#27336: Does sbws need a node cap?
---+--
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  sbws 1.1
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Old description:

> Torflow caps individual nodes at 5% of the consensus weight.
>
> When Tor gets better multithreading,
> https://gitweb.torproject.org/torflow.git/tree/NetworkScanners/BwAuthority/aggregate.py#n44

New description:

 Torflow caps individual nodes at 5% of the consensus weight.

 When Tor gets better multithreading, we might need to implement a cap.

 
https://gitweb.torproject.org/torflow.git/tree/NetworkScanners/BwAuthority/aggregate.py#n44

 Edit: fix short sentence.

--

Comment (by teor):

 Since we're using observed bandwidths, we must limit the maximum node
 bandwidth.

 5% is ok, but 1% might be better, because the largest relay is only 0.5%.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs