Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 This ticket is obsoleted by proposal 306:
 https://gitweb.torproject.org/torspec.git/tree/proposals/306-ipv6-happy-
 eyeballs.txt

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * status:  needs_revision => new


Comment:

 Setting as new again.
 #29801 is the ticket for the proposal changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * status:  needs_review => needs_revision


Comment:

 I have added some changes with a new PR at #29801
 (https://github.com/torproject/torspec/pull/63). This PR can get updated
 if another reviewer comes up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 There are multiple discussion threads for this proposal on tor-dev.
 Here's one of them:
 https://lists.torproject.org/pipermail/tor-dev/2019-March/013730.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * reviewer:  teor =>


Comment:

 Here is the pull request for the latest version of the proposal:
 https://github.com/torproject/torspec/pull/61

 I'm going to review it and make some comments.
 But I'd also like a second reviewer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:  teor  |Sponsor:
--+--
Changes (by teor):

 * status:  needs_information => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+---
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:  teor  |Sponsor:
--+---

Comment (by teor):

 After the proposal is done, we can also update the man page to describe
 Tor's new behaviour.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+---
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:  teor  |Sponsor:
--+---
Changes (by teor):

 * reviewer:  mikeperry => teor


Comment:

 I did a review on the pull request, and added some questions to think
 about for your proposal.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+---
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  needs-proposal, ipv6  |  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:  mikeperry |Sponsor:
--+---
Changes (by teor):

 * status:  needs_review => needs_information
 * keywords:   => needs-proposal, ipv6


Comment:

 Thanks for this code. It looks like you put a lot of work into it. Your
 work is valuable, because it helps us see what kind of questions we need
 to answer.

 We need to think carefully about the design and implementation of this
 feature. Otherwise, users could rely on this feature, and that makes it
 hard for us to change it later.

 When we design a complex feature, we do the design in a proposal, so we
 can work through the design issues without changing the code all the time.
 Here's our proposals process:
 https://gitweb.torproject.org/torspec.git/tree/proposals/001-process.txt

 If you're having trouble writing a whole proposal, just write an email to
 tor-dev explaining how this new feature works. We can help you from there.

 Once we have a proposal, we can work out how to implement this feature.
 For example, tor already tracks connection history in rephist.c. At the
 moment, this code forgets all its IP history once a week. But maybe it
 should just forget the oldest IP failures, not all the IP failures.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:  mikeperry |Sponsor:
--+--
Changes (by dgoulet):

 * reviewer:   => mikeperry


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * status:  assigned => needs_review


Comment:

 PR is here: https://github.com/torproject/tor/pull/566

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * type:  defect => enhancement


Comment:

 I have a few questions:

 1. I believe I should modify `connection_or_connect_failed()`. Is this
 correct?

 2. In the above function, is an instant connection failure determined by
 the OR error `END_OR_CONN_REASON_NO_ROUTE`?

 I know that #27490 is not committed yet, but I am already planning this
 patch while I wait.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27491 [Core Tor/Tor]: Prefer IPv4 or IPv6 based on the number of failures

[Tor Bug Tracker & Wiki]

#27491: Prefer IPv4 or IPv6 based on the number of failures
--+--
 Reporter:  neel  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #17835| Points:
 Reviewer:|Sponsor:
--+--
Changes (by neel):

 * reviewer:  #17385 =>
 * parent:   => #17835


Old description:

> Suggested by teor at #17385:
>
> > 3. If the machine instantly fails IPv4 or IPv6 connections, stop those
> connections for a while
> > 4. When there are a lot more IPv4 than IPv6 failures, don't try IPv4 as
> much
> > 5. When there are a lot more IPv6 than IPv4 failures, don't try IPv6 as
> much
> > 6. After a while, forget old failures

New description:

 Suggested by teor at #17835:

 > 3. If the machine instantly fails IPv4 or IPv6 connections, stop those
 connections for a while
 > 4. When there are a lot more IPv4 than IPv6 failures, don't try IPv4 as
 much
 > 5. When there are a lot more IPv6 than IPv4 failures, don't try IPv6 as
 much
 > 6. After a while, forget old failures

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs