Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:  0.5
  tbb-8.0.1-can, tbb-9.0-must-alpha, |
  TorBrowserTeam201909R  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * actualpoints:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, tbb-9.0-must-alpha, |
  TorBrowserTeam201909R  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:21 acat]:

 [snip]

 > So, given that we are hiding/disabling content blocking for now (and in
 principle are not affected by that regression) should we postpone
 backporting this patch until we explore/decide enabling content blocking?
 If yes, perhaps we could update #30939 so that we remember to backport
 this.

 That looks like a good idea. I am interested in seeing
 https://bugzilla.mozilla.org/show_bug.cgi?id=1554805 in 9.0, too. The
 proposed patches are not really big and are probably straightforward to
 apply. I'd wait a bit, though, until they have actually landed. I've
 created #31811 to keep track of that.

 > The first two are backported here: https://github.com/acatarineu/tor-
 browser/commits/27601.

 Those look good and I cherry-picked them onto `tor-
 browser-68.1.0esr-9.0-2` (commit c6eb1efb7d3ca6a9b5e19f6ec352ee1b129efbd3
 and f970a6e8a14d8f80f15be22fa1ed6b091b4d596b).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, tbb-9.0-must-alpha, |
  TorBrowserTeam201909R  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  new => needs_review
 * keywords:
 tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, tbb-9.0-must-alpha,
 TorBrowserTeam201909
 =>
 tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, tbb-9.0-must-alpha,
 TorBrowserTeam201909R


Comment:

 Unless I'm missing some, these are the fixes we would have to backport:

 * [https://bugzilla.mozilla.org/show_bug.cgi?id=1568521 Bug 1568521 -
 Tracking protection doorhanger's Enable/Disable states don't work]
   * https://github.com/mozilla/gecko-
 dev/commit/4f11cdabb32cf1de9cd6ee871ec31f6d8cab660c

 * [https://bugzilla.mozilla.org/show_bug.cgi?id=1557729 Bug 1557729 -
 google calendar loses notification permission every time it's loaded]
   * https://github.com/mozilla/gecko-
 dev/commit/52d5f250f15152d0672a30c5c2ef9c6f67ed38ed

 * [https://bugzilla.mozilla.org/show_bug.cgi?id=1572240 Bug 1572240 -
 ContentBlockingAllowList._basePrincipalForAntiTrackingCommon is a bit
 wasteful]
   * https://github.com/mozilla/gecko-
 dev/commit/7b2ff7275b4484a9bab1d4bd4d0d4c1da513b031
   * https://github.com/mozilla/gecko-
 dev/commit/e06a6e7ca6873165785927fd3c6e29a0d3e5aac2
   * https://github.com/mozilla/gecko-
 dev/commit/575c480fc556dc5614a9291dd8fb37928d21a316
   * https://github.com/mozilla/gecko-
 dev/commit/68aa0ff3f4c1e2048ef078714ad57b3ad5a75191
   * https://github.com/mozilla/gecko-
 dev/commit/05feeeb79be579eb1c651aba060ed783e12470d3
   * https://github.com/mozilla/gecko-
 dev/commit/c771ae8334e2f691decbcc95526b64e521c11339

 The first two are simple fixes, but the third one is not so easy to
 backport. As it was mentioned on IRC, the patch writer thinks this is
 risky to backport
 (https://bugzilla.mozilla.org/show_bug.cgi?id=1560623#c9). I took a quick
 look, and the patch as is relies on this other patch
 https://bugzilla.mozilla.org/show_bug.cgi?id=1510569 to update
 `aContentBlockingAllowListPrincipal`: https://searchfox.org/mozilla-
 
central/rev/7531325c8660cfa61bf71725f83501028178cbb9/dom/interfaces/base/nsIBrowser.idl#160.
 I assume it should not be difficult to adapt it to use the old JSM code
 that is still present in esr68, but probably not a straightforward
 backport either.

 So, given that we are hiding/disabling content blocking for now (and in
 principle are not affected by that regression) should we postpone
 backporting this patch until we explore/decide enabling content blocking?
 If yes, perhaps we could update #30939 so that we remember to backport
 this.

 The first two are backported here: https://github.com/acatarineu/tor-
 browser/commits/27601.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, tbb-9.0-must-alpha, |
  TorBrowserTeam201909   |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:17 gk]:
 > We keep this on our radar for two reasons, even though we backported the
 fixes for 1330467:
 >
 > 1) There are follow-up bug fixes that we should backport in case we keep
 the patch series
 > 2) It's not clear yet that the permission isolation works with disabling
 Enhanced Tracking Protection, which we want.

 I think we are good with respect to 2) as we actually don't disable it but
 just the UI while setting it to block third party cookies as we are doing
 right now in the stable series. Which leaves 1).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, tbb-9.0-must-alpha, |
  TorBrowserTeam201909   |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by pili):

 * points:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201908, tbb-9.0   |
  -must-alpha|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: acat (added)


Comment:

 We keep this on our radar for two reasons, even though we backported the
 fixes for 1330467:

 1) There are follow-up bug fixes that we should backport in case we keep
 the patch series
 2) It's not clear yet that the permission isolation works with disabling
 Enhanced Tracking Protection, which we want.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201908, tbb-9.0   |
  -must-alpha|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-8.0-issues, tbb-regression, tbb-8.0.1-can,
 TorBrowserTeam201901 =>
 tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, TorBrowserTeam201908,
 tbb-9.0-must-alpha


Comment:

 Using this for backporting the patch in 1330467.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201901|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, TorBrowserTeam201901,
 ff68-esr-will-have
 => tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, TorBrowserTeam201901


Comment:

 Got backed out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201901, ff68  |
  -esr-will-have |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-8.0-issues, tbb-regression, tbb-8.0.1-can,
 TorBrowserTeam201901 =>
 tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, TorBrowserTeam201901,
 ff68-esr-will-have


Comment:

 https://bugzilla.mozilla.org/show_bug.cgi?id=1330467 got fixed recently.
 Thus, we'll get this latest with the switch to Firefox 68 ESR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8 (was: growl a-like browser notifications are not working anymore on macOS with Tor Br

[Tor Bug Tracker & Wiki]

#27601: browser notifications are not working anymore with Tor Browser 8
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,  |  Actual Points:
  tbb-8.0.1-can, TorBrowserTeam201810|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nsIContentPermissionRequest):

 Replying to [comment:2 mcs]:
 On Windows 10:
 {{{
 0:26:44.707 [Exception... "Component returned failure code: 0x80004005
 (NS_ERROR_FAILURE) [nsIContentPermissionRequest.principal]"  nsresult:
 "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
 
jar:file:///C:/Tor%20Browser/Browser/browser/omni.ja!/components/nsBrowserGlue.js
 :: prompt :: line 3000"  data: no] (unknown)
 prompt
 
jar:file:///C:/Tor%20Browser/Browser/browser/omni.ja!/components/nsBrowserGlue.js:3000:1
 0:26:44.707 NS_ERROR_FAILURE: Component returned failure code: 0x80004005
 (NS_ERROR_FAILURE) [nsIContentPermissionRequest.cancel]
 nsBrowserGlue.js:3024
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs