Re: [tor-bugs] #27984 [Circumvention/BridgeDB]: bridgedb verifyHostname doesn't check subjectAltName extension

2020-06-04 Thread Tor Bug Tracker & Wiki
#27984: bridgedb verifyHostname doesn't check subjectAltName extension
-+
 Reporter:  kaie |  Owner:  agix
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, ex-sponsor19  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 I like your second approach, great work! I left a few minor comments in
 the commit. Do you mind addressing them?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #27984 [Circumvention/BridgeDB]: bridgedb verifyHostname doesn't check subjectAltName extension

2020-06-02 Thread Tor Bug Tracker & Wiki
#27984: bridgedb verifyHostname doesn't check subjectAltName extension
-+--
 Reporter:  kaie |  Owner:  agix
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, ex-sponsor19  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+--
Changes (by agix):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #27984 [Circumvention/BridgeDB]: bridgedb verifyHostname doesn't check subjectAltName extension

2020-06-02 Thread Tor Bug Tracker & Wiki
#27984: bridgedb verifyHostname doesn't check subjectAltName extension
-+--
 Reporter:  kaie |  Owner:  agix
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, ex-sponsor19  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+--

Comment (by agix):

 I basically worked on two different solutions.
 
[https://github.com/agiix/bridgedb/commit/1c3cdb7ff937d5aff1f424d19398c81a437cace7
 Here] the first one.
 
[https://github.com/agiix/bridgedb/commit/574dd30552c1b2911fb0f4097babad09ec6e10c0
 Here] the second one, that uses the service_identity package as previously
 mentioned by kaie.
 \\
 I tend to prefer the latter, since BridgeDB already relies on the package.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #27984 [Circumvention/BridgeDB]: bridgedb verifyHostname doesn't check subjectAltName extension

2020-05-06 Thread Tor Bug Tracker & Wiki
#27984: bridgedb verifyHostname doesn't check subjectAltName extension
-+--
 Reporter:  kaie |  Owner:  agix
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Circumvention/BridgeDB   |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ex-sponsor-19, ex-sponsor19  |  Actual Points:
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
-+--
Changes (by agix):

 * owner:  (none) => agix
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs