Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-12-11 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Patches work for me; merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-12-10 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Thanks for the updated patches!  I'm not set up to easily run scan-build,
 so nickm or someone else properly equipped should smoke test the updated
 script.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-12-08 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by rl1987):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-11-29 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 rl1987]:
 > Reworked the patch to no longer require Bash:
 https://github.com/torproject/tor/pull/545
 Thanks! I made a small comment on the pull request about word expansion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-11-26 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by rl1987):

 * status:  needs_information => needs_review


Comment:

 Reworked the patch to no longer require Bash:
 https://github.com/torproject/tor/pull/545

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-11-20 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by teor):

 Replying to [comment:7 rl1987]:
 > IMO it is perfectly reasonable to expect developers to have bash in
 /bin.

 Many BSD systems have bash in /usr/bin, or as an optional extra.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-11-20 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by nickm):

 How bad would it be to allow any /bin/sh  here?  OTOH for scan-build.sh it
 doesn't seem to bad to require bash.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-11-20 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+

Comment (by rl1987):

 IMO it is perfectly reasonable to expect developers to have bash in /bin.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-10-25 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.3.6.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by catalyst):

 * status:  needs_review => needs_information


Comment:

 Thanks for working on this! At first glance the changes themselves seem
 reasonable.

 Do we really want to restrict ourselves to platforms with bash, or ones
 where it might not be in /bin? I'm not sure we have guidelines for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-10-15 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.6.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-10-12 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.6.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.3.6.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28007 [Core Tor/Tor]: shellcheck: scan-build.sh issues

2018-10-12 Thread Tor Bug Tracker & Wiki 
#28007: shellcheck: scan-build.sh issues
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by rl1987):

 https://github.com/torproject/tor/pull/398

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs