Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen201904, ex-  |
  sponsor-19, tbb-10.0a1 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by sysrqb):

 * status:  needs_review => closed
 * keywords:
 tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen201904, ex-
 sponsor-19
 =>
 tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen201904, ex-
 sponsor-19, tbb-10.0a1
 * resolution:   => fixed


Comment:

 Replying to [comment:43 cohosh]:
 > Woo okay here's a working patch with those fixes, thanks:
 https://gitweb.torproject.org/user/cohosh/tor-browser-
 
build.git/commit/?h=snowflake_android&id=5ef430adf7b7232566955aba86695ea88fd3b642

 Thanks! I rebased this and merged it with commit
 `853e75e9276432a39153db2e3fa54375af9b8822` on `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen201904, ex-  |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * keywords:
 tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen201904, ex-
 sponsor-19
 =>
 tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen201904, ex-
 sponsor-19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen201904, ex-   |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen201904, ex-   |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by cohosh):

 Woo okay here's a working patch with those fixes, thanks:
 https://gitweb.torproject.org/user/cohosh/tor-browser-
 
build.git/commit/?h=snowflake_android&id=5ef430adf7b7232566955aba86695ea88fd3b642

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen201904, ex-   |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by gk):

 I posted some notes and a link to a test bundle with snowflake integration
 in comment:3:ticket:30318.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen201904, ex-   |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * keywords:
 tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen201904, ex-
 sponsor-19
 =>
 tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen201904, ex-
 sponsor-19
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:40 cohosh]:
 > > So, it turns out that Pluto is actually not bundling snowflake at all.
 I guess you could just copy snowflake-client over in the for loop already
 dealing with obfs4proxy. I am not sure why we actually copy things over to
 all the different arch dirs given that we build per arch, but that's up
 for a different bug.
 >
 > I was going to ask what Pluto is and how it knows about obfs4. Does it
 need to build snowflake?

 Pluto is the [https://github.com/guardianproject/pluto Guardian Project's
 pluggable transport library] which is deprecated. We should redo at some
 point the whole tor-android-service/tor-onion-proxy-library parts which
 use Pluto but for now we just play along. :)

 > > Please squash the commits and rebase onto latest master, we are close
 with this ticket (modulo testing that things actually work) I think.
 Thanks.
 >
 > Here it is: https://gitweb.torproject.org/user/cohosh/tor-browser-
 build.git/log/?h=snowflake_android
 >
 > I started my own build of this rebased branch.

 Thanks. Let's just use one `for` loop maybe (see my previous comment),
 like so (untested):
 {{{
 # Extract obfs4proxy from TorBrowser/Tor/PluggableTransports/obfs4proxy
 tar --strip-components=4 -xf $rootdir/[% c('input_files_by_name/obfs4') %]
 # Extract snowflake from TorBrowser/Tor/PluggableTransports/snowflake
 tar --strip-components=4 -xf $rootdir/[%
 c('input_files_by_name/snowflake') %]

 # Overwrite the obfs4proxy binary provided by Pluto and add snowflake
 for d in external/pluto/bin/*; do
   cp obfs4proxy $d/
   cp snowflake-client $d/
 done

 rm obfs4proxy
 rm snowflake-client
 }}}
 ? I don't think we need two separate `for` loops for what we want to do.

 I'll try to come up with some patches for #30318 over the weekend (I copy
 and pasted things for the browser part already I believe), so we can
 actually test on mobile.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen201904, ex-  |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  needs_revision => needs_review


Comment:

 > So, it turns out that Pluto is actually not bundling snowflake at all. I
 guess you could just copy snowflake-client over in the for loop already
 dealing with obfs4proxy. I am not sure why we actually copy things over to
 all the different arch dirs given that we build per arch, but that's up
 for a different bug.

 I was going to ask what Pluto is and how it knows about obfs4. Does it
 need to build snowflake?

 > Please squash the commits and rebase onto latest master, we are close
 with this ticket (modulo testing that things actually work) I think.
 Thanks.

 Here it is: https://gitweb.torproject.org/user/cohosh/tor-browser-
 build.git/log/?h=snowflake_android

 I started my own build of this rebased branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen201904, ex-  |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:37 cohosh]:
 > Okay here's an additional commit on the
 [https://gitweb.torproject.org/user/cohosh/tor-browser-
 build.git/log/?h=snowflake_android snowflake_android] branch that bundles
 snowflake with tor browser for android. I followed the same procedure used
 for obfs4 to enable it only for alpha and nightlies in `rbm.conf` and
 bundle it with `tor-onion-proxy-library`.

 So, it turns out that Pluto is actually not bundling `snowflake` at all. I
 guess you could just copy `snowflake-client` over in the for loop already
 dealing with `obfs4proxy`. I am not sure why we actually copy things over
 to all the different arch dirs given that we build per arch, but that's up
 for a different bug.

 Please squash the commits and rebase onto latest `master`, we are close
 with this ticket (modulo testing that things actually work) I think.
 Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen201904, ex-  |
  sponsor-19 |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, GeorgKoppen201904, ex-sponsor-19 =>
 tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen201904, ex-
 sponsor-19


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen201904, ex-sponsor-19   |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  needs_revision => needs_review


Comment:

 Okay here's an additional commit on the
 [https://gitweb.torproject.org/user/cohosh/tor-browser-
 build.git/log/?h=snowflake_android snowflake_android] branch that bundles
 snowflake with tor browser for android. I followed the same procedure used
 for obfs4 to enable it only for alpha and nightlies in `rbm.conf` and
 bundle it with `tor-onion-proxy-library`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen201904, ex-sponsor-19   |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * keywords:
 tbb-mobile, tbb-rbm, GeorgKoppen201904, ex-sponsor-19,
 TorBrowserTeam202005R
 => tbb-mobile, tbb-rbm, GeorgKoppen201904, ex-sponsor-19
 * status:  needs_review => needs_revision


Comment:

 `needs_revision` as per feedback on #tor-dev.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen201904, ex-sponsor-19,  |
  TorBrowserTeam202005R  |
Parent ID:  #30318   | Points:
 Reviewer:  gk   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gk):

 * keywords:
 tbb-mobile, tbb-rbm, GeorgKoppen201904, ex-sponsor-19,
 TorBrowserTeam201907
 =>
 tbb-mobile, tbb-rbm, GeorgKoppen201904, ex-sponsor-19,
 TorBrowserTeam202005R
 * reviewer:   => gk


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28672 [Applications/Tor Browser]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-+-
 Reporter:  dcf  |  Owner:  cohosh
 Type:  project  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  GeorgKoppen201904, ex-sponsor-19,  |
  TorBrowserTeam201907   |
Parent ID:  #30318   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  assigned => needs_review
 * component:  Circumvention/Snowflake => Applications/Tor Browser


Comment:

 Hmm okay it seems that this ticket is just for building snowflake and
 #30318 is for integrating with Tor Browser. I'll put this in needs_review
 then since reproducible builds are now working.

 Here's the single patch needed: https://gitweb.torproject.org/user/cohosh
 /tor-browser-
 
build.git/commit/?h=snowflake_android&id=bec6cbace3d6c5125beac926645341b0921fb792

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs