Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam202006R  |
Parent ID:  #30506   | Points:
 Reviewer:  gk   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-torbutton, TorBrowserTeam202003R, TorBrowserTeam202006 =>
 tbb-torbutton, TorBrowserTeam202006R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam202001R  |
Parent ID:  #30506   | Points:
 Reviewer:  gk   |Sponsor:
-+-

Comment (by gk):

 Resolved #10575 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam202001R  |
Parent ID:  #30506   | Points:
 Reviewer:  gk   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:32 acat]:
 > Replying to [comment:28 gk]:
 > > Okay, let's move on with the review process, commit
 8269902a22357697c46c7052c9d946bd874c3f55:
 > >
 > > Looks mostly good. It misses a `tor-browser` change to remove the
 `extensions.torbutton.updateNeeded` and
 `extensions.torbutton.versioncheck_enabled` pref, now that we moved the
 preferences. Additionally, please remove the `torbutton-update-needed.svg`
 as well. It seems to be obsolete now, too.
 > >
 > > For 8c0c18a09a30f14dd0b4a99fe67238fec0ad3bac what command did you
 run/tool did you use to check for those errors (and fix them)?
 >
 > Hmm, i can't find `8269902a22357697c46c7052c9d946bd874c3f55` commit, I
 assume it was from `torbutton` (I hope it was not `push --force` again).

 Hrm. I still have that commit but not on any branch it seems?? Weird.
 Anyway, it is essentially `0a3ec4944f4d03bc05c6d557ea7008df81e4dcac` on
 your `28745+4`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam202001R  |
Parent ID:  #30506   | Points:
 Reviewer:  gk   |Sponsor:
-+-
Changes (by acat):

 * keywords:  tbb-torbutton, TorBrowserTeam202001 => tbb-torbutton,
 TorBrowserTeam202001R
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:28 gk]:
 > Okay, let's move on with the review process, commit
 8269902a22357697c46c7052c9d946bd874c3f55:
 >
 > Looks mostly good. It misses a `tor-browser` change to remove the
 `extensions.torbutton.updateNeeded` and
 `extensions.torbutton.versioncheck_enabled` pref, now that we moved the
 preferences. Additionally, please remove the `torbutton-update-needed.svg`
 as well. It seems to be obsolete now, too.
 >
 > For 8c0c18a09a30f14dd0b4a99fe67238fec0ad3bac what command did you
 run/tool did you use to check for those errors (and fix them)?

 Hmm, i can't find `8269902a22357697c46c7052c9d946bd874c3f55` commit, I
 assume it was from `torbutton` (I hope it was not `push --force` again).

 In any case, I removed the mentioned prefs and some more that are now
 unused from `000-tor-browser-prefs.js`: https://github.com/acatarineu/tor-
 browser/commit/28745+3. Some are unused because of changes already
 commited, some are due to `torbutton` changes from this ticket not yet
 commited.

 I also rebased the torbutton changes from `28745+4` to current master, and
 removed `torbutton-updated-needed.svg`. Besides, I split the style-
 changing commits into two, the ones automatically done by eslint tool, and
 the remaining ones that had to be addressed manually. Changes are in
 https://github.com/acatarineu/torbutton/commits/28745+5.

 The command to fix `eslint` issues was `./mach lint -l eslint --fix
 toolkit/torproject/torbutton`, run in the `tor-browser` repo with the
 right `torbutton` repo temporarily checked in in
 `toolkit/torproject/torbutton` (this time I also had to run `./mach
 bootstrap --no-system-changes` with Desktop selected before, which is
 new).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201912  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:  gk   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:22 acat]:

 [snip]

 > There were some conflicts with the last commit of 28745+2
 (2d318efde8faccf3980c6d7da163c32103202b26) and the
 46efc92348dbed06fc31ddfb0a5ac2e4e8554de2 commit in master (#30237). I
 think these are not straightforward to solve, as in that commit I moved
 `m_tb_control_ipc_file, m_tb_control_host, m_tb_control_port,
 m_tb_control_pass, m_tb_control_desc` to a service while in the master
 commit those were moved to a different module and initialized via
 `configureControlPortModule`. I would suggest dropping that commit for
 now, and perhaps do it later in #30850 (some of the previous dropped
 commits are also related to that one).

 Sounds good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201912R  |
Parent ID:  #30506   | Points:
 Reviewer:  gk   |Sponsor:
-+-

Comment (by gk):

 Okay, let's move on with the review process, commit
 8269902a22357697c46c7052c9d946bd874c3f55:

 Looks mostly good. It misses a `tor-browser` change to remove the
 `extensions.torbutton.updateNeeded` and
 `extensions.torbutton.versioncheck_enabled` pref, now that we moved the
 preferences. Additionally, please remove the `torbutton-update-needed.svg`
 as well. It seems to be obsolete now, too.

 For 8c0c18a09a30f14dd0b4a99fe67238fec0ad3bac what command did you run/tool
 did you use to check for those errors (and fix them)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201912  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:  gk   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-torbutton, TorBrowserTeam201912R => tbb-torbutton,
 TorBrowserTeam201912


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  tbb-torbutton, TorBrowserTeam201911 => tbb-torbutton,
 TorBrowserTeam201911R
 * status:  needs_revision => needs_review


Comment:

 Done in https://github.com/acatarineu/torbutton/commits/28745+4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I closed #30888 as the changes look good to me now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton, TorBrowserTeam201911R => tbb-torbutton,
 TorBrowserTeam201911
 * status:  needs_review => needs_revision


Comment:

 Thanks. While I am preparing a patch for #30787 I realized that it seems
 we forgot to clean up the respective locale files, too, while removing the
 code. E.g. I am right now still seeing `torbutton.cookieDialog.*` entries.
 Could you go over the locale files and get rid of the string we don't need
 anymore due to this clean-up?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  assigned => needs_review
 * keywords:  tbb-torbutton, TorBrowserTeam201911 => tbb-torbutton,
 TorBrowserTeam201911R


Comment:

 Thanks for the review.

 Revised branch: https://github.com/acatarineu/torbutton/commits/28745+3.

 With respect to the `k_tb_browser_update_needed_pref` comment, I decided
 to squash `Remove versioncheck from torbutton.js` and `Remove code dealing
 with torbutton UI button in toolbar`, as some of the requested changes
 were already included in the other commit, and I think these are related
 (we can remove versioncheck because there is not torbutton UI anymore).

 There were some conflicts with the last commit of 28745+2
 (2d318efde8faccf3980c6d7da163c32103202b26) and the
 46efc92348dbed06fc31ddfb0a5ac2e4e8554de2 commit in master (#30237). I
 think these are not straightforward to solve, as in that commit I moved
 `m_tb_control_ipc_file, m_tb_control_host, m_tb_control_port,
 m_tb_control_pass, m_tb_control_desc` to a service while in the master
 commit those were moved to a different module and initialized via
 `configureControlPortModule`. I would suggest dropping that commit for
 now, and perhaps do it later in #30850 (some of the previous dropped
 commits are also related to that one).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  acat
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: tbb-team (added)
 * owner:  tbb-team => acat
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton, TorBrowserTeam201911R => tbb-torbutton,
 TorBrowserTeam201911
 * status:  needs_review => needs_revision


Comment:

 commit a12088fdc0d343d81b6ecf53faf06c91f8da27d5 looks good. I've applied
 it tor `torbutton`'s `master` (commit
 65e1e8ba67ba865e7b3ded74b7e4bbc5b86c721c)

 Some nits and a question for commit
 7e23b3cbf66717c1b9b3a107daf3147b54061a96:
 {{{
 +/* global ,
 }}}
 I think you don't want to have a `,` + whitespace there?

 Are you sure we want to do
 {{{
 -  let firstPartyDomain = getDomainForBrowser(gBrowser.selectedBrowser);
 +  let firstPartyDomain = getDomainForBrowser(gBrowser);
 }}}
 ? In `utils.js` it says
 {{{
 // Assuming this is called with gBrowser.selectedBrowser
 var getDomainForBrowser = (browser) => {
 }}}
 Please remove the superfluous whitespaces in
 {{{
 +// So we can use it in boolean expressions to determine where the
 }}}
 and
 {{{
 +function torbutton_get_property_string(propertyname)
 +{
 +try {
 }}}
 (the `try` line)

 commit 38720bfe8f88248534d4d211a40274c613a6ade6:

 1) Do we really need the remaining `k_tb_browser_update_needed_pref` parts
 (including the pref) now that the pref observer is gone (and the code
 acting upon pref changes)? What about the respective button CSS parts?
 Can't we get rid of them as well in this commit? For instance, if we don't
 set `tbStatus` anymore it seems to me we don't need the `[tb-status="on"]`
 and `[tb-status="off"]` parts anymore either etc.

 2) Please adapt the commit message to what has happened since you wrote
 it. :)

 Please base your new branch on current `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Thanks. I close #30851 as the updated changes look good to me. And I
 applied the `m_tb_tbb` one to `torbutton`'s `master` (comit
 6b1a5ded2cab7e51aeb504483fa0d8fbf0cae957). Getting closer...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  tbb-torbutton, TorBrowserTeam201911 => tbb-torbutton,
 TorBrowserTeam201911R
 * status:  needs_revision => needs_review


Comment:

 Revised branches: https://github.com/acatarineu/tor-
 browser/commits/28745+2 and
 https://github.com/acatarineu/torbutton/commits/28745+2.

 I moved the `extensions.torbutton.launch_warning = false` mobile override
 to `000-tor-browser-android.js`.

 >Have you tested that moving browser.startup.homepage is fine now and that
 we can ditch non-localized.properties in torbutton? The code mentioned in
 the comment is still there. But I guess we don't hit the codepath as we
 are not setting any default prefs in the extension anymore?
 Yes, I tested that it works fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-torbutton, TorBrowserTeam201911R => tbb-torbutton,
 TorBrowserTeam201911


Comment:

 Commit 46b550c5550d3ad4a7d526a402a33bbb40dce5e2 on your `torbutton` branch
 has
 {{{
 -  // Disable the External App Blocker on Android
 -  if ((aPrefName === "extensions.torbutton.launch_warning") &&
 -  (Services.appinfo.OS === "Android")) {
 -defaultPrefBranch.setBoolPref(aPrefName, false);
 -  }
 }}}
 It seems we want to keep that part, though, and I don't see a matching
 counterpart in any of your related `tor-browser` commits.

 Commit f797d8ba19c5838032abff6da3c4b5e8cabc518f on your `tor-browser`
 branch:
 {{{
 +pref("extensions.torbutton.cookie_protections",true);
 +pref("extensions.torbutton.cookie_auto_protect",false);
 }}}
 That's already gone, I think.
 {{{
 +pref("extensions.torbutton.prompt_torbrowser", true);
 }}}
 No need to add this anymore, see my previous comment.
 {{{
 +// TODO: This is just part of a stopgap until #14429 gets properly
 implemented.
 +// See #7255 for details. We display the warning three times to make sure
 the
 +// user did not click on it by accident.
 }}}
 I think we should update the comment at least. We still have this
 mechanism for users that disable letterboxing, I think.

 Have you tested that moving `browser.startup.homepage` is fine now and
 that we can ditch `non-localized.properties` in `torbutton`? The code
 mentioned in the comment is still there. But I guess we don't hit the
 codepath as we are not setting any default prefs in the extension anymore?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Could you remove the `extensions.torbutton.prompt_torbrowser` pref in the
 commit where you are removing all the `m_tb_tbb` parts? It seems that pref
 removal belongs there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201911R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton, TorBrowserTeam201910R => tbb-torbutton,
 TorBrowserTeam201911R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Alright I started reviewing and applying patches. The first two landed on
 `master` (the latter closing #28746): commit
 2dfa0e0c9cff7cfad93664e0b0b6cdc05b24b7f2 and
 938997fa6de418e423186a5fe5c3e8adf4d82a38.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201910R  |
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  needs_revision => needs_review
 * keywords:  tbb-torbutton, TorBrowserTeam201910 => tbb-torbutton,
 TorBrowserTeam201910R


Comment:

 Rebased in https://github.com/acatarineu/torbutton/commits/28745+1 and
 https://github.com/acatarineu/tor-browser/commits/28745+1.

 I dropped some commits wrt the original `torbutton` changes (`Refactor
 code to always use tor-control-port.js`, `Tor controller promises should
 fail when there is an error`, `Move torbutton_do_new_identity to separate
 module`, `Move some code from torbutton to torCheckService`) as I was not
 sure whether they fit in this ticket or they added much value, and the
 changes were quite big already. Maybe we can continue on these on later
 torbutton refactors?

 I think #13198 would be fixed with these changes, and perhaps #19256 too,
 although there might be more dead code that I missed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201910  |  Actual Points:
Parent ID:  #30506   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton, TorBrowserTeam201910R => tbb-torbutton,
 TorBrowserTeam201910
 * status:  needs_review => needs_revision
 * parent:   => #30506


Comment:

 We'd want to have this rebased I think (sorry for the delay).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 #13198

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 #19256

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton TorBrowserTeam201907R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 > Refactor code to always use tor-control-port.js
 It's a rewriting, not only refactoring. Should we do it inside the general
 clean-up?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton TorBrowserTeam201907R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  tbb-torbutton => tbb-torbutton TorBrowserTeam201907R
 * status:  new => needs_review


Comment:

 Some changes for review here:
 https://github.com/acatarineu/torbutton/commits/28745 (starting from
 6023e0875c8085a58e6269801113a2a4600cb6d3, which is the last commit from
 #10760 patch). Corresponding tor-browser changes here:
 https://github.com/acatarineu/tor-browser/commits/28745 (last 4 commits).

 Some comments:

 Remove cookie-jar-selector component
   - For `browser.privatebrowsing.autostart = true`, cookie-jar-selector
 does nothing currently, so for new identity we just `clearCookies()`.
   - For `browser.privatebrowsing.autostart = false`, some cookies json
 files are stored in the browser profile folder, which we clear on startup
 in the patch.
 Bug 30851: Move default preferences to 000-tor-browser.js
   - This has a corresponding patch in tor-browser.
 Bug 30888: move torbutton_util.js to modules/utils.js
   - This also has a corresponding patch in tor-browser, to stop including
 torbutton_util.js in browser.xul.
 Make torbutton_open_network_settings global
   - This will have to be called somewhere in UI at some point, for now we
 just expose it.
 Refactor code to always use tor-control-port.js
   - Trying to use a single implementation of tor controller. Perhaps next
 step would be to do the same with tor-launcher.
   - The code had to be adapted a bit, since tor-control-port.js is async
 while previous impl. was sync.
 Remove versioncheck from torbutton.js
   - I'm assuming we don't need this, with the browser updater and having
 removed the blinking notification in torbutton UI. But perhaps we still
 want as telemetry, not sure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by acat):

 * status:  needs_review => new


Comment:

 I think it's better to wait until #10760 changes are reviewed and
 accepted, because the changes here will depend on that. So removing the
 review flag until then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by acat):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by acat):

 There is some work in
 https://github.com/acatarineu/torbutton/compare/10760...10760+1. Adding it
 here instead of #10760, and assuming this is a next step. Commit for
 #30851 needs tor-browser changes from https://github.com/acatarineu/tor-
 browser/commit/30851.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: igt0 (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs