Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Added those in a0a3694fd16660911756eb1d38c9c0efc4a35334.

 Squashed and merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:8 nickm]:
 > Okay, I think the branch is better now.  The leftovers are gone, it
 passes the tests you gave, and still passes the fuzzer.

 lgtm;

 But before merging, can you do a fixup that adds the test cases I added on
 the ticket that caught `AB=`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Okay, I think the branch is better now.  The leftovers are gone, it passes
 the tests you gave, and still passes the fuzzer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Provided a review. Majority of comments are about leftovers in the code.
 The more important thing is about a test case I tried which failed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+

Comment (by nickm):

 I've made a new ticket, "ticket28755_v2", including a fuzzer.  PR at
 https://github.com/torproject/tor/pull/577

 The initial implementation is a bit different, because the fuzzer found a
 bunch of problems, most of them related to eat_whitespace() not doing what
 I expected, and a few of them related to ambiguity involving weird
 standalone values like "=foo" or "".

 The fuzzing corpus is in a "strops" branch in my private fuzzing-corpora
 repo; I'll merge that when you like this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+

Comment (by nickm):

 Good call. I found a couple of bugs while fuzzing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+

Comment (by ahf):

 Looks very good for our use case. A fuzz function might be a good idea to
 get in.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+

Comment (by teor):

 We could test this branch by moving all our K=V parsing over to it, and
 running the unit and integration tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:  ahf, dgoulet  |Sponsor:
--+
Changes (by dgoulet):

 * reviewer:   => ahf, dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28755 [Core Tor/Tor]: Implement a K/V parser library

[Tor Bug Tracker & Wiki]

#28755: Implement a K/V parser library
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .3
Parent ID:  #25502| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review
 * actualpoints:   => .3


Comment:

 Branch `ticket28755` has my first take on this.  PR at
 https://github.com/torproject/tor/pull/568 .  More testing and/or fuzzing
 might be a good idea here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs