Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This is fixed by commit 06bb0f2d4c91d7ac60ae180297d3c0707a004199 (see
 ticket:33877#comment:5).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by sisbell):

 After breaking out #33877, this commit only contains the android config

 https://github.com/sisbell/tor-browser-build/commits/bug-28765d

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:31 gk]:

 > There is still comment:12 unaddressed,no?

 See #33877

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by gk):

 There is still comment:12 unaddressed,no?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sisbell):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R
 * status:  needs_revision => needs_review


Comment:

 I made the changes to #31499 so this is ready for review again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:28 sisbell]:
 > I added the 'configure_opt_project' in rbm.conf for linux-x86_64 so that
 it will pick now
 >
 > I removed reference to 'var/configure_opt_i686' and just collapsed it
 into the 'var/configure_opt' field
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-28765c

 The patch for #28765 looks good, but is difficult to test since it is
 based on a version of the patch for #31499 which doesn't build on Linux.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sisbell):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R
 * status:  needs_revision => needs_review


Comment:

 I added the 'configure_opt_project' in rbm.conf for linux-x86_64 so that
 it will pick now

 I removed reference to 'var/configure_opt_i686' and just collapsed it into
 the 'var/configure_opt' field

 https://github.com/sisbell/tor-browser-build/commits/bug-28765c

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:25 sysrqb]:
 > Is `configure_opt_project` included on linux-x86_64?

 Yes, I think it is missing.

 By the way, while doing this change, I think we can simplify
 `configure_opt` on `linux-i686` by renaming `var/configure_opt_i686` to
 `var/configure_opt`. I'm not sure why we have this `configure_opt_i686`,
 as it doesn't seem to be used anywhere else.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 Is `configure_opt_project` included on linux-x86_64?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sisbell):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202003 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202003R
 * status:  needs_revision => needs_review


Comment:

 I updated the other platforms to includevar/configure_opt_projectin the
 rbm.conf file. Built windows, mac and linux variant to make sure it didn't
 break

 https://github.com/sisbell/tor-browser-build/commits/bug-28765b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202003R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202003
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:20 sisbell]:
 > This commit now includes using a configure_opt_project variable. I
 verified this is building correctly for android. Again I still need to
 test with #31499 to verify all platforms.

 I think it doesn't work on other platforms: the commit moves the
 `--disable-static` from `projects/libevent/build` to
 `var/configure_opt_project`, but the `var/configure_opt` from other
 platforms does not use `var/configure_opt_project`.

 I think we should update the `var/configure_opt` in `rbm.conf` from all
 platforms to include `var/configure_opt_project`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sisbell):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202003R
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by sisbell):

 #31499 now includes the version change for libevent (I sitll need to test
 this for non-android platforms)

 #33216 contains the CC=clang and host info

 This commit now includes using a configure_opt_project variable. I
 verified this is building correctly for android. Again I still need to
 test with #31499 to verify all platforms.

 !https://github.com/sisbell/tor-browser-build/commits/bug-28765a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by gk):

 Replying to [comment:16 boklm]:
 > Replying to [comment:14 sisbell]:
 > > Broke commit into its own branch, otherwise no changes since last
 commit.
 > >
 > > https://github.com/sisbell/tor-browser-build/commits/bug-28765
 >
 > When looking at commit f73f0125252cdf18596291c45ba3d92cb719b883:
 >
 > You define `var/configure_opt` to `--disable-static` in
 `project/libevent/config` for all platforms except android. I think this
 is wrong as `var/configure_opt` already has some values defined in
 `rbm.conf`, so we override those values which will probably break the
 build on non-android platforms.
 >
 > By the way in ticket:28704#comment:14 I said this:
 > > it seems we could have a var/configure_opt for android in `rbm.conf`
 containing something like `CC=clang --host=[% c("var/host") %] [%
 c("var/configure_opt_project") %]`, where `var/configure_opt_project` is
 defined in each project to define options specific to this project
 > I still think that would be a good idea. If you don't think so, then
 please at least explain why instead of just ignoring comments and not
 doing the changes suggested.
 >
 > Regarding update to version `2.1.11`, I think it would be a good idea to
 mention it in the commit message. Or maybe do it as a separate commit
 (with #31499 as the bug number) as this is a change that affect all
 platforms.

 +1 for a separate commit before a the patch for this ticket (and making
 sure the other platforms are not exploding)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:17 sisbell]:
 > >
 > > By the way in ticket:28704#comment:14 I said this:
 > >
 > > > it seems we could have a var/configure_opt for android in `rbm.conf`
 containing something like `CC=clang --host=[% c("var/host") %] [%
 c("var/configure_opt_project") %]`, where `var/configure_opt_project` is
 defined in each project to define options specific to this project
 > > >
 > > I still think that would be a good idea. If you don't think so, then
 please at least explain why instead of just ignoring comments and not
 doing the changes suggested.
 >
 > I didn't ignore the comment. i previously stated the reason I didn't do
 it and requested more discussion around a solution.

 Ah, indeed, I missed that. Sorry.

 >
 > "There was a suggestion to move some of the fields in configure_opt up
 to  rbm.  OpenSSL doesn't use the same configure_host value as other
 projects so this will require some more discussion if we want to move
 forward with this suggestion."

 I think openssl not using `var/configure_opt` is not a reason for not
 using it in other projects. We are in the same situation on other
 platforms, where we define `var/configure_opt`, and use it in some
 projects, and not in others projects expecting different options like
 openssl.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:16 boklm]:


 > Replying to [comment:14 sisbell]:
 >
 > > Broke commit into its own branch, otherwise no changes since last
 commit.
 > >
 > > https://github.com/sisbell/tor-browser-build/commits/bug-28765
 > >
 >
 > When looking at commit f73f0125252cdf18596291c45ba3d92cb719b883:
 >
 > You define `var/configure_opt` to `--disable-static` in
 `project/libevent/config` for all platforms except android. I think this
 is wrong as `var/configure_opt` already has some values defined in
 `rbm.conf`, so we override those values which will probably break the
 build on non-android platforms.
 Ok that should be easy to fix.

 >
 >
 > By the way in ticket:28704#comment:14 I said this:
 >
 > > it seems we could have a var/configure_opt for android in `rbm.conf`
 containing something like `CC=clang --host=[% c("var/host") %] [%
 c("var/configure_opt_project") %]`, where `var/configure_opt_project` is
 defined in each project to define options specific to this project
 > >
 > I still think that would be a good idea. If you don't think so, then
 please at least explain why instead of just ignoring comments and not
 doing the changes suggested.

 I didn't ignore the comment. i previously stated the reason I didn't do it
 and requested more discussion around a solution.

 "There was a suggestion to move some of the fields in configure_opt up to
 rbm.  OpenSSL doesn't use the same configure_host value as other  projects
 so this will require some more discussion if we want to move  forward with
 this suggestion."

 https://trac.torproject.org/projects/tor/ticket/28704#comment:23
 >
 > Regarding update to version `2.1.11`, I think it would be a good idea to
 mention it in the commit message. Or maybe do it as a separate commit
 (with #31499 as the bug number) as this is a change that affect all
 platforms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:14 sisbell]:
 > Broke commit into its own branch, otherwise no changes since last
 commit.
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-28765

 When looking at commit f73f0125252cdf18596291c45ba3d92cb719b883:

 You define `var/configure_opt` to `--disable-static` in
 `project/libevent/config` for all platforms except android. I think this
 is wrong as `var/configure_opt` already has some values defined in
 `rbm.conf`, so we override those values which will probably break the
 build on non-android platforms.

 By the way in ticket:28704#comment:14 I said this:
 > it seems we could have a var/configure_opt for android in `rbm.conf`
 containing something like `CC=clang --host=[% c("var/host") %] [%
 c("var/configure_opt_project") %]`, where `var/configure_opt_project` is
 defined in each project to define options specific to this project
 I still think that would be a good idea. If you don't think so, then
 please at least explain why instead of just ignoring comments and not
 doing the changes suggested.

 Regarding update to version `2.1.11`, I think it would be a good idea to
 mention it in the commit message. Or maybe do it as a separate commit
 (with #31499 as the bug number) as this is a change that affect all
 platforms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_revision => needs_review


Comment:

 Broke commit into its own branch, otherwise no changes since last commit.

 https://github.com/sisbell/tor-browser-build/commits/bug-28765

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:12 sysrqb]:


 > Replying to [ticket:28704#comment:23 sisbell]:
 >
 > > Other issues:
 > >
 > > 1. There was a suggestion to move some of the fields in configure_opt
 up to rbm.  OpenSSL doesn't use the same configure_host value as other
 projects so this will require some more discussion if we want to move
 forward with this suggestion.
 > > 1. Information regarding libevent --disable-libevent-regress--disable-
 samples. I need to look back through my notes. I'll post in a follow up
 comment.
 > >
 >
 > From ticket:28704#comment:26, do including these change the size of the
 resulting library? I'd rather disable these for all platforms in a
 separate ticket.

 The tar files themselves are a few bytes off (looks to be due to timestamp
 differences on files). But after unarchiving, the following directories
 all have the same size

  * libevent --disable-libevent-regress --disable-samples
  * libevent --disable-libevent-regress
  * libevent --disable-samples
  * libevent

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-

Comment (by sysrqb):

 Replying to [ticket:28704#comment:23 sisbell]:
 > Other issues:
 >
 >  1. There was a suggestion to move some of the fields in configure_opt
 up to rbm.  OpenSSL doesn't use the same configure_host value as other
 projects so this will require some more discussion if we want to move
 forward with this suggestion.
 >  1. Information regarding libevent --disable-libevent-regress--disable-
 samples. I need to look back through my notes. I'll post in a follow up
 comment.

 From ticket:28704#comment:26, do including these change the size of the
 resulting library? I'd rather disable these for all platforms in a
 separate ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202001   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202001R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202001


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912R, tbb-parity  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:  sysrqb, boklm|Sponsor:
-+-
Changes (by sysrqb):

 * reviewer:   => sysrqb, boklm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912R, tbb-parity  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 FWIW, I think bumping Libevent to 2.1.11 is the right thing to do (we
 would squash #31499 while doing so, which is nice).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912R, tbb-parity  |
Parent ID:  #28704   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  assigned => needs_review
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201912, tbb-parity => tbb-
 mobile, tbb-rbm, TorBrowserTeam201912R, tbb-parity


Comment:

 I verified it builds on 4 targets. I updated the version to 2.1.11

 https://github.com/sisbell/tor-browser-
 build/commit/da222654e20ad1878f238fde0eb1f9caed905d53

 If we continue with 2.1.8, we get the following error. We can apply a
 patch if we want to support this older version.

 {{{
 ./.libs/libevent_core-2.1.so: error: undefined reference to
 'arc4random_addrandom'
 }}}

 I have the other flags because sample and libevent regress are triggering
 tests which have unsupported classes (older versions of tor-android do the
 same thing)


 {{{
 test/test-dumpevents.c:104: error: undefined reference to 'stdout'
 test/test-dumpevents.c:104: error: undefined reference to 'stderr'
 }}}

 If we need libevent regress, we could patch and remove the tests

 {{{
 AM_CONDITIONAL([BUILD_SAMPLES], [test "$enable_samples" = "yes"])
 AM_CONDITIONAL([BUILD_REGRESS], [test "$enable_libevent_regress" = "yes"])
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 For Reference, Google's Android build config

 
https://android.googlesource.com/platform/external/libevent/+/0895a49cc55794c7fc41e78c53ffa9882377dcc7/README.android

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201812, tbb-parity => tbb-
 mobile, tbb-rbm, TorBrowserTeam201912, tbb-parity
 * owner:  tbb-team => sisbell
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * points:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs