Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.5.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.4.9
 Severity:  Normal | Resolution:
   |  implemented
 Keywords:  startup performance  035-backport  |  Actual Points:  0
Parent ID:  #28481 | Points:
 Reviewer:  asn|Sponsor:
   |  Sponsor8-can
---+---
Changes (by teor):

 * milestone:  Tor: 0.4.0.x-final => Tor: 0.3.5.x-final


Comment:

 Merged to 0.3.5.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.4.9
 Severity:  Normal | Resolution:
   |  implemented
 Keywords:  startup performance  035-backport  |  Actual Points:  0
Parent ID:  #28481 | Points:
 Reviewer:  asn|Sponsor:
   |  Sponsor8-can
---+---
Changes (by nickm):

 * actualpoints:   => 0


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.4.9
 Severity:  Normal | Resolution:
   |  implemented
 Keywords:  startup performance  035-backport  |  Actual Points:
Parent ID:  #28481 | Points:
 Reviewer:  asn|Sponsor:
   |  Sponsor8-can
---+---
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged to 0.3.5 and forward; I think we already do more spot-checking than
 this in the unit tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:
   |  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.4.9
 Severity:  Normal | Resolution:
 Keywords:  startup performance  035-backport  |  Actual Points:
Parent ID:  #28481 | Points:
 Reviewer:  asn|Sponsor:
   |  Sponsor8-can
---+---
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM. Maybe we can also consider moving this check on the unittests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.4.9
 Severity:  Normal | Resolution:
 Keywords:  startup performance  035-backport  |  Actual Points:
Parent ID:  #28481 | Points:
 Reviewer: |Sponsor:
   |  Sponsor8-can
---+---

Comment (by dgoulet):

 Very simple, lgtm;

 I'm not familiar enough with this though to judge how much that is a "bad"
 idea vs "good" idea. So I'll rely on you for the reasoning behind this
 choice. Apart from that, trivial change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.4.9
 Severity:  Normal | Resolution:
 Keywords:  startup performance  035-backport  |  Actual Points:
Parent ID:  #28481 | Points:
 Reviewer: |Sponsor:
   |  Sponsor8-can
---+---
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 See branch `ticket28835_035` in my public repository, with PR at
 https://github.com/torproject/tor/pull/585

 This change is so simple that I think it would be safe to backport to Tor
 0.3.5.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.4.9
 Severity:  Normal | Resolution:
 Keywords:  startup performance  035-backport  |  Actual Points:
Parent ID:  #28481 | Points:
 Reviewer: |Sponsor:
   |  Sponsor8-can
---+---
Changes (by nickm):

 * keywords:  startup performance => startup performance  035-backport
 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28838 [Core Tor/Tor]: Make curve25519_basepoint_spot_check() faster

[Tor Bug Tracker & Wiki]

#28838: Make curve25519_basepoint_spot_check() faster
-+
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.4.9
 Severity:  Normal   | Resolution:
 Keywords:  startup performance  |  Actual Points:
Parent ID:  #28481   | Points:
 Reviewer:   |Sponsor:  Sponsor8-can
-+
Changes (by nickm):

 * keywords:  android startup performance controller => startup performance


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs