Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:  3
  040-backport, postfreeze-ok, network-team- |
  roadmap-july   |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Backported to 0.3.5.
 Merged with the other 0.3.5 and 0.4.0 backports on 2019-08-12.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:  3
  040-backport, postfreeze-ok, network-team- |
  roadmap-july   |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * keywords:
 tor-hs-reachability, 029-backport-maybe, 035-backport, 040-backport,
 postfreeze-ok, network-team-roadmap-july, 034-unreached-backport-maybe
 =>
 tor-hs-reachability, 035-backport, 040-backport, postfreeze-ok,
 network-team-roadmap-july
 * actualpoints:   => 3
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.3.5.x-final


Comment:

 This ticket doesn't have any code for 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-july   |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by teor):

 This PR was merged into 0.4.0, so it can be merged now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0415, tor-   |  Actual Points:
  hs-reachability, 029-backport-maybe, 034   |
  -backport-maybe, 035-backport, 040-backport,   |
  postfreeze-ok, network-team-roadmap-july   |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * keywords:
 tor-hs-reachability, 029-backport-maybe, 034-backport-maybe,
 035-backport, 040-backport, postfreeze-ok, network-team-roadmap-july
 =>
 consider-backport-after-0415, tor-hs-reachability, 029-backport-maybe,
 034-backport-maybe, 035-backport, 040-backport, postfreeze-ok,
 network-team-roadmap-july


Comment:

 This PR was merged into 0.4.1.4, so we will test it until 0.4.1.5 is
 released, then merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-july   |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by gaba):

 * keywords:
 tor-hs-reachability, 029-backport-maybe, 034-backport-maybe,
 035-backport, 040-backport, postfreeze-ok, network-team-
 roadmap-2019-Q1Q2
 =>
 tor-hs-reachability, 029-backport-maybe, 034-backport-maybe,
 035-backport, 040-backport, postfreeze-ok, network-team-roadmap-july


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Here is the new backport branch for 0.3.5+:
 https://github.com/torproject/tor/pull/1077

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * owner:  dgoulet => mikeperry
 * status:  merge_ready => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by nickm):

 We should not backport this; instead we should backport
 c525135dac354892a45ad3d2f6de9450d393f09f combined with the changes file
 for this branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * parent:  #28634 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * keywords:
 tor-hs-reachability, 029-backport-maybe, 034-backport-maybe,
 035-backport, 040-backport, postfreeze-ok, network-team-
 roadmap-2019-Q1Q2, 041-should
 =>
 tor-hs-reachability, 029-backport-maybe, 034-backport-maybe,
 035-backport, 040-backport, postfreeze-ok, network-team-
 roadmap-2019-Q1Q2
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 Okay, merged!  Marking for possible backport, but before we do so, let's
 confirm that backporting would actually help something.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 OK let's get this merged. We still don't know if it helps against #28970
 and #27471 but the unittests show that it will help with the circpad
 issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by asn):

 Unittest LGTM, but has this been tested on the real network as well, to
 see if it works as intended? IMO, it should be tested before we merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Unit test pushed. CI is running on the 035 branch only.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  merge_ready => needs_revision
 * cc: dgoulet (removed)


Comment:

 Need unit tests here per nickm request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by teor):

 Reminder: please merge the 0.3.5 branch into master, so the backport merge
 forward is clean.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Ah yes I think so. Here is an 035 branch:

 `ticket29034_035_01`
 https://github.com/torproject/tor/pull/1053

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by asn):

 Should this get backported due to its significance to bugs #28970 and
 #27471 ?
 This way we learn faster if those bugs get fixed?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  assigned => needs_review


Comment:

 New version. It is the same from the initial branches but with a v2/v3
 separation:

 Branch: `ticket29034_041_01`
 PR: https://github.com/torproject/tor/pull/1048

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2, 041-should  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by mikeperry):

 dgoulet - So far we have not experienced any obvious reliability issues
 due to this bug while testing #26834 (which uses #28780, which changes
 client-side INTRO and REND circ purposes to PADDING circs).

 I think this means that the hs_circuitmap reliability issues do not apply
 to client-side intros?

 My guess is it is because clients only seem to use this map for the 128bit
 rend cookie, and not any permanent mappings that could be invalid later.
 In which case, this is "just" a client-side memory leak of this state with
 #28780, and not a reliability problem?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  needs_revision => assigned
 * owner:  mikeperry => dgoulet


Comment:

 Taking over as part of s27 since we believe #28970 and #27471 will get
 fixed with this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by asn):

 further clarification by dgoulet:
 {{{
 11:27 <+dgoulet> asn: anyway, my main point about #29043 is that if the
 cleanup function we need needs to be v2 and v3 , we should do one high
 level in hs_common.h and then specialized in hs/ and rend/ ...
 but simply not use hs_circuit.c for v2
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by dgoulet):

 Replying to [comment:22 mikeperry]:
 > Hrmm, I am not sure how to differentiate the v2 vs v3 calls+data. What
 is the convention for that?

 Within the circuit, v2 has a `rend_data` and v3 has `hs_ident`. One
 circuit can _not_ have both. If none exist also, it is not an HS circuit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #28634   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by mikeperry):

 * parent:  #29995 => #28634


Comment:

 This is needed for #28634+#28780 for 0.4.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #29995   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-

Comment (by mikeperry):

 >  dgoulet: what do you think about what I did earlier in that
 case?
 
(https://github.com/torproject/tor/pull/931/commits/bee7979e87d51735d2d5f746d69761d89d7dd928)
 >  mikeperry: yeah something like that but it needs to  call
 hs_circ_cleanup() for v3 only and the v2 stuff needs to ideally not be
 done there... so I think the place it needs to go is hs_common.c and then
 call the v2 or v3 specialized calls

 Hrmm, I am not sure how to differentiate the v2 vs v3 calls+data. What is
 the convention for that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #29995   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by dgoulet):

 * status:  merge_ready => needs_revision


Comment:

 Commented on PR. The approach is not correct I believe if we are serious
 about the v2 and v3 code separation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #29995   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * cc: dgoulet (added)


Comment:

 Hey David, what needs to happen here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok, network-team- |
  roadmap-2019-Q1Q2  |
Parent ID:  #29995   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by mikeperry):

 * status:  needs_revision => merge_ready


Comment:

 Ok, dgoulet said it should be a different function, but I figure you guys
 can hash that out. I'm fine with asn's
 https://github.com/torproject/tor/pull/969.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok|
Parent ID:  #29995   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 LGTM!

 I have a slight revision in https://github.com/torproject/tor/pull/969,
 because I opted for not calling the new functions `hs_circ_free()` since
 `*_free()` functions have a very specific meaning in Tor (they free and
 NULL their input). Instead I hijacked `hs_circ_cleanup()` which seamed a
 better target.

 If you like, let's merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok|
Parent ID:  #29995   | Points:  3
 Reviewer:  asn  |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok|
Parent ID:  #29995   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * status:  needs_review => assigned
 * owner:  (none) => mikeperry
 * version:   => Tor: 0.3.2.1-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok|
Parent ID:  #29995   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok|
Parent ID:  #29995   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by mikeperry):

 * status:  assigned => needs_review


Comment:

 Ok I did the simplest narrow fix, based on what dgoulet said in the
 description:
 https://github.com/torproject/tor/pull/931

 Someone who is deeply familiar with both v2 and v3 state should review
 this. It's simple, and I think it's ok, but I don't know both v2 and v3
 code bases well enough to really be sure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok|
Parent ID:  #29995   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by pili):

 * parent:   => #29995


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,   |
  040-backport, postfreeze-ok|
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * keywords:  tor-hs-reachability, 035-backport, 040-backport, postfreeze-ok
 =>
 tor-hs-reachability, 029-backport-maybe, 034-backport-maybe,
 035-backport, 040-backport, postfreeze-ok


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:
  040-backport, postfreeze-ok|
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * milestone:  Tor: 0.4.0.x-final => Tor: 0.4.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:
  040-backport, postfreeze-ok|
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by teor):

 * keywords:  tor-hs-reachability, 035-backport, postfreeze-ok => tor-hs-
 reachability, 035-backport, 040-backport, postfreeze-ok


Comment:

 This is not a release blocker, we can do it later and backport

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:
  postfreeze-ok  |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by nickm):

 * keywords:  tor-hs-reachability, 035-backport, postfreeze-ok, 040-must =>
 tor-hs-reachability, 035-backport, postfreeze-ok


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:
  postfreeze-ok, 040-must|
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor27-must
-+-
Changes (by asn):

 * points:   => 3
 * sponsor:   => Sponsor27-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:
  postfreeze-ok, 040-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * owner:  dgoulet => mikeperry


Comment:

 dgoulet is on leave, assigning to Mike, because asn already has 3 tickets
 in 040-must.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs-reachability, 035-backport,   |  Actual Points:
  postfreeze-ok  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mikeperry):

 * keywords:  tor-hs, 035-backport, postfreeze-ok => tor-hs-reachability,
 035-backport, postfreeze-ok


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, 035-backport, postfreeze-ok  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-hs, 035-backport => tor-hs, 035-backport, postfreeze-ok


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs