Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-05-14 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+---
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  |  Actual Points:  0.5
Parent ID:  #31279  | Points:  1
 Reviewer:  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * status:  needs_review => closed
 * resolution:   => fixed
 * sponsor:   => Sponsor30-can
 * parent:   => #31279
 * actualpoints:   => 0.5


Comment:

 Looks good to me! I
 
[https://gitweb.torproject.org/bridgedb.git/commit/?h=develop&id=f25943ef8aabf8cc2b9b5bdfb32b422c2d4960ef
 merged your patch into develop] after doing the following:

 * I added a CHANGELOG entry (and reduced the indentation of CHANGELOG
 entries to four characters).
 * I re-extracted strings to translate by running `python setup.py
 extract_messages`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-05-09 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by agix):

 Replying to [comment:8 phw]:
 > Replying to [comment:6 agix]:
 > > There you go:
 > >
 > >
 
[https://github.com/agiix/bridgedb/commit/7d421714bb79733712da7d0ca704c2209d1d2e12]
 > [[br]]
 > The patch looks great, thanks! I left a few minor comments in the
 commit. Do you mind addressing them? After that, it's ready to merge.


 Thanks for the feedback!
 I implemented it
 
[https://github.com/agiix/bridgedb/commit/0f7e47fbb26140438e3da4906ca9d086f93931d2
 here]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-05-09 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by agix):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-05-07 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  agix
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by agix):

 * status:  needs_revision => assigned
 * owner:  (none) => agix


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-05-01 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:6 agix]:
 > There you go:
 >
 >
 
[https://github.com/agiix/bridgedb/commit/7d421714bb79733712da7d0ca704c2209d1d2e12]
 [[br]]
 The patch looks great, thanks! I left a few minor comments in the commit.
 Do you mind addressing them? After that, it's ready to merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-30 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by agix):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-30 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+

Comment (by agix):

 There you go:

 
[https://github.com/agiix/bridgedb/commit/7d421714bb79733712da7d0ca704c2209d1d2e12]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-21 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 Can you please make available a branch (based off of BridgeDB's develop
 branch) which contains your code?

 You can discard 0004-Removed-or-replaced-all-chatspeak-like-strings-in-
 st.patch because we took care of these issues over at #30941.

 Regarding 0003-Changed-redirection-to-a-classic.patch: Instead of
 redirecting to a video, I prefer to return an HTTP error code. Code 400 or
 406 seem reasonable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-06 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by agix):

 * Attachment "0005-Updated-dependencies-to-Python3-compatibility.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-06 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by agix):

 I removed all occurrences of "vanilla" in the Web UI in patch 0004, since
 it might only confuse the user.
 Internally the reference is still in use.
 I also updated the dependencies in patch 0005 to be Python3 compatible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-01 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by agix):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-01 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by agix):

 * Attachment "0003-Changed-redirection-to-a-classic.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-01 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by agix):

 * Attachment "0002-Replaced-occurrences-of-Uh-oh-spaghettios.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-04-01 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by agix):

 * Attachment "0004-Removed-or-replaced-all-chatspeak-like-strings-in-
 st.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-03-16 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the patch, agix! The string "Oh no!" still seems a bit silly. I
 suggest replacing "Oh no!" with "BridgeDB encountered an error."

 Besides, there are several other occurrences that we may want to remove:
 * BridgeDB redirects assumed-to-be-malicious requests to a
 
[https://gitweb.torproject.org/bridgedb.git/tree/bridgedb/distributors/https/server.py?id=9a7ae57cfc85be8aa488bf0e69e8b6f35e2ce38d#n168
 porn site].
 * [https://bridges.torproject.org/options Over here], the Web UI talks
 about "plain-ol'-vanilla bridges". We should at least remove the string
 "plain-ol'"
 * In #30941, we're improving BridgeDB's email response.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-03-12 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+--
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by agix):

 * status:  new => needs_review


Comment:

 Changed all occurrences of 'Uh oh, spaghettios!' to just simply 'Oh no!'.
 No other obscure references can be found.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31528 [Circumvention/BridgeDB]: Get rid of BridgeDB's "chatspeak"

2020-03-12 Thread Tor Bug Tracker & Wiki
#31528: Get rid of BridgeDB's "chatspeak"
+
 Reporter:  phw |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+
Changes (by agix):

 * Attachment "0001-Changed-all-occurrences-of-Uh-oh-spaghettios-to-
 just.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs