Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.5-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:18 Thorin]:
 > So this is a `ff78-esr-will-have` keyword (lots of keywords there!) and
 we can come back and check this ticket when we build based on that - and
 we don't rebase the patch from comment 13? Right?

 If the patch which landed in Firefox 72 is actually fixing the problem
 (maybe it's a new/different one?) we can add the keyword, yes. I was under
 the impression that the version we shipped would do that and I was wrong.
 Maybe that holds for the fix from Firefox 72 onward as well... Or we could
 just remove the patch we currently have and apply the one that actually
 landed earlier than that if it turns out to be good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.5-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by Thorin):

 So this is a `ff78-esr-will-have` keyword (lots of keywords there!) and we
 can come back and check this ticket when we build based on that - and we
 don't rebase the patch from comment 13? Right?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.5-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:16 Thorin]:
 > Great .. my `D:\Portable\ArchiveTBalpha` has almost everything but 9.5a2
 .. sigh... OK, done - yes, the error is in 9.5a2 as well

 Great. And Firefox 72 looks fine? (That's the first version which contains
 the fix developed and deployed by Mozilla)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.5-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by Thorin):

 Great .. my `D:\Portable\ArchiveTBalpha` has almost everything but 9.5a2
 .. sigh... OK, done - yes, the error is in 9.5a2 as well

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.5-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 ff68-esr, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 GeorgKoppen201911, TorBrowserTeam201911R
 =>
 ff68-esr, tbb-9.5-issues, tbb-regression, tbb-9.0.1-can,
 GeorgKoppen201911, TorBrowserTeam201911R


Comment:

 Hrm, I wonder why that's actually happening again. Maybe the backport we
 did is not generic enough anymore?

 Thorin: do you see that with 9.5a2 as well?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  closed => reopened
 * resolution:  fixed =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by Thorin):

 * Attachment "its-still-happening-guys.png" added.

 it's still happening guys...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! Merged to `tor-browser-68.2.0esr-9.5-1` (commit
 739c353b91d30238977a20b31b7ecf624c17006b).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 Looks good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:  0.1
  regression, tbb-9.0.1-can, GeorgKoppen201911,  |
  TorBrowserTeam201911R  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => needs_review
 * keywords:  ff68-esr, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can =>
 ff68-esr, tbb-9.0-issues, tbb-regression, tbb-9.0.1-can,
 GeorgKoppen201911, TorBrowserTeam201911R
 * points:   => 0.1
 * actualpoints:   => 0.1


Comment:

 We have a patch that landed and should get backported. `bug_31573`
 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_31573&id=739c353b91d30238977a20b31b7ecf624c17006b)
 has a possible fix up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 This issue appears to have been fixed in gecko-dev commit
 {{{6a0111db7ba5a1a92f3eb68b89cb415bd08a4f3e}}} in
 [https://bugzilla.mozilla.org/show_bug.cgi?id=1369436 Mozilla Bug
 1369436]. It's a relatively small change so I'll see if back-porting to
 ESR68 makes this problem go away.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 Filed Mozilla issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1591259

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:6 pospeselr]:
 > So this is happening because the {{{dom.push.enabled}}} pref is false,
 so {{{PushComponents.jsm}}} throws {{{NS_ERROR_NOT_AVAILABLE}}} when
 trying to access the {{{PushService}}} singleton. I *think* we can solve
 this by just swallowing the exception, but I need to look through the code
 a bit more to be sure.

 So, this is actually a Firefox bug given that the pref is set to `false`
 [https://searchfox.org/mozilla-
 esr68/source/browser/app/profile/firefox.js#1710 in plain esr68]? If so,
 please file an upstream bug as well and get the patch attached there, too,
 thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by pospeselr):

 So this is happening because the {{{dom.push.enabled}}} pref is false, so
 {{{PushComponents.jsm}}} throws {{{NS_ERROR_NOT_AVAILABLE}}} when trying
 to access the {{{PushService}}} singleton. I *think* we can solve this by
 just swallowing the exception, but I need to look through the code a bit
 more to be sure.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-issues, tbb-   |  Actual Points:
  regression, tbb-9.0.1-can  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * owner:  tbb-team => pospeselr
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31573 [Applications/Tor Browser]: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31573: Uncaught exception in SessionStore.jsm with Tor Browser based on ESR 68
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff68-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by intrigeri):

 * cc: intrigeri (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs