Re: [tor-bugs] #31649 [Metrics]: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist

[Tor Bug Tracker & Wiki]

#31649: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist
--+-
 Reporter:  irl   |  Owner:  karsten
 Type:  task  | Status:  closed
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  irl   |Sponsor:
--+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Great! Thanks for checking! Merged to all repositories. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31649 [Metrics]: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist

[Tor Bug Tracker & Wiki]

#31649: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist
--+-
 Reporter:  irl   |  Owner:  karsten
 Type:  task  | Status:  merge_ready
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  irl   |Sponsor:
--+-
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 Both metrics-base and metrics-web patches look good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31649 [Metrics]: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist

[Tor Bug Tracker & Wiki]

#31649: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist
--+--
 Reporter:  irl   |  Owner:  karsten
 Type:  task  | Status:  needs_review
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  irl   |Sponsor:
--+--
Changes (by karsten):

 * status:  accepted => needs_review
 * reviewer:   => irl


Comment:

 Please review this metrics-base commit:

 {{{
 commit 07c2a00c27f0d536223f8b5a61fc91e60eb524d4 (HEAD -> task-31649)
 Author: Karsten Loesing 
 Date:   Mon Sep 23 15:27:32 2019 +0200

 Add ant task to fetch metrics-lib from dist.

 Implements part of #31649.

 diff --git a/java/base.xml b/java/base.xml
 index 8342e91..4ce1660 100644
 --- a/java/base.xml
 +++ b/java/base.xml
 @@ -28,6 +28,7 @@



 +  



 @@ -99,6 +100,7 @@
  
  
  
 +
  


 @@ -109,6 +111,20 @@
  


 +  
 +
 +https://dist.torproject.org/metrics-lib/${metricslibversion
 }/metrics-lib-${metricslibversion}.tar.gz"
 + dest="${downloadedlibs}"/>
 +
 +  
 +
 +  
 +  
 +
 +  
 +

  https://gitweb.torproject.org/user/karsten
 /metrics-
 web.git/commit/?h=task-31649=85bbd482ee0bccc449656ddccad34e58b1562bb0
 metrics-web commit 85bbd48].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31649 [Metrics]: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist

[Tor Bug Tracker & Wiki]

#31649: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist
--+--
 Reporter:  irl   |  Owner:  karsten
 Type:  task  | Status:  accepted
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by karsten):

 * cc: metrics-team (added)
 * owner:  metrics-team => karsten
 * status:  new => accepted


Comment:

 Ah, never mind my comment above. We can of course download whichever
 metrics-lib version is written in `build.xml`. Accepting this ticket and
 doing some Ant hacking now...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31649 [Metrics]: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist

[Tor Bug Tracker & Wiki]

#31649: Add ant task in metrics-base to fetch metrics-lib/exonerator from dist
--+--
 Reporter:  irl   |  Owner:  metrics-team
 Type:  task  | Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Metrics   |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by karsten):

 I wonder if there are situations where we want to upgrade the metrics-lib
 version in some of our code bases but not all of them. In that case,
 having the version in metrics-base might cause problems.

 Note that we'll have to update versions in the respective `build.xml`
 files anyway. Should be fine to do it in the GitLab CI file, too. What do
 you think?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs