Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
+--
 Reporter:  asn |  Owner:  (none)
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  control-port easy extra-review  |  Actual Points:  0.5
Parent ID:  | Points:  1
 Reviewer:  asn |Sponsor:
+--
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
+--
 Reporter:  asn |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  control-port easy extra-review  |  Actual Points:  0.5
Parent ID:  | Points:  1
 Reviewer:  asn |Sponsor:
+--

Comment (by teor):

 The torspec PR is https://github.com/torproject/torspec/pull/92
 They should merge at the same time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
+--
 Reporter:  asn |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  control-port easy extra-review  |  Actual Points:  0.5
Parent ID:  | Points:  1
 Reviewer:  asn |Sponsor:
+--

Comment (by teor):

 I also tested the new GETINFO with tor-prompt.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
+--
 Reporter:  asn |  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  control-port easy extra-review  |  Actual Points:  0.5
Parent ID:  | Points:  1
 Reviewer:  asn |Sponsor:
+--
Changes (by teor):

 * keywords:  control-port easy extra-review nickm-merge dgoulet-merge =>
 control-port easy extra-review
 * type:  task => enhancement
 * actualpoints:   => 0.5


Comment:

 I did some fixes:
 * standard whitespace
 * typos
 * standard error handling
 * remove unnecessary test code

 Here is the branch with all the fixes:
 https://github.com/teor2345/tor/commits/ticket31684
 There is a description of each fix in my review on PR 1328.

 Here is the squashed PR for merging:
 * master: https://github.com/torproject/tor/pull/1434
 I squashed the whitespace fixes with the rest of the code, to minimise the
 diff.

 Since these are obvious fixes on already reviewed code, any maintainer can
 merge after CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
-+-
 Reporter:  asn  |  Owner:  (none)
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  control-port easy extra-review   |  Actual Points:
  nickm-merge dgoulet-merge  |
Parent ID:   | Points:  1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * keywords:  control-port easy extra-review => control-port easy extra-
 review nickm-merge dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
+--
 Reporter:  asn |  Owner:  (none)
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  control-port easy extra-review  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  asn |Sponsor:
+--
Changes (by ltbringer):

 * status:  needs_revision => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
+--
 Reporter:  asn |  Owner:  (none)
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  control-port easy extra-review  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * keywords:  control-port easy => control-port easy extra-review


Comment:

 Thanks. Two more minor issues and we are done.

 I also tested that this works fine with a stem script that looks like
 this:
 {{{
  controller = Controller.from_port(port=9090)
  controller.authenticate()
  ns = controller.get_info("dir/status-vote/current/consensus-microdesc")
  print("microdesc: %s" % ns)
  ns = controller.get_info("dir/status-vote/current/consensus")
  print("ns: %s" % ns)
 }}}

 After you change these two minor issues please mark it as `merge_ready`.

 Marking as extra review so that the merger checks that the issues have
 been fixed before merging (I will be away for two weeks)

 Thanks again for the code!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
+--
 Reporter:  asn |  Owner:  (none)
 Type:  task| Status:
|  needs_revision
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  control-port easy extra-review  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by ltbringer):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 This seems pretty much ready, but you should use
 `networkstatus_get_flavor_name()` instead of making a new function for
 that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by ltbringer):

 * status:  needs_revision => needs_review


Comment:

 > function declaration and definition are not separated within tests.
 > unmocked `networkstatus_get_cache_fname` and `we_want_to_fetch_flavor`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Thanks for all the work. We are moving closer!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by ltbringer):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Yes the unittest looks much better now! There are still a few things that
 need to be ironed out, and also the Appveyor CI fails. But we are close!
 :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by ltbringer):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+

Comment (by ltbringer):

 I created a mock of `networkstatus_map_cached_consensus` and make it
 return a simulated `tor_mmap_t` object. Please review and let me know if
 that works.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Closer! Some more work on the unittest would be great!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by ltbringer):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+

Comment (by ltbringer):

 You are welcome :)
 I'll work on the comments in the PR.

 I used the python stem client to test this feature.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 OK I finished a code review here. And left a few comments on the PR.
 Marking as needs_revision for now!

 Thanks for all the code!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer:  asn|Sponsor:
---+
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+

Comment (by teor):

 Thanks! We'll get someone to review this change in the next week or so.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+

Comment (by ltbringer):

 https://github.com/torproject/tor/pull/1328 is updated with the function
 that switches between the two dir/status-vote/*

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+

Comment (by teor):

 Yes, the whole function could be turned in to a lookup table.

 Hopefully we'll do that in #28982.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+

Comment (by ltbringer):

 > This ticket creates a small reduction in code quality, because it turns
 a 300-line function into a 320-line function. If you would like to improve
 code quality, please add a commit that splits the two dir/status-vote/*
 GETINFOs into their own static function. Otherwise, our reviewer can do
 that for you, before they approve your pull request.

 I will create the static function. I feel the entire function could use
 some help as I see the if-else blocks having some degree of similarity (my
 commit creates almost identical blocks, which differ only by a string
 argument).

 Also, I was unaware of the spec. I'll fix that too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+

Comment (by teor):

 Hi, thanks for this pull request!

 Replying to [comment:3 ltbringer]:
 > https://github.com/torproject/tor/pull/1328
 >
 > This adds `GETINFO dir/status-vote/microdesc/consensus`

 How did you come up with this GETINFO name?
 If we want the control spec to match the directory spec, it should be:
 GETINFO dir/status-vote/current/consensus-microdesc
 See https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n3895

 This ticket creates a small reduction in code quality, because it turns a
 300-line function into a 320-line function. If you would like to improve
 code quality, please add a commit that splits the two dir/status-vote/*
 GETINFOs into their own static function. Otherwise, our reviewer can do
 that for you, before they approve your pull request.

 We also need to update the control-spec, I'll open a child ticket.

 (We could do #28982 instead of this ticket, but that's a much more complex
 refactor.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+
Changes (by ltbringer):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+

Comment (by ltbringer):

 https://github.com/torproject/tor/pull/1328

 This adds `GETINFO dir/status-vote/microdesc/consensus`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * status:  needs_information => new


Comment:

 Whoops!  `dir/status-vote/current/consensus` works for an NS consensus,
 but not for a microdesc consensus.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus

[Tor Bug Tracker & Wiki]

#31684: Add control port GETINFO support for dumping the local consensus
---+
 Reporter:  asn|  Owner:  (none)
 Type:  task   | Status:  needs_information
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  control-port easy  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+
Changes (by nickm):

 * status:  new => needs_information


Comment:

 I think this is already implemented as `GETINFO dir/status-
 vote/current/consensus`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs