Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 CI runs fine in #31919, just tweaking the performance now.

 Merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by teor):

 This is merge_ready.

 But there are actually 22 files that don't pass, see:
 https://github.com/torproject/tor/pull/1454/files#diff-
 8eaf87fc1c11a68a2909b7da648da0a9

 I'm going to wait until #31919 passes before merging, just in case there
 are any more surprises.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by teor):

 I would like to check the fixed files using cocci in CI. If we don't, they
 will degrade over time.
 The CI shouldn't take long, I'll see if I can get it done today,

 We can exclude the files that are hard to fix, and open a ticket to deal
 with them later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:14 teor]:
 > Seems fine, but there are some typos and minor commit message/content
 issues.

 I've added a fixup commits for the typos.  To solve the commit
 message/content issues, I had to squash those and make a new rebased
 branch, as `ticket31705_v2`.  This still had merge conflicts with master,
 so it is merged in a `ticket31705_v2_merged` branch.  The PR for that is
 https://github.com/torproject/tor/pull/1447 .

 > How do you want to make progress on the remaining files?
 > Do you want to set up CI, so we preserve cocci compatibility over time?

 I don't have a strong opinion here right now: I think it would make more
 sense to get some experience using coccinelle more in our regular
 development workflow, so we can decide how to prioritize these items.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Seems fine, but there are some typos and minor commit message/content
 issues.

 How do you want to make progress on the remaining files?
 Do you want to set up CI, so we preserve cocci compatibility over time?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  1.5
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * actualpoints:   => 1.5


Comment:

 I have fixed all of the issues above, and gotten the number of files with
 parsing errors down from 143 to 12.  The remaining unhandled files are:

  * Those with funny case statement macros:
 * src/core/mainloop/connection.c
 * src/core/or/reasons.c
 * src/lib/tls/tortls.h
  * Those that use SMARTLIST_FOREACH_JOIN():
* src/feature/nodelist/networkstatus.c
  * Those that consist entirely or almost entirely of macro definitions
 that Coccinelle does not understand:
* src/lib/pubsub/pubsub_macros.h
* src/lib/testsupport/testsupport.h
* src/lib/smartlist_core/smartlist_foreach.h
* src/lib/container/order.c
* src/lib/container/handles.h
* src/lib/container/map.c
* src/lib/container/map.h
* src/lib/cc/compat_compiler.h

 Also, in some cases, I had to disable parsing of certain things with an
 `#ifdef COCCI macro`.  In the future, if we can figure out how to parse
 those things, we should use this macro less often.

 After these changes, I ran into some merge conflicts with master and its
 improved annotate_ifdef_directives.  I have made a new branch
 `ticket31705_merged` to handle those conflicts, which has a PR at
 https://github.com/torproject/tor/pull/1403 .  If CI passes, I'll call it
 needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * keywords:  042-can => 042-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I left some comments on the ticket:
 * document tor-coccinelle.h
 * document test_operator_cleanup
 * make try_parse.sh exit with a non-zero status if it finds any files
 * make (a mode for) try_parse.sh that shows the parsing errors, so they
 can be fixed
 * it looks like you missed some files:
 {{{
 $ find src/{app,config,core,feature,lib,test,tools,win32} -name *.c -o
 -name *.h | xargs ~/dev/tor/scripts/coccinelle/try_parse.sh
 # 143 files
 }}}

 Reminder: please fill in actual points on this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 (Does this still belong in needs_revision?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by teor):

 The make check is now #31919

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 > Is that a separate ticket?

 I think/hope that's a separate ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Design review:

 The design and overall structure looks good. I am not that familiar with
 coccinelle, so I will need to run these scripts myself as part of my
 review.

 Should we be running these scripts as part of our code quality checks?
 (We could install coccinelle on Travis, so it runs them.)
 Is that a separate ticket?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * keywords:   => 042-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by asn):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 CI has passed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress

[Tor Bug Tracker & Wiki]

#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 See branch `ticket31705` with PR at
 https://github.com/torproject/tor/pull/1321

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs