Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  network-team-roadmap-august  |  Actual Points:  .4
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented
 * actualpoints:  .3 => .4


Comment:

 CI passed; squashed and merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-

Comment (by nickm):

 (To be clear, the 100% coverage is on the lines modified by this branch; I
 hope that's ok)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-

Comment (by nickm):

 ok, pushed a fix and waiting for CI.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-

Comment (by teor):

 Ok, if we have 100% coverage, we don't need more tests.

 There's one fix remaining: the CMD_OTHER rename didn't reach the
 nt_service files:
 
https://ci.appveyor.com/project/torproject/tor/builds/28177080/job/svbqubudyuw6c38i#L3075

 When that's fixed, and CI passes, feel free to merge this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-

Comment (by nickm):

 I've made the requested changes.  For the quiet levels, I think I can do
 that, but what do you mean by "mode"?

 I'd hoped that the existing tests might be enough for this patch, since
 they cover 100% of affected lines; I'd be okay with writing more, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I added some comments on the PR.

 Do we need more command-line tests?
 We might not need a test for every option, but one per mode/quiet level
 would be nice.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:  teor |Sponsor:  Sponsor31-can
-+-
Changes (by nickm):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:   |Sponsor:  Sponsor31-can
-+-

Comment (by teor):

 I didn't do a full review here, but I noticed a typo in a comment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:   |Sponsor:  Sponsor31-can
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 CI has passed; I've squashed some fixups, split a commit, and re-pushed.
 Putting in needs_review under the presumption it will pass again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32003 [Core Tor/Tor]: Unify handling of command-line option parsing

[Tor Bug Tracker & Wiki]

#32003: Unify handling of command-line option parsing
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:  .3
Parent ID:  #29211   | Points:  .4
 Reviewer:   |Sponsor:  Sponsor31-can
-+-

Comment (by nickm):

 branch is `cmdline_refactor` with PT at
 https://github.com/torproject/tor/pull/1400.  I'll wait for CI and
 coverage before I merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs