Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
-+-
 Reporter:  toralf   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.5
 Severity:  Normal   | Resolution:
 Keywords:  regression crash 035-backport,   |  Actual Points:  0.6
  040-backport, 041-backport, 042-backport,  |
  BugSmashFund 043-can   |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 regression crash 035-backport, 040-backport, 041-backport,
 042-backport, BugSmashFund
 =>
 regression crash 035-backport, 040-backport, 041-backport,
 042-backport, BugSmashFund 043-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
-+-
 Reporter:  toralf   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.5
 Severity:  Normal   | Resolution:
 Keywords:  regression crash 035-backport,   |  Actual Points:  0.6
  040-backport, 041-backport, 042-backport,  |
  BugSmashFund   |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by nickm):

 Let's try it 042 if it doesn't break anything in master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
-+-
 Reporter:  toralf   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.5
 Severity:  Normal   | Resolution:
 Keywords:  regression crash 035-backport,   |  Actual Points:  0.6
  040-backport, 041-backport, 042-backport,  |
  BugSmashFund   |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 regression crash 035-backport, 040-backport, 041-backport,
 042-backport
 =>
 regression crash 035-backport, 040-backport, 041-backport,
 042-backport, BugSmashFund


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
-+-
 Reporter:  toralf   |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  High |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.4.2.5
 Severity:  Normal   | Resolution:
 Keywords:  regression crash 035-backport,   |  Actual Points:  0.6
  040-backport, 041-backport, 042-backport   |
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => needs_information
 * keywords:  regression crash =>
 regression crash 035-backport, 040-backport, 041-backport,
 042-backport
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.3.x-final


Comment:

 CI passed, merging the diagnostic to master.

 Nick, how far did you want to backport the diagnostic, and how soon?
 I'll open a child ticket to track the diagnostic backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:  0.6
Parent ID:| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by nickm):

 Almost certainly it's unrelated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:  0.6
Parent ID:| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by toralf):

 Replying to [comment:8 nickm]:

 > 0.3.5 PR: https://github.com/torproject/tor/pull/1661
 > This won't fix the underlying problem, but I think we should consider
 merging it to help track the problem down.

 I patched the 0.4.2.5 Tor sources here at this Gentoo Linux system and
 restartet both Tor relays.
 I observed a jump of the value "cswch/s (Total number of context switches
 per second.)" - collected by sysstat - from 10,000 to 20,000 at this
 system. I do wonder if this is due to the debug code or completely
 unrelated?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:  0.6
Parent ID:| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 lgtm; CI still running...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:  0.6
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:  0.6
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm
 * actualpoints:  0.5 => 0.6


Comment:

 Okay, I'm pretty well stymied.  I'm not sure where this RS is coming from,
 or how it's getting in this state. I think my best bet for now is to write
 a diagnostic patch to disable the assertion here, and instead log what we
 can find out about the routerstatus.

 Branch is: diagnose_32868_035
 0.3.5 PR: https://github.com/torproject/tor/pull/1661
 master PR: (for CI) https://github.com/torproject/tor/pull/1662

 This won't fix the underlying problem, but I think we should consider
 merging it to help track the problem down.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:  0.5
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+

Comment (by toralf):

 Replying to [comment:5 nickm]:
 > Is it possible that AuthoritativeDir or V3AuthoritativeDir was set on
 this relay?
 No, not at all, the config isn't changed at all since a longer time
 (except maybe the exit policy)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:  0.5
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * points:   => 1
 * actualpoints:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Is it possible that AuthoritativeDir or V3AuthoritativeDir was set on this
 relay?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Okay, after a few hours of searching through the code I still don't know
 what's going on.

 We can only reach the assertion failure when a routerstatus entry in the
 consensus we're using has a guardfraction set on a node that is not in
 fact is_possible_guard.

 But whenever we're parsing a consensus, we only set has_guardfraction when
 is_possible_guard is true.

 At first I thought that the issue here might that we were looking at a
 vote instead of a consensus, and I searched for a long time for a way that
 this non-authority relay might be downloading votes and getting confused
 about how to treat them.  I couldn't find such a way.

 But instead, we could be clearing routerstatus_t.is_possible_guard after
 it was first set.  But I can't find a place where we do that on a live
 routerstatus either.

 There is probably something I'm missing here. I'll keep looking.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by toralf):

 Replying to [comment:2 nickm]:
 > Did the crash happen in response to running the info.py script, or did
 it happen a little after?

 A little after. I just mentioned it b/c I do not know if pressing Ctrl-C
 at a runninf info.py script could had affected any cached files in Tor's
 data directory.

 > Can you include the rest of your configuration file as well, in case it
 has something that would help reproduce or explain this bug?
 Sure, here you go:
 {{{
 mr-fox /etc/tor # cat torrc
 # torrc
 #
 PIDFile /var/run/tor/tor.pid
 DataDirectory /var/lib/tor/data

 Nickname zwiebeltoralf
 Address 5.9.158.75
 OutboundBindAddress 5.9.158.75
 OutboundBindAddress [2a01:4f8:190:514a::2]
 DirPort 80
 ORPort  443
 DirPort [2a01:4f8:190:514a::2]:80   NoAdvertise
 ORPort  [2a01:4f8:190:514a::2]:443

 ControlPort 9051

 Log notice file /tmp/notice.log
 Log warn   file /var/log/tor/warn.log

 %include /etc/tor/torrc.d/

 mr-fox /etc/tor # cat torrc.d/*
 User tor

 SandBox 1

 OfflineMasterKey 1

 MyFamily
 
63BF46A63F9C21FD315CD061B3EAA3EB05283A0A,509EAB4C5D10C9A9A24B4EA0CE402C047A2D64E6

 ContactInfo replace k with c : kontakt @ zwiebeltoralf . de
 DirPortFrontPage /etc/tor/tor-exit-notice_DE.html

 # used by Nyx
 #
 CookieAuthentication 1

 # https://stem.torproject.org/tutorials/mirror_mirror_on_the_wall.html
 #
 FetchDirInfoEarly 1
 FetchDirInfoExtraEarly 1
 FetchUselessDescriptors 1
 UseMicrodescriptors 0
 DownloadExtraInfo 1

 SocksPort 0

 AvoidDiskWrites 1

 ExitRelay 1
 IPv6Exit 1

 ExitPolicy reject 1.1.1.1:53
 ExitPolicy reject 4.2.2.2:53
 ExitPolicy reject 8.8.8.8:53
 ExitPolicy reject 9.9.9.9:53
 ExitPolicy reject 9.9.9.10:53

 ExitPolicy reject 108.166.183.219/32:53
 ExitPolicy reject 168.156.8.90/24:53
 ExitPolicy reject 184.105.193.73/32:53

 ExitPolicy reject 193.70.85.1:

 # https://trac.torproject.org/projects/tor/wiki/doc/ReducedExitPolicy
 ExitPolicy accept *:53# DNS
 ExitPolicy accept *:706   # SILC
 ExitPolicy accept *:853   # DNS over TLS
 ExitPolicy accept *:1194  # OpenVPN
 ExitPolicy accept *:1533  # Sametime
 ExitPolicy accept *:5222  # XMPP over SSL
 ExitPolicy accept *:5223  # XMPP
 ExitPolicy accept *:5269  # ejabberd s2s_in
 ExitPolicy accept *:5280  # ejabberd admin
 ExitPolicy accept *:6660-6669 # IRC
 ExitPolicy accept *:6679  # IRC SSL
 ExitPolicy accept *:6697  # IRC SSL
 ExitPolicy accept *:  # ejabberd file service
 ExitPolicy accept *:8074  # Gadu-Gadu
 ExitPolicy accept *:8232-8233 # Zcash
 ExitPolicy accept *:8332-8333 # Bitcoin
 ExitPolicy accept *:9418  # git
 ExitPolicy accept *:11371 # OpenPGP hkp (http keyserver protocol)
 ExitPolicy accept *:50002 # Electrum Bitcoin SSL
 ExitPolicy accept *:64738 # Mumble

 ExitPolicy reject *:*
 }}}
 and
 {{{
 mr-fox /etc/tor # cat /etc/conf.d/tor
 #
 # Set the file limit
 rc_ulimit="-n 5"

 torrc=/etc/tor/torrc
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * cc: mikeperry (added)


Comment:

 Did the crash happen in response to running the info.py script, or did it
 happen a little after?

 Can you include the rest of your configuration file as well, in case it
 has something that would help reproduce or explain this bug?

 The simplest solution here would be to use IF_BUG_ONCE instead of
 tor_assert(), so that the error message wouldn't come with a crash.   But
 really, I'd rather find out what the bug is and fix it directly.

 Adding mikeperry to the ccs, since I believe he knows this code well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32868 [Core Tor/Tor]: crash: Assertion node->rs->is_possible_guard failed in compute_weighted_bandwidths at

[Tor Bug Tracker & Wiki]

#32868: crash:  Assertion node->rs->is_possible_guard failed in
compute_weighted_bandwidths at
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.2.5
 Severity:  Normal| Resolution:
 Keywords:  regression crash  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => regression crash
 * priority:  Medium => High
 * milestone:   => Tor: 0.4.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs