Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-sign, tbb-maint, |  Actual Points:
  GeorgKoppen202006, TorBrowserTeam202006R   |
Parent ID:   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:  tbb-sign, tbb-maint, GeorgKoppen202005, TorBrowserTeam202006
 => tbb-sign, tbb-maint, GeorgKoppen202006, TorBrowserTeam202006R


Comment:

 `bug_32895_v4` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32895_v4=a3c272d2e53ea60c1a596bc25189e6f63a535471)
 rebased onto `master` has the changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-sign, tbb-maint, |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202006|
Parent ID:   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-sign, tbb-maint, GeorgKoppen202005, TorBrowserTeam202006R
 => tbb-sign, tbb-maint, GeorgKoppen202005, TorBrowserTeam202006


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-sign, tbb-maint, |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202006R   |
Parent ID:   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 Can we print the error message for only non-osx64? Printing 35+ non-match
 messages seems like unnecessary noise.

 {{{
 +if ! [ "$sha256_txt" = "$(sha256sum "$f")" ]
  then
echo "$f does not have the SHA-256 sum of the unsigned MAR file!"
 -  BADSIGNED_MARS=`expr $BADSIGNED_MARS + 1`
 +  not_reproduced_mars=$((not_reproduced_mars + 1))
 +  case "$f" in
 +*osx64*)
 +  not_reproduced_mars_expected=$((not_reproduced_mars_expected +
 1))
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-sign, tbb-maint, |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202006R   |
Parent ID:   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-

Comment (by gk):

 `bug_32893_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32895_v3=c7de39d13d1f8f9640700a094a3cbb9cb1cc8ce6)
 has another small improvement and is rebased against `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-sign, tbb-maint, |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by gk):

 * type:  defect => enhancement


Comment:

 `bug_32895_v2` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32895_v2=4e792c08cc9903b1243ccda2c40c320a98e814a1)
 has a slightly improved patch for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-sign, tbb-maint, |  Actual Points:
  GeorgKoppen202005, TorBrowserTeam202005R   |
Parent ID:   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by gk):

 * cc: tbb-team (added)
 * keywords:  tbb-sign, tbb-maint, GeorgKoppen202005 => tbb-sign, tbb-maint,
 GeorgKoppen202005, TorBrowserTeam202005R
 * status:  assigned => needs_review
 * reviewer:   => sysrqb


Comment:

 `bug_32895` () has a patch for review. I fixed all the issues `shellcheck`
 found, too, while I was at it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
-+-
 Reporter:  gk   |  Owner:  gk
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-sign, tbb-maint, |  Actual Points:
  GeorgKoppen202005  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => assigned
 * keywords:  tbb-sign => tbb-sign, tbb-maint, GeorgKoppen202005
 * owner:  tbb-team => gk


Old description:

> Our current mar-signing check script does two things:
>
> 1) It checks whether the SHA-256 sum from the signed .mar file is the
> same one as from the unsigned one and returns an error if so.
>
> 2) It strips the signature and compares the SHA-256 sum of the resulting
> .mar file with the unsigned one.
>
> Step 2) essentially tries to do 2 checks in one: a) that there is a
> proper signature that can get stripped and b) that the resulting .mar
> file is the same as the unsigned one. That's cool in theory as we want to
> have both checks but it has a number of issues in practice. The most
> important ones are:
>
> i) The script fails the mar-signing check for macOS as the stripping the
> signatures from those files does not give us the unsigned .mar due to the
> content signing
>
> ii) It's not clear we signed actually with the right key (although that
> is in practice not much of an issue) or whether the signature verifies
> later on (which is actually what we want to know).

New description:

 Our current mar-signing check script does two things:

 1) It checks whether the SHA-256 sum from the signed .mar file is the same
 one as from the unsigned one and returns an error if so.

 2) It strips the signature and compares the SHA-256 sum of the resulting
 .mar file with the unsigned one.

 Step 2) essentially tries to do 2 checks in one: a) that there is a proper
 signature that can get stripped and b) that the resulting .mar file is the
 same as the unsigned one. That's cool in theory as we want to have both
 checks but it has a number of issues in practice. The most important ones
 are:

 i) The script fails the mar-signing check for macOS as stripping the
 signatures from those files does not give us the unsigned .mar yet due to
 the content signing. (see: #20254)

 ii) It's not clear we signed actually with the right key (although that is
 in practice not much of an issue) or whether the signature verifies later
 on (which is actually what we want to know).

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32895 [Applications/Tor Browser]: Improve marsigning_check.sh script to deal better with non-reproducible, signed macOS mar files

[Tor Bug Tracker & Wiki]

#32895: Improve marsigning_check.sh script to deal better with non-reproducible,
signed macOS mar files
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-sign  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 I guess what we could do here is to point to the cert which got supposedly
 used (like we point to the `SIGNMAR` binary) and the nickname and then do
 the actual verification + we make the output for 2a) and 2b) separate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs