Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, prop313, ipv6, |  Actual Points:
  outreachy-ipv6, network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor55-can
-+-

Comment (by asn):

 Replying to [comment:38 MrSquanchee]:
 > Hii, asn.

 Hello MrSquanchee,

 thanks for showing interest to write these tests. Let me try to help out.

 > 1. `rep_hist_bw_stats_write()` gets called from
 `write_stats_file_callback` in mainloop.c.
 >  This function handles disk write for all the stats produced.
 >  So, do you want exhaustive unit-tests for `write_stats_file_callback`,
 which would test
 >  for all the stats ?? or should I write unit tests for
 `write_stats_file_callback`
 >  pertaining only to the bandwidth statistics ??

 I would like unittests for `write_stats_file_callback` pertaining only to
 the bandwidth statistics.

 In particular, you could call that function with a special `options`
 argument that only activates the bandwidth statistics. As part of this, I
 would like to see that the separation between `BandwidthStatistics` and
 `ExtraInfoStatistics` is clear. That is, how does each of those two
 options influence the other? Given that this is one of the original
 purposes of this ticket (i.e. not having `ExtraInfoStatistics` control
 everything) I would like the test to be able to test that things work as
 expected.

 > 2. Also, `rep_hist_bw_stats_write()` writes the stats to the disk, so
 does many other stat
 >  functions, but I haven't yet seen a unit test that tests for a
 directory and contents of
 >  a file maybe for some reasons I don't know or maybe I am wrong and you
 can point me to
 >  an appropriate test.
 >  Would you like to explain how I can write such a test  ??

 There are a bunch of ways to achieve this. One way would be to actually do
 the file writes; see how `test_config_write_to_data_subdir()` and
 `test_config_check_or_create_data_subdir()` do this. IMO this would be the
 best and most robust way to approach this (also probably simpler).

 The other way, would be to mock the file-writing functions, so that their
 behavior does not happen when they are getting tested. As an example, of a
 test that does mocking check `test_config_resolve_my_address()`.

 Best of luck in this adventure!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, prop313, ipv6, |  Actual Points:
  outreachy-ipv6, network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor55-can
-+-

Comment (by MrSquanchee):

 Hii, asn.
 1. `rep_hist_bw_stats_write()` gets called from
 `write_stats_file_callback` in mainloop.c.
  This function handles disk write for all the stats produced.
  So, do you want exhaustive unit-tests for `write_stats_file_callback`,
 which would test
  for all the stats ?? or should I write unit tests for
 `write_stats_file_callback`
  pertaining only to the bandwidth statistics ??
 2. Also, `rep_hist_bw_stats_write()` writes the stats to the disk, so does
 many other stat
  functions, but I haven't yet seen a unit test that tests for a directory
 and contents of
  a file maybe for some reasons I don't know or maybe I am wrong and you
 can point me to
  an appropriate test.
  Would you like to explain how I can write such a test  ??

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, prop313, ipv6, |  Actual Points:
  outreachy-ipv6, network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor55-can
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Sorry for the late review here.

 The code looks good, but I'm wondering that there is no unittest for this
 functionality. In particularly, I'm refering to
 `rep_hist_bw_stats_write()` and its position in
 `wep_hist_bw_stats_write()`. I think we need a unittest that tests the
 latter function and makes sure that `rep_hist_bw_stats_write()` will be
 called (or not be called) based on the consensus/torrc parameter, and that
 when it's called it does the right thing.

 Please let me know if you need help designing this unittest.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, prop313, ipv6, |  Actual Points:
  outreachy-ipv6, network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  asn  |Sponsor:
 |  Sponsor55-can
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  extra-review, prop313, ipv6, |  Actual Points:
  outreachy-ipv6, network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * keywords:  prop313, ipv6, outreachy-ipv6, network-team-roadmap-2020Q1 =>
 extra-review, prop313, ipv6, outreachy-ipv6, network-team-roadmap-
 2020Q1


Comment:

 Replying to [comment:33 MrSquanchee]:
 > Replying to [comment:32 teor]:
 > > We've been a bit busy for the past few weeks. I was also waiting for
 you to write more tests.
 >
 > I thought we were done with the tests. Can you please tell me what
 functions do you want to have
 > tests for ??

 We should test all the functions that have been modified. Sometimes we
 decide to do unit tests later, and open another ticket. Other times we ask
 for them as part of the PR, so we are sure that the new code works.

 We don't have good integration tests for this code, so unit tests are
 important.

 I'll leave it to the next reviewer to decide if we need more tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-

Comment (by MrSquanchee):

 PR https://github.com/torproject/tor/pull/1872
 Rebased with a cleaner git history.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-

Comment (by MrSquanchee):

 Replying to [comment:32 teor]:
 > We've been a bit busy for the past few weeks. I was also waiting for you
 to write more tests.

 I thought we were done with the tests. Can you please tell me what
 functions do you want to have
 tests for ??

 > I did a review. We need a few tweaks to the documentation, then this
 part is done.
 > Please open another pull request, once you've made these changes. And
 the next reviewer can work with you on more tests.

 I am committing the changes you have requested and will open a new PR with
 a cleaner git history.
 Thanks :)

 > (I might not have time to review this ticket in future. So I'm leaving
 it for another reviewer to finish.)

 No problem. We all have some unfinished rescheduled tasks nowadays.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * cc: nickm, ahf, dgoulet (added)
 * reviewer:  teor =>


Comment:

 Replying to [comment:31 MrSquanchee]:
 > Hii teor,
 >
 > It has been two weeks and, I think now is the prefect time to review it
 before
 > I forgot how did I do this :)

 We've been a bit busy for the past few weeks. I was also waiting for you
 to write more tests.

 I did a review. We need a few tweaks to the documentation, then this part
 is done.

 Please open another pull request, once you've made these changes. And the
 next reviewer can work with you on more tests.

 (I might not have time to review this ticket in future. So I'm leaving it
 for another reviewer to finish.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by MrSquanchee):

 Hii teor,

 It has been two weeks and, I think now is the prefect time to review it
 before
 I forgot how did I do this :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-
Changes (by MrSquanchee):

 * status:  needs_revision => needs_review


Comment:

 Hii teor,

 I think you should review this PR
 https://github.com/torproject/tor/pull/1808 now
 for the documentation, comments and other changes so far.

 Also I looked at the similar functions as rep_hist_bw_stats_write() and
 they seem
 to have no tests, i.e. the functions which write stats to disk and rightly
 so
 because for that we have to mock a lot of lower level functions.

 Suggest me again if I should write a test for this function and if so
 whether
 in test_bwmgt.c or test_stats.c ??

 Thanks :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by teor):

 Great! Thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by MrSquanchee):

 Hii teor,
 I just started writing test for rep_hist_bw_stats_write(),
 and realized that before testing rep_hist_bw_stats_write()
 we have to test rep_get_bandwidth_lines() and
 rep_hist_fill_bandwidth_history().

 I should say that we need a new ticket ( #33812 ) to write tests for
 bandwidth code,
 and only than this ticket can be closed :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by teor):

 Every function should have unit tests,

 We write tests to make sure that every function works now, and to make
 sure we don't break it in future. It doesn't matter how similar they are.
 (But sometimes similar functions can be tested using similar tests.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by MrSquanchee):

 Hii reviewer,
 I added tests for get_bandwidth_stats_param() (one of the functions,
 I added).
 And the PRs all green now (for some reason the CI succeeded but it shows
 still pending).
 https://github.com/torproject/tor/pull/1808
 Now, I am adding tests for rep_hist_bw_stats_write() (the second function
 I added).

 Suggest me if I should continue making test for the second function or not
 ??
 Because it's a lot similar to other functions for other statistics.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-
Changes (by MrSquanchee):

 * status:  needs_revision => needs_review


Comment:

 Made reviewer changes.
 I will add the tests soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by teor):

 Thanks, please set this ticket to needs_review when you have made all the
 changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by MrSquanchee):

 Replying to [comment:21 teor]:
 > Hi MrSquanchee, just wondering how you are going with these tests and
 documentation?

 I have added the changes you suggested, yesterday only. You can see my
 commit
 here
 
https://github.com/torproject/tor/pull/1808/commits/32778dc6a09eaeca3d03e4261a2dbb9b669eb6fc.

 tbh, I was a little distracted, I am adding the tests today.

 Thanks,

 Suraj Upadhyay (MrSquanchee).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-+-
 Reporter:  teor |  Owner:
 |  MrSquanchee
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6,   |  Actual Points:
  network-team-roadmap-2020Q1|
Parent ID:  #33052   | Points:  1
 Reviewer:  teor |Sponsor:
 |  Sponsor55-can
-+-

Comment (by teor):

 Replying to [comment:18 teor]:
 > Replying to [comment:16 MrSquanchee]:
 > > I think, I can use this
 [https://github.com/torproject/tor/blob/master/src/test/test_bwmgt.c file]
 to test the added changes.
 > > What do you say ??
 >
 > Sounds like a great idea!
 >
 > > Also I added the changes requested.
 > > And I think when BandwidthStatistics is explicitly set to 1, it should
 not check the consensus as cited
 [https://gitweb.torproject.org/torspec.git/tree/proposals/313-relay-
 ipv6-stats.txt#n305. here] (indirectly).
 >
 > Thanks! We need to answer those questions in the comments and manual
 page.
 >
 > Writing comments and manuals can be hard.
 > Can you try one more time?
 > Try to use similar options as a template.
 >
 > If you're still having trouble, I can help rewrite them. But I might not
 have time this week.

 Hi MrSquanchee, just wondering how you are going with these tests and
 documentation?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer:  teor   |Sponsor:  Sponsor55-can
---+---
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Replying to [comment:16 MrSquanchee]:
 > I think, I can use this
 [https://github.com/torproject/tor/blob/master/src/test/test_bwmgt.c file]
 to test the added changes.
 > What do you say ??

 Sounds like a great idea!

 > Also I added the changes requested.
 > And I think when BandwidthStatistics is explicitly set to 1, it should
 not check the consensus as cited
 [https://gitweb.torproject.org/torspec.git/tree/proposals/313-relay-
 ipv6-stats.txt#n305. here] (indirectly).

 Thanks! We need to answer those questions in the comments and manual page.

 Writing comments and manuals can be hard.
 Can you try one more time?
 Try to use similar options as a template.

 If you're still having trouble, I can help rewrite them. But I might not
 have time this week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by MrSquanchee):

 * status:  needs_revision => needs_review


Comment:

 Finding ways to test :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by MrSquanchee):

 I think, I can use this
 [https://github.com/torproject/tor/blob/master/src/test/test_bwmgt.c file]
 to test the added changes.
 What do you say ??

 Also I added the changes requested.
 And I think when BandwidthStatistics is explicitly set to 1, it should not
 check the consensus as cited
 [https://gitweb.torproject.org/torspec.git/tree/proposals/313-relay-
 ipv6-stats.txt#n305. here] (indirectly).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by teor):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Thanks, I left comments on the pull request.

 Please also write test_parseconf.sh tests for BandwidthStatistics 1 and
 auto.

 I'm still not sure how we will test this change. Maybe see if there are
 existing tests for any of the bandwidth functions?
 (I remember writing some. Maybe they never got finished and merged.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by MrSquanchee):

 * status:  assigned => needs_review


Comment:

 I added the changes,
 Hope you like them,
 Suggestions are most welcomed,
 [PR]https://github.com/torproject/tor/pull/1808 ,

 Thanks,
 MrSquanchee

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by MrSquanchee):

 Replying to [comment:11 MrSquanchee]:
 > Replying to [comment:7 MrSquanchee]:
 > > I want to know where should I create that function ??
 > > Help Required !!!
 >
 > I wrote the function.
 > But where should I place it ??

 Never mind I figured it out :)

 Updating the PR soon !!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by MrSquanchee):

 Replying to [comment:7 MrSquanchee]:
 > I want to know where should I create that function ??
 > Help Required !!!

 I wrote the function.
 But where should I place it ??

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 I found these examples by searching the tor github for "consensus
 parameter".

 If you tell us what you've already looked at (with links), then we won't
 suggest the same things. And we have a better idea of what you're missing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by MrSquanchee):

 * status:  needs_review => assigned


Comment:

 Hii teor,
 Thanks for your suggestion,
 I was really stuck with this consensus parameter :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Here's a good example of a function that checks an option and a consensus
 parameter:
 
https://github.com/torproject/tor/blob/44f92e8e4278403b9e633668f8be70f197b6e8db/src/core/or/dos.c#L154

 You shouldn't need to worry about when the consensus arrives.
 networkstatus_get_param() handles that for you.

 The tricky part will be turning statistics on and off based on the
 parameter. I suggest you collect the statistics if:
 * the BandwidthStatistics option is on (1), or
 * the BandwidthStatistics option is auto (-1).

 And then you only put the statistics in the extra-info if:
 * the BandwidthStatistics option is on (1), or
 * the BandwidthStatistics option is auto (-1), and the consensus parameter
 is on (1).

 So it looks like you'll need two new functions, one for collecting the
 statistics, and another for submitting them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by MrSquanchee):

 > Stage 2:
 >
 > Add a BandwidthStatistics consensus paramter.

 How to add a consensus parameter. Please cite me to some useful resources.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by MrSquanchee):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:4 teor]:
 > So I made a pull request here:
 > https://github.com/torproject/tor/pull/1808

 Thanks :)

 > * this code looks good, but how do you know it works?

 How can I test it ? Do I have to run a relay ?

 > * you made a new file, so you'll need to add it to:
 >   * the sandbox:
 > *
 https://github.com/torproject/tor/blob/master/src/app/main/main.c#L1032
 > *
 https://github.com/torproject/tor/blob/master/src/app/main/main.c#L1055
 >   * the man page:
 https://github.com/torproject/tor/blob/master/doc/tor.1.txt#L3773

 Modified the files pointed. Correct me if there is any problem with the
 man entry `Only used by servers`.

 Resolved your comments on github.
 You can check it on https://github.com/torproject/tor/pull/1808

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by teor):

 Please make any changes by adding new commits to the
 MrSquanchee:ticket#33617 branch. (The pull request will update
 automatically, and run CI.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by teor):

 * status:  assigned => needs_revision


Comment:

 Hi, it's a bit hard to read and review this branch.

 So I made a pull request here:
 https://github.com/torproject/tor/pull/1808

 Please submit code for review as a pull request, even if it isn't ready
 yet.

 I made some specific comments on the pull request. Here are some general
 comments:
 * this code looks good, but how do you know it works?
 * there's no need to fix formatting issues on your own new code in a
 separate commit. Instead, run "make check" before you commit your code.
 And then you can fix issues before you commit.
 * you made a new file, so you'll need to add it to:
   * the sandbox:
 *
 https://github.com/torproject/tor/blob/master/src/app/main/main.c#L1032
 *
 https://github.com/torproject/tor/blob/master/src/app/main/main.c#L1055
   * the man page:
 https://github.com/torproject/tor/blob/master/doc/tor.1.txt#L3773
 * CI hasn't finished yet, so I don't know if your code compiles

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---

Comment (by MrSquanchee):

 Hii teor,
 I completed stage 1 partially.
 You can check my branch at
 https://github.com/MrSquanchee/tor/commits/ticket%2333617 .
 Just added the BandwidthStatistics option and made it activate reporting
 of bandwidth statistics.
 Will add the tests in the next commit.
 And I don't have any idea on how to add a consensus parameter, any hint
 will do./
 And please do tell me if I went wrong in some way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  MrSquanchee
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by MrSquanchee):

 * status:  new => assigned
 * owner:  (none) => MrSquanchee


Comment:

 Hii teor,
 Thanks for the ticket on tasks for summer-of-code.
 Assigning myself.
 Hope I would be valuable here :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33052 | Points:  1
 Reviewer: |Sponsor:  Sponsor55-can
---+---
Changes (by teor):

 * keywords:  prop313, ipv6 => prop313, ipv6, outreachy-ipv6


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs