Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-06-10 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
-+-
 Reporter:  karsten  |  Owner:  acute
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.3
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  2.0
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-

Comment (by robgjansen):

 If you want to make use of TGen internal log parser to parse the log files
 that `tgen` 1.0 produces, that should be doable. The parser is written in
 python and is very similar to the one written for OnionPerf.

 The parsing code is inside the `tgentools` python package, which can be
 installed [https://github.com/shadow/tgen/blob/master/doc/Tools-Setup.md
 as explained here]. Then, once you have a `tgen` 1.0 log file that you
 want to parse, you just need to import one of the analysis modules: the
 
[https://github.com/shadow/tgen/blob/c3199b82017e559c3b9bb0a691d76349631238e1/tools/tgentools/tgentools#L273-L279
 `tgentools` file shows how this is done].

 Hopefully you can make use of the output straight away. If for some reason
 you need some change to the output format, let me know!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-06-09 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
-+-
 Reporter:  karsten  |  Owner:  acute
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.3
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  2.0
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by acute):

 * owner:  metrics-team => acute
 * status:  assigned => accepted


Comment:

 Thank you for releasing, jnewsome!
 Will take this for the next couple of days and see where I get to.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-06-08 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
-+-
 Reporter:  karsten  |  Owner:
 |  metrics-team
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.3
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  2.0
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-
Changes (by jnewsome):

 * owner:  jnewsome => metrics-team


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-06-08 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
-+-
 Reporter:  karsten  |  Owner:
 |  jnewsome
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionperf|Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-team-roadmap-2020, metrics-  |  Actual Points:  0.3
  team-roadmap-2020-june |
Parent ID:  #33321   | Points:  2.0
 Reviewer:   |Sponsor:
 |  Sponsor59-must
-+-

Comment (by jnewsome):

 Given this tickets higher prioritization, probably doesn't make sense to
 block it on me ramping up on onionperf. Handing back to metrics team.

 Btw a volunteer sent an applicable PR; might be worth reaching out to
 them: https://github.com/torproject/onionperf/pull/26

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-06-03 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+
 Reporter:  karsten|  Owner:  jnewsome
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.3
Parent ID:  #33321 | Points:  2.0
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * points:  2 => 2.0
 * actualpoints:   => 0.3


Comment:

 Adding my 0.3 actual points from working on this a while ago.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs


Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-05-18 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+
 Reporter:  karsten|  Owner:  jnewsome
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by jnewsome):

 * owner:  metrics-team => jnewsome


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-05-13 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Replying to [comment:15 jnewsome]:
 > IIUC, the proposed work remaining here is roughly:
 >
 > * Update log-parsing for tgen 1.0 (ideally by using TGen's analysis.py)
 > * Validate measurements in this patch.

 Yes, this sounds good. Are you going to work on this? If so, can you
 assign the ticket to yourself?

 > It'd be nice to have some automated end to end test for onionperf in
 general, and for this change in particular. I *think* the right way to do
 that would be to make an option in onionperf to set up and run its
 experiment under Shadow, rather than running the onionperf python script
 itself under Shadow. That *might* be possible with today's Shadow.
 Probably outside the scope of this ticket but I'll keep this in mind while
 I'm digging into onionperf, and perhaps open another ticket for it.

 Agreed that this would probably be out of scope for this ticket, yet
 useful to test changes like this one. Do you want to create a new ticket
 for this? How many points do you think this would take?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-05-12 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+

Comment (by jnewsome):

 IIUC, the proposed work remaining here is roughly:

 * Update log-parsing for tgen 1.0 (ideally by using TGen's analysis.py)
 * Validate measurements in this patch.

 It'd be nice to have some automated end to end test for onionperf in
 general, and for this change in particular. I *think* the right way to do
 that would be to make an option in onionperf to set up and run its
 experiment under Shadow, rather than running the onionperf python script
 itself under Shadow. That *might* be possible with today's Shadow.
 Probably outside the scope of this ticket but I'll keep this in mind while
 I'm digging into onionperf, and perhaps open another ticket for it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-05-12 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by jnewsome):

 * cc: jnewsome (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-05-05 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  Sponsor59
---+--
Changes (by gaba):

 * keywords:   => metrics-team-roadmap-2020
 * points:   => 2
 * sponsor:   => Sponsor59


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-05-05 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  needs_review => assigned
 * owner:  karsten => metrics-team


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-28 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * type:  defect => enhancement


Comment:

 It's not broken at the moment with TGen 0.0.1, it would just be good to
 upgrade to the newer TGen version 1.0.0. Calling this an enhancement, not
 a defect.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-27 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Opened #34024 for the timeout/stallout discussion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-24 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 So, I got measurements running with TGen 1.0.0 with the changes above. But
 the log messages have changed quite a bit between TGen 0.0.1 and 1.0.0. I
 briefly looked into updating this code in OnionPerf. But I wonder if it
 wouldn't be smarter to import TGen's `tools/tgentools/analysis.py` and use
 that in OnionPerf rather than maintain a copy of that code in OnionPerf.
 What's the best way to import and use tgen Python code in OnionPerf?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-23 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by robgjansen):

 > Let me try to get the recent OnionPerf with the recent TGen running
 first before making more changes. I might move the timeouts/stallouts
 change to another ticket then.

 Sounds good! With the more realistic timeouts, I think the
 [https://metrics.torproject.org/torperf-failures.html failure graphs on
 Tor metrics] may become more interesting :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-23 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Replying to [comment:4 robgjansen]:
 > Also, BTW, I've always thought the torperf timeouts were crazy high and
 not that realistic. In my recent research using Shadow, I found that the
 following values are more realistic. However they will likely result in
 more "timeouts" appearing in the OnionPerf output and this would introduce
 an inconsistency with all of the previous data from torperf, so I'm not
 sure if it makes sense to change the timeouts now or not.
 >
 > {{{
 > g.add_node("stream50k", sendsize="1 KiB", recvsize="50 KiB", timeout="15
 seconds", stallout="0 seconds")
 > g.add_node("stream1m", sendsize="1 KiB", recvsize="1 MiB", timeout="60
 seconds", stallout="0 seconds")
 > g.add_node("stream5m", sendsize="1 KiB", recvsize="5 MiB", timeout="120
 seconds", stallout="0 seconds")
 > }}}
 >
 > (I.e., disable stallouts and use much shorter absolute timeouts only.)
 >
 > FWIW, this is what I now use in Shadow, and I think it would give us a
 better sense of timeouts as users actually experience them.

 The original timeouts used by Torperf were designed so that we use all
 available time between starting new runs. In Torperf, the three file sizes
 were downloaded in parallel, with different start times. For example, a 5
 MiB download would start once per hour, so there was no difference between
 timing out after 120 seconds or leaving it running for up 59 minutes to
 see what happens. But you're right that it's not very realistic.

 With OnionPerf this is a bit different, with new runs starting every 5
 minutes, picking a file size at random. So, yes, I agree that we should
 make that change.

 Let me try to get the recent OnionPerf with the recent TGen running first
 before making more changes. I might move the timeouts/stallouts change to
 another ticket then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-23 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Whoops! That's good to know. Thanks! New patch:

 {{{
 diff --git a/onionperf/model.py b/onionperf/model.py
 index 3c057c5..5a5fb25 100644
 --- a/onionperf/model.py
 +++ b/onionperf/model.py
 @@ -77,9 +77,9 @@ class TorperfModel(GeneratableTGenModel):
  if self.socksproxy is not None:
  g.node["start"]["socksproxy"] = self.socksproxy
  g.add_node("pause", time="5 minutes")
 -g.add_node("transfer50k", type="get", protocol="tcp", size="50
 KiB", timeout="295 seconds", stallout="300 seconds")
 -g.add_node("transfer1m", type="get", protocol="tcp", size="1
 MiB", timeout="1795 seconds", stallout="1800 seconds")
 -g.add_node("transfer5m", type="get", protocol="tcp", size="5
 MiB", timeout="3595 seconds", stallout="3600 seconds")
 +g.add_node("stream50k", sendsize="1 KiB", recvsize="50 KiB",
 timeout="295 seconds", stallout="300 seconds")
 +g.add_node("stream1m", sendsize="1 KiB", recvsize="1 MiB",
 timeout="1795 seconds", stallout="1800 seconds")
 +g.add_node("stream5m", sendsize="1 KiB", recvsize="5 MiB",
 timeout="3595 seconds", stallout="3600 seconds")

  g.add_edge("start", "pause")

 @@ -88,9 +88,9 @@ class TorperfModel(GeneratableTGenModel):
  g.add_edge("pause", "pause")

  # these are chosen with weighted probability, change edge
 'weight' attributes to adjust probability
 -g.add_edge("pause", "transfer50k", weight="12.0")
 -g.add_edge("pause", "transfer1m", weight="2.0")
 -g.add_edge("pause", "transfer5m", weight="1.0")
 +g.add_edge("pause", "stream50k", weight="12.0")
 +g.add_edge("pause", "stream1m", weight="2.0")
 +g.add_edge("pause", "stream5m", weight="1.0")

  return g

 @@ -109,10 +109,10 @@ class OneshotModel(GeneratableTGenModel):
  g.add_node("start", serverport=self.tgen_port, peers=server_str,
 loglevel="info", heartbeat="1 minute")
  if self.socksproxy is not None:
  g.node["start"]["socksproxy"] = self.socksproxy
 -g.add_node("transfer5m", type="get", protocol="tcp", size="5
 MiB", timeout="15 seconds", stallout="10 seconds")
 +g.add_node("stream5m", sendsize="1 KiB", recvsize="5 MiB",
 timeout="15 seconds", stallout="10 seconds")

 -g.add_edge("start", "transfer5m")
 -g.add_edge("transfer5m", "start")
 +g.add_edge("start", "stream5m")
 +g.add_edge("stream5m", "start")

  return g

 }}}

 Thanks, acute, for confirming that we both found the same set of changes.
 Will post here how the analysis goes tomorrow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-23 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by robgjansen):

 Also, BTW, I've always thought the torperf timeouts were crazy high and
 not that realistic. In my recent research using Shadow, I found that the
 following values are more realistic. However they will likely result in
 more "timeouts" appearing in the OnionPerf output and this would introduce
 an inconsistency with all of the previous data from torperf, so I'm not
 sure if it makes sense to change the timeouts now or not.

 {{{
 g.add_node("stream50k", sendsize="1 KiB", recvsize="50 KiB", timeout="15
 seconds", stallout="0 seconds")
 g.add_node("stream1m", sendsize="1 KiB", recvsize="1 MiB", timeout="60
 seconds", stallout="0 seconds")
 g.add_node("stream5m", sendsize="1 KiB", recvsize="5 MiB", timeout="120
 seconds", stallout="0 seconds")
 }}}

 (I.e., disable stallouts and use much shorter absolute timeouts only.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-23 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by robgjansen):

 Karsten,

 These changes look good except one thing. You'll want to also specify a
 `sendsize` on the `stream50k`, `stream1m`, and `stream5m` nodes. For
 example:

 {{{
 g.add_node("stream50k", sendsize="1 KiB", recvsize="50 KiB", timeout="295
 seconds", stallout="300 seconds")
 g.add_node("stream1m", sendsize="1 KiB", recvsize="1 MiB", timeout="1795
 seconds", stallout="1800 seconds")
 g.add_node("stream5m", sendsize="1 KiB", recvsize="5 MiB", timeout="3595
 seconds", stallout="3600 seconds")
 }}}

 If you don't, an internal "nonstop" sending Markov model will be used to
 send an infinite data stream in the sending direction.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-23 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by acute):

 I've had a look at the new tgen syntax yesterday, and those are the same
 changes I've identified! This looks good to me, if it runs fine and the
 analysis step produces valid results, you can commit it to the repository.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33974 [Metrics/Onionperf]: Update OnionPerf to TGen 1.0.0

2020-04-23 Thread Tor Bug Tracker & Wiki
#33974: Update OnionPerf to TGen 1.0.0
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs