Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  implemented
  control,termination,signals,windows,winapi |  Actual Points:
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 Awesome! Looking forward to the release with this feature :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  implemented
  control,termination,signals,windows,winapi |  Actual Points:
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Looks good to me; merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 Tor is one of the most important software that I use, so I am pleased that
 I could contribute a tiny part as my first step into proper open-source
 contribution. Thank you for the guidance, I will definitely let you know
 when I am ready for more!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by ahf):

 Wow, that is awesome to hear. Thanks for letting Tor be the first project
 you contribute to! If you ever feel like diving into more things in Tor
 feel free to prod us on IRC for help as well :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 It has been my pleasure and I am happy to see that it is ready to be
 merged, this is my first contribution to a major open-source project :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good. Thank you for working on this!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by TheDcoder):

 * Attachment "tor_win32_ctrl_revised2.patch" added.

 The patch which passed CI tests

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by TheDcoder):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:11 ahf]:

 Sorry, I was a bit busy and distracted earlier today, so I didn't catch
 the other stylistic inconsistencies, but I have now taken my time to
 correct them and have submitted the updated code to GH, please review it.
 Thanks for the continued input.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by ahf):

 One minor nitpick is left it seems before our code style checker is happy.
 The `{` in the function definition have to go on its own line like the
 other functions in the file. That should make CI happy again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by TheDcoder):

 * Attachment "tor_win32_ctrl_revised.patch" added.

 The revised patch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 I have revised my patch to fix several issues, these are the changes that
 I made:

  1. Add `static` specifier to the function definition in order to satisfy
 gcc complaining about a missing prototype
  1. Add a dummy statement which references the unused `ctrl_type`
 parameter in order to satisfy gcc complaining about it being unused
  1. Update the ticket file in !`changes` directory to use the more generic
 `windows` category to group it along with other windows-specific changes
  1. Add a new-line between the function type and function identifier as
 per the general convention

 Thanks to ahf and others who provided me with the feedback and input. I
 have pushed the changes to my repository and the CI is still running, I
 will attach the revised patch here too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Thank you! Looks like CI was unhappy with a minor whitespace issue where
 the types need to go on their own line. I've left a comment on Github.

 Once that is fixed, you can move the ticket back to needs_review and/or
 poke me on IRC.

 Thank you!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_revision => needs_review


Comment:

 Thank you. Putting this back into needs_review while we wait for CI to
 finish.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 I renamed my original repository to `tor-fork` and forked a new repository
 from the official `tor` mirror repository, and then pushed my changes.

 I have created pull request [https://github.com/torproject/tor/pull/1899
 #1899]

 P.S I just noticed teor's reply, I was a bit slower when posting :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:5 TheDcoder]:
 > Replying to [comment:4 ahf]:
 >
 > > I think the patch looks fine, but could I get you to create a pull-
 request against our master branch on https://github.com/torproject/tor ?
 This would allow us to verify that the code passes our test-suites and is
 mergeable.
 >
 > Great to know that the patch looks fine. I will certainly create a pull-
 request, though it looks like GitHub's user interface only allows PRs from
 "forks", my repository is not considered a fork because I had cloned it
 from gitweb.torproject.org and then pushed it to a repository under my
 user account. So I need to figure out how to create a pull-request.

 Yes, that's an annoying limitation of GitHub.

 When that's happened to me, I've created a fork under another name, and
 used that fork. (You can also rename and archive the old repository. Then
 you can push all your branches to a new fork under the correct name.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by TheDcoder):

 Replying to [comment:4 ahf]:

 > I think the patch looks fine, but could I get you to create a pull-
 request against our master branch on https://github.com/torproject/tor ?
 This would allow us to verify that the code passes our test-suites and is
 mergeable.

 Great to know that the patch looks fine. I will certainly create a pull-
 request, though it looks like GitHub's user interface only allows PRs from
 "forks", my repository is not considered a fork because I had cloned it
 from gitweb.torproject.org and then pushed it to a repository under my
 user account. So I need to figure out how to create a pull-request.

 > We are generally not very good at dealing with Microsoft Windows, so if
 you know its APIs well, and are working on something related to this,
 please feel free to poke us about anything that you might discover. We
 could definitely need some help in this area :-)

 Thank you, I am not an expert, but I will try to lend a hand whenever I
 can :)

 > Thank you for working on this!

 My pleasure!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision
 * reviewer:   => ahf


Comment:

 I think the patch looks fine, but could I get you to create a pull-request
 against our master branch on https://github.com/torproject/tor ? This
 would allow us to verify that the code passes our test-suites and is
 mergeable.

 We are generally not very good at dealing with Microsoft Windows, so if
 you know its APIs well, and are working on something related to this,
 please feel free to poke us about anything that you might discover. We
 could definitely need some help in this area :-)

 Thank you for working on this!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * version:  Tor: unspecified =>
 * milestone:   => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by TheDcoder):

 * Attachment "tor_win32_ctrl.patch" added.

 The patch in the form of an independent file

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows

[Tor Bug Tracker & Wiki]

#34211: Add support for control signals (ex. Ctrl+C) in Windows
-+-
 Reporter:  TheDcoder|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
  control,termination,signals,windows,winapi |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by TheDcoder):

 I have finished work on the patch and committed it to a separate branch,
 it can be found [https://github.com/TheDcoder/tor/tree/winapi_ctrl_signal
 here]. Please review the changes and let me know if there are any issues
 or improvements that can be worked on.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs