Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:  0.3
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * sponsor:   => Sponsor59-must


Comment:

 This was part of Sponsor 59.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:  0.3
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:  0.1 => 0.3


Comment:

 Awesome! Rebased and pushed to master. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+--
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+--

Comment (by acute):

 I've tested this with version 2.4, and can confirm it works there also.
 Setting to merge_ready and adding my 0.1 points.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+-
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+-
Changes (by acute):

 * status:  needs_review => merge_ready
 * actualpoints:   => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+--
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Yesterday night it was too late to write code, but let's hope that now
 it's not too early in the morning to do that. Please review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-34298=b28d94f1d0c1e3b842ee74f242dc0b770c8564f1
 commit b28d94f in my task-34298 branch] with a possible workaround. Tested
 with version 2.2.1. Would be neat if you could also test it with 2.4 while
 reviewing it. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 I noticed the same issue when setting up an OnionPerf instance on Ubuntu.
 It would be nice to find a solution that works for 2.2.1 and 2.4.

 Is there any way that we can avoid calling `g.node` or `g.nodes`? Maybe
 there's a function for that that hasn't changed its name between 2.2.1 and
 2.4? Or maybe we can specify `socksproxy` when adding the node in the
 first place? (It's too late for me to try this out today, but I wanted to
 leave this idea here just in case somebody wants to pick it up.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+--
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+--

Comment (by acute):

 The patch looks good, but the current version of `python3-networkx` in
 Debian Stable (what we run in deployment) is 2.2.1, so this would break
 it.

 Maybe we could create a `debian-testing` branch where we could merge this
 patch/other bugs we find with newer library versions?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34298 [Metrics/Onionperf]: Address networkx's API change, which breaks OnionPerf

[Tor Bug Tracker & Wiki]

#34298: Address networkx's API change, which breaks OnionPerf
---+--
 Reporter:  phw|  Owner:  phw
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+--
Changes (by phw):

 * status:  assigned => needs_review


Old description:

> Networkx in version
> [https://networkx.github.io/documentation/stable/release/release_2.4.html
> 2.4] deprecated the `node` attribute of `DiGraph` and suggests using
> `nodes` instead. This breaks OnionPerf but luckily, it's an easy fix.

New description:

 Networkx in version
 [https://networkx.github.io/documentation/stable/release/release_2.4.html
 2.4] deprecated the `node` attribute of `DiGraph` and suggests using
 `nodes` instead. This breaks OnionPerf but luckily, it's an easy fix.

 Here's the error I'm getting on master:
 {{{
 Traceback (most recent call last):
   File "/home/phw/rcs/onionperf/venv/bin/onionperf", line 4, in 
 __import__('pkg_resources').run_script('OnionPerf==0.2rc0',
 'onionperf')
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/pkg_resources/__init__.py", line 666, in run_script
 self.require(requires)[0].run_script(script_name, ns)
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/pkg_resources/__init__.py", line 1453, in run_script
 exec(script_code, namespace, namespace)
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/EGG-INFO/scripts/onionperf", line 529,
 in 
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/EGG-INFO/scripts/onionperf", line 350,
 in main
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/EGG-INFO/scripts/onionperf", line 401,
 in measure
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/onionperf/measurement.py", line 239,
 in run
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/onionperf/measurement.py", line 315,
 in __start_tgen_client
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/onionperf/measurement.py", line 341,
 in __start_tgen
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/onionperf/model.py", line 66, in
 __init__
   File "/home/phw/rcs/onionperf/venv/lib/python3.7/site-
 packages/OnionPerf-0.2rc0-py3.7.egg/onionperf/model.py", line 74, in
 generate
 AttributeError: 'DiGraph' object has no attribute 'node'
 }}}

--

Comment:

 Here's my patch:
 https://github.com/NullHypothesis/onionperf/compare/defect/34298

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs