[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit e6befe85fea6b1f0806b2a378d50f56574fd9420 Author: Translation commit bot Date: Wed Sep 5 05:19:13 2018 + Update translations for support-portal --- contents+ga.po | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/contents+ga.po b/contents+ga.po index

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit 8315652bb5bb41ab7aa2411f5944f3b02bd14d9e Author: Translation commit bot Date: Wed Sep 5 04:48:54 2018 + Update translations for support-portal --- contents+ga.po | 87 +- 1 file changed, 74 insertions(+), 13 deletions(-)

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit ef1a9a597a70d40138054b09f611a97479b80f3b Author: Translation commit bot Date: Wed Sep 5 04:18:53 2018 + Update translations for support-portal --- contents+ga.po | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/contents+ga.po

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit 48fd1a6b0fbdc8a16013c584ceb3ca84b7d6dee4 Author: Translation commit bot Date: Wed Sep 5 03:49:15 2018 + Update translations for support-portal --- contents+ga.po | 74 -- 1 file changed, 67 insertions(+), 7 deletions(-)

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit 1424c430a1e2206574ec75a8c99a9c2f48df37bb Author: Translation commit bot Date: Wed Sep 5 03:19:13 2018 + Update translations for support-portal --- contents+ga.po | 45 +++-- 1 file changed, 39 insertions(+), 6 deletions(-) diff --git

[tor-commits] [translation/bridgedb] Update translations for bridgedb

2018-09-04 Thread translation
commit 42ee13268bd7e57f8e1e770841a30449580d6143 Author: Translation commit bot Date: Wed Sep 5 03:15:13 2018 + Update translations for bridgedb --- ml/LC_MESSAGES/bridgedb.po | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ml/LC_MESSAGES/bridgedb.po

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit 7aa5cd6fbb27e198f5d51d714116b305c34a18af Author: Translation commit bot Date: Wed Sep 5 02:49:37 2018 + Update translations for support-portal --- contents+ga.po | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contents+ga.po b/contents+ga.po index 7e726d8de..299910df5

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit 1a8513f3c1237858abbb7e77d40b6fcd2ca7 Author: Translation commit bot Date: Wed Sep 5 02:19:36 2018 + Update translations for support-portal --- contents+ga.po | 58 +++--- 1 file changed, 55 insertions(+), 3 deletions(-)

[tor-commits] [translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd

2018-09-04 Thread translation
commit 116dc8aa387d2d245aec724edd15498c7edcdcd4 Author: Translation commit bot Date: Wed Sep 5 02:18:26 2018 + Update translations for torbutton-torbuttondtd --- hi/torbutton.dtd | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hi/torbutton.dtd

[tor-commits] [translation/tor-browser-manual] Update translations for tor-browser-manual

2018-09-04 Thread translation
commit d7518df67d885efc3be9902af4be677f23e66d50 Author: Translation commit bot Date: Wed Sep 5 02:17:46 2018 + Update translations for tor-browser-manual --- hi/hi.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hi/hi.po b/hi/hi.po index aaa3f109a..a0e543a45

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit 2634144c07bd77834c53e064f54ff8cdcb2e680e Author: Translation commit bot Date: Wed Sep 5 01:48:48 2018 + Update translations for support-portal --- contents+ga.po | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/contents+ga.po

[tor-commits] [translation/support-portal] Update translations for support-portal

2018-09-04 Thread translation
commit 3cbbb643d26d81ac4ad4ee542de3fe4ffc7c479c Author: Translation commit bot Date: Wed Sep 5 01:18:52 2018 + Update translations for support-portal --- contents+ga.po | 6 ++ 1 file changed, 6 insertions(+) diff --git a/contents+ga.po b/contents+ga.po index f67dceb2b..9069a0240

[tor-commits] [tor/master] Add unit test for bridge-style TLS initialization.

2018-09-04 Thread nickm
commit 3cdf0497f9672bc281b0aac2606123249d7b9ddc Author: Nick Mathewson Date: Tue Sep 4 12:08:06 2018 -0400 Add unit test for bridge-style TLS initialization. --- src/test/test_tortls.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/test/test_tortls.c

[tor-commits] [tor/master] Debug one last reference-counting issue that only appeared on openssl master

2018-09-04 Thread nickm
commit 03efb67b42ce88ca6073eadc1b66d6151d646607 Author: Nick Mathewson Date: Tue Sep 4 20:46:46 2018 -0400 Debug one last reference-counting issue that only appeared on openssl master --- src/lib/tls/tortls_openssl.c | 5 ++--- src/test/test_tortls.c | 10 -- 2 files

[tor-commits] [tor/master] Fix an easy refcounting bug in a unit test

2018-09-04 Thread nickm
commit eeba944ee0a642ef105b639f1bb0580fae28d3ab Author: Nick Mathewson Date: Tue Sep 4 20:25:25 2018 -0400 Fix an easy refcounting bug in a unit test --- src/test/test_x509.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/test/test_x509.c b/src/test/test_x509.c index

[tor-commits] [tor/master] Fix documentation of ENABLE_NSS

2018-09-04 Thread nickm
commit 3b10108a2abec89a9f1f8ba57a99a8b10a67515c Author: Nick Mathewson Date: Tue Sep 4 09:51:39 2018 -0400 Fix documentation of ENABLE_NSS --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f99697a44..de53b1ab2 100644 ---

[tor-commits] [tor/master] Document winsock includes better

2018-09-04 Thread nickm
commit 7acb8c8d1835f919fee09585c966dee837f2e9f6 Author: Nick Mathewson Date: Tue Sep 4 10:55:15 2018 -0400 Document winsock includes better --- src/lib/tls/tortls_nss.c | 2 +- src/lib/tls/tortls_openssl.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

[tor-commits] [tor/master] Resolve openssl-only memory leaks

2018-09-04 Thread nickm
commit d644c93ae9373f99d95870c7b752b790f8714201 Author: Nick Mathewson Date: Tue Sep 4 19:41:59 2018 -0400 Resolve openssl-only memory leaks --- src/lib/tls/tortls_openssl.c | 2 +- src/lib/tls/x509.c | 3 +-- src/test/test_tortls_openssl.c | 2 +- 3 files changed, 3

[tor-commits] [tor/master] Fix documentation of initialized fields in crypto_init.c

2018-09-04 Thread nickm
commit 70c27b7e39b9437bf18c0342b15a5c6a3022e204 Author: Nick Mathewson Date: Tue Sep 4 10:51:26 2018 -0400 Fix documentation of initialized fields in crypto_init.c --- src/lib/crypt_ops/crypto_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[tor-commits] [tor/master] Remove tor_tls_check_lifetime as unused.

2018-09-04 Thread nickm
commit 59c1b34b72ec6c55ca4de0c56a9be3da3d1c3e08 Author: Nick Mathewson Date: Tue Sep 4 12:09:43 2018 -0400 Remove tor_tls_check_lifetime as unused. Everything that might have used it, uses tor_tls_cert_is_valid() instead. --- src/lib/tls/tortls.c | 32

[tor-commits] [tor/master] Use FREE_AND_NULL for impl types

2018-09-04 Thread nickm
commit 274efb126324f3f8a7e98b15a697c0038a9803d0 Author: Nick Mathewson Date: Tue Sep 4 14:37:42 2018 -0400 Use FREE_AND_NULL for impl types --- src/lib/tls/tortls.c | 17 ++--- src/lib/tls/tortls_internal.h | 6 +- src/lib/tls/tortls_nss.c | 6 +-

[tor-commits] [tor/master] Several unit tests to improve test coverage of x509*.c

2018-09-04 Thread nickm
commit 7163389b550a36fa017f700713405fc3c89dc234 Author: Nick Mathewson Date: Thu Aug 23 14:03:00 2018 -0400 Several unit tests to improve test coverage of x509*.c --- src/lib/crypt_ops/crypto_digest.c | 4 +- src/lib/crypt_ops/crypto_digest.h | 3 +- src/lib/tls/x509.c

[tor-commits] [tor/master] Fix a pair of remaining leaks in tortls_nss.c

2018-09-04 Thread nickm
commit c50537fd9462af45f0a53aa4f0d5ca03a08fc41e Author: Nick Mathewson Date: Tue Sep 4 19:23:55 2018 -0400 Fix a pair of remaining leaks in tortls_nss.c Fun fact: PR_Close leaks memory if its socket is not valid. --- src/lib/tls/tortls_nss.c | 8 +++- src/test/test_router.c

[tor-commits] [tor/master] Port test_tortls_verify to not depend on openssl internals

2018-09-04 Thread nickm
commit ad94d43fc50525e8814b6e99f78d4b9635fa80ca Author: Nick Mathewson Date: Tue Sep 4 12:59:47 2018 -0400 Port test_tortls_verify to not depend on openssl internals --- src/lib/tls/x509.c | 9 +++ src/lib/tls/x509_internal.h| 1 + src/lib/tls/x509_nss.c | 10

[tor-commits] [tor/master] Unify functions for reading/writing PEM keys, to avoid duplication.

2018-09-04 Thread nickm
commit 3b5d6ef15bec26c3bda22057ba09e1301613ee71 Author: Nick Mathewson Date: Wed Aug 29 16:43:54 2018 -0400 Unify functions for reading/writing PEM keys, to avoid duplication. --- src/lib/crypt_ops/crypto_rsa.c | 145 - 1 file changed, 71

[tor-commits] [tor/master] Test a few more tortls.c functions

2018-09-04 Thread nickm
commit 52ac539b9938af6c47355b67ce1def1236f4ee39 Author: Nick Mathewson Date: Thu Aug 23 18:57:26 2018 -0400 Test a few more tortls.c functions --- src/lib/tls/tortls_nss.c | 17 ++ src/test/test_tortls.c | 82 2 files changed, 93

[tor-commits] [tor/master] Update prefork and postfork NSS code for unit tests.

2018-09-04 Thread nickm
commit 36f3bdac032523c6d98022c84059d8ebd69dfdfe Author: Nick Mathewson Date: Wed Aug 29 08:39:19 2018 -0400 Update prefork and postfork NSS code for unit tests. --- src/ext/tinytest.c | 5 - src/lib/crypt_ops/crypto_init.c| 12 +++-

[tor-commits] [tor/master] Make some additional RSA functions const

2018-09-04 Thread nickm
commit edbb5ef5b258db15459407f8964b83b6dd4c3d22 Author: Nick Mathewson Date: Tue Sep 4 09:51:03 2018 -0400 Make some additional RSA functions const --- src/lib/crypt_ops/crypto_rsa.h | 4 ++-- src/lib/crypt_ops/crypto_rsa_nss.c | 4 ++-- src/lib/crypt_ops/crypto_rsa_openssl.c

[tor-commits] [tor/master] Refactor some of the certificate-manipulation logic

2018-09-04 Thread nickm
commit 91c1e88b7a6d41f93f88cd8754746c836b25721f Author: Nick Mathewson Date: Sat Aug 11 19:54:11 2018 -0400 Refactor some of the certificate-manipulation logic --- src/lib/tls/tortls.c | 5 ++-- src/lib/tls/x509.c | 68

[tor-commits] [tor/master] NSS support for x509 certs

2018-09-04 Thread nickm
commit c567b8fcb4e4851d6db19946cce8c4d5e75535f5 Author: Nick Mathewson Date: Mon Aug 13 14:54:35 2018 -0400 NSS support for x509 certs 7 unit tests are failing at this point, but they're all TLS-related. --- src/lib/crypt_ops/crypto_nss_mgt.c | 9 +

[tor-commits] [tor/master] Remove tor_tls_shutdown()

2018-09-04 Thread nickm
commit dd04fc35c665976f9fc9ff586cbf7fe34d9cc241 Author: Nick Mathewson Date: Thu Aug 23 09:32:20 2018 -0400 Remove tor_tls_shutdown() This function was supposed to implement a half-duplex mode for our TLS connections. However, nothing in Tor actually uses it (besides some

[tor-commits] [tor/master] Avoid double-close on TCP sockets under NSS.

2018-09-04 Thread nickm
commit b5fddbd24144a94580e50886cd07a82968a1b86c Author: Nick Mathewson Date: Thu Aug 23 13:02:12 2018 -0400 Avoid double-close on TCP sockets under NSS. --- src/core/mainloop/connection.c | 25 + src/lib/tls/tortls_openssl.c | 2 +- 2 files changed, 18

[tor-commits] [tor/master] Remove tor_x509_get_cert_impl as unneeded.

2018-09-04 Thread nickm
commit 02086a216f15fd8c45e603a8d9bab482f60753f4 Author: Nick Mathewson Date: Thu Aug 23 13:05:38 2018 -0400 Remove tor_x509_get_cert_impl as unneeded. --- src/lib/tls/tortls_openssl.c | 2 +- src/lib/tls/x509.c | 8 src/lib/tls/x509_internal.h | 2 -- 3 files changed,

[tor-commits] [tor/master] Do not leave a certificate allocated after testing dirvote_add()

2018-09-04 Thread nickm
commit b892133fb9307aba2b9e7931472b9ad9a1628bb2 Author: Nick Mathewson Date: Wed Aug 29 16:00:49 2018 -0400 Do not leave a certificate allocated after testing dirvote_add() --- src/test/test_dir_handle_get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[tor-commits] [tor/master] Implement RSA for NSS.

2018-09-04 Thread nickm
commit aa45511250ed9509ca06b76497f66835796a7998 Author: Nick Mathewson Date: Thu Jul 19 12:03:01 2018 -0400 Implement RSA for NSS. --- src/lib/crypt_ops/crypto_rsa.h | 16 +- src/lib/crypt_ops/crypto_rsa_nss.c | 699 +

[tor-commits] [tor/master] Initial NSS support for TLS.

2018-09-04 Thread nickm
commit 5205c7fd903cb5bd751812bddb5497ac76e1f30b Author: Nick Mathewson Date: Fri Aug 17 11:24:50 2018 -0400 Initial NSS support for TLS. This is enough to get a chutney network to bootstrap, though a bunch of work remains. --- src/lib/tls/tortls.c | 122 +

[tor-commits] [tor/master] Rename crypto_pk_check_key(), use it more reasonably, add tests

2018-09-04 Thread nickm
commit 600e046ed32f9826bcbdf223d99ed8af23a67504 Author: Nick Mathewson Date: Fri Aug 31 16:15:20 2018 -0400 Rename crypto_pk_check_key(), use it more reasonably, add tests This function was a wrapper around RSA_check_key() in openssl, which checks for invalid RSA private keys

[tor-commits] [tor/master] Do not leak a reference to "slot" when decoding private key.

2018-09-04 Thread nickm
commit f46a7eafb88494922f331d198500f94dee0a6d8e Author: Nick Mathewson Date: Wed Aug 29 15:17:47 2018 -0400 Do not leak a reference to "slot" when decoding private key. --- src/lib/crypt_ops/crypto_rsa_nss.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[tor-commits] [tor/master] Extract internal-only parts of x509.h

2018-09-04 Thread nickm
commit b9ca8f2356a98630a262951486cd10436963e169 Author: Nick Mathewson Date: Sun Aug 12 18:01:14 2018 -0400 Extract internal-only parts of x509.h --- src/lib/tls/include.am | 3 ++- src/lib/tls/x509.c | 1 + src/lib/tls/x509.h | 11 ---

[tor-commits] [tor/master] Avoid spurious error logs when using NSS

2018-09-04 Thread nickm
commit 52d5f4da12cf4a9647a896395209121cbf9483c4 Author: Nick Mathewson Date: Thu Aug 23 10:13:32 2018 -0400 Avoid spurious error logs when using NSS The tls_log_errors() function now behaves differently for NSS than it did for OpenSSL, so we need to tweak it a bit. ---

[tor-commits] [tor/master] changes file for our NSS support

2018-09-04 Thread nickm
commit c18967d6c80f6a40acc78556490a4f40bc0e7003 Author: Nick Mathewson Date: Thu Aug 23 11:45:34 2018 -0400 changes file for our NSS support --- changes/NSS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/changes/NSS b/changes/NSS new file mode 100644 index 0..fc13867b4

[tor-commits] [tor/master] The RSA_free in this test is no longer needed or wanted

2018-09-04 Thread nickm
commit 3ccb94d7b6ff6806bc17d71ef461f4211a014879 Author: Nick Mathewson Date: Sat Aug 11 16:36:05 2018 -0400 The RSA_free in this test is no longer needed or wanted --- src/test/test_tortls.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/test/test_tortls.c b/src/test/test_tortls.c

[tor-commits] [tor/master] Refactor crypto_rsa to use pem module.

2018-09-04 Thread nickm
commit b94e7de7dbf31a9b9bfe2d376013e279f15500f8 Author: Nick Mathewson Date: Thu Jul 19 17:09:23 2018 -0400 Refactor crypto_rsa to use pem module. This cleans up a lot of junk from crypto_rsa_openssl, and will save us duplicated code in crypto_rsa_nss (when it exists).

[tor-commits] [tor/master] Change log_test_helpers macros to use printf, not pasting

2018-09-04 Thread nickm
commit 8148c0717dc6b05b0cda18ade94e03ed947bc7a3 Author: Nick Mathewson Date: Wed Aug 22 10:31:44 2018 -0400 Change log_test_helpers macros to use printf, not pasting This ensures that our test failure messages actually tell us what strings Tor was expecting. I will need this

[tor-commits] [tor/master] Use a constant for "65537"

2018-09-04 Thread nickm
commit 0812f1cbc2f528f0acb785e2fea416b9f2113c7c Author: Nick Mathewson Date: Thu Jul 19 09:23:30 2018 -0400 Use a constant for "65537" --- src/lib/crypt_ops/crypto_rsa.h | 3 +++ src/lib/crypt_ops/crypto_rsa_openssl.c | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-)

[tor-commits] [tor/master] Make some x509 functions generic; remove some fields NSS doesn't need

2018-09-04 Thread nickm
commit 5245a296c58eb8aba712e94a78d5bcaa2a2f25fb Author: Nick Mathewson Date: Sun Aug 12 19:40:47 2018 -0400 Make some x509 functions generic; remove some fields NSS doesn't need --- src/lib/tls/x509.c | 79 +--- src/lib/tls/x509.h

[tor-commits] [tor/master] When enabling NSS, disable OpenSSL.

2018-09-04 Thread nickm
commit 6a88d8f6b413efdac4b0176cfb78431be46ca9e0 Author: Nick Mathewson Date: Sun Aug 12 17:18:41 2018 -0400 When enabling NSS, disable OpenSSL. We used to link both libraries at once, but now that I'm working on TLS, there's nothing left to keep OpenSSL around for when NSS is

[tor-commits] [tor/master] Log error strings in crypto_nss_log_errors().

2018-09-04 Thread nickm
commit 7c5339677fd4d524a95bc8c18af223f710ca94e2 Author: Nick Mathewson Date: Wed Aug 22 11:03:33 2018 -0400 Log error strings in crypto_nss_log_errors(). I'll need this for debugging. --- src/lib/crypt_ops/crypto_nss_mgt.c | 16 +--- 1 file changed, 13 insertions(+),

[tor-commits] [tor/master] Implement PBKDF2 with NSS.

2018-09-04 Thread nickm
commit 96f8e1980204e83bb943fbff31e308a03b41160c Author: Nick Mathewson Date: Sun Aug 12 17:46:53 2018 -0400 Implement PBKDF2 with NSS. This was a gap that we left in the last commit. --- src/lib/crypt_ops/crypto_s2k.c | 47 +++--- 1 file

[tor-commits] [tor/master] Split X509 code out of tortls.c

2018-09-04 Thread nickm
commit 9a4f05b05c12687e640d2aed9bb21229138bd1a5 Author: Nick Mathewson Date: Sat Aug 11 18:16:04 2018 -0400 Split X509 code out of tortls.c --- src/core/or/channeltls.c | 1 + src/core/or/connection_or.c| 1 + src/feature/nodelist/torcert.c | 1 +

[tor-commits] [tor/master] Extract the non-generic part of tor_tls_context_decref().

2018-09-04 Thread nickm
commit 108d9879eb814bc06095a1819d98b1c7c9a38e88 Author: Nick Mathewson Date: Sun Aug 12 17:54:06 2018 -0400 Extract the non-generic part of tor_tls_context_decref(). --- src/lib/tls/tortls.c | 19 +++ src/lib/tls/tortls_internal.h | 7 +++

[tor-commits] [tor/master] Rename openssl-bridging functions in crypto_rsa

2018-09-04 Thread nickm
commit 824009cde52d40c937c23670b71e9c5b28d2e1f3 Author: Nick Mathewson Date: Thu Jul 19 09:07:08 2018 -0400 Rename openssl-bridging functions in crypto_rsa These functions exist only to expose RSA keys to other places in Tor that use OpenSSL; let's be specific about their

[tor-commits] [tor/master] Also reinitialize the pregenerated keys postfork.

2018-09-04 Thread nickm
commit cb5cfe3177bbf841e5ad18c0103b3d2ebe443e07 Author: Nick Mathewson Date: Tue Jul 31 18:42:42 2018 -0400 Also reinitialize the pregenerated keys postfork. --- src/test/testing_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/testing_common.c

[tor-commits] [tor/master] Extract tortls structures into a new header; clean up a little

2018-09-04 Thread nickm
commit 598bc78bfa62e0879497c0ef03999d3700a5cd16 Author: Nick Mathewson Date: Sat Aug 11 19:38:07 2018 -0400 Extract tortls structures into a new header; clean up a little --- src/lib/tls/tortls.c | 5 ++-- src/lib/tls/tortls.h | 58 +---

[tor-commits] [tor/master] Add rudimentary support for PEM-encoding, since NSS doesn't do that.

2018-09-04 Thread nickm
commit 9566ed6fd9e4aab2ce6b84afc2f7112550cf0483 Author: Nick Mathewson Date: Thu Jul 19 15:47:48 2018 -0400 Add rudimentary support for PEM-encoding, since NSS doesn't do that. --- src/lib/encoding/.may_include | 1 + src/lib/encoding/include.am | 2 + src/lib/encoding/pem.c

[tor-commits] [tor/master] Add a cast to make clang happier.

2018-09-04 Thread nickm
commit b590cc0449e1432a36e61bf259e92c679c8f5b6d Author: Nick Mathewson Date: Thu Aug 2 08:36:24 2018 -0400 Add a cast to make clang happier. --- src/lib/crypt_ops/crypto_dh_nss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/crypt_ops/crypto_dh_nss.c

[tor-commits] [tor/master] Fix issues with crypto_ope compilation now that crypto.h is gone

2018-09-04 Thread nickm
commit a4c0a0e81eb3616d7d66806e9ac8ea7c8d3bf439 Author: Nick Mathewson Date: Tue Jul 31 19:56:42 2018 -0400 Fix issues with crypto_ope compilation now that crypto.h is gone --- src/lib/crypt_ops/crypto_ope.c | 2 +- src/test/test_crypto_ope.c | 4 +++- 2 files changed, 4

[tor-commits] [tor/master] Remove a redundant function.

2018-09-04 Thread nickm
commit 38212d2e40a1eae9f65c1a695e478854177c0783 Author: Nick Mathewson Date: Thu Jul 19 09:00:12 2018 -0400 Remove a redundant function. --- src/lib/crypt_ops/crypto_rsa_openssl.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git

[tor-commits] [tor/master] Extract openssl RSA functionality into its own file.

2018-09-04 Thread nickm
commit 752ffa21973c67a789c34511e13d079d8bec3858 Author: Nick Mathewson Date: Thu Jul 19 08:53:40 2018 -0400 Extract openssl RSA functionality into its own file. --- src/lib/crypt_ops/crypto_rsa.c | 795 src/lib/crypt_ops/crypto_rsa_openssl.c | 815

[tor-commits] [tor/master] Make finish_daemon() return a boolean to say whether it did anything.

2018-09-04 Thread nickm
commit 622a2c6bee19af3bab0e84702a36ff2df39db7e7 Author: Nick Mathewson Date: Wed Aug 8 16:59:53 2018 -0400 Make finish_daemon() return a boolean to say whether it did anything. --- src/lib/process/daemon.c | 9 ++--- src/lib/process/daemon.h | 2 +- 2 files changed, 7 insertions(+), 4

[tor-commits] [tor/master] Fix double-link of crypto_openssl_mgt.c

2018-09-04 Thread nickm
commit 727f1676d68fca00f2f40f166b5afda3a5728dc4 Author: Nick Mathewson Date: Thu Aug 2 08:38:59 2018 -0400 Fix double-link of crypto_openssl_mgt.c --- src/lib/crypt_ops/include.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib/crypt_ops/include.am

[tor-commits] [tor/master] Rename functions that encode/decode private keys

2018-09-04 Thread nickm
commit 0f971d7c915e45556c582b8e02017927bf196f7e Author: Nick Mathewson Date: Thu Jul 19 08:56:51 2018 -0400 Rename functions that encode/decode private keys It is not nice to expose a private key's contents without having the function name advertise the fact. Fortunately, we

[tor-commits] [tor/master] Adjust windows stubs for new start/finish_daemon() return types

2018-09-04 Thread nickm
commit e56f0c9d33a6d7f30f790ec304c87900e9ea7d51 Author: Nick Mathewson Date: Tue Aug 14 16:44:59 2018 -0400 Adjust windows stubs for new start/finish_daemon() return types --- src/lib/process/daemon.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[tor-commits] [tor/master] When RunAsDaemon is set, crypto_postfork() as needed

2018-09-04 Thread nickm
commit 4f300d547d65e50ac1fd635f8b22714c1544ba33 Author: Nick Mathewson Date: Wed Aug 8 16:50:23 2018 -0400 When RunAsDaemon is set, crypto_postfork() as needed --- src/app/config/config.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/app/config/config.c

[tor-commits] [tor/master] Refactor the dependency between tortls and crypto_dh.

2018-09-04 Thread nickm
commit 32bbc8f6b5e7d964439c6ba91f87f7d5fba673cc Author: Nick Mathewson Date: Tue Jul 17 11:23:53 2018 -0400 Refactor the dependency between tortls and crypto_dh. We only ever need this to get us a DH ephemeral key object, so make a function that does just that. ---

[tor-commits] [tor/master] Only link crypto_dh_openssl.c once

2018-09-04 Thread nickm
commit 17f922d3719837fade1888dfa7cc99ac801ad800 Author: Nick Mathewson Date: Wed Jul 18 10:19:20 2018 -0400 Only link crypto_dh_openssl.c once (We do this unconditionally, since we still need it for tortls.c) --- src/lib/crypt_ops/include.am | 3 +-- 1 file changed, 1

[tor-commits] [tor/master] Call crypto_postfork on start_daemon() instead.

2018-09-04 Thread nickm
commit a57c27a1c749add88b088f570838373687a0c6fd Author: Nick Mathewson Date: Wed Aug 8 17:32:26 2018 -0400 Call crypto_postfork on start_daemon() instead. --- src/app/config/config.c | 7 +++ src/lib/process/daemon.c | 10 ++ src/lib/process/daemon.h | 2 +- 3 files

[tor-commits] [tor/master] Merge branch 'nss_dh_squashed' into nss_dh_squashed_merged

2018-09-04 Thread nickm
commit fdaa483098d723b4be24a4e861c4280a67a3d4b0 Merge: 7e4ac0283 17f922d37 Author: Nick Mathewson Date: Tue Jul 31 19:56:23 2018 -0400 Merge branch 'nss_dh_squashed' into nss_dh_squashed_merged Makefile.am | 8 + changes/feature26815

[tor-commits] [tor/master] Suppress strict-prototypes warning in crypto_nss_mgt.c

2018-09-04 Thread nickm
commit f83b417bf819ef0cc5f6ff31dd683a53cd7f90f2 Author: Nick Mathewson Date: Thu Aug 2 08:41:33 2018 -0400 Suppress strict-prototypes warning in crypto_nss_mgt.c --- src/lib/crypt_ops/crypto_nss_mgt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/crypt_ops/crypto_nss_mgt.c

[tor-commits] [tor/master] Fix "make distcheck."

2018-09-04 Thread nickm
commit 2d80673b9a7965d5b2af895c7527eb58bd6a00ce Author: Nick Mathewson Date: Wed Jul 18 09:52:47 2018 -0400 Fix "make distcheck." --- src/lib/crypt_ops/include.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/crypt_ops/include.am b/src/lib/crypt_ops/include.am index

[tor-commits] [tor/master] Extract the OpenSSL DH functionality to a new file.

2018-09-04 Thread nickm
commit 60a5b784803df5a1a9e467e0aa14c17b0991f68c Author: Nick Mathewson Date: Tue Jul 17 09:06:05 2018 -0400 Extract the OpenSSL DH functionality to a new file. --- src/lib/crypt_ops/crypto_dh.c | 515 ++ src/lib/crypt_ops/crypto_dh.h | 4 +

[tor-commits] [tor/master] Additional tests for NSS DH

2018-09-04 Thread nickm
commit f5e22358b0d8f71e4d6bad4b72859e2d3f38c700 Author: Nick Mathewson Date: Tue Jul 17 13:08:34 2018 -0400 Additional tests for NSS DH Notably, there's a test to make sure that it round-trips with OpenSSL, if OpenSSL is enabled. --- src/test/test_crypto.c | 56

[tor-commits] [tor/master] Implement DH in NSS.

2018-09-04 Thread nickm
commit 17ea931ac70af3cc11c1729b09b8e1ff17a53348 Author: Nick Mathewson Date: Tue Jul 17 11:27:08 2018 -0400 Implement DH in NSS. --- src/lib/crypt_ops/crypto_dh.c | 22 src/lib/crypt_ops/crypto_dh.h | 11 +- src/lib/crypt_ops/crypto_dh_nss.c | 207

[tor-commits] [tor/master] Extract the shared part of crypto_dh_compute_secret.

2018-09-04 Thread nickm
commit ac9a470c641fd3ba826cdad07b1a7a495c00acba Author: Nick Mathewson Date: Tue Jul 17 09:16:11 2018 -0400 Extract the shared part of crypto_dh_compute_secret. --- src/lib/crypt_ops/crypto_dh.c | 47 +++ src/lib/crypt_ops/crypto_dh.h | 7

[tor-commits] [tor/master] Use NSS for AES_CTR.

2018-09-04 Thread nickm
commit 76e10ee6b9fbd5a0372f6d04e432c78aa560e9f9 Author: Nick Mathewson Date: Mon Jul 16 09:49:05 2018 -0400 Use NSS for AES_CTR. --- src/lib/crypt_ops/aes_nss.c| 106 + src/lib/crypt_ops/{aes.c => aes_openssl.c} | 4 +-

[tor-commits] [tor/master] Use NSS in crypto_rand.c

2018-09-04 Thread nickm
commit 60705a5719d929a5f3180bc4e6906f972855f84b Author: Nick Mathewson Date: Fri Jul 13 14:35:51 2018 -0400 Use NSS in crypto_rand.c This is comparatively straightforward too, except for a couple of twists: * For as long as we're building with two crypto libraries,

[tor-commits] [tor/master] Use NSS's digest code in Tor.

2018-09-04 Thread nickm
commit f64c9dccde9ac8261c9f80ed063acc7988d6836c Author: Nick Mathewson Date: Wed Jul 11 16:54:05 2018 -0400 Use NSS's digest code in Tor. This was a fairly straightforward port, once I realized which layer I should be calling into. --- src/lib/crypt_ops/crypto_digest.c | 258

[tor-commits] [tor/master] Make the rust tests link.

2018-09-04 Thread nickm
commit 99beed152e5df41181703645a67fe10a98225d55 Author: Nick Mathewson Date: Wed Jul 18 10:40:52 2018 -0400 Make the rust tests link. --- config.rust.in| 2 ++ src/rust/build.rs | 1 + 2 files changed, 3 insertions(+) diff --git a/config.rust.in b/config.rust.in index

[tor-commits] [tor/master] Add a configure switch to build with NSS.

2018-09-04 Thread nickm
commit 79267bad654ed39f13e6fb89a5468f23468c3169 Author: Nick Mathewson Date: Wed Jul 11 12:57:30 2018 -0400 Add a configure switch to build with NSS. When it is set, include the NSS headers and libraries as appropriate. Doesn't actually use them yet, though. --- Makefile.am

[tor-commits] [tor/master] Remove most includes from crypto.c

2018-09-04 Thread nickm
commit 9010797e632065ae073cd69f6b76a2d55c06160d Author: Nick Mathewson Date: Wed Jul 11 14:02:23 2018 -0400 Remove most includes from crypto.c --- src/lib/crypt_ops/crypto.c | 49 -- 1 file changed, 49 deletions(-) diff --git

[tor-commits] [tor/master] Move crypto_add_spaces_to_fp() to crypto_rsa.c

2018-09-04 Thread nickm
commit 8e2df9886003c12b0624c54b950090c8fc36396b Author: Nick Mathewson Date: Wed Jul 11 13:51:26 2018 -0400 Move crypto_add_spaces_to_fp() to crypto_rsa.c --- src/lib/crypt_ops/crypto.c | 20 src/lib/crypt_ops/crypto.h | 2 -- src/lib/crypt_ops/crypto_rsa.c |

[tor-commits] [tor/master] Rename crypto.c to crypto_cipher.c (since that's all it still has.)

2018-09-04 Thread nickm
commit f45107e7de7ff15c630dedcdd1f9bc524423838f Author: Nick Mathewson Date: Wed Jul 11 14:08:22 2018 -0400 Rename crypto.c to crypto_cipher.c (since that's all it still has.) --- src/core/crypto/onion_ntor.c| 2 +- src/core/crypto/relay_crypto.c | 2

[tor-commits] [tor/master] Changes files for feature26815 and 26816

2018-09-04 Thread nickm
commit e7a061681769beb9b643dbb703427e6faca3ef21 Author: Nick Mathewson Date: Mon Jul 16 14:07:38 2018 -0400 Changes files for feature26815 and 26816 --- changes/feature26815 | 3 +++ changes/feature26816 | 11 +++ 2 files changed, 14 insertions(+) diff --git

[tor-commits] [tor/master] Make sure NSS is initialized before running benchmarks

2018-09-04 Thread nickm
commit be8d497b656b674e33726f49d9829cc03fccea09 Author: Nick Mathewson Date: Fri Jul 13 13:43:23 2018 -0400 Make sure NSS is initialized before running benchmarks --- src/test/bench.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/bench.c

[tor-commits] [tor/master] Initialize and shut down NSS.

2018-09-04 Thread nickm
commit c317e78dd75b6bf9c195c9bef5a0b8300d55411a Author: Nick Mathewson Date: Wed Jul 11 14:46:28 2018 -0400 Initialize and shut down NSS. This is largely conjectural, based on online documentation for NSS and NSPR. --- src/lib/crypt_ops/crypto_init.c| 18 +--

[tor-commits] [tor/master] Make nss get initialized before we fuzz anything.

2018-09-04 Thread nickm
commit 27dd2b1f1ff612977ec50c9e15dbe14607b0551b Author: Nick Mathewson Date: Wed Jul 11 16:15:42 2018 -0400 Make nss get initialized before we fuzz anything. --- src/test/fuzz/fuzzing_common.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[tor-commits] [tor/master] Move the initialization and cleanup parts of crypto.c

2018-09-04 Thread nickm
commit 12a1ada15853f0cde2839921bf413ba24a741192 Author: Nick Mathewson Date: Wed Jul 11 13:44:35 2018 -0400 Move the initialization and cleanup parts of crypto.c These are now part of crypto_init.c. The openssl-only parts now live in crypto_openssl_mgt.c. I recommend

[tor-commits] [tor/master] Make our crypto library symbolic in the makefiles.

2018-09-04 Thread nickm
commit 92db96d80fddca5394a24256bb6b4691f380a8ae Author: Nick Mathewson Date: Wed Jul 11 12:51:36 2018 -0400 Make our crypto library symbolic in the makefiles. --- Makefile.am | 3 +++ src/app/include.am | 8 src/test/fuzz/include.am | 4 ++--

[tor-commits] [tor/master] Add postfork support for nss

2018-09-04 Thread nickm
commit d811ce2421dcf1684db7e34f2b5998d9f360d5fb Author: Nick Mathewson Date: Wed Jul 11 15:36:54 2018 -0400 Add postfork support for nss We need this in our unit tests, since otherwise NSS will notice we've forked and start cussing us out. I suspect we'll need a

[tor-commits] [tor/master] Extract and rename crypto_log_errors().

2018-09-04 Thread nickm
commit 922208bd2d63c282a189b6fdd0da29ff40c08e82 Author: Nick Mathewson Date: Wed Jul 11 13:54:47 2018 -0400 Extract and rename crypto_log_errors(). --- src/lib/crypt_ops/crypto_dh.c | 6 +++--- src/lib/crypt_ops/crypto_openssl_mgt.c | 22 ++

[tor-commits] [translation/torbutton-abouttbupdatedtd] Update translations for torbutton-abouttbupdatedtd

2018-09-04 Thread translation
commit e36d084f73230eeb4abd9b1885776b084fee197a Author: Translation commit bot Date: Tue Sep 4 23:18:07 2018 + Update translations for torbutton-abouttbupdatedtd --- zh_TW/abouttbupdate.dtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zh_TW/abouttbupdate.dtd

[tor-commits] [translation/tba-android_stringsdtd] Update translations for tba-android_stringsdtd

2018-09-04 Thread translation
commit 5bd790aa10046ed234e62ff7cc6e3aa5fd6f521e Author: Translation commit bot Date: Tue Sep 4 23:16:48 2018 + Update translations for tba-android_stringsdtd --- zh_TW/android_strings.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zh_TW/android_strings.dtd

[tor-commits] [translation/https_everywhere] Update translations for https_everywhere

2018-09-04 Thread translation
commit 40c4c799565e5921607e8e966e6783baf0ae1a9a Author: Translation commit bot Date: Tue Sep 4 23:15:28 2018 + Update translations for https_everywhere --- zh_TW/https-everywhere.dtd | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[tor-commits] [translation/abouttor-homepage] Update translations for abouttor-homepage

2018-09-04 Thread translation
commit 923712ddb853503793ddf69b9194f2e3bacd5313 Author: Translation commit bot Date: Tue Sep 4 23:15:03 2018 + Update translations for abouttor-homepage --- zh_TW/aboutTor.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zh_TW/aboutTor.dtd b/zh_TW/aboutTor.dtd

[tor-commits] [translation/torbutton-torbuttonproperties_completed] Update translations for torbutton-torbuttonproperties_completed

2018-09-04 Thread translation
commit 240cf0e87d36ac4f7e0450665a22ce9ca9687a22 Author: Translation commit bot Date: Tue Sep 4 22:17:48 2018 + Update translations for torbutton-torbuttonproperties_completed --- ga/torbutton.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[tor-commits] [translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties

2018-09-04 Thread translation
commit 106c3b4f2f02218b78817ca86e19ded71b005861 Author: Translation commit bot Date: Tue Sep 4 22:17:44 2018 + Update translations for torbutton-torbuttonproperties --- ga/torbutton.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ga/torbutton.properties

[tor-commits] [translation/tails-misc] Update translations for tails-misc

2018-09-04 Thread translation
commit 47e3d0b143629c27a4fe107a5ab2f1b1272766ba Author: Translation commit bot Date: Tue Sep 4 22:15:53 2018 + Update translations for tails-misc --- gl.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gl.po b/gl.po index 2c46929b1..19f768a42 100644 ---

[tor-commits] [translation/tails-persistence-setup] Update translations for tails-persistence-setup

2018-09-04 Thread translation
commit 72ae07bfa134a02e3d16efb971bce0905de8a658 Author: Translation commit bot Date: Tue Sep 4 21:46:39 2018 + Update translations for tails-persistence-setup --- lt/lt.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lt/lt.po b/lt/lt.po index

[tor-commits] [translation/tails-misc] Update translations for tails-misc

2018-09-04 Thread translation
commit 7ff9b64ca0644b663bebbb34478702ecc58a0782 Author: Translation commit bot Date: Tue Sep 4 21:45:52 2018 + Update translations for tails-misc --- lt.po | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/lt.po b/lt.po index

[tor-commits] [translation/bridgedb] Update translations for bridgedb

2018-09-04 Thread translation
commit aba31a5302ecd778a9f247b681d6fc4064ba3a87 Author: Translation commit bot Date: Tue Sep 4 21:15:10 2018 + Update translations for bridgedb --- cs/LC_MESSAGES/bridgedb.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cs/LC_MESSAGES/bridgedb.po

  1   2   3   >