[tor-commits] [tor/master] hs: Add changes file for 32020

commit 85b984dbc6b97df8908bd7a3fe5433ddd4dfaf5a Author: David Goulet Date: Wed Nov 20 11:01:47 2019 -0500 hs: Add changes file for 32020 Signed-off-by: David Goulet --- changes/ticket32020 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/changes/ticket32020 b/changes/tic

[tor-commits] [tor/master] hs-v2: Move v2 circuit cleanup actions into hs_circ_cleanup()

commit 00136c9430c60edcd8a4e0d725ed711e03c7c607 Author: David Goulet Date: Wed Oct 30 14:48:04 2019 -0400 hs-v2: Move v2 circuit cleanup actions into hs_circ_cleanup() Refactor to decomplexify circuit_about_to_free() and finally have one single entry point into the HS subsystem

[tor-commits] [tor/master] hs-v2: Modernize rend_client_circuit_cleanup() code

commit 1aafe3376ea08fb31fcb7e0a8a390ff5edeb8602 Author: David Goulet Date: Wed Oct 30 15:17:47 2019 -0400 hs-v2: Modernize rend_client_circuit_cleanup() code Old and messy code path. Structure it in a more pleasant and readable way. No behavior change with this refactor.

[tor-commits] [tor/master] hs-v3: Remove unused hs_service_intro_circ_has_closed()

commit a423cec670140c3afa59258e302435a5a4a9791d Author: David Goulet Date: Wed Nov 20 11:03:45 2019 -0500 hs-v3: Remove unused hs_service_intro_circ_has_closed() Since the removal of ip->circuit_established, this function does litterally nothing so clean it up. Part of

[tor-commits] [tor/master] test: Add unit tests for closing intro circ on failure

commit c508513014c6a6034d98e0b07f499d62d56786a5 Author: David Goulet Date: Thu Oct 31 09:04:52 2019 -0400 test: Add unit tests for closing intro circ on failure Signed-off-by: David Goulet --- src/test/test_hs_client.c | 109 ++ 1 file

[tor-commits] [tor/master] circ: Add hidden service helper functions

commit 588794771fdaf7cd129efb2043fb58572c8b04ca Author: David Goulet Date: Wed Oct 30 14:26:21 2019 -0400 circ: Add hidden service helper functions Functions to correctly identify HS circuit type and version. Part of #32020 Signed-off-by: David Goulet --- src/co

[tor-commits] [tor/master] hs-v3: Add changes file for ticket #30382

commit cb11276068fc06090e6b5a27c3dd17676dab4aac Author: David Goulet Date: Wed Nov 20 09:24:38 2019 -0500 hs-v3: Add changes file for ticket #30382 Signed-off-by: David Goulet --- changes/ticket30382 | 5 + 1 file changed, 5 insertions(+) diff --git a/changes/ticket30382 b/c

[tor-commits] [tor/master] hs-v3: Return bad address SOCKS5 extended error

commit 709d7fba11482a7dae23aaecf8a5ec2bd78e47fb Author: David Goulet Date: Tue Nov 19 11:10:13 2019 -0500 hs-v3: Return bad address SOCKS5 extended error If ExtendedErrors is set for the SocksPort, an invalid .onion address now returns the 0xF6 error code per prop304.

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1555'

commit f23d4df091a3b4c3933d041481316f624cdb98d1 Merge: fe68d83b2 cb1127606 Author: George Kadianakis Date: Thu Nov 21 13:03:44 2019 +0200 Merge branch 'tor-github/pr/1555' changes/ticket30382 | 5 + doc/tor.1.txt | 18 -- src/core/or/connecti

[tor-commits] [torspec/master] socks-extensions.txt: Merge in prop304

commit c5bca880894f216c42635b5f1982d057d7cf4778 Author: David Goulet Date: Wed Nov 20 09:35:52 2019 -0500 socks-extensions.txt: Merge in prop304 Signed-off-by: David Goulet --- socks-extensions.txt | 4 1 file changed, 4 insertions(+) diff --git a/socks-extensions.txt b/soc

[tor-commits] [torspec/master] prop304: Close proposal now merged into our main specs

commit 7c222131ba32bc22d3f34baa13eecaa6e8bd7546 Author: David Goulet Date: Wed Nov 20 09:36:39 2019 -0500 prop304: Close proposal now merged into our main specs Signed-off-by: David Goulet --- proposals/000-index.txt | 4 ++-- proposals/304-socks5-extend

[tor-commits] [tor/master] hs-v3: Function to re-parse unencrypted descriptor

commit 48a9f8a63f4d605e9bee5e7131b1f6db1ec95295 Author: David Goulet Date: Fri May 31 09:27:36 2019 -0400 hs-v3: Function to re-parse unencrypted descriptor We now keep descriptor that we can't decode due to missing client authorization in the cache. This new function

[tor-commits] [tor/master] test: Unit test for the hs cache decrypt on new auth

commit 3892ac7c718d25315d779b5c29ffae58c70a5dce Author: David Goulet Date: Thu Jun 6 09:36:02 2019 -0400 test: Unit test for the hs cache decrypt on new auth Part of #30382 Signed-off-by: David Goulet --- src/feature/hs/hs_client.c | 6 src/feature/hs/hs_client.h |

[tor-commits] [tor/master] socks: Send back extended error code if set

commit 84162c1d33c94f6d7eb87fdfea5934cba1d4fad3 Author: David Goulet Date: Thu Oct 17 08:52:58 2019 -0400 socks: Send back extended error code if set This commit defines the new extended error codes. It also flags the socks request object that it can use them. Part of

[tor-commits] [tor/master] hs-v3: Improve documentation of hs_cache_client_descriptor_t

commit 68a004d147bd4bd245563b7b7ed2f97e1f333dd4 Author: David Goulet Date: Thu Oct 17 09:50:23 2019 -0400 hs-v3: Improve documentation of hs_cache_client_descriptor_t Signed-off-by: David Goulet --- src/feature/hs/hs_cache.h | 6 -- 1 file changed, 4 insertions(+), 2 deletion

[tor-commits] [tor/master] hs-v3: Add a series of decoding error code

commit 52bf54ecd4aa48a95f16c2e678ede7d24ef4d322 Author: David Goulet Date: Tue May 28 12:35:04 2019 -0400 hs-v3: Add a series of decoding error code This commit introduces the hs_desc_decode_status_t enum which aims at having more fine grained error code when decoding a descrip

[tor-commits] [tor/master] hs-v3: Set extended error when descriptor is not found

commit fb1d2120212bef100f2b5e90d27b8c251280cb0c Author: David Goulet Date: Tue May 28 13:36:34 2019 -0400 hs-v3: Set extended error when descriptor is not found Part of #30382 Signed-off-by: David Goulet --- src/feature/dirclient/dirclient.c | 1 + src/feature/hs/hs_cli

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1423'

commit d28b6792cb99f25d42607eb46985ac4553013dd8 Merge: c34fb3413 d60ed5a6a Author: George Kadianakis Date: Mon Nov 18 19:06:53 2019 +0200 Merge branch 'tor-github/pr/1423' doc/tor.1.txt | 38 src/app/config/config.c | 6 +- src/core/mainloop/connectio

[tor-commits] [tor/master] hs-v3: Keep descriptor in cache if client auth is missing or bad

commit 96a53221b08436d1fa97e3024f46039591f988c7 Author: David Goulet Date: Tue May 28 13:00:57 2019 -0400 hs-v3: Keep descriptor in cache if client auth is missing or bad We now keep the descriptor in the cache, obviously not decoded, if it can't be decrypted for which we beli

[tor-commits] [tor/master] test: Unit test for the SOCKS5 HS client auth errors

commit c0dd5324b35ee158dc392556b67b5a098de2874a Author: David Goulet Date: Thu Jun 6 08:43:48 2019 -0400 test: Unit test for the SOCKS5 HS client auth errors Part of #30382 Signed-off-by: David Goulet --- src/test/test_hs_client.c | 135 ++

[tor-commits] [tor/master] doc: Manpage entry for ExtendedErrors of prop304

commit d60ed5a6a2586bdf4feb266e44b7db4703d3c4a6 Author: David Goulet Date: Thu Oct 17 10:28:18 2019 -0400 doc: Manpage entry for ExtendedErrors of prop304 Signed-off-by: David Goulet --- doc/tor.1.txt | 38 ++ 1 file changed, 38 insertions(+)

[tor-commits] [tor/master] socks: Add SocksPort flag ExtendedErrors

commit 78a9158bf00e771dcfc41d7e992692b915f27689 Author: David Goulet Date: Thu Oct 17 08:52:21 2019 -0400 socks: Add SocksPort flag ExtendedErrors This new flag tells tor that it can send back the SOCKS5 extended error code detailed in prop304. Part of #30382

[tor-commits] [tor/master] hs-v3: Helper function to find all entry connections

commit 8e0d9189c5e0331d713ec5d5ef3593e2fb0e11d7 Author: David Goulet Date: Tue May 28 11:29:18 2019 -0400 hs-v3: Helper function to find all entry connections No code behavior change. This removes duplicate code that was finding all entry connections for a specific onion servic

[tor-commits] [tor/master] hs-v3: Set extended error if .onion is invalid

commit 80f241907c1b3d69784de98e9ff3f96d5c37f51b Author: David Goulet Date: Thu Oct 17 15:15:14 2019 -0400 hs-v3: Set extended error if .onion is invalid In order to achieve this, the parse_extended_hostname() had to be refactored to return either success or failure and setting

[tor-commits] [tor/master] hs-v3: Refactor descriptor dir fetch done code

commit fbc18c8989bae0e2acb5d903f2bd5b0648bad828 Author: David Goulet Date: Tue May 28 14:43:28 2019 -0400 hs-v3: Refactor descriptor dir fetch done code This commit extract most of the code that dirclient.c had to handle the end of a descriptor directory requests (fetch). It i

[tor-commits] [tor/master] hs-v3: Return descriptor decoding status when storing as client

commit 7bba8bf72f20aa2ac71ac381a7fdf66fadbd473f Author: David Goulet Date: Tue May 28 13:32:15 2019 -0400 hs-v3: Return descriptor decoding status when storing as client This will allow us to callback into the HS subsytem depending on the decoding status and return an extended

[tor-commits] [tor/master] hs-v3: Set extended error when missing/bad client auth

commit 542402cd60bc6b26f43c399b238602a1f3c18d85 Author: David Goulet Date: Tue May 28 13:49:03 2019 -0400 hs-v3: Set extended error when missing/bad client auth Part of #30382 Signed-off-by: David Goulet --- src/feature/dirclient/dirclient.c | 37

[tor-commits] [tor/master] Doxygen: enable source code browser

commit bd6bd7d28eb2718b6c2bfd9fa60d1a855d177f5d Author: Nick Mathewson Date: Tue Nov 5 12:52:28 2019 -0500 Doxygen: enable source code browser --- Doxyfile.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Doxyfile.in b/Doxyfile.in index be500bbfa..4569df545 1006

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1504'

commit 8344776224f83e7438167039d0bbfffe0523123c Merge: 8af8ed72b d7872b775 Author: George Kadianakis Date: Mon Nov 11 14:47:33 2019 +0200 Merge branch 'tor-github/pr/1504' Doxyfile.in | 8 doc/include.am | 1 + doc/tor-doxygen.css | 10 ++ 3 files changed,

[tor-commits] [tor/master] Doxygen: provide a style sheet

commit d7872b775d77fb40a88695b5bea11f751262ad1f Author: Nick Mathewson Date: Tue Nov 5 13:04:51 2019 -0500 Doxygen: provide a style sheet This sheet tries to make links to the source code browser less obtrusive. --- Doxyfile.in | 2 +- doc/include.am | 1 + doc/tor-

[tor-commits] [tor/master] hs-v2: Lookup intro failure cache when picking an intro from descriptor

commit f81e4aa831c51e47954c2d52b72066e796253d80 Author: Neel Chauhan Date: Sun Jul 28 16:34:39 2019 -0400 hs-v2: Lookup intro failure cache when picking an intro from descriptor When picking an intro point from the service descriptor, the client failed to lookup the failure ca

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1484'

commit fa0257eda0b985349b376a6613ca850132b2 Merge: e046903f9 f81e4aa83 Author: George Kadianakis Date: Thu Oct 31 15:31:14 2019 +0800 Merge branch 'tor-github/pr/1484' changes/bug25568 | 5 + src/feature/rend/rendcache.c | 11 +++ src/feature/rend/rendcache.

[tor-commits] [tor/master] hs-v3: Remove the circuit_established intro flag

commit b6c24eb484862cf8741362de792d364d31dc3b0e Author: David Goulet Date: Wed Oct 23 11:37:33 2019 -0400 hs-v3: Remove the circuit_established intro flag Only use the HS circuit map to know if an introduction circuit is established or not. No need for a flag to keep state of

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1456'

commit 4413b98190d94b543b85f57ac3c58f29d4bb96f1 Merge: 30705e829 b6c24eb48 Author: George Kadianakis Date: Tue Oct 29 21:29:13 2019 +0800 Merge branch 'tor-github/pr/1456' changes/ticket32094 | 4 src/feature/hs/hs_circuit.c | 21 + src/feature/hs/hs_circ

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1377'

commit 9309eaf8ead0058aed6f1399b63fc8ae54cef799 Merge: 3778b97ca db329522e Author: George Kadianakis Date: Thu Oct 3 19:13:57 2019 +0300 Merge branch 'tor-github/pr/1377' changes/bug31854| 3 +++ src/lib/log/log.c | 22 -- src/lib/log/log.h | 13 ++

[tor-commits] [tor/master] log: When initialising log domain masks, only set known log domains

commit db329522ef6f0d097cbd07f35d54e0c7eced Author: teor Date: Thu Sep 26 13:37:06 2019 +1000 log: When initialising log domain masks, only set known log domains And add a runtime test that checks for unknown domains and flags. Fixes bug 31854; bugfix on 0.2.1.1-alpha.

[tor-commits] [tor/master] log: Define count, boundary, and all macros for domains and flags

commit 25c5322dfe228178391b37fffdabdf57baa5 Author: teor Date: Thu Sep 26 13:33:17 2019 +1000 log: Define count, boundary, and all macros for domains and flags And do static checks on those macro definitions. Part of 31854. --- src/lib/log/log.c | 4 +++- src/lib/log

[tor-commits] [tor/master] log: Remove duplicate code and an outdated comment

commit 4c88ebcf4728084cad0a1f177eb9cdb107388581 Author: teor Date: Thu Sep 26 13:31:32 2019 +1000 log: Remove duplicate code and an outdated comment Preparation for 31854. --- src/lib/log/log.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/lib/log/lo

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1276'

commit 3778b97cabbf6f89694884c5f6b42dccb488df7f Merge: 065e467e7 49d6990ca Author: George Kadianakis Date: Thu Oct 3 19:13:02 2019 +0300 Merge branch 'tor-github/pr/1276' changes/ticket31549 | 4 +++ src/feature/dirauth/process_descs.c | 59 +++

[tor-commits] [tor/master] Unit tests for dirserv_reject_tor_version().

commit 49d6990cae0f6e7e636e320d0efcaec31b3c0453 Author: Nick Mathewson Date: Thu Aug 29 11:45:41 2019 -0400 Unit tests for dirserv_reject_tor_version(). --- src/test/include.am | 1 + src/test/test.c | 1 + src/test/test.h | 1 + src/test/test_proce

[tor-commits] [tor/master] Authorities reject relays running unsupported Tor release series.

commit 4d4e2abd2f961e735b9b8d93e9e09695515b8ac8 Author: Nick Mathewson Date: Thu Aug 29 11:43:43 2019 -0400 Authorities reject relays running unsupported Tor release series. Our minimum version is now 0.2.9.5-alpha. Series 0.3.0, 0.3.1, 0.3.2, 0.3.3, and 0.3.4 are now rejected

[tor-commits] [tor/master] Add a changes file about the introduction of doc/HACKING/design.

commit b03cb0cc269548f103c2fc3ff611ea3cf90437a5 Author: Nick Mathewson Date: Tue Sep 24 19:35:42 2019 -0400 Add a changes file about the introduction of doc/HACKING/design. --- changes/ticket31849 | 5 + 1 file changed, 5 insertions(+) diff --git a/changes/ticket31849 b/changes/ticket

[tor-commits] [tor/master] Copy architectural documentation from tor-guts.git repository

commit 469051f650096765e1c6b86f23a49b1bcaa0 Author: Nick Mathewson Date: Tue Sep 24 19:26:04 2019 -0400 Copy architectural documentation from tor-guts.git repository I started this repository a while ago to work on documentation for Tor's internals. It needs substantial re

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1366'

commit de66bed604377db23cfa303b83e385ef59121a64 Merge: 931868210 b03cb0cc2 Author: George Kadianakis Date: Mon Sep 30 14:01:01 2019 +0300 Merge branch 'tor-github/pr/1366' changes/ticket31849 | 5 + doc/HACKING/design/00-overview.md | 124 + doc/HAC

[tor-commits] [tor/master] lock: Avoid some undefined behaviour when freeing mutexes.

commit d1eab05834566f998721d3a16107767885711c57 Author: teor Date: Fri Sep 20 11:27:05 2019 +1000 lock: Avoid some undefined behaviour when freeing mutexes. Fixes bug 31736; bugfix on 0.0.7. --- changes/bug31736 | 3 +++ src/app/config/config.c

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1346'

commit 9318682109c5b8742bc868f3d30cb5cd39095f98 Merge: ae8d36db3 d1eab0583 Author: George Kadianakis Date: Mon Sep 30 13:56:51 2019 +0300 Merge branch 'tor-github/pr/1346' changes/bug31736 | 3 +++ src/app/config/config.c| 6 +- src/feature/rela

[tor-commits] [tor/master] log: explain why it is safe to leave the log mutex initialized

commit 749c2e1761c753992fb2549e7ee912e568f563d6 Author: teor Date: Thu Sep 26 12:18:23 2019 +1000 log: explain why it is safe to leave the log mutex initialized The log mutex is dynamically initialized, guarded by log_mutex_initialized. We don't want to destroy it, because afte

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1302'

commit ae8d36db313a548d9828384f2131f481640c6173 Merge: fc760c508 749c2e176 Author: George Kadianakis Date: Mon Sep 30 13:47:53 2019 +0300 Merge branch 'tor-github/pr/1302' changes/bug31614 | 9 + src/lib/err/backtrace.c | 26 +++--- src/lib/log/log.

[tor-commits] [tor/master] changes: file for 31614

commit c9c046c365f10f5cbffada921931413edc690dbe Author: teor Date: Thu Sep 26 12:09:56 2019 +1000 changes: file for 31614 --- changes/bug31614 | 9 + 1 file changed, 9 insertions(+) diff --git a/changes/bug31614 b/changes/bug31614 new file mode 100644 index 0..c425a9fcd --

[tor-commits] [tor/master] backtrace: avoid undefined behaviour on re-initialisation

commit 315f14c709d019c55731faedb19a97b771f9c42f Author: teor Date: Fri Sep 20 11:40:05 2019 +1000 backtrace: avoid undefined behaviour on re-initialisation cb_buf_mutex is statically initialised, so we can not destroy it when we are shutting down the err subsystem. If we destro

[tor-commits] [tor/master] backtrace: Disable signal handlers in remove_bt_handler()

commit 6b97a5a843341b5ea2a9039bdd5290d524a44cd4 Author: teor Date: Wed Sep 4 14:50:09 2019 +1000 backtrace: Disable signal handlers in remove_bt_handler() Fixes bug 31614; bugfix on 0.2.5.2-alpha. --- src/lib/err/backtrace.c | 19 +-- 1 file changed, 17 insertions(

[tor-commits] [tor/master] sandbox: Allow backtrace signals to be disabled

commit 2f8a9a2db692a101b7e6241cbcdf9ed87841310b Author: teor Date: Tue Sep 24 13:51:38 2019 +1000 sandbox: Allow backtrace signals to be disabled Part of 31614. --- src/lib/sandbox/sandbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/sandbox/sandbox.c b/src/lib/sa

[tor-commits] [tor/master] backtrace: Add a missing check for HAVE_PTHREAD_H before using mutexes

commit ab7bfdf40402449d6a2214e1dd5bc3fe5bc9a2e7 Author: teor Date: Mon Sep 9 11:21:15 2019 +1000 backtrace: Add a missing check for HAVE_PTHREAD_H before using mutexes Fixes bug 31614; bugfix on 0.2.5.2-alpha. --- src/lib/err/backtrace.c | 3 ++- 1 file changed, 2 insertions(+), 1

[tor-commits] [tor/master] test: Use SEVERITY_MASK_IDX() to find the LOG_* mask indexes

commit d30a042fa8348028e0bea6f3e46cba1ffbe5adcc Author: teor Date: Wed Sep 25 16:35:02 2019 +1000 test: Use SEVERITY_MASK_IDX() to find the LOG_* mask indexes In the unit tests and fuzzers. Fixes bug 31334; bugfix on 0.2.5.2-alpha. --- changes/bug31334 | 4 +

[tor-commits] [tor/master] log: Move SEVERITY_MASK_IDX() to log.h

commit 1ad1e84b17267f04960b322effaf57ea8a9690c0 Author: teor Date: Mon Aug 5 20:04:08 2019 +1000 log: Move SEVERITY_MASK_IDX() to log.h Move SEVERITY_MASK_IDX() to log.h private/unit tests section, so that we can use it in log.c, the unit tests, and the fuzzers. (The t

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1356'

commit fc760c5088394741ac8c83706be6b737aef79beb Merge: 4673cb816 d30a042fa Author: George Kadianakis Date: Mon Sep 30 13:47:06 2019 +0300 Merge branch 'tor-github/pr/1356' changes/bug31334 | 4 src/lib/log/log.c | 4 src/lib/log/log.h | 6

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1339'

commit 4673cb8168cbacd817c38c3f1ca5c9e88d10b053 Merge: ffd857bbe fc1134e3e Author: George Kadianakis Date: Mon Sep 30 13:44:59 2019 +0300 Merge branch 'tor-github/pr/1339' Makefile.am| 2 +- changes/ticket31759| 5 + scripts/main

[tor-commits] [tor/master] annotate_ifdef_directives: Allow it to be imported as a module.

commit d229399e77f17a8ad19a793fcc7252027c0d3758 Author: Nick Mathewson Date: Thu Sep 26 15:36:20 2019 -0400 annotate_ifdef_directives: Allow it to be imported as a module. --- scripts/maint/annotate_ifdef_directives | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-

[tor-commits] [tor/master] annotate_ifdef_directives: test edge-case of 80-char line

commit fc1134e3e59df2ca473e787f70a57ebf659d78f2 Author: Nick Mathewson Date: Thu Sep 26 20:30:41 2019 -0400 annotate_ifdef_directives: test edge-case of 80-char line An 80-character line (79 characters if you don't count the newline) should not be truncated, and should not have

[tor-commits] [tor/master] Rename annotate_ifdef_directives to end with .py.

commit f1e0665c934db49cc86936a17a3a1247db9e3337 Author: Nick Mathewson Date: Thu Sep 26 15:43:40 2019 -0400 Rename annotate_ifdef_directives to end with .py. This allows the python doctest module to process it correctly when invoked as: python -m doctest -v annotate_ifde

[tor-commits] [tor/master] annotate_ifdef_directives: clarify situation with newlines

commit 21cc9d13f34d116b521c4415098ca1c9993bd198 Author: Nick Mathewson Date: Wed Sep 25 21:13:30 2019 -0400 annotate_ifdef_directives: clarify situation with newlines Our line limit is 80 characters, assuming that there is a single terminating newline character that counts towa

[tor-commits] [tor/master] Run "make autostyle" with new "annotate_ifdef_directives"

commit 194dbea24d1d05fa7b63b361b06054da4df011b9 Author: Nick Mathewson Date: Wed Sep 18 11:01:12 2019 -0400 Run "make autostyle" with new "annotate_ifdef_directives" --- src/app/config/config.c| 6 +++--- src/lib/crypt_ops/compat_openssl.h | 2 +- src/lib/fs/dir.c

[tor-commits] [tor/master] Annotate_ifdef_directives: doctest for 80-column lines.

commit 21c9f7c85e90f4d3ef539d41a36a24b2f26ad3d1 Author: Nick Mathewson Date: Thu Sep 26 19:57:41 2019 -0400 Annotate_ifdef_directives: doctest for 80-column lines. --- scripts/maint/annotate_ifdef_directives.py | 12 1 file changed, 12 insertions(+) diff --git a/scripts/maint

[tor-commits] [tor/master] Changes file for 31759 and 31779

commit 3283fd7e79913e25cd5e626d6bb3a12a05b2f3fc Author: Nick Mathewson Date: Wed Sep 18 11:06:54 2019 -0400 Changes file for 31759 and 31779 --- changes/ticket31759 | 5 + 1 file changed, 5 insertions(+) diff --git a/changes/ticket31759 b/changes/ticket31759 new file mode 100644 index

[tor-commits] [tor/master] annotate_ifdef_directives: introduce a function to make commented lines

commit f36e743e5de92cecee81a64d2e78ce5ca3070f98 Author: Nick Mathewson Date: Wed Sep 18 10:46:47 2019 -0400 annotate_ifdef_directives: introduce a function to make commented lines No functional change in this commit. --- scripts/maint/annotate_ifdef_directives | 15 ---

[tor-commits] [tor/master] annotate_ifdef_directives: remove some cases of double negation

commit 65e63e746120a03b54de51f1db148a7fa1aa27e2 Author: Nick Mathewson Date: Wed Sep 18 10:59:35 2019 -0400 annotate_ifdef_directives: remove some cases of double negation This change should reduce the number of cases where we say "/* !(!defined(foo)) */" . This only d

[tor-commits] [tor/master] annotate_ifdef_directives: generate paren-balanced expressions

commit 195aa2f5f73e0cd9462afd4f21f3f0dac36bbc82 Author: Nick Mathewson Date: Wed Sep 25 21:27:17 2019 -0400 annotate_ifdef_directives: generate paren-balanced expressions This algorithm is not fully general, but it strikes a balance between efficiency, simplicity, and correctne

[tor-commits] [tor/master] Use Doctests to test the behavior of annotate_ifdef_directives.

commit 6f0e697e4155ca567ddfd46a7f4e7c013287c42a Author: Nick Mathewson Date: Thu Sep 26 10:03:28 2019 -0400 Use Doctests to test the behavior of annotate_ifdef_directives. --- scripts/maint/annotate_ifdef_directives | 115 ++-- 1 file changed, 94 insertions(+),

[tor-commits] [tor/master] Add comments to annotate_ifdef_directives

commit 0b367f3386b0ec25f85716001690c95ae2e78c4d Author: Nick Mathewson Date: Wed Sep 18 10:41:05 2019 -0400 Add comments to annotate_ifdef_directives --- scripts/maint/annotate_ifdef_directives | 40 +++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff -

[tor-commits] [tor/master] annotate_ifdef_directives: obey an 80-column line-limit

commit 16890839d35e9ac270e32934a232b45de9e8544b Author: Nick Mathewson Date: Wed Sep 18 10:51:05 2019 -0400 annotate_ifdef_directives: obey an 80-column line-limit If we would add a comment making a line longer than 80 columns, instead truncate the variable portion of the comme

[tor-commits] [tor/master] Practracker: do not list problems when told to --list-overbroad.

commit 25d55fa01ebc8d9bc8cd52672605636a9261ddf5 Author: Nick Mathewson Date: Wed Sep 18 08:49:57 2019 -0400 Practracker: do not list problems when told to --list-overbroad. --- scripts/maint/practracker/practracker.py | 9 + scripts/maint/practracker/util.py| 7 +++ 2 f

[tor-commits] [tor/master] practracker: Integration test for --list-overbroad

commit 1c67d261d528767bc3a24f738dc316635f000f7e Author: Nick Mathewson Date: Wed Sep 18 08:53:17 2019 -0400 practracker: Integration test for --list-overbroad Make sure that we list overbroad exceptions, and nothing else --- Makefile.am

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1337'

commit 7157d80c6f0dc2bdcaf8993f5010f0e8d791c675 Merge: 01a797be4 82ad63ef4 Author: George Kadianakis Date: Wed Sep 25 14:19:49 2019 +0300 Merge branch 'tor-github/pr/1337' Makefile.am | 1 + changes/ticket31338

[tor-commits] [tor/master] practracker: An exception is "used" even when it is violated.

commit d1ffac3f8abbdd5b7d8e5955615821bff3ee3729 Author: Nick Mathewson Date: Wed Sep 18 08:52:01 2019 -0400 practracker: An exception is "used" even when it is violated. The purpose of tracking whether an exception is used is so that we can tell whether it is overbroad. This m

[tor-commits] [tor/master] changes file for 31338

commit 82ad63ef404c4634ea98352febe70296918df28d Author: Nick Mathewson Date: Wed Sep 18 08:56:47 2019 -0400 changes file for 31338 --- changes/ticket31338 | 4 1 file changed, 4 insertions(+) diff --git a/changes/ticket31338 b/changes/ticket31338 new file mode 100644 index 0.

[tor-commits] [tor/master] Correct a comment in channel_tls_process_cell.

commit 2d744de355d65c8f13c721558025bbfbfaa0758e Author: Nick Mathewson Date: Tue Sep 17 11:42:19 2019 -0400 Correct a comment in channel_tls_process_cell. --- src/core/or/channeltls.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/or/channeltls.c b/src/core/

[tor-commits] [tor/master] Move PROCESS_CELL macros outside of channel_tls_process_cell().

commit 7f5c6a603cafff9870f487bc03fa2874dcf00f8d Author: Nick Mathewson Date: Tue Sep 17 11:40:14 2019 -0400 Move PROCESS_CELL macros outside of channel_tls_process_cell(). These macros are used in multiple functions, and as such really don't belong within a single function.

[tor-commits] [tor/master] Merge branch 'bug31107_040' into bug31107_041

commit 6ee19e57c2a25060f6610e795731575aa776d903 Merge: 4596ead2f da8ba5010 Author: Nick Mathewson Date: Tue Sep 17 09:16:52 2019 -0400 Merge branch 'bug31107_040' into bug31107_041 changes/bug31107 | 4 src/core/or/channeltls.c | 10 +- 2 files changed, 13 insertions

[tor-commits] [tor/master] Merge branch 'bug31107_035' into bug31107_040

commit da8ba5010b59ac3d55563df420711f862faeb2f8 Merge: 896a1ac50 758999511 Author: Nick Mathewson Date: Tue Sep 17 09:16:52 2019 -0400 Merge branch 'bug31107_035' into bug31107_040 changes/bug31107 | 4 src/core/or/channeltls.c | 10 +- 2 files changed, 13 insertions

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1334'

commit 01a797be4ef4e55031f56307b4f8485bd6402c13 Merge: 0a77e5f1c 2d744de35 Author: George Kadianakis Date: Wed Sep 25 14:19:02 2019 +0300 Merge branch 'tor-github/pr/1334' changes/bug31107 | 4 src/core/or/channeltls.c | 35 +++ 2 files change

[tor-commits] [tor/master] Treat an unexpected constant-sized VERSIONS cell as a PROTOCOL_WARN.

commit 3c97ab3c24ba4a133377c7ec6ec89cc6903ffb2e Author: Nick Mathewson Date: Tue Sep 17 09:09:36 2019 -0400 Treat an unexpected constant-sized VERSIONS cell as a PROTOCOL_WARN. We previously used tor_fragile_assert() to declare that this case could not happen: VERSIONS cells ar

[tor-commits] [tor/master] Merge branch 'bug30916_035' into bug30916_041

commit 4bbefc2aac2d3770817200700e2a384d966bffe2 Merge: 70bcff601 2da4d64a6 Author: Nick Mathewson Date: Wed Sep 18 11:19:41 2019 -0400 Merge branch 'bug30916_035' into bug30916_041 changes/bug30916 | 4 src/feature/relay/router.c | 18 -- 2 files changed, 1

[tor-commits] [tor/master] Extract expressions in construct_ntor_key_map()

commit 1e9488f2fd829d48eb5ef6c2170e0f7163061136 Author: Nick Mathewson Date: Wed Sep 18 11:11:05 2019 -0400 Extract expressions in construct_ntor_key_map() No behavioral change here: this is just refactoring. --- src/feature/relay/router.c | 17 +++-- 1 file changed, 7

[tor-commits] [tor/master] Merge branch 'bug31107_041' into bug31107_master

commit 4d7ce27105dfb7f04ef14a59d098d2f81363298c Merge: b5f39955d 6ee19e57c Author: Nick Mathewson Date: Tue Sep 17 09:16:53 2019 -0400 Merge branch 'bug31107_041' into bug31107_master changes/bug31107 | 4 src/core/or/channeltls.c | 10 +- 2 files changed, 13 inserti

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1341'

commit 0a77e5f1c23d43d25a10436dcd30adb4596762fb Merge: 09769779a 4bbefc2aa Author: George Kadianakis Date: Wed Sep 25 14:18:15 2019 +0300 Merge branch 'tor-github/pr/1341' changes/bug30916 | 4 src/feature/relay/router.c | 18 -- 2 files changed, 12 inserti

[tor-commits] [tor/master] Avoid a crash if our "current" and "old" ntor onion keys are equal

commit 2da4d64a64a803f4b0a6d56e517b4288bef6c4f8 Author: Nick Mathewson Date: Wed Sep 18 11:14:45 2019 -0400 Avoid a crash if our "current" and "old" ntor onion keys are equal Our dimap code asserts if you try to add the same key twice; this can't happen if everything is running

[tor-commits] [tor/master] changes: file for 31839

commit 0c07cd24d43a19c02333eb5a031df80ef00c891a Author: teor Date: Tue Sep 24 15:22:57 2019 +1000 changes: file for 31839 --- changes/ticket31839 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changes/ticket31839 b/changes/ticket31839 new file mode 100644 index 0..d7da40f53

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1357'

commit 09769779a0b0d422b1cc4ec22ca8d95daba706ba Merge: 6677eae57 0c07cd24d Author: George Kadianakis Date: Wed Sep 25 14:17:35 2019 +0300 Merge branch 'tor-github/pr/1357' changes/ticket31839 | 3 +++ doc/tor.1.txt | 11 ++- src/lib/log/log.c | 10 +++--- 3 files chan

[tor-commits] [tor/master] log: Improve the documentation for tor_log_update_sigsafe_err_fds()

commit dfea789203a83a05176bd590a04d91c13da44ef6 Author: teor Date: Tue Sep 24 15:04:03 2019 +1000 log: Improve the documentation for tor_log_update_sigsafe_err_fds() Part of 31839. --- src/lib/log/log.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a

[tor-commits] [tor/master] doc: Document the signal-safe log behaviour in the tor man page

commit 102546f99f2efbc21f9e0860c66f2c3ae714352f Author: teor Date: Tue Sep 24 15:03:17 2019 +1000 doc: Document the signal-safe log behaviour in the tor man page Part of 31389. --- doc/tor.1.txt | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/to

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1355'

commit 6677eae57903eae05a31856e4d55da6fb51701b5 Merge: 6712fb9e2 22c33ea7f Author: George Kadianakis Date: Wed Sep 25 14:17:03 2019 +0300 Merge branch 'tor-github/pr/1355' scripts/maint/practracker/practracker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) _

[tor-commits] [tor/master] practracker: Fix a typo in the usage message

commit 22c33ea7f707e6b348b743277066b14bdb0f7f1b Author: teor Date: Tue Aug 6 00:20:49 2019 +1000 practracker: Fix a typo in the usage message Fixes bug 31828; bugfix on 0.4.2.1-alpha. --- scripts/maint/practracker/practracker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[tor-commits] [tor/master] configure: Explain --disable-module-dirauth better

commit c7c849bba82f9a47f404882348dd00f22492f310 Author: teor Date: Tue Sep 24 11:29:22 2019 +1000 configure: Explain --disable-module-dirauth better Explain what the optional Directory Authority module is, and what happens when it is disabled. Fixes bug 31825; bugfix o

[tor-commits] [tor/master] dirauth: reorder the checks in dirserv_router_has_valid_address()

commit 03c2b1be8d1e749b4f468cfe522da9e8375a83ad Author: teor Date: Thu Sep 19 15:27:39 2019 +1000 dirauth: reorder the checks in dirserv_router_has_valid_address() To avoid a bug warning. Fixes 31793. Bug not in any release, no changes file required. --- src/feature/dirau

[tor-commits] [tor/master] test: test dirserv_router_has_valid_address() with DirAllowPrivateAddresses

commit 69a1f9c8a7a9c8221029ce83f19d0e8d3e93f917 Author: teor Date: Thu Sep 19 16:17:17 2019 +1000 test: test dirserv_router_has_valid_address() with DirAllowPrivateAddresses Part of 31793. --- src/test/test_address.c | 38 +++--- 1 file changed, 31

[tor-commits] [tor/master] test: refactor dirserv_router_has_valid_address() tests

commit c2ceede37623935a63c05187d89ba7b6d86df7e8 Author: teor Date: Thu Sep 19 15:39:36 2019 +1000 test: refactor dirserv_router_has_valid_address() tests Cleanup after 31793. --- src/test/test_address.c | 39 ++- 1 file changed, 18 insertions(+)

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1353'

commit 6712fb9e270b51af67d72706b54dcaa749950de1 Merge: 219962964 c7c849bba Author: George Kadianakis Date: Wed Sep 25 14:16:28 2019 +0300 Merge branch 'tor-github/pr/1353' changes/bug31825 | 3 +++ configure.ac | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) _

[tor-commits] [tor/master] test: dirserv_router_has_valid_address() with zero-family addresses

commit 46fea1dfeeae1b575d427a9c3c6b4a8d1ab7f2b9 Author: teor Date: Thu Sep 19 15:24:01 2019 +1000 test: dirserv_router_has_valid_address() with zero-family addresses Sometimes tor doesn't initialise an address, so its family is zero. Failing test for 31793. Future commits

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1345'

commit 219962964812f75cff3ab8cede254e71ea48dd7b Merge: e77ad795c 69a1f9c8a Author: George Kadianakis Date: Wed Sep 25 14:14:30 2019 +0300 Merge branch 'tor-github/pr/1345' src/feature/dirauth/process_descs.c | 10 +++-- src/test/test_address.c | 89

[tor-commits] [tor/master] Merge branch 'tor-github/pr/1322'

commit e77ad795c68f28e8431dc5b098fba05fcec49c19 Merge: 99f75373d 387cfccee Author: George Kadianakis Date: Wed Sep 25 14:13:44 2019 +0300 Merge branch 'tor-github/pr/1322' changes/ticket30743 | 7 +++ scripts/coccinelle/debugmm.cocci | 29 + 2

<    2   3   4   5   6   7   8   9   10   11   >