[tor-commits] [tor/master] Use htonll() when INT_8 is used.

2017-08-08 Thread nickm
commit 1397ac11d69b9a48ef5f17485ac1fd5e3ada922e Author: George Kadianakis Date: Thu Aug 3 12:01:52 2017 +0300 Use htonll() when INT_8 is used. Also prepend period_length to any period_num, as specified by the spec. --- src/or/hs_common.c | 69

[tor-commits] [tor/master] Improve documentation all around the codebase.

2017-08-08 Thread nickm
commit 5ca9b830eacf46acde56469e5f19f977e5f02668 Author: George Kadianakis Date: Thu Aug 3 16:02:51 2017 +0300 Improve documentation all around the codebase. --- src/or/hs_cell.h | 17 +++-- src/or/hs_circuit.c| 18 +++---

[tor-commits] [tor/master] Validate intro point limits to avoid asserts.

2017-08-08 Thread nickm
commit 3bc52dae8932b42c809e2b233d5c194b74fa4f9b Author: George Kadianakis Date: Thu Aug 3 15:49:42 2017 +0300 Validate intro point limits to avoid asserts. --- src/or/hs_service.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff

[tor-commits] [tor/master] Improve setting hsdir index procedure.

2017-08-08 Thread nickm
commit d88984a137b9f06fd72f57636b6ec321044c8908 Author: George Kadianakis Date: Thu Aug 3 15:54:42 2017 +0300 Improve setting hsdir index procedure. - Fix memleak. --- src/or/nodelist.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff

[tor-commits] [tor/master] prop224: Don't use nodes as HSDirs if they don't have an HSDir index.

2017-08-08 Thread nickm
commit e42c55626abf7447a154f5271e3bc35743340a21 Author: George Kadianakis Date: Wed Aug 2 16:50:15 2017 +0300 prop224: Don't use nodes as HSDirs if they don't have an HSDir index. --- src/or/hs_common.c | 28 +++- src/or/nodelist.c | 6

[tor-commits] [tor/master] Fix small easy bugs all around

2017-08-08 Thread nickm
commit a561a10da726b426d326515ca7f75988b405bab7 Author: George Kadianakis Date: Thu Aug 3 16:04:25 2017 +0300 Fix small easy bugs all around - Fix log message format string. - Do extra circuit purpose check. - wipe memory in a clear function -

[tor-commits] [tor/master] prop224: Refactor the overlap function to not use absolute time.

2017-08-08 Thread nickm
commit 2e5a2d64bd4d26323a226d1069b960b28bd25440 Author: George Kadianakis Date: Tue Jul 18 16:06:12 2017 +0300 prop224: Refactor the overlap function to not use absolute time. We consider to be in overlap mode when we are in the period of time between a

[tor-commits] [tor/master] Improve code based on Nick review:

2017-08-08 Thread nickm
commit c62da5cf95de0958d28d2dfd8cdc66cf11498ebe Author: George Kadianakis Date: Fri Aug 4 22:02:28 2017 +0300 Improve code based on Nick review: - Fix some more crazy ternary ops. - Fix the order of disaster SRV computation. - Whitespace fixes. -

[tor-commits] [tor/master] Relax assertions: turn them to BUGs and non-fatal asserts.

2017-08-08 Thread nickm
commit 7c507a1f7f58adb48be887cd26686190c3b22cfd Author: George Kadianakis Date: Thu Aug 3 15:47:06 2017 +0300 Relax assertions: turn them to BUGs and non-fatal asserts. --- src/or/connection_edge.c | 4 +++- src/or/hs_service.c| 33

[tor-commits] [tor/master] Fix 32-bit bug when writing address to descriptor.

2017-08-08 Thread nickm
commit 29b3dd1c054e8dda464c046c701d6946f53434fa Author: George Kadianakis Date: Thu Aug 3 13:24:50 2017 +0300 Fix 32-bit bug when writing address to descriptor. We used to sizeof() a pointer. Let's just use asprintf to avoid having to be smart. ---

[tor-commits] [tor/master] prop224: HSDir v3 support is >= 0.3.0.8

2017-08-08 Thread nickm
commit 85c80adf4a75e1f44250379a4806796a26e861e3 Author: David Goulet Date: Fri Jul 14 16:37:13 2017 -0400 prop224: HSDir v3 support is >= 0.3.0.8 Because of bug #22447, we have to select nodes that are at least this version. Signed-off-by: David

[tor-commits] [tor/master] Constify functions that can be constified.

2017-08-08 Thread nickm
commit 2c6f2e9be9db6d3889a0756be93d7203888eaa72 Author: George Kadianakis Date: Thu Aug 3 16:03:30 2017 +0300 Constify functions that can be constified. --- src/or/hs_circuit.c | 4 ++-- src/or/hs_service.c | 6 +++--- src/or/hs_service.h | 4 ++-- 3 files changed, 7

[tor-commits] [tor/master] prop224 tests: test_gen_establish_intro_cell() check cell contents.

2017-08-08 Thread nickm
commit a464d49aeb66ad2daa6b753c34ceadfe0b391490 Author: George Kadianakis Date: Fri Aug 4 22:53:53 2017 +0300 prop224 tests: test_gen_establish_intro_cell() check cell contents. --- src/test/test_hs_cell.c | 16 +++- 1 file changed, 11 insertions(+), 5

[tor-commits] [tor/master] Fix a memory leak in consdiffmgr.c

2017-08-08 Thread nickm
commit 3af4aafbcb035271f84480ef745bad2b8c28a92b Author: Nick Mathewson Date: Tue Aug 8 09:12:09 2017 -0400 Fix a memory leak in consdiffmgr.c Fixes bug 23139; bugfix on 0.3.1.1-alpha. --- changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files

[tor-commits] [tor/master] Merge branch 'bug23139' into maint-0.3.1

2017-08-08 Thread nickm
commit a47b8fcf9295111339b80e5bc81c3de428241cad Merge: 5368eaf62 3af4aafbc Author: Nick Mathewson Date: Tue Aug 8 19:29:05 2017 -0400 Merge branch 'bug23139' into maint-0.3.1 changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files changed, 4 insertions(+)

[tor-commits] [tor/master] Merge branch 'maint-0.3.1'

2017-08-08 Thread nickm
commit b08a2dc95470d448b25e52b702701b432d056d17 Merge: 48a57f981 a47b8fcf9 Author: Nick Mathewson Date: Tue Aug 8 19:29:10 2017 -0400 Merge branch 'maint-0.3.1' changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files changed, 4 insertions(+)

[tor-commits] [tor/release-0.3.1] Merge branch 'maint-0.3.1' into release-0.3.1

2017-08-08 Thread nickm
commit 47e7a167d23c6ba1492a4006f6275e34c6a57b14 Merge: cbcff6759 a47b8fcf9 Author: Nick Mathewson Date: Tue Aug 8 19:29:10 2017 -0400 Merge branch 'maint-0.3.1' into release-0.3.1 changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files changed, 4

[tor-commits] [tor/release-0.3.1] Fix a memory leak in consdiffmgr.c

2017-08-08 Thread nickm
commit 3af4aafbcb035271f84480ef745bad2b8c28a92b Author: Nick Mathewson Date: Tue Aug 8 09:12:09 2017 -0400 Fix a memory leak in consdiffmgr.c Fixes bug 23139; bugfix on 0.3.1.1-alpha. --- changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files

[tor-commits] [tor/release-0.3.1] Merge branch 'bug23139' into maint-0.3.1

2017-08-08 Thread nickm
commit a47b8fcf9295111339b80e5bc81c3de428241cad Merge: 5368eaf62 3af4aafbc Author: Nick Mathewson Date: Tue Aug 8 19:29:05 2017 -0400 Merge branch 'bug23139' into maint-0.3.1 changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files changed, 4 insertions(+)

[tor-commits] [tor/maint-0.3.1] Merge branch 'bug23139' into maint-0.3.1

2017-08-08 Thread nickm
commit a47b8fcf9295111339b80e5bc81c3de428241cad Merge: 5368eaf62 3af4aafbc Author: Nick Mathewson Date: Tue Aug 8 19:29:05 2017 -0400 Merge branch 'bug23139' into maint-0.3.1 changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files changed, 4 insertions(+)

[tor-commits] [tor/maint-0.3.1] Fix a memory leak in consdiffmgr.c

2017-08-08 Thread nickm
commit 3af4aafbcb035271f84480ef745bad2b8c28a92b Author: Nick Mathewson Date: Tue Aug 8 09:12:09 2017 -0400 Fix a memory leak in consdiffmgr.c Fixes bug 23139; bugfix on 0.3.1.1-alpha. --- changes/bug23139 | 3 +++ src/or/consdiffmgr.c | 1 + 2 files

[tor-commits] [tor/master] prop224: Make circuit prediction aware of v3 services

2017-08-08 Thread nickm
commit 6c3d525c361adac1ad769f87a343fe3e9d2b050b Author: David Goulet Date: Tue Jul 11 11:18:23 2017 -0400 prop224: Make circuit prediction aware of v3 services Signed-off-by: David Goulet --- src/or/circuituse.c | 2 +-

[tor-commits] [tor/master] prop224: Use state file to save/load revision counters

2017-08-08 Thread nickm
commit 6f046b2191ed1a10e9058fcc49491b8db5a96280 Author: George Kadianakis Date: Fri Jul 21 15:53:17 2017 +0300 prop224: Use state file to save/load revision counters Signed-off-by: David Goulet --- src/or/hs_service.c | 209

[tor-commits] [tor/master] test: Add unit test coverage of hs_service.c

2017-08-08 Thread nickm
commit b547c5423930a430f70505a12d587735a7c83e1c Author: David Goulet Date: Fri May 5 14:55:26 2017 -0400 test: Add unit test coverage of hs_service.c Signed-off-by: David Goulet --- src/or/hs_common.c | 4 +-

[tor-commits] [tor/master] test: Unbreak test_upload_descriptors()

2017-08-08 Thread nickm
commit ec0da9a6f150c3e96a5aa777dea38105350a2b53 Author: George Kadianakis Date: Mon Jul 24 13:17:59 2017 +0300 test: Unbreak test_upload_descriptors() To upload the descriptor we needed a state file to write the rev counters in, but that test did not

[tor-commits] [tor/master] memwipe interesting unused memory

2017-08-08 Thread nickm
commit 74981d1f133f0ecb1050715af4ee5d409fcebd41 Author: George Kadianakis Date: Thu Aug 3 15:42:30 2017 +0300 memwipe interesting unused memory --- src/or/hs_cell.c | 15 +-- src/or/hs_common.c | 8 2 files changed, 17 insertions(+), 6

[tor-commits] [tor/master] hs: Rename num_rend_services()

2017-08-08 Thread nickm
commit 4a8cf17897ca23f8352a27c1bffb6ebfd68a1e0e Author: David Goulet Date: Mon Jul 10 11:31:51 2017 -0400 hs: Rename num_rend_services() Renamed to rend_num_services() so it is consistent with the legacy naming. Signed-off-by: David Goulet

[tor-commits] [tor/master] prop224: Remove INTRODUCE2 legacy handling

2017-08-08 Thread nickm
commit 708789025da9369f45ff18a6bcf743f005d9abff Author: David Goulet Date: Tue Aug 1 13:30:04 2017 -0400 prop224: Remove INTRODUCE2 legacy handling Turns out that introduction points don't care about the INTRODUCE2 cell format as long as the top field

[tor-commits] [tor/master] prop224: Add a circuit has closed callback

2017-08-08 Thread nickm
commit 15864a1b70c1061a89f97a2054b1c19788af7dbc Author: David Goulet Date: Thu May 25 10:28:00 2017 -0400 prop224: Add a circuit has closed callback When the circuit is about to be freed which has been marked close before, for introduction circuit we

[tor-commits] [tor/master] prop224: Add service rendezvous circuit relaunch

2017-08-08 Thread nickm
commit 713eb08bc9582b49e8073122fb68c3fac5bae188 Author: David Goulet Date: Tue May 30 16:11:59 2017 -0400 prop224: Add service rendezvous circuit relaunch This introduces a callback to relaunch a service rendezvous circuit when a previous one failed to

[tor-commits] [tor/master] prop224: Compute start time of next time period.

2017-08-08 Thread nickm
commit 2cd5f9a2fc2765539899b6e84ed4b1c9e02febad Author: George Kadianakis Date: Tue Jul 18 16:44:03 2017 +0300 prop224: Compute start time of next time period. --- src/or/hs_common.c| 16 + src/or/hs_common.h| 1 +

[tor-commits] [tor/master] prop224: Different intro point timings with TestingNetwork

2017-08-08 Thread nickm
commit 1b403a83821d86ac358e49ae24bd1284ed0dcfab Author: David Goulet Date: Fri May 26 14:20:00 2017 -0400 prop224: Different intro point timings with TestingNetwork Change the timing for intro point's lifetime and maximum amount of circuit we are

[tor-commits] [tor/master] prop224: Move get_intro_circuit() to hs_circuit.c

2017-08-08 Thread nickm
commit 2cae4f41006cd1885c33870232a040f98ffd6597 Author: David Goulet Date: Wed Jul 19 11:42:04 2017 -0400 prop224: Move get_intro_circuit() to hs_circuit.c Make this function public so we can use it both in hs_circuit.c and hs_service.c to avoid code

[tor-commits] [tor/master] prop224: Refactor hs_get_time_period_num() to not use absolute time.

2017-08-08 Thread nickm
commit cf58451a8ba03e869a805f973ef5b5f3f6d82b6b Author: George Kadianakis Date: Mon Jul 24 13:31:17 2017 +0300 prop224: Refactor hs_get_time_period_num() to not use absolute time. Instead use the SRV protocol duration to calculate the rotation offset that

[tor-commits] [tor/master] SR: Calculate current SRV phase/run duration.

2017-08-08 Thread nickm
commit 0b22b7fce3f1ce97a85f4022533b206f847b7307 Author: George Kadianakis Date: Mon Jul 24 13:30:04 2017 +0300 SR: Calculate current SRV phase/run duration. This is also needed to make the HS desc overlap mode function independent of absolute hours. ---

[tor-commits] [tor/master] SR: Compute the start time of the current protocol run.

2017-08-08 Thread nickm
commit 2af254096f68f0cefadb5cb06b010d19edd2e6e1 Author: George Kadianakis Date: Mon Jul 17 14:45:14 2017 +0300 SR: Compute the start time of the current protocol run. This function will be used to make the HS desc overlap function be independent of

[tor-commits] [tor/master] test: Add test_hs_ntor unit tests

2017-08-08 Thread nickm
commit 6061f5e2bd8272079e5b72e0d19aa2a6ca342e4e Author: David Goulet Date: Thu Apr 20 10:04:28 2017 -0400 test: Add test_hs_ntor unit tests Move the ntor test from test_hs_service.c to this file. Signed-off-by: David Goulet

[tor-commits] [tor/master] test: Unit tests for the revision counter state file codethe

2017-08-08 Thread nickm
commit b47139d7583ff247fcdd07904144dc99c412028a Author: George Kadianakis Date: Mon Jul 24 13:03:19 2017 +0300 test: Unit tests for the revision counter state file codethe Signed-off-by: David Goulet --- src/or/hs_service.c|

[tor-commits] [tor/master] Fix ternary operator abuse.

2017-08-08 Thread nickm
commit 434112df4bfd4f94e553d5a41579a70765949904 Author: George Kadianakis Date: Mon Jul 31 13:27:16 2017 +0300 Fix ternary operator abuse. --- src/or/hs_service.c | 38 +- 1 file changed, 25 insertions(+), 13 deletions(-) diff

[tor-commits] [tor/master] prop224: Make prop224 time periods smaller in testnets.

2017-08-08 Thread nickm
commit 6c00bd1f10f4683824deeaa7dd8a23aaf6b9a40e Author: George Kadianakis Date: Tue Jul 18 18:10:26 2017 +0300 prop224: Make prop224 time periods smaller in testnets. It used to be that time periods were 24 hours long even on chutney, which made testing

[tor-commits] [tor/master] Fix the build_hs_index() function.

2017-08-08 Thread nickm
commit 101ce6da01770ba0d05291ccafb98c4274cb616e Author: George Kadianakis Date: Mon Aug 7 18:58:13 2017 +0300 Fix the build_hs_index() function. Also add a unittest for hs_get_responsible_hsdirs() which was used to find and fix the bug. ---

[tor-commits] [tor/master] prop224: Improve comments and tests for ed25519 keys in IPs/RPs.

2017-08-08 Thread nickm
commit 8bac50d7559adba16e282d5c83b891a387a8a3d5 Author: George Kadianakis Date: Mon Aug 7 16:17:33 2017 +0300 prop224: Improve comments and tests for ed25519 keys in IPs/RPs. Also make sure we are not gonna advertise the ed25519 key of an intro point that

[tor-commits] [tor/master] Increase HS desc cert lifetime.

2017-08-08 Thread nickm
commit 827bd0e8827e10d1fe14c04b3d605b2278e3001e Author: George Kadianakis Date: Sun Aug 6 22:24:07 2017 +0300 Increase HS desc cert lifetime. We used to have a small HS desc cert lifetime but those certs can stick around for 36 hours if they get

[tor-commits] [tor/master] Start caching disaster SRV values.

2017-08-08 Thread nickm
commit ff249ee4a6ea665bb7ed1c7ab53d4d6b0eb9db78 Author: George Kadianakis Date: Tue Aug 8 11:45:45 2017 +0300 Start caching disaster SRV values. Also add some unittests. --- src/or/hs_common.c| 56 ++-

[tor-commits] [tor/master] prop224 tests: Better HS address tests.

2017-08-08 Thread nickm
commit e70341deb7dd8a8f50b872e9f7f999a113bb62b0 Author: George Kadianakis Date: Sat Aug 5 23:25:44 2017 +0300 prop224 tests: Better HS address tests. --- src/or/hs_service.c | 2 +- src/or/hs_service.h | 3 +++ src/test/test_hs_common.c | 25

[tor-commits] [tor/master] Extract intro point onion key even with multiple types.

2017-08-08 Thread nickm
commit 471489ca035a50733205f97c8d589d80c58e36e8 Author: George Kadianakis Date: Fri Aug 4 23:35:04 2017 +0300 Extract intro point onion key even with multiple types. --- src/or/hs_descriptor.c | 58 +++---

[tor-commits] [tor/master] Do more type checking when setting HS idents.

2017-08-08 Thread nickm
commit 0bf8587858b927d1dcb39189442f55d8dabe50aa Author: George Kadianakis Date: Sat Aug 5 00:33:34 2017 +0300 Do more type checking when setting HS idents. I repurposed the old directory_request_set_hs_ident() into a new

[tor-commits] [tor/master] Put comment in the trunnel file, so it wont go away.

2017-08-08 Thread nickm
commit 2f17743d6f7222cf96250890dd91d6689b2d55c6 Author: Nick Mathewson Date: Tue Aug 8 20:31:47 2017 -0400 Put comment in the trunnel file, so it wont go away. --- src/trunnel/ed25519_cert.trunnel | 6 ++ 1 file changed, 6 insertions(+) diff --git

[tor-commits] [tor/master] Improve docs on rendezvous circ relaunch.

2017-08-08 Thread nickm
commit 273638288d4e6516011c4d538e5c1447f4753958 Author: George Kadianakis Date: Mon Aug 7 12:02:45 2017 +0300 Improve docs on rendezvous circ relaunch. --- src/or/hs_circuit.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[tor-commits] [tor/master] Add note about handling INTRODUCE2 cells.

2017-08-08 Thread nickm
commit 0a0bbfe96fe425f27641f86fabd19f65a551ac6c Author: George Kadianakis Date: Tue Aug 8 11:51:16 2017 +0300 Add note about handling INTRODUCE2 cells. Also fix a check-spaces instance. --- src/or/hs_cell.c | 5 + src/test/test_hs_service.c | 3

[tor-commits] [tor/master] Merge branch 'ticket20657_nickm_bugfixes_squashed'

2017-08-08 Thread nickm
commit 34e4122025791d1a607426e5e543d6312872b9dd Merge: 649104fdb 2f17743d6 Author: Nick Mathewson Date: Tue Aug 8 20:31:57 2017 -0400 Merge branch 'ticket20657_nickm_bugfixes_squashed' src/ext/ed25519/donna/ed25519_tor.c|8 +-

[tor-commits] [translation/https_everywhere] Update translations for https_everywhere

2017-08-08 Thread translation
commit 8bb79623189b0ba58f9ffca6c62587f9e081a3ce Author: Translation commit bot Date: Tue Aug 8 23:15:33 2017 + Update translations for https_everywhere --- da/https-everywhere.dtd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[tor-commits] [translation/https_everywhere_completed] Update translations for https_everywhere_completed

2017-08-08 Thread translation
commit 503cda834ce6dbcaf0012a60ac46061af5134e35 Author: Translation commit bot Date: Tue Aug 8 23:15:42 2017 + Update translations for https_everywhere_completed --- da/https-everywhere.dtd | 13 + 1 file changed, 13 insertions(+) diff --git

[tor-commits] [tor/master] prop224: Link rendezvous circuit to edge connection

2017-08-08 Thread nickm
commit 30b5c6a95ec9932f17f0b171c60229c1d77f829d Author: David Goulet Date: Wed May 10 15:04:40 2017 -0400 prop224: Link rendezvous circuit to edge connection This commit refactors the handle_hs_exit_conn() function introduced at a prior commit that

[tor-commits] [tor/master] prop224: Directory function to upload descriptor

2017-08-08 Thread nickm
commit bce0c6caadaf27b857f6980f1453798909625267 Author: David Goulet Date: Wed Apr 19 14:36:53 2017 -0400 prop224: Directory function to upload descriptor This commit adds a directory command function to make an upload directory request for a service

[tor-commits] [tor/master] prop224: Implement a service intro point failure cache

2017-08-08 Thread nickm
commit feed375f194d389dbc4c624e09bdd9161931e23a Author: David Goulet Date: Tue May 9 14:31:17 2017 -0400 prop224: Implement a service intro point failure cache Imagine a Tor network where you have only 8 nodes available due to some reasons. And your

[tor-commits] [tor/master] prop224: Sandbox support for service

2017-08-08 Thread nickm
commit 5d2506d70cdc73d840e0222d0f007365ae44fac0 Author: David Goulet Date: Wed May 10 11:04:06 2017 -0400 prop224: Sandbox support for service Signed-off-by: David Goulet --- src/or/hs_cache.c | 6 -- src/or/hs_service.c |

[tor-commits] [tor/master] test: Add test_hs_cell unit tests

2017-08-08 Thread nickm
commit 472835d6e94134d7e30e390c4e294bd3a3af5eaa Author: David Goulet Date: Thu Apr 20 09:58:21 2017 -0400 test: Add test_hs_cell unit tests Move ESTABLISH_INTRO tests from test_hs_service.c to this new file. Signed-off-by: David Goulet

[tor-commits] [tor/master] prop224: Make intro point min/max lifetime a consensus param

2017-08-08 Thread nickm
commit f0e02e3a141150f02bafaab35d6ab48c79d78d6d Author: David Goulet Date: Tue May 9 16:10:14 2017 -0400 prop224: Make intro point min/max lifetime a consensus param Signed-off-by: David Goulet --- src/or/hs_service.c | 29

[tor-commits] [tor/master] prop224: Handle service INTRODUCE2 cell

2017-08-08 Thread nickm
commit 5e710368b3e9a19862422d4bd43f2c1d8d0ceba8 Author: David Goulet Date: Tue Mar 7 14:57:14 2017 -0500 prop224: Handle service INTRODUCE2 cell At this commit, launching rendezvous circuit is not implemented, only a placeholder. Signed-off-by:

[tor-commits] [tor/master] hs: Refactor the service exit connection code

2017-08-08 Thread nickm
commit 7163ce7f62d6c487193fe43828420ba4fe721b9f Author: David Goulet Date: Wed May 10 13:43:37 2017 -0400 hs: Refactor the service exit connection code This commit simply moves the code from the if condition of a rendezvous circuit to a function to

[tor-commits] [tor/master] prop224: Add a responsible HSDir function

2017-08-08 Thread nickm
commit 0bcc9ad58d18bdd9fb73db33b9a7fe4cfd2ac93b Author: David Goulet Date: Wed Apr 19 12:23:43 2017 -0400 prop224: Add a responsible HSDir function Signed-off-by: David Goulet --- src/or/hs_common.c | 152

[tor-commits] [tor/master] test: Refactor HS tests to use the new ESTABLISH_INTRO cell code

2017-08-08 Thread nickm
commit 559ffd71798765970205d0559c9f5a06dc55cf37 Author: David Goulet Date: Fri Apr 28 13:41:34 2017 -0400 test: Refactor HS tests to use the new ESTABLISH_INTRO cell code Signed-off-by: David Goulet --- src/or/hs_service.c

[tor-commits] [tor/master] test: Add test_hs_common unit tests

2017-08-08 Thread nickm
commit 8ffb49422bffd911dbe0b4aea5a59ad589d785c1 Author: David Goulet Date: Thu Apr 20 11:20:02 2017 -0400 test: Add test_hs_common unit tests Move tests from test_hs_service.c to this file. Signed-off-by: David Goulet ---

[tor-commits] [tor/master] test: Fix prop224 HS descriptor to use subcredential

2017-08-08 Thread nickm
commit a6b6227b2141f8d9d36f8555253ec4d56f423b04 Author: George Kadianakis Date: Thu Jun 1 15:11:03 2017 +0300 test: Fix prop224 HS descriptor to use subcredential We used to use NULL subcredential which is a terrible terrible idea. Refactor HS unittests

[tor-commits] [tor/master] prop224: Upload service descriptors

2017-08-08 Thread nickm
commit ac848777f9db588c54ce3eb950d41375dc324074 Author: David Goulet Date: Wed Apr 19 15:27:11 2017 -0400 prop224: Upload service descriptors Signed-off-by: David Goulet --- src/or/hs_service.c | 326

[tor-commits] [tor/master] prop224: Support INTRODUCE2 cell replay cache

2017-08-08 Thread nickm
commit 27dd1a716c63bcdda31f24ed08d259b4a91aa1c3 Author: David Goulet Date: Thu Apr 6 14:37:24 2017 -0400 prop224: Support INTRODUCE2 cell replay cache Signed-off-by: David Goulet --- src/or/hs_cell.c| 13 +++--

[tor-commits] [tor/master] prop224: Make INTRODUCE2 min/max a consensus param

2017-08-08 Thread nickm
commit 670cecaf669d87bd3bdb52ef1848cf6d73725746 Author: David Goulet Date: Tue May 9 16:05:28 2017 -0400 prop224: Make INTRODUCE2 min/max a consensus param Introduction point are rotated either if we get X amounts of INTRODUCE2 cells on it or a time

[tor-commits] [tor/master] prop224: Make the number of extra intro point a consensus param

2017-08-08 Thread nickm
commit 848e701f55039b43e90cb1dae226db567876f2d3 Author: David Goulet Date: Tue May 9 16:15:12 2017 -0400 prop224: Make the number of extra intro point a consensus param Signed-off-by: David Goulet --- src/or/hs_service.c | 23

[tor-commits] [tor/master] prop224: Handle service RENDEZVOUS1 cell

2017-08-08 Thread nickm
commit dfa6301aed8f1c7164b1e8513ab64119944d976c Author: David Goulet Date: Thu Mar 9 12:54:51 2017 -0500 prop224: Handle service RENDEZVOUS1 cell Signed-off-by: David Goulet --- src/or/hs_cell.c| 35

[tor-commits] [tor/master] prop224: Introduction circuit creation

2017-08-08 Thread nickm
commit 6a21ac7f9809963287dd678c9f2c494b3f9ebba3 Author: David Goulet Date: Thu Feb 16 15:55:12 2017 -0500 prop224: Introduction circuit creation Signed-off-by: David Goulet --- src/or/circuitlist.c | 1 + src/or/hs_circuit.c |

[tor-commits] [tor/master] prop224: Implement subcredential creation

2017-08-08 Thread nickm
commit c4ba4d4cc8a1d31f78d1dc54c7851bed32a25e5c Author: David Goulet Date: Thu May 11 10:16:28 2017 -0400 prop224: Implement subcredential creation Signed-off-by: David Goulet --- src/or/hs_common.c | 37

[tor-commits] [tor/master] prop224: Scheduled events for service

2017-08-08 Thread nickm
commit 0f104ddce578c52d604931c595b28aa61a184b40 Author: David Goulet Date: Fri Feb 3 15:29:31 2017 -0500 prop224: Scheduled events for service Add the main loop entry point to the HS service subsystem. It is run every second and make sure that all

[tor-commits] [tor/master] prop224: Add descriptor overlap mode function

2017-08-08 Thread nickm
commit f53b72baf7472423f662b49bebde1a88727901fb Author: George Kadianakis Date: Mon Feb 13 15:32:13 2017 +0200 prop224: Add descriptor overlap mode function The function has been added but not used except for the unit tests. Signed-off-by: David

[tor-commits] [tor/master] prop224: Handle service INTRO_ESTABLISHED cell

2017-08-08 Thread nickm
commit 79e8d113d5ebfbc5ccf76f5db7bc0259a29520fc Author: David Goulet Date: Tue Mar 7 14:33:03 2017 -0500 prop224: Handle service INTRO_ESTABLISHED cell Signed-off-by: David Goulet --- src/or/hs_cell.c| 22

[tor-commits] [tor/master] prop224: Add the introduction point onion key to descriptor

2017-08-08 Thread nickm
commit 78e2bc4000a9014c1762f828e15e762c359aa20e Author: David Goulet Date: Wed Jul 19 13:42:35 2017 -0400 prop224: Add the introduction point onion key to descriptor A prop224 descriptor was missing the onion key for an introduction point which is

[tor-commits] [tor/master] prop224: Establish rendezvous circuit for service

2017-08-08 Thread nickm
commit acc7c4ee9578e37a66dff6a09c86bee5777f782d Author: David Goulet Date: Wed Mar 8 17:31:36 2017 -0500 prop224: Establish rendezvous circuit for service Signed-off-by: David Goulet --- src/or/hs_cell.c | 5 +-

[tor-commits] [tor/master] prop224: Build hsdir index for node_t

2017-08-08 Thread nickm
commit 267bc7bc3b574f3e60d7836fde5a24652e3ac9c2 Author: David Goulet Date: Tue Apr 18 15:06:44 2017 -0400 prop224: Build hsdir index for node_t This hsdir index value is used to give an index value to all node_t (relays) that supports HSDir v3. An index

[tor-commits] [tor/master] prop224: Support legacy INTRODUCE2 cell

2017-08-08 Thread nickm
commit 100386e659533cfa92c5bfff93a15fb3535f7970 Author: David Goulet Date: Wed Apr 5 12:26:02 2017 -0400 prop224: Support legacy INTRODUCE2 cell Also rename some function to follow a bit more the naming convention in that file. Signed-off-by:

[tor-commits] [tor/master] prop224: Add helper function to lookup HS objects

2017-08-08 Thread nickm
commit faadbafba37932455ee60e02053e2e1300b63f33 Author: David Goulet Date: Wed Mar 8 12:08:03 2017 -0500 prop224: Add helper function to lookup HS objects Add this helper function that can lookup and return all the needed object from a circuit

[tor-commits] [tor/master] prop224: Update hs identifier circuit

2017-08-08 Thread nickm
commit 2b9575a9c0ecf6e3880654be16d103326788cecf Author: David Goulet Date: Mon Jul 24 13:45:01 2017 -0400 prop224: Update hs identifier circuit Remove the legacy intro point key because both service and client only uses the ed25519 key even though the

[tor-commits] [tor/master] prop224: Add service replay cache

2017-08-08 Thread nickm
commit 77b279c35c5ecf83c045f9c1d613544d958aef81 Author: David Goulet Date: Thu Apr 6 14:58:13 2017 -0400 prop224: Add service replay cache Signed-off-by: David Goulet --- src/or/hs_circuit.c | 17 +

[tor-commits] [tor/master] prop224: Add hsdir consensus parameters

2017-08-08 Thread nickm
commit 06909cafef6aee9141541fc85cbea5de0b2e5f6a Author: David Goulet Date: Wed Apr 19 11:06:19 2017 -0400 prop224: Add hsdir consensus parameters Signed-off-by: David Goulet --- src/or/hs_common.c | 30

[tor-commits] [tor/master] Make ed25519 id keys optional for IPs and RPs.

2017-08-08 Thread nickm
commit f106af3c41dffdc8576c52399a61d34116b78f38 Author: George Kadianakis Date: Thu Aug 3 16:00:18 2017 +0300 Make ed25519 id keys optional for IPs and RPs. --- src/or/hs_circuit.c| 6 -- src/or/hs_descriptor.c | 8 src/or/hs_service.c

[tor-commits] [tor/master] prop224 tests: Improve SRV protocol tests.

2017-08-08 Thread nickm
commit 4a1b57e9b00c8474ada28dd052a2de73a1e9c641 Author: George Kadianakis Date: Sat Aug 5 23:11:37 2017 +0300 prop224 tests: Improve SRV protocol tests. --- src/or/shared_random_state.c | 2 +- src/or/shared_random_state.h | 1 + src/test/test_shared_random.c |

[tor-commits] [tor/master] Don't double hash the ed25519 blind key parameter.

2017-08-08 Thread nickm
commit 4ad4467fa13a0e6333fa0016a63060d5b9dd9715 Author: George Kadianakis Date: Fri Aug 4 12:37:48 2017 +0300 Don't double hash the ed25519 blind key parameter. We used to do: h = H(BLIND_STRING | H(A | s | B | N ) when we should be doing: h

[tor-commits] [tor/master] prop224: Function to inc/decrement num rendezvous stream

2017-08-08 Thread nickm
commit 5c4f4acedb8600769889cdff0940806c27b679bd Author: George Kadianakis Date: Mon Jul 31 17:59:12 2017 +0300 prop224: Function to inc/decrement num rendezvous stream Add a common function for both legacy and prop224 hidden service to increment and

[tor-commits] [tor/master] prop224: Always note down the use of internal circuit

2017-08-08 Thread nickm
commit 400ba2f636edf5afb14fe3b57f23d80e433d893d Author: David Goulet Date: Fri Aug 4 12:06:34 2017 -0400 prop224: Always note down the use of internal circuit Also, this removes all the callsite of this rephist in the hs subsystem Fixes #23097

[tor-commits] [tor/master] Don't set HSDir index if we don't have a live consensus.

2017-08-08 Thread nickm
commit b89d2fa1db2379bffd2e2b4c851c3facc57b6ed8 Author: George Kadianakis Date: Fri Aug 4 12:21:14 2017 +0300 Don't set HSDir index if we don't have a live consensus. We also had to alter the SRV functions to take a consensus as optional input, since we

[tor-commits] [tor/master] Make HidServRevCounter be a LINELIST as it should.

2017-08-08 Thread nickm
commit 706392e6b5967c8a7766a6b68b2428a17c1bbe8f Author: George Kadianakis Date: Thu Aug 3 15:52:01 2017 +0300 Make HidServRevCounter be a LINELIST as it should. --- src/or/hs_service.c | 8 src/or/or.h | 2 +- src/or/statefile.c | 3 +-- 3 files

[tor-commits] [tor/master] Re-run trunnel.

2017-08-08 Thread nickm
commit 8e84968ffbf6d284e8a877ddcde6ded40b3f5681 Author: Nick Mathewson Date: Tue Aug 8 20:34:39 2017 -0400 Re-run trunnel. --- src/trunnel/channelpadding_negotiation.c | 10 +- src/trunnel/channelpadding_negotiation.h | 10 +-

[tor-commits] [tor/master] prop224: Add XXX about opaqueness of link_specifier_t.

2017-08-08 Thread nickm
commit 686891d67ebf69808ac3d2b2c98263d21a3fe143 Author: George Kadianakis Date: Tue Aug 8 21:25:04 2017 +0300 prop224: Add XXX about opaqueness of link_specifier_t. --- src/trunnel/ed25519_cert.h | 4 1 file changed, 4 insertions(+) diff --git

[tor-commits] [tor/master] Rename some free() functions that are actually clear().

2017-08-08 Thread nickm
commit 3ce69a58ce908ea88443c1321a7e4378f059a897 Author: George Kadianakis Date: Thu Aug 3 15:51:24 2017 +0300 Rename some free() functions that are actually clear(). --- src/or/hs_descriptor.c | 2 +- src/or/hs_descriptor.h | 2 +- src/or/hs_intropoint.c | 5 +++--

[tor-commits] [tor/master] Correctly assign HSDir flags based on protocol list

2017-08-08 Thread nickm
commit 440eaa9b22573cdb0d38bf5c13200cc1077a453f Author: George Kadianakis Date: Thu Aug 3 16:08:17 2017 +0300 Correctly assign HSDir flags based on protocol list In Nick's words: "We want to always return false if the platform is a Tor version, and

[tor-commits] [tor/master] Fix broken intro point unittest.

2017-08-08 Thread nickm
commit fe0c40c9b344853963dc7af0f746d8c772bb3a97 Author: George Kadianakis Date: Fri Aug 4 23:46:20 2017 +0300 Fix broken intro point unittest. The structure was not zeroed out, and left some boolean fields uninitialized. --- src/test/test_hs_service.c |

[tor-commits] [tor/master] prop224 tests: Better HS time period tests.

2017-08-08 Thread nickm
commit bd3213b17e6ff94bfd1c5deb3ecf2d906dd8d0b6 Author: George Kadianakis Date: Sat Aug 5 23:43:05 2017 +0300 prop224 tests: Better HS time period tests. --- src/test/test_hs_common.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-)

[tor-commits] [tor/master] Remove a needless memwipe.

2017-08-08 Thread nickm
commit 649104fdb950057288a5e7b48f402d563546b83b Author: Nick Mathewson Date: Tue Aug 8 19:58:19 2017 -0400 Remove a needless memwipe. The interior of ctx here is already wiped by crypto_digest_free(). This memwipe call only wiped the pointer itself,

[tor-commits] [tor/master] prop224: Circuit has opened and ESTABLISH_INTRO cell

2017-08-08 Thread nickm
commit d765cf30b51dfcd58756b6b3d24a14ac2c47f3e8 Author: David Goulet Date: Tue Feb 21 14:20:39 2017 -0500 prop224: Circuit has opened and ESTABLISH_INTRO cell Add the entry point from the circuit subsystem of "circuit has opened" which is for all type

[tor-commits] [tor/master] prop224: Helper to dup a link_specifier_t object

2017-08-08 Thread nickm
commit b8ceab9bb33a8096f14a671399ce34db439f63e2 Author: David Goulet Date: Sun Jul 23 10:43:16 2017 -0400 prop224: Helper to dup a link_specifier_t object Signed-off-by: David Goulet --- src/or/hs_common.c | 18 ++

[tor-commits] [tor/master] prop224: Service v3 descriptor creation and logic

2017-08-08 Thread nickm
commit 00a02a3a59f6e44619e6caed150b001acae37231 Author: David Goulet Date: Fri Feb 3 15:30:46 2017 -0500 prop224: Service v3 descriptor creation and logic This commit adds the functionality for a service to build its descriptor. Also, a global call to

  1   2   >