[tor-commits] [tor/master] Merge remote-tracking branch 'dgoulet/bug23319_032_01'

2017-08-24 Thread nickm
commit f9cd870f50d770f629e370583b0e9df2f8844436 Merge: cbfc50d48 dfaa5c65f Author: Nick Mathewson Date: Thu Aug 24 16:23:57 2017 -0400 Merge remote-tracking branch 'dgoulet/bug23319_032_01' src/or/hs_descriptor.c| 2 +- src/or/hs_descriptor.h| 2 ++

[tor-commits] [tor/master] test: Fix memory leak in hs_descriptor/decode_bad_signature

2017-08-24 Thread nickm
commit dfaa5c65f9fbfde9a12d8eb3ed848cab6ed1a5f9 Author: David Goulet Date: Thu Aug 24 16:21:44 2017 -0400 test: Fix memory leak in hs_descriptor/decode_bad_signature Fixes #23319 Signed-off-by: David Goulet ---

[tor-commits] [tor/master] add another invizbox maintainer to ReleasingTor.md

2017-08-24 Thread nickm
commit cbfc50d485c65a5e4711f64d3a4cf395030246c9 Author: Nick Mathewson Date: Thu Aug 24 16:20:26 2017 -0400 add another invizbox maintainer to ReleasingTor.md --- doc/HACKING/ReleasingTor.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[tor-commits] [tor/master] Re-run trunnel. Cosmetic changes only.

2017-08-24 Thread nickm
commit a007c02df0140d15697cf0ca61cea90bfc494789 Author: Nick Mathewson Date: Thu Aug 24 16:13:01 2017 -0400 Re-run trunnel. Cosmetic changes only. --- src/ext/trunnel/trunnel-impl.h | 2 +- src/ext/trunnel/trunnel.c| 2 +-

[tor-commits] [tor/master] Ensure that `make check-spaces` is happy.

2017-08-24 Thread nickm
commit 77b92c2214325e2e26a06b1e61158a88a15bc227 Author: Alexander Færøy Date: Mon Jun 5 14:38:20 2017 + Ensure that `make check-spaces` is happy. The `test-operator-cleanup` patch, and related coccinelle patches, don't do any checks for line length.

[tor-commits] [tor/master] Apply ahf's ceil_div.cocci patch.

2017-08-24 Thread nickm
commit 067a4422fec371e1ef3a1b8d13d5da9a1e90c70b Author: Nick Mathewson Date: Thu Aug 24 15:33:27 2017 -0400 Apply ahf's ceil_div.cocci patch. --- src/or/rephist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/or/rephist.c b/src/or/rephist.c

[tor-commits] [tor/master] Fix a needless line-continuation in aes.c

2017-08-24 Thread nickm
commit e884248118e946c56fb8b70c2d5189946f3af95a Author: Nick Mathewson Date: Thu Aug 24 15:32:30 2017 -0400 Fix a needless line-continuation in aes.c coccinelle was getting confused --- src/common/aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[tor-commits] [tor/master] Changes file for 22497

2017-08-24 Thread nickm
commit e7c1a6f4f7a1854a780f7f006f2346db2e378e8f Author: Nick Mathewson Date: Thu Aug 24 16:11:08 2017 -0400 Changes file for 22497 --- changes/bug22497 | 4 1 file changed, 4 insertions(+) diff --git a/changes/bug22497 b/changes/bug22497 new file mode 100644

[tor-commits] [tor/master] Merge branch 'ahf_bug22497_redux'

2017-08-24 Thread nickm
commit da75dfc0e52ea1dee89396a2d7bfb0a0339358db Merge: 91c6bc160 e7c1a6f4f Author: Nick Mathewson Date: Thu Aug 24 16:11:43 2017 -0400 Merge branch 'ahf_bug22497_redux' changes/bug22497 | 4 + scripts/coccinelle/ceil_div.cocci |

[tor-commits] [tor/master] Add Coccinelle patch for replacing tt_assert() usage on integer types.

2017-08-24 Thread nickm
commit 7666cd88817422da17f6ef725122ce0b230c1d24 Author: Alexander Færøy Date: Mon Jun 5 15:22:11 2017 + Add Coccinelle patch for replacing tt_assert() usage on integer types. This patch replaces tt_assert() comparison of integers and unsigned

[tor-commits] [tor/master] Apply test-operator-cleanup to src/common too.

2017-08-24 Thread nickm
commit 1d0f7b7ccd547f1e4f381cf4a8a461ff669b73e2 Author: Nick Mathewson Date: Thu Aug 24 15:26:57 2017 -0400 Apply test-operator-cleanup to src/common too. --- src/common/compat_time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[tor-commits] [tor/master] Add Coccinelle patch for detecing places where CEIL_DIV should be used.

2017-08-24 Thread nickm
commit 25eaf77033cd4cc6a5241554be8951a022dd54bd Author: Alexander Færøy Date: Mon Jun 5 14:45:53 2017 + Add Coccinelle patch for detecing places where CEIL_DIV should be used. --- scripts/coccinelle/ceil_div.cocci | 6 ++ 1 file changed, 6 insertions(+)

[tor-commits] [tor/master] Add Coccinelle patch for replacing tt_assert(0) with tt_abort().

2017-08-24 Thread nickm
commit 3fd68b249b1472097c3d1466d28b926dbd380657 Author: Alexander Færøy Date: Mon Jun 5 15:19:46 2017 + Add Coccinelle patch for replacing tt_assert(0) with tt_abort(). --- scripts/coccinelle/test_assert_zero.cocci | 5 + 1 file changed, 5 insertions(+)

[tor-commits] [tor/master] Add Coccinelle patch for replacing NULL/non-NULL tt_assert().

2017-08-24 Thread nickm
commit 9e1fa959201611b764ac90ce59485d33b8ea975b Author: Alexander Færøy Date: Mon Jun 5 15:54:21 2017 + Add Coccinelle patch for replacing NULL/non-NULL tt_assert(). This patch replaces tt_assert() checks for NULL/non-NULL values with tt_ptr_op().

[tor-commits] [tor/master] apply ahf's test_assert_zero.cocci

2017-08-24 Thread nickm
commit 0b36208fd88e284592bb78d5b7c41226d6576e00 Author: Nick Mathewson Date: Thu Aug 24 15:34:34 2017 -0400 apply ahf's test_assert_zero.cocci --- src/test/test_config.c | 12 ++-- src/test/test_dir.c| 8 src/test/test_dir_common.c | 2

[tor-commits] [tor/master] Add script for cleaning op operator usage in test files.

2017-08-24 Thread nickm
commit 7c3e980fb939aa93e9ea950a3ed96b53bb525adb Author: Alexander Færøy Date: Mon Jun 5 14:20:39 2017 + Add script for cleaning op operator usage in test files. This patch adds a script written by Nick for bug #13172 to clean up the usage of ==, !=,

[tor-commits] [tor-messenger-build/master] Update build dependencies in README.md

2017-08-24 Thread sukhbir
commit e7150d2abc89fe0b331985577c8a59ba882878f6 Author: Sukhbir Singh Date: Thu Aug 24 15:33:59 2017 -0400 Update build dependencies in README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index

[tor-commits] [tor/master] Merge remote-tracking branch 'dgoulet/ticket17242_032_03-squashed'

2017-08-24 Thread nickm
commit 91c6bc160b1d2be60e5756f13d28ba469049351c Merge: b5c5086ab dc0264f65 Author: Nick Mathewson Date: Thu Aug 24 15:12:16 2017 -0400 Merge remote-tracking branch 'dgoulet/ticket17242_032_03-squashed' src/or/circuitlist.c |7 +-

[tor-commits] [tor/master] prop224: Try to recover from a bad intro circuit

2017-08-24 Thread nickm
commit 954f663831622f281ece83519552f91cd0fdda72 Author: David Goulet Date: Wed Aug 23 11:15:25 2017 -0400 prop224: Try to recover from a bad intro circuit Changed the assert_intro_circ_ok() to an almost non fatal function so tor can recover properly.

[tor-commits] [tor/master] Silence some spammy log messages.

2017-08-24 Thread nickm
commit dc0264f6593116da413dc5ca6c424dcff36fbbd2 Author: George Kadianakis Date: Thu Aug 24 19:09:25 2017 +0300 Silence some spammy log messages. --- src/or/hs_service.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/or/hs_service.c

[tor-commits] [tor/master] prop224: Rename hs_desc_encode_lspec()

2017-08-24 Thread nickm
commit cb462b95b7e864b71ea3dc0a6bfb76c30fb8d378 Author: David Goulet Date: Tue Aug 22 14:12:49 2017 -0400 prop224: Rename hs_desc_encode_lspec() Give it a name that shows the transition from a descriptor link spec to a trunnel link spec.

[tor-commits] [tor/master] prop224: Add a function to clear INTRO data

2017-08-24 Thread nickm
commit 7c543412fc4c77a58fb928c6eb322e48fae97137 Author: David Goulet Date: Tue Aug 22 14:37:33 2017 -0400 prop224: Add a function to clear INTRO data New function named hs_cell_introduce1_data_clear() is introduced to clear off an

[tor-commits] [tor/master] hs: Remove unused rend_client_rendezvous_acked()

2017-08-24 Thread nickm
commit 98efb646fc2caac850684f35e2ff6fd9eeab1450 Author: David Goulet Date: Tue Aug 22 15:03:19 2017 -0400 hs: Remove unused rend_client_rendezvous_acked() This function has been replaced by hs_client_receive_rendezvous_acked(() doing the same exact

[tor-commits] [tor/master] prop224: Register RP circuit when it opens

2017-08-24 Thread nickm
commit dca105d58853c7ba6f8ef594cca34230dbb87394 Author: David Goulet Date: Thu Aug 24 08:49:24 2017 -0400 prop224: Register RP circuit when it opens Only register the RP circuit when it opens and not when we send the INTRODUCE1 cell else, when

[tor-commits] [tor/master] circuit: Consider v3 hidden service circuit in circuit_expire_building()

2017-08-24 Thread nickm
commit e546ac6b32d5478f50644ca8f1eac0a66513fe8d Author: David Goulet Date: Thu Aug 24 09:31:30 2017 -0400 circuit: Consider v3 hidden service circuit in circuit_expire_building() For a ready v3 rendezvous circuit, consider it so we don't expire.

[tor-commits] [tor/master] hs: Update intro circuit timestamp when re-extending

2017-08-24 Thread nickm
commit a1125625449617ef427d8816f6e0174806e2d947 Author: David Goulet Date: Thu Aug 24 09:12:57 2017 -0400 hs: Update intro circuit timestamp when re-extending A client can re-extend up to 3 intro points on the same circuit. This happens when we get

[tor-commits] [tor/master] circuit: Avoid needless log info in circuit_get_best()

2017-08-24 Thread nickm
commit 1077e9894cd60d9b991e38d965e57be00fd83277 Author: David Goulet Date: Thu Aug 24 09:00:18 2017 -0400 circuit: Avoid needless log info in circuit_get_best() When looking for an introduction circuit in circuit_get_best(), we log an info message if

[tor-commits] [tor/master] prop224: Implement hs_client_any_intro_points_usable()

2017-08-24 Thread nickm
commit a64ef7d6c5f609229c4e6a25f1b18494a3ba6eea Author: David Goulet Date: Thu Jul 27 17:15:19 2017 -0400 prop224: Implement hs_client_any_intro_points_usable() Signed-off-by: David Goulet --- src/or/connection_edge.c | 4 +++-

[tor-commits] [tor/master] prop224: Update OOM counters when freeing a client descriptor cache object

2017-08-24 Thread nickm
commit 68887fdc5d4ff94cb8e88480e160349007d8a6a5 Author: David Goulet Date: Tue Aug 22 11:27:47 2017 -0400 prop224: Update OOM counters when freeing a client descriptor cache object When we free a client descriptor cache object, tell the OOM handler.

[tor-commits] [tor/master] prop224: Add a function to find an intro point by legacy ID

2017-08-24 Thread nickm
commit a16627db1f099e8eaa2ac899cead604fe611f117 Author: David Goulet Date: Tue Aug 22 14:51:27 2017 -0400 prop224: Add a function to find an intro point by legacy ID The client needs to find the right intro point object from the circuit identity digest

[tor-commits] [tor/master] prop224: Add client-side rend circuit support to HS circuitmap

2017-08-24 Thread nickm
commit 3152c583af052571cbcd058bb1569f2ad821ec42 Author: George Kadianakis Date: Tue Jul 25 12:05:02 2017 +0300 prop224: Add client-side rend circuit support to HS circuitmap Signed-off-by: David Goulet --- src/or/hs_circuitmap.c

[tor-commits] [tor/master] prop224: Add a client intro point state cache

2017-08-24 Thread nickm
commit 2671399e67e19c125fbfb6f4b9f1ba71c4e52031 Author: David Goulet Date: Thu Jul 27 15:51:32 2017 -0400 prop224: Add a client intro point state cache This cache keeps track of the state of intro points which is needed when we have failures when using

[tor-commits] [tor/master] prop224: Refactor how we use connection_ap_handle_onion

2017-08-24 Thread nickm
commit 5f94c4a0f17403060d5030fab3e81bde46693119 Author: David Goulet Date: Wed Aug 23 10:48:48 2017 -0400 prop224: Refactor how we use connection_ap_handle_onion Simply directly return its returned value. Signed-off-by: David Goulet

[tor-commits] [tor/master] prop224: Parse INTRODUCE_ACK cell

2017-08-24 Thread nickm
commit cb336a7062f87c5c306549a4f4a26eab66c5b825 Author: David Goulet Date: Fri Jul 21 17:06:04 2017 -0400 prop224: Parse INTRODUCE_ACK cell Add a function to parse an INTRODUCE_ACK cell in hs_cell.c. Furthermore, add an enum that lists all possible

[tor-commits] [tor/master] prop224: Client function to pick intro point

2017-08-24 Thread nickm
commit abb840bf6431cfeb4f5e32ae2774fcde29e7724d Author: David Goulet Date: Fri Jul 21 15:19:32 2017 -0400 prop224: Client function to pick intro point From an edge connection object, add a function that randomly pick an introduction point for the

[tor-commits] [tor/master] trunnel: Add RENDEZVOUS2 cell definition

2017-08-24 Thread nickm
commit 2f1b3d647ff1489f4cb0f25d96701eaf35e076da Author: David Goulet Date: Sun Jul 23 15:04:59 2017 -0400 trunnel: Add RENDEZVOUS2 cell definition Signed-off-by: David Goulet --- src/trunnel/hs/cell_rendezvous.c | 178

[tor-commits] [tor/master] prop224: Update OOM counters when storing a client descriptor cache object

2017-08-24 Thread nickm
commit e046e6fb4816e118f1bb32bd709b5dce5b729994 Author: David Goulet Date: Tue Aug 22 11:30:11 2017 -0400 prop224: Update OOM counters when storing a client descriptor cache object Signed-off-by: David Goulet --- src/or/hs_cache.c

[tor-commits] [tor/master] hs: Stub link_specifier_t in hs_descriptor.h

2017-08-24 Thread nickm
commit 61009d40d127e0435e9fd98a8daf81c50e6687f0 Author: David Goulet Date: Tue Aug 22 14:10:30 2017 -0400 hs: Stub link_specifier_t in hs_descriptor.h Avoid including a huge trunnel interface everytime we include hs_descriptor.h Signed-off-by:

[tor-commits] [tor/master] prop224: Check decoded descriptor matches the expected blinded key

2017-08-24 Thread nickm
commit 47672ec1c7202feb0422317b39f9bcefb231fe5b Author: David Goulet Date: Tue Aug 22 09:02:23 2017 -0400 prop224: Check decoded descriptor matches the expected blinded key When a client decodes a descriptor, make sure it matches the expected blinded

[tor-commits] [tor/master] prop224: Use the client-side circuitmap in hs_client.c

2017-08-24 Thread nickm
commit 379ad6f6eb5393e74daba8ac71c252155c052a34 Author: George Kadianakis Date: Tue Jul 25 12:17:20 2017 +0300 prop224: Use the client-side circuitmap in hs_client.c Signed-off-by: David Goulet --- src/or/circuitlist.c | 27

[tor-commits] [tor/master] test: Fix broken HS upload descriptor test

2017-08-24 Thread nickm
commit 520fcdf2f377909e980dfcc8baea4733476f096c Author: David Goulet Date: Fri Aug 11 15:41:23 2017 -0400 test: Fix broken HS upload descriptor test We can't trigger a valid upload because it would require us to MOCK a long list of functions ultimately

[tor-commits] [tor/master] prop224: Add directory_request_fetch_set_hs_ident()

2017-08-24 Thread nickm
commit 31da3898e72cc2b9e8c25f6b4e89d34bbb17737e Author: David Goulet Date: Wed Aug 9 11:45:29 2017 -0400 prop224: Add directory_request_fetch_set_hs_ident() Needed by the client when fetching a descriptor. This function checks the directory purpose and

[tor-commits] [tor/master] hs: Only note a connection attempt with a valid rend_data

2017-08-24 Thread nickm
commit e67f8623f95082341c06c9c70ef664ed7b186483 Author: David Goulet Date: Tue Jul 25 10:31:44 2017 -0400 hs: Only note a connection attempt with a valid rend_data For now, prop224 doesn't have a mechanism to note down connection attempts so we only do

[tor-commits] [tor/master] prop224: Make client send INTRODUCE1 cell

2017-08-24 Thread nickm
commit e7c06e694766c6e2fb1f06ed5e1bf9c216e7a976 Author: David Goulet Date: Fri Jul 21 16:31:27 2017 -0400 prop224: Make client send INTRODUCE1 cell Signed-off-by: David Goulet --- src/or/circuituse.c | 34

[tor-commits] [tor/master] prop224: Handle client RENDEZVOUS_ESTABLISHED cell

2017-08-24 Thread nickm
commit 89eb96c19a091b1e892e4a7c05f06e188131aed0 Author: David Goulet Date: Fri Jul 21 14:20:37 2017 -0400 prop224: Handle client RENDEZVOUS_ESTABLISHED cell Client now handles a RENDEZVOUS_ESTABLISHED cell when it arrives on the rendezvous circuit. This

[tor-commits] [tor/master] prop224: Client has opened circuit logic

2017-08-24 Thread nickm
commit 6eb125d14bf69e9dad427fe4b1005477177acc04 Author: David Goulet Date: Fri Jul 21 13:56:10 2017 -0400 prop224: Client has opened circuit logic Make a single entry point for the entire HS subsystem when a client circuit opens (every HS version).

[tor-commits] [tor/master] prop224: Use the intro point state cache

2017-08-24 Thread nickm
commit 14b858c4ced594ee5130a685ac4b143bf66da04a Author: David Goulet Date: Thu Jul 27 17:06:42 2017 -0400 prop224: Use the intro point state cache This commit makes the client use the intro point state cache. It notes down when we get a NACK from the

[tor-commits] [tor/master] prop224: Move and refactor rend_client_reextend_intro_circuit()

2017-08-24 Thread nickm
commit 88b843608accd10af6d12c53531950566ded5ef9 Author: David Goulet Date: Thu Jul 27 12:37:52 2017 -0400 prop224: Move and refactor rend_client_reextend_intro_circuit() This moves it to hs_client.c so it can be used by both system (legacy and prop224).

[tor-commits] [tor/master] prop224: Parse RENDEZVOUS2 cell

2017-08-24 Thread nickm
commit ee15c16742aecb4795ce12847068b7907be9e8a2 Author: David Goulet Date: Sun Jul 23 13:01:00 2017 -0400 prop224: Parse RENDEZVOUS2 cell Signed-off-by: David Goulet --- src/or/hs_cell.c | 32 1

[tor-commits] [tor/master] prop224: Handle RENDEZVOUS2 cell

2017-08-24 Thread nickm
commit 9af311630626b920aa74c4fb8d36eb086ebfb8a4 Author: David Goulet Date: Tue Jul 25 10:14:00 2017 -0400 prop224: Handle RENDEZVOUS2 cell The client can now handle RENDEZVOUS2 cell when they arrive. This consolidate both hidden service version in one

[tor-commits] [tor/master] hs: Update the IP failure cache only if legacy

2017-08-24 Thread nickm
commit 88f64eee68c972845131c8e372af067d8bb37cd1 Author: David Goulet Date: Tue Jul 25 11:37:55 2017 -0400 hs: Update the IP failure cache only if legacy Don't assert() on rend_data when closing circuits to report an IP failure. The prop224 code doesn't

[tor-commits] [tor/master] prop224: Handle INTRODUCE_ACK cell

2017-08-24 Thread nickm
commit fca2f64e2f563c07e2d5467adc49914bc4545e36 Author: David Goulet Date: Fri Jul 21 17:48:18 2017 -0400 prop224: Handle INTRODUCE_ACK cell The client is now able to handle an INTRODUCE_ACK cell and do the appropriate actions. An intro point

[tor-commits] [tor/master] prop224: Client callback when descriptor has arrived

2017-08-24 Thread nickm
commit c38144bb0f1a38cd4d72b60efd038aab63182b8b Author: David Goulet Date: Fri Jul 21 14:32:47 2017 -0400 prop224: Client callback when descriptor has arrived When a descriptor fetch has completed and it has been successfully stored in the client cache,

[tor-commits] [tor/master] prop224: Build INTRODUCE1 cell and send logic

2017-08-24 Thread nickm
commit d599325b5e1f92395742c3380112b4d2d7cbe9db Author: David Goulet Date: Fri Jul 14 10:16:48 2017 -0400 prop224: Build INTRODUCE1 cell and send logic Add a function in hs_cell.{c|h} for a client to build an INTRODUCE1 cell using an object that

[tor-commits] [tor/master] prop224: Build ESTABLISH_RENDEZVOUS cell and logic

2017-08-24 Thread nickm
commit b91693f7c3099c691d0e5dbb60ac55df14b7bd68 Author: David Goulet Date: Fri Jul 21 13:57:10 2017 -0400 prop224: Build ESTABLISH_RENDEZVOUS cell and logic Add a function to build the cell. Add a the logic to send the cell when the rendezvous

[tor-commits] [tor/master] prop224: Make lspecs to extend info public

2017-08-24 Thread nickm
commit 8a552bf49bb94dbca6163e7063d776f5f3a96694 Author: David Goulet Date: Tue Jul 18 15:17:37 2017 -0400 prop224: Make lspecs to extend info public The hs circuit file had this function that takes a list of link specifiers and return a newly allocated

[tor-commits] [tor/master] prop224: Helper function to assert on invalid client intro circuit

2017-08-24 Thread nickm
commit 8e2854372d777d6be63d1bf766ca6db9100490de Author: David Goulet Date: Thu Jun 29 13:29:23 2017 -0400 prop224: Helper function to assert on invalid client intro circuit Put all the possible assert() we can do on a client introduction circuit in one

[tor-commits] [tor/master] test: Add tests for fetching descs and handling SOCKS conns.

2017-08-24 Thread nickm
commit 6eb9de1b8c2ede739ebcd3514201c07365fadb18 Author: George Kadianakis Date: Thu Jun 1 14:35:39 2017 +0300 test: Add tests for fetching descs and handling SOCKS conns. - Add tests that ensure that SOCKS requests for v2/v3 addresses get intercepted

[tor-commits] [tor/master] prop224: Refactor rendclient.c to use the new hsdir_req code.

2017-08-24 Thread nickm
commit 5c9cd912eece244f90ecf31712722dc6b993f6da Author: George Kadianakis Date: Thu Jun 1 14:01:48 2017 +0300 prop224: Refactor rendclient.c to use the new hsdir_req code. - Also add tests for the hidserv_req subsystem. - Introduce purge_v2_hidserv_req()

[tor-commits] [tor/master] prop224: Rename hs_client_note_connection_attempt_succeeded()

2017-08-24 Thread nickm
commit b2a820958e8389853757c3e5ad59114bd82623d4 Author: David Goulet Date: Wed Jun 28 14:20:28 2017 -0400 prop224: Rename hs_client_note_connection_attempt_succeeded() This is a static function so don't polute the hs_client_ namespace.

[tor-commits] [tor/master] prop224: Fix hidserv request code to work for both v2 and v3.

2017-08-24 Thread nickm
commit 15c9b7e891dea655476dc77a07cef8824402fb00 Author: George Kadianakis Date: Thu Jun 1 13:56:43 2017 +0300 prop224: Fix hidserv request code to work for both v2 and v3. See documentation of `last_hid_serv_requests_` for how it works. strmaps are cool!

[tor-commits] [tor/master] conn: Add a function to return a list of connection by state

2017-08-24 Thread nickm
commit 6222eae8cabd7ab99e634ad7463a8c38d414fa19 Author: David Goulet Date: Tue Jul 18 11:41:41 2017 -0400 conn: Add a function to return a list of connection by state This will be useful to the hidden service subsystem that needs to go over all

[tor-commits] [tor/master] hs: Move link specifier encoding to a function

2017-08-24 Thread nickm
commit b13ee8e4ae59f85ce75800aa7dd90cfe58c04a5e Author: David Goulet Date: Tue Jul 18 13:56:19 2017 -0400 hs: Move link specifier encoding to a function This commit only moves code into a function. The client code will need a way to take a bunch of

[tor-commits] [tor/master] prop224: Connect to v3 services in connection_ap_handle_onion().

2017-08-24 Thread nickm
commit 776e796d96a9f60bf41f62cbf7cc3e16c8452bdf Author: George Kadianakis Date: Thu Jun 1 14:17:49 2017 +0300 prop224: Connect to v3 services in connection_ap_handle_onion(). Recognize and handle v3 addresses. Signed-off-by: David Goulet

[tor-commits] [tor/master] prop224: Add client code to handle fetched HS descriptors.

2017-08-24 Thread nickm
commit f93b77a18c5d1e77cb80fec0827d82d3672f9673 Author: George Kadianakis Date: Thu Jun 1 14:25:46 2017 +0300 prop224: Add client code to handle fetched HS descriptors. This code handles received HS descriptors by storing them in the client-side HS cache.

[tor-commits] [tor/master] hs: Fix comment of the get max size descriptor function

2017-08-24 Thread nickm
commit 79ff2e014f5726648e3f2c4a3f521ede76b8c6e2 Author: David Goulet Date: Tue Jun 27 09:28:15 2017 -0400 hs: Fix comment of the get max size descriptor function Signed-off-by: David Goulet --- src/or/hs_cache.c | 5 + 1 file

[tor-commits] [tor/master] prop224: Add code that launches v3 HS desc fetches.

2017-08-24 Thread nickm
commit c754864cfda8cf1fffcf754c400be0c21b74b50d Author: George Kadianakis Date: Thu Jun 1 14:12:33 2017 +0300 prop224: Add code that launches v3 HS desc fetches. Entry point is hs_client_refetch_v3_renddesc(). Will be used in subsequent commits.

[tor-commits] [tor/master] prop224: Introduce v2/v3 HS desc fetch retry functionality.

2017-08-24 Thread nickm
commit ebacf4dd6e709f45d2e23da62312848161e78091 Author: George Kadianakis Date: Thu Jun 1 14:22:17 2017 +0300 prop224: Introduce v2/v3 HS desc fetch retry functionality. Signed-off-by: David Goulet --- src/or/directory.c | 39

[tor-commits] [tor/master] prop224: Refactor pick_hsdir() to be used by both v2 and v3.

2017-08-24 Thread nickm
commit 0f6633abb29743d920c27e8d7888dba4d83217b5 Author: George Kadianakis Date: Thu Jun 1 14:07:53 2017 +0300 prop224: Refactor pick_hsdir() to be used by both v2 and v3. Also refactor rendclient.c to use the new hs_pick_hdsir() func. Signed-off-by:

[tor-commits] [tor/master] prop224: Add the dir purpose HAS_FETCHED

2017-08-24 Thread nickm
commit 343af1a9cf64e060150caf7b53e513315cc37f72 Author: David Goulet Date: Tue Jun 27 09:46:16 2017 -0400 prop224: Add the dir purpose HAS_FETCHED Once a descriptor has been successfully downloaded from an HSDir, we flag the directory connection to

[tor-commits] [tor/master] prop224: Add client-side HS descriptor cache.

2017-08-24 Thread nickm
commit 7aef3ec0fde0b320343ecb3aa7080b6e1d9a2e62 Author: George Kadianakis Date: Thu Jun 1 13:37:11 2017 +0300 prop224: Add client-side HS descriptor cache. Signed-off-by: David Goulet --- src/or/hs_cache.c | 259

[tor-commits] [tor/master] prop224: Recompute all HSDir indices when we enter overlap mode.

2017-08-24 Thread nickm
commit 3e593f09addb210f1da39bd46f5fb904cac4e410 Author: George Kadianakis Date: Sat Aug 19 16:00:58 2017 +0300 prop224: Recompute all HSDir indices when we enter overlap mode. When we enter overlap mode we start using the next hsdir index of relays.

[tor-commits] [tor/master] prop224: Refactor parse_extended_hostname() to parse v3 addrs.

2017-08-24 Thread nickm
commit bce18a764252c66e605680e29a27ea30375a6db1 Author: George Kadianakis Date: Thu Jun 1 13:21:03 2017 +0300 prop224: Refactor parse_extended_hostname() to parse v3 addrs. We need this func so that we recognize SOCKS conns to v3 addresses. - Also

[tor-commits] [tor/master] prop224: Move some rendclient.c code to hs_common.c

2017-08-24 Thread nickm
commit 912c11761c5b5b0a80e232bdc96788677300ca67 Author: George Kadianakis Date: Thu Jun 1 13:48:03 2017 +0300 prop224: Move some rendclient.c code to hs_common.c Specifically move the pick_hsdir() function and all the HSDir request tracking code. We plan

[tor-commits] [tor/master] prop224: Improve descriptor reupload logic.

2017-08-24 Thread nickm
commit 7823c98a38556237a86c7235d411d7d2237cc2d6 Author: George Kadianakis Date: Sat Aug 19 16:26:46 2017 +0300 prop224: Improve descriptor reupload logic. We want to reupload our descriptor if its set of responsible HSDirs changed to minimize reachability

[tor-commits] [tor/master] prop224: Decouple the HS part of connection_ap_handshake_rewrite_and_attach().

2017-08-24 Thread nickm
commit 5d89ea1e6c148ce584dc2059c4d353d12d01e8d1 Author: George Kadianakis Date: Thu Jun 1 13:24:28 2017 +0300 prop224: Decouple the HS part of connection_ap_handshake_rewrite_and_attach(). We will need to edit this function, and it's already pretty huge.

[tor-commits] [tor/master] test: Improve get_responsible_hsdirs test.

2017-08-24 Thread nickm
commit 26c85fcc863678c06cc79ec1a58bd6c504d3321a Author: George Kadianakis Date: Sun Aug 13 23:25:08 2017 +0300 test: Improve get_responsible_hsdirs test. --- src/test/test_hs_common.c | 94 --- 1 file changed, 73

[tor-commits] [tor/master] sr: Log voting schedule at debug level

2017-08-24 Thread nickm
commit 5750f18bc7efacc2405918d08bc3f47e4c6a7ae9 Author: David Goulet Date: Wed Aug 9 11:25:53 2017 -0400 sr: Log voting schedule at debug level Because the HS subsystem calls it every second, change the log level to debug so it doesn't spam the info

[tor-commits] [tor/master] prop224: Improve our checks for unset HSDir index.

2017-08-24 Thread nickm
commit 43343ec019e24cb3b1d5802d1369ab75ec0e8776 Author: George Kadianakis Date: Sat Aug 12 13:05:25 2017 +0300 prop224: Improve our checks for unset HSDir index. We used to not check next hsdir index. --- src/or/hs_common.c | 11 +-- 1 file changed,

[tor-commits] [tor/master] prop224: Only upload descriptor if we have good hash ring and SRV.

2017-08-24 Thread nickm
commit 1f7b8012ae9b6226e5853751685c98782a48c0c4 Author: George Kadianakis Date: Sun Aug 13 20:16:21 2017 +0300 prop224: Only upload descriptor if we have good hash ring and SRV. Make sure we have a live consensus (for SRV) and enough descriptors (for hash

[tor-commits] [webwml/master] Fix security policy for amazon donate page

2017-08-24 Thread hiro
commit 9f7db64946870614808bc6cc8a7f94eef181e5e0 Author: hiromipaw Date: Tue Aug 8 11:35:15 2017 +0200 Fix security policy for amazon donate page --- include/head.wmi | 1 + 1 file changed, 1 insertion(+) diff --git a/include/head.wmi b/include/head.wmi index

[tor-commits] [webwml/master] Merge branch 'master' of ssh://git-rw.torproject.org/project/web/webwml

2017-08-24 Thread hiro
commit 7e3fccb40a7c619f44845b5495bfab411141b777 Merge: e670475b 52c29243 Author: hiromipaw Date: Thu Aug 24 16:21:48 2017 +0200 Merge branch 'master' of ssh://git-rw.torproject.org/project/web/webwml about/en/corepeople.wml| 2 +-

[tor-commits] [webwml/master] Escaping equals sign in viewport

2017-08-24 Thread hiro
commit e670475bcd5d84bfcc58440469d20c5280dfc800 Author: hiromipaw Date: Thu Aug 24 16:21:44 2017 +0200 Escaping equals sign in viewport --- include/head.wmi | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/include/head.wmi

[tor-commits] [tor/master] Merge branch 'bug23106_032'

2017-08-24 Thread nickm
commit b5c5086aba2fa24649fcbda7db80ef599d56e3c6 Merge: 35a29e81a 3b646bf88 Author: Nick Mathewson Date: Thu Aug 24 09:45:03 2017 -0400 Merge branch 'bug23106_032' changes/bug23106 | 5 + src/or/onion.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

[tor-commits] [tor/master] Fix ntohs() that should have been htons()

2017-08-24 Thread nickm
commit 3b646bf887f95c7f26ca05fb7fb3af10806b1328 Author: Nick Mathewson Date: Fri Aug 4 12:17:53 2017 -0400 Fix ntohs() that should have been htons() Fixes bug 23106; bugfix on 0.2.4.8-alpha. Fortunately, we only support big-endian and little-endian

[tor-commits] [tor/master] Make write_escaped_data more robust to large inputs.

2017-08-24 Thread nickm
commit 6f7d548bc428a5aa923c04cdcdab59af88a3495b Author: Nick Mathewson Date: Wed Aug 9 08:58:38 2017 -0400 Make write_escaped_data more robust to large inputs. The old implementation would fail with super-long inputs. We never gave it any, but still, it's

[tor-commits] [tor/master] Merge branch 'bug19281_025'

2017-08-24 Thread nickm
commit 35a29e81aea1712caada533dbdab4248612cc185 Merge: d37e8b407 6f7d548bc Author: Nick Mathewson Date: Thu Aug 24 09:27:26 2017 -0400 Merge branch 'bug19281_025' changes/bug19281 | 5 + src/or/control.c | 20 ++-- 2 files changed, 19

[tor-commits] [tor/master] Treat a bad tor_spawn_background() as a BUG().

2017-08-24 Thread nickm
commit b4963da987f0b374a2bbfd866e1a36358b1e750f Author: Nick Mathewson Date: Wed Aug 9 10:55:30 2017 -0400 Treat a bad tor_spawn_background() as a BUG(). The contract is that, if may_spawn_background_process() is 0, you're not even allowed to try to spawn

[tor-commits] [tor/master] Block the port-forwarding helper at a higher point

2017-08-24 Thread nickm
commit 801aa5d03b3a62c7ed09e8c36629ced23e8c663a Author: Nick Mathewson Date: Wed Aug 9 10:48:43 2017 -0400 Block the port-forwarding helper at a higher point --- src/or/config.c | 4 src/or/main.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff

[tor-commits] [tor/master] Remove the #if 0ed code that was supposed to let the sandbox allow exec

2017-08-24 Thread nickm
commit 94352368db9045a9704c713dbbc0f41ecc511910 Author: Nick Mathewson Date: Wed Aug 9 10:36:45 2017 -0400 Remove the #if 0ed code that was supposed to let the sandbox allow exec --- src/common/sandbox.c | 63

[tor-commits] [tor/master] Merge branch 'feature22976_squashed'

2017-08-24 Thread nickm
commit d37e8b407a762316e89e0c0a613c26372ec897aa Merge: f4f828640 a0bb1ff6a Author: Nick Mathewson Date: Thu Aug 24 09:23:43 2017 -0400 Merge branch 'feature22976_squashed' changes/feature22976 | 8 +++ doc/tor.1.txt| 7 ++ src/common/sandbox.c | 63

[tor-commits] [tor/master] Add a 'NoExec' option that causes tor_spawn_background() to fail

2017-08-24 Thread nickm
commit eb43401bfb6d69db66d256582a99e63de7d222d8 Author: Nick Mathewson Date: Wed Aug 9 10:42:37 2017 -0400 Add a 'NoExec' option that causes tor_spawn_background() to fail Core of an implementation for 22976. --- changes/feature22976 | 7 +++

[tor-commits] [tor/master] Also disable spawning on Sandbox.

2017-08-24 Thread nickm
commit a0bb1ff6ab0be8faa7284aec3f7f93e31e8578d9 Author: Nick Mathewson Date: Wed Aug 9 10:56:57 2017 -0400 Also disable spawning on Sandbox. This isn't a functional change, but it makes our logic more clear, and catches bugs earlier. ---

[tor-commits] [tor/master] Block managed proxies at a higher point

2017-08-24 Thread nickm
commit 5fa8d05bfa17d61a2cf96c87f0ffd9a2b6e577d2 Author: Nick Mathewson Date: Wed Aug 9 10:48:43 2017 -0400 Block managed proxies at a higher point --- src/or/config.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/or/config.c b/src/or/config.c index

[tor-commits] [tor/master] Merge branch 'bug22779_031'

2017-08-24 Thread nickm
commit f4f828640f25d73e9a29c3d901af4ab594de0d56 Merge: 53c82c082 df3bdc6bd Author: Nick Mathewson Date: Thu Aug 24 09:18:39 2017 -0400 Merge branch 'bug22779_031' changes/bug22779 | 4 src/or/circuitbuild.c | 8 +--- 2 files changed, 9 insertions(+), 3

[tor-commits] [tor/master] Clean up choose_good_entry_server() doc; add assertion

2017-08-24 Thread nickm
commit df3bdc6bdeb7e8eef13248ba245a70fd8cbf1f86 Author: Nick Mathewson Date: Mon Jul 31 20:35:58 2017 -0400 Clean up choose_good_entry_server() doc; add assertion We used to allow state==NULL here, but we no longer do. Fixes bug 22779. ---

[tor-commits] [tor/master] Merge branch 'bug22677'

2017-08-24 Thread nickm
commit 53c82c0821737ce76bb99a75b5f309d0b2d715ba Merge: 18f3f1ffa 69222fe87 Author: Nick Mathewson Date: Thu Aug 24 09:18:03 2017 -0400 Merge branch 'bug22677' changes/bug22677 | 3 +++ doc/tor.1.txt| 6 -- 2 files changed, 7 insertions(+), 2 deletions(-)

[tor-commits] [tor/master] Clarify that "sandbox 1" requires linux and seccomp2

2017-08-24 Thread nickm
commit 69222fe87d5c79bd389905b3041f1c2187d6a1e8 Author: Nick Mathewson Date: Wed Aug 9 09:29:34 2017 -0400 Clarify that "sandbox 1" requires linux and seccomp2 Closes 22677. --- changes/bug22677 | 3 +++ doc/tor.1.txt| 6 -- 2 files changed, 7

[tor-commits] [tor-browser-bundle/master] Add Felix's obfs4 bridges to the built-in bridges.

2017-08-24 Thread gk
commit fc2449fc0ef8bebfeaaa1a44c23215a86f64d75a Author: Isis Lovecruft Date: Wed Aug 23 19:27:44 2017 + Add Felix's obfs4 bridges to the built-in bridges. * FIXES #23166: https://bugs.torproject.org/23166 --- Bundle-Data/PTConfigs/bridge_prefs.js | 2 ++