[tor-commits] [goptlib/main] Update PT spec references.

2022-02-08 Thread dcf
commit b31bdca77deeeb3c9da4116473b65e8ffba9ea0b Author: David Fifield Date: Tue Feb 8 13:05:53 2022 -0700 Update PT spec references. Proposals 196 (ExtORPort) and 217 (ExtORPort authentication) were merged together into ext-orport-spec.txt in

[tor-commits] [meek/main] Fix the locking around rt.rt.

2021-12-29 Thread dcf
commit 46e612d2e9afd6e5dfa54c473ed17aeab49001af Author: David Fifield Date: Wed Dec 29 22:06:41 2021 -0700 Fix the locking around rt.rt. sync.Once does not prevent other goroutines from accessing a variable that has not been defined yet. --- meek-client/utls.go | 12

[tor-commits] [meek/main] Only lock the assignment to rt.rt, not the whole RoundTrip.

2021-12-29 Thread dcf
commit 88fd7233036450e0d3278f3afe0a9995974ae120 Author: David Fifield Date: Wed Dec 29 21:35:06 2021 -0700 Only lock the assignment to rt.rt, not the whole RoundTrip. We need to guard against concurrent modification of rt.rt, but once it is set, we many concurrently call

[tor-commits] [goptlib/main] Add a go.mod file.

2021-09-15 Thread dcf
commit 0018750f0851d5b427828bfbdfc7968ae3c398c3 Author: David Fifield Date: Wed Sep 15 14:37:36 2021 -0600 Add a go.mod file. This is an attempt to fix a warning message observed when trying to build the Snowflake proxy.

[tor-commits] [goptlib/main] v1.2.0

2021-09-15 Thread dcf
commit 13b7b3552e1eef32e4d8a2a7813f22488f91dc09 Author: David Fifield Date: Wed Sep 15 15:01:21 2021 -0600 v1.2.0 --- ChangeLog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ChangeLog b/ChangeLog index a25f5a9..7a86c48 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,5 @@ +==

[tor-commits] [meek/main] Add missing transport to ServerTransportListenAddr in meek-server man page.

2021-09-14 Thread dcf
commit 6600c52acb7979b08dd0916a7a779dd0e5dde0b0 Author: David Fifield Date: Tue Sep 14 13:22:10 2021 -0600 Add missing transport to ServerTransportListenAddr in meek-server man page. --- doc/meek-server.1 | 6 +++--- doc/meek-server.1.txt | 2 +- 2 files changed, 4 insertions(+), 4

[tor-commits] [meek/main] Actually recognize utls=HelloChrome_83 in meek-client.

2021-09-03 Thread dcf
commit 17083fc53147161fda0784a116026e29e2debee2 Author: David Fifield Date: Fri Sep 3 15:46:34 2021 -0600 Actually recognize utls=HelloChrome_83 in meek-client. To match documentation added in 7aa47e7ffc9ca9153d2d2e79c55c90e7e618. --- doc/meek-client.1.txt | 1 -

[tor-commits] [meek/main] programVersion = "0.36.0"

2021-09-03 Thread dcf
commit 87f29032d03ebdd5a0ec597c2bb38515a1b721aa Author: David Fifield Date: Fri Sep 3 15:40:40 2021 -0600 programVersion = "0.36.0" --- meek-server/meek-server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meek-server/meek-server.go b/meek-server/meek-server.go

[tor-commits] [meek/main] programVersion = "0.37.0"

2021-09-03 Thread dcf
commit 53974afcd281204a9e7622d7454c10a49192d619 Author: David Fifield Date: Fri Sep 3 15:47:28 2021 -0600 programVersion = "0.37.0" --- meek-server/meek-server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meek-server/meek-server.go b/meek-server/meek-server.go

[tor-commits] [meek/main] Fix markup in meek-server man page.

2021-09-03 Thread dcf
commit ae42cad2499b0b139ded386eec3a5f99f0493ab0 Author: David Fifield Date: Fri Sep 3 15:39:09 2021 -0600 Fix markup in meek-server man page. --- doc/meek-server.1 | 22 -- doc/meek-server.1.txt | 4 ++-- 2 files changed, 18 insertions(+), 8 deletions(-) diff

[tor-commits] [meek/main] Update utls to v0.0.0-20210713165636-0b2885c8c0d4.

2021-09-03 Thread dcf
commit 7aa47e7ffc9ca9153d2d2e79c55c90e7e618 Author: David Fifield Date: Fri Sep 3 15:33:25 2021 -0600 Update utls to v0.0.0-20210713165636-0b2885c8c0d4. --- doc/meek-client.1 | 15 +-- doc/meek-client.1.txt | 1 + go.mod| 2 +- go.sum|

[tor-commits] [meek/main] Use a non-empty ServerName in TestProxyHTTPSCONNECT.

2021-09-03 Thread dcf
commit d9d57c24616a52f3f591fd49e4a5b34e2567fef3 Author: David Fifield Date: Fri Sep 3 15:27:01 2021 -0600 Use a non-empty ServerName in TestProxyHTTPSCONNECT. The crypto/tls server, since go1.12, requires that if a server_name extension is present, it is not empty. With go1.12

[tor-commits] [meek/main] Remove TestCopyPublicFieldsHTTPTransport.

2021-09-03 Thread dcf
commit ae328538b8b582f2e594d8e3fcf192e8f70b8b16 Author: David Fifield Date: Thu Sep 2 07:06:23 2021 -0600 Remove TestCopyPublicFieldsHTTPTransport. This ought to have been removed in bc887de694bc2d2381af099d5c38f0e9efd76c4b.

[tor-commits] [meek/main] Document equalities of "_Auto" utls fingerprints.

2021-09-03 Thread dcf
commit 339f3d8ea06d765283d177bd4a273befae0bbb42 Author: David Fifield Date: Fri Sep 3 15:38:20 2021 -0600 Document equalities of "_Auto" utls fingerprints. --- doc/meek-client.1 | 6 +++--- doc/meek-client.1.txt | 7 --- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git

[tor-commits] [meek/master] programVersion = "0.37.0"

2021-09-03 Thread dcf
commit 53974afcd281204a9e7622d7454c10a49192d619 Author: David Fifield Date: Fri Sep 3 15:47:28 2021 -0600 programVersion = "0.37.0" --- meek-server/meek-server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meek-server/meek-server.go b/meek-server/meek-server.go

[tor-commits] [meek/master] Actually recognize utls=HelloChrome_83 in meek-client.

2021-09-03 Thread dcf
commit 17083fc53147161fda0784a116026e29e2debee2 Author: David Fifield Date: Fri Sep 3 15:46:34 2021 -0600 Actually recognize utls=HelloChrome_83 in meek-client. To match documentation added in 7aa47e7ffc9ca9153d2d2e79c55c90e7e618. --- doc/meek-client.1.txt | 1 -

[tor-commits] [meek/master] programVersion = "0.36.0"

2021-09-03 Thread dcf
commit 87f29032d03ebdd5a0ec597c2bb38515a1b721aa Author: David Fifield Date: Fri Sep 3 15:40:40 2021 -0600 programVersion = "0.36.0" --- meek-server/meek-server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meek-server/meek-server.go b/meek-server/meek-server.go

[tor-commits] [meek/master] Remove TestCopyPublicFieldsHTTPTransport.

2021-09-03 Thread dcf
commit ae328538b8b582f2e594d8e3fcf192e8f70b8b16 Author: David Fifield Date: Thu Sep 2 07:06:23 2021 -0600 Remove TestCopyPublicFieldsHTTPTransport. This ought to have been removed in bc887de694bc2d2381af099d5c38f0e9efd76c4b.

[tor-commits] [meek/master] Use a non-empty ServerName in TestProxyHTTPSCONNECT.

2021-09-03 Thread dcf
commit d9d57c24616a52f3f591fd49e4a5b34e2567fef3 Author: David Fifield Date: Fri Sep 3 15:27:01 2021 -0600 Use a non-empty ServerName in TestProxyHTTPSCONNECT. The crypto/tls server, since go1.12, requires that if a server_name extension is present, it is not empty. With go1.12

[tor-commits] [meek/master] Update utls to v0.0.0-20210713165636-0b2885c8c0d4.

2021-09-03 Thread dcf
commit 7aa47e7ffc9ca9153d2d2e79c55c90e7e618 Author: David Fifield Date: Fri Sep 3 15:33:25 2021 -0600 Update utls to v0.0.0-20210713165636-0b2885c8c0d4. --- doc/meek-client.1 | 15 +-- doc/meek-client.1.txt | 1 + go.mod| 2 +- go.sum|

[tor-commits] [meek/master] Fix markup in meek-server man page.

2021-09-03 Thread dcf
commit ae42cad2499b0b139ded386eec3a5f99f0493ab0 Author: David Fifield Date: Fri Sep 3 15:39:09 2021 -0600 Fix markup in meek-server man page. --- doc/meek-server.1 | 22 -- doc/meek-server.1.txt | 4 ++-- 2 files changed, 18 insertions(+), 8 deletions(-) diff

[tor-commits] [meek/master] Document equalities of "_Auto" utls fingerprints.

2021-09-03 Thread dcf
commit 339f3d8ea06d765283d177bd4a273befae0bbb42 Author: David Fifield Date: Fri Sep 3 15:38:20 2021 -0600 Document equalities of "_Auto" utls fingerprints. --- doc/meek-client.1 | 6 +++--- doc/meek-client.1.txt | 7 --- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git

[tor-commits] [snowflake/main] Implement ampCacheRendezvous.

2021-08-05 Thread dcf
commit 5adb99402861569a0c3d0e46299d48a583f48725 Author: David Fifield Date: Sun Jul 18 14:57:45 2021 -0600 Implement ampCacheRendezvous. --- client/lib/rendezvous_ampcache.go | 56 ++-- client/lib/rendezvous_test.go | 132 +- 2 files

[tor-commits] [snowflake/main] Document -ampcache in snowflake-client man page.

2021-08-05 Thread dcf
commit b203a75c41df5fca3b4b8bd41e7c98d0360f1575 Author: David Fifield Date: Mon Jul 26 10:24:47 2021 -0600 Document -ampcache in snowflake-client man page. --- doc/snowflake-client.1 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/snowflake-client.1

[tor-commits] [snowflake/main] Document /amp/client in broker-spec.txt.

2021-08-05 Thread dcf
commit f2dc41d77891816b3f6aec78cf9491fad6999388 Author: David Fifield Date: Mon Jul 26 10:23:12 2021 -0600 Document /amp/client in broker-spec.txt. --- doc/broker-spec.txt | 37 + 1 file changed, 37 insertions(+) diff --git a/doc/broker-spec.txt

[tor-commits] [snowflake/main] Add info about rendezvous methods to client README.

2021-08-05 Thread dcf
commit 521eb4d4d6d76a1d57d3c8fc5c3a8261c171ea4e Author: David Fifield Date: Mon Jul 19 09:01:17 2021 -0600 Add info about rendezvous methods to client README. --- client/README.md | 56 1 file changed, 56 insertions(+) diff --git

[tor-commits] [snowflake/main] Broker /amp/client route (AMP cache client registration).

2021-08-05 Thread dcf
commit e833119befa052e4837fe147f8bc2766a4ca7c54 Author: David Fifield Date: Sun Jul 18 23:37:41 2021 -0600 Broker /amp/client route (AMP cache client registration). --- broker/amp.go | 76 +++ broker/broker.go| 2 ++

[tor-commits] [snowflake/main] Factor out httpRendezvous separate from BrokerChannel.

2021-08-05 Thread dcf
commit 0f34a7778fa1f4c28c7cc161991080d146689591 Author: David Fifield Date: Sun Jul 18 12:36:16 2021 -0600 Factor out httpRendezvous separate from BrokerChannel. Makes BrokerChannel abstract over a rendezvousMethod. BrokerChannel itself is responsible for keepLocalAddresses

[tor-commits] [snowflake/main] Skeleton of ampCacheRendezvous.

2021-08-05 Thread dcf
commit c13810192d243690dab4c0e890a1f50273a22ca1 Author: David Fifield Date: Sun Jul 18 14:18:32 2021 -0600 Skeleton of ampCacheRendezvous. Currently the same as httpRendezvous, but activated using the -ampcache command-line option. --- client/lib/rendezvous.go | 13

[tor-commits] [snowflake/main] amp package.

2021-08-05 Thread dcf
commit c9e0dd287f30b2acb0145a7efc326c881792138a Author: David Fifield Date: Sun Jul 18 15:22:03 2021 -0600 amp package. This package contains a CacheURL function that modifies a URL to be accessed through an AMP cache, and the "AMP armor" data encoding scheme for encoding

[tor-commits] [snowflake/main] Change the representation of domain fronting in HTTP rendezvous.

2021-08-05 Thread dcf
commit 55f4814dfb5c196bb66416d4f3ba367498602489 Author: David Fifield Date: Sun Jul 18 10:39:51 2021 -0600 Change the representation of domain fronting in HTTP rendezvous. Formerly, BrokerChannel represented the broker URL and possible domain fronting as bc.url

[tor-commits] [snowflake/main] Use a URL with a Host component in BrokerChannel tests.

2021-08-05 Thread dcf
commit 191510c416db6b0229e62cc2b869aaf3cee907fa Author: David Fifield Date: Sun Jul 18 11:44:43 2021 -0600 Use a URL with a Host component in BrokerChannel tests. The tests were using a broker URL of "test.broker" (i.e., a schema-less, host-less, relative path), and running

[tor-commits] [snowflake/main] Use the readLimit constant in a test.

2021-07-18 Thread dcf
commit 2d7cd3f2b7d06094c0e2810441ba324c9dc37689 Author: David Fifield Date: Sun Jul 18 16:25:09 2021 -0600 Use the readLimit constant in a test. Instead of copying the value. --- client/lib/lib_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[tor-commits] [snowflake/main] Remove unused FakePeers.

2021-07-18 Thread dcf
commit d9a83e26b5de158da481e87702183546a4ea4e65 Author: David Fifield Date: Sun Jul 18 13:11:29 2021 -0600 Remove unused FakePeers. Unused since 1364d7d45bbec9de605a266a84ea60cdfa6676db. --- client/lib/lib_test.go | 6 -- 1 file changed, 6 deletions(-) diff --git

[tor-commits] [meek/turbotunnel-kcp] Comment typo.

2021-06-14 Thread dcf
commit 3e49af522f1b3216163eff9d6e4da7c2443952bd Author: David Fifield Date: Mon Jun 14 01:06:53 2021 -0600 Comment typo. --- common/encapsulation/encapsulation.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/encapsulation/encapsulation.go

[tor-commits] [meek/turbotunnel-kcp] Comment typo.

2021-05-30 Thread dcf
commit 9fd2e507b302cc5f4f81ed5fe6e09091bbcb3cc3 Author: David Fifield Date: Sun May 30 01:13:28 2021 -0600 Comment typo. --- meek-client/turbotunnel.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meek-client/turbotunnel.go b/meek-client/turbotunnel.go index

[goptlib/master] Note master→main name change in ChangeLog.

2021-05-29 Thread dcf
commit e6425ce5287c9545e5ce00b356156b57b4edbcd8 Author: David Fifield Date: Sat May 29 01:01:20 2021 -0600 Note master→main name change in ChangeLog. --- ChangeLog | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ChangeLog b/ChangeLog index 2aae857..12391ca 100644 ---

[goptlib/main] Note master→main name change in ChangeLog.

2021-05-29 Thread dcf
commit e6425ce5287c9545e5ce00b356156b57b4edbcd8 Author: David Fifield Date: Sat May 29 01:01:20 2021 -0600 Note master→main name change in ChangeLog. --- ChangeLog | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ChangeLog b/ChangeLog index 2aae857..12391ca 100644 ---

[tor-commits] [snowflake/master] Update required Go version to 1.13 in README.

2021-03-08 Thread dcf
commit 850d2f0683ede3d24a2b907161b6d88b32bed24a Author: David Fifield Date: Fri Mar 5 23:26:35 2021 -0700 Update required Go version to 1.13 in README. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d9be45b..6d47012 100644 ---

[snowflake-webext/master] Update link to anti-censorship team page trac→gitlab.

2021-02-04 Thread dcf
commit cf477b0119503beaa9389c4ee173b9c650e6f1f6 Author: David Fifield Date: Fri Feb 5 00:50:28 2021 -0700 Update link to anti-censorship team page trac→gitlab. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2d45948..90ce21b

[tor-commits] [snowflake/master] Don't log io.ErrClosedPipe in proxy.

2020-10-27 Thread dcf
commit 912bcae24eb71bc52c6f28b908e3c7678781e1a2 Author: David Fifield Date: Thu Oct 22 23:01:45 2020 -0600 Don't log io.ErrClosedPipe in proxy. We expect one of these at the end of just about every proxy session, as the Conns in both directions are closed as soon as the copy

[tor-commits] [snowflake-webext/master] Sync messages.json with index.html.

2020-10-08 Thread dcf
commit 0b31ee9efa611998a819ee67a42e5bfc13913419 Author: David Fifield Date: Thu Oct 8 10:53:27 2020 -0600 Sync messages.json with index.html. This brings in the bug-reporting instructions from #14 (bbf3629e). --- static/_locales/en_US/messages.json | 8 1 file changed, 4

[tor-commits] [snowflake-webext/master] Convert tabs to spaces in static/index.html.

2020-10-08 Thread dcf
commit bf2fbc1a8e1a10e609b5b66e3d5efe31219b228d Author: David Fifield Date: Thu Oct 8 10:45:29 2020 -0600 Convert tabs to spaces in static/index.html. --- static/index.html | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/static/index.html

[tor-commits] [snowflake/master] Consider more IPs to be local

2020-09-23 Thread dcf
commit 8467c01e9e88523fcdef22fed8efadbd07484966 Author: Peter Gerber Date: Mon Sep 21 15:53:24 2020 + Consider more IPs to be local --- common/util/util.go | 6 +- common/util/util_test.go | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[tor-commits] [snowflake-webext/master] Update a trac reference.

2020-08-06 Thread dcf
commit c2c3bdb2280a856f3e0d790e89be447404d9251d Author: David Fifield Date: Thu Aug 6 11:54:45 2020 -0600 Update a trac reference. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a2d8478..2d45948 100644 --- a/README.md +++

[tor-commits] [snowflake-webext/master] Update bug-reporting instructions.

2020-08-06 Thread dcf
commit bbf3629ec21123add37193904f270b06f38c8eb2 Author: David Fifield Date: Wed Aug 5 23:34:50 2020 -0600 Update bug-reporting instructions. Option 1 is to request an account at gitlab.torproject.org. Option 2 is to edit the public pad I just created. Closes #14. ---

[tor-commits] [meek/turbotunnel] comment typo

2020-07-27 Thread dcf
commit 70ce713a9d48810dff51984498d7898f6d57374d Author: David Fifield Date: Fri Jul 10 14:50:43 2020 -0600 comment typo --- meek-client/turbotunnel.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meek-client/turbotunnel.go b/meek-client/turbotunnel.go index

[tor-commits] [snowflake/master] Reduce DataChannelTimeout from 30s to 10s.

2020-05-04 Thread dcf
commit 7043a055f9fb0680281ecffd7d458a43f2ce65b5 Author: David Fifield Date: Fri May 1 10:49:40 2020 -0600 Reduce DataChannelTimeout from 30s to 10s. https://bugs.torproject.org/34042 --- client/lib/snowflake.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[tor-commits] [snowflake/master] Format the establishDataChannel error log message like other log messages.

2020-05-01 Thread dcf
commit c8293a5de315ddc5e212e0c894ebdc82a46ce1e1 Author: David Fifield Date: Fri May 1 10:30:04 2020 -0600 Format the establishDataChannel error log message like other log messages. It was sticking out in the context of other log messages. 2020/04/30 22:39:10 WebRTC:

[tor-commits] [meek/master] Update utls fingerprints

2020-04-29 Thread dcf
commit 9bd0572a639e0e33085496ecb9539c618229df0e Author: David Fifield Date: Wed Apr 29 13:30:40 2020 -0600 Update utls fingerprints github.com/refraction-networking/utls Adds HelloFirefox_65 HelloChrome_72 HelloIOS_12_1 ---

[tor-commits] [meek/master] Remove d2zfqthxsdq309.cloudfront.net from the example torrc.

2020-04-29 Thread dcf
commit ec78bba23155908ba3a46eb4e06fa7753c249a76 Author: David Fifield Date: Wed Apr 29 13:23:42 2020 -0600 Remove d2zfqthxsdq309.cloudfront.net from the example torrc. --- meek-client/torrc | 1 - 1 file changed, 1 deletion(-) diff --git a/meek-client/torrc b/meek-client/torrc index

[tor-commits] [meek/master] Use Clone to make copies of http.DefaultTransport.

2020-04-29 Thread dcf
commit bc887de694bc2d2381af099d5c38f0e9efd76c4b Author: David Fifield Date: Wed Apr 29 13:22:07 2020 -0600 Use Clone to make copies of http.DefaultTransport. Clone is new in go1.13. https://github.com/golang/go/issues/26013 --- meek-client/meek-client.go | 2 +-

[tor-commits] [meek/master] Do the go.mod thing.

2020-04-29 Thread dcf
commit 1b9883a620c9b12096c83809524b9f12076955bc Author: David Fifield Date: Wed Apr 29 13:34:58 2020 -0600 Do the go.mod thing. --- go.mod | 11 +++ go.sum | 17 + 2 files changed, 28 insertions(+) diff --git a/go.mod b/go.mod new file mode 100644 index

[tor-commits] [snowflake/master] Restore check for nil writePipe in WebRTCPeer.Close.

2020-04-28 Thread dcf
commit 72cfb96edeb7c9a3c93d38539bc31a51e30dbe8d Author: David Fifield Date: Tue Apr 28 11:33:09 2020 -0600 Restore check for nil writePipe in WebRTCPeer.Close. I removed this check in 047d3214bfb46de07e5d9f223e4fb1ba24584c8a because NewWebRTCPeer always initializes writePipe,

[tor-commits] [snowflake/master] Wait for data channel OnOpen before returning from NewWebRTCPeer.

2020-04-27 Thread dcf
commit 047d3214bfb46de07e5d9f223e4fb1ba24584c8a Author: David Fifield Date: Fri Apr 24 13:30:13 2020 -0600 Wait for data channel OnOpen before returning from NewWebRTCPeer. Now callers cannot call Write without there being a DataChannel to write to. This lets us remove the

[tor-commits] [snowflake/master] Make preparePeerConnection a standalone function.

2020-04-27 Thread dcf
commit 8295c87fbe4a3fb0d9e6c5fb04f6f0a52573faaf Author: David Fifield Date: Thu Apr 23 20:57:50 2020 -0600 Make preparePeerConnection a standalone function. --- client/lib/webrtc.go | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git

[tor-commits] [snowflake/master] Make WebRTCPeer.preparePeerConnection block.

2020-04-27 Thread dcf
commit 81d14ad33a21ac487cefb2912a32a72a7cc8ee39 Author: David Fifield Date: Thu Apr 23 20:13:16 2020 -0600 Make WebRTCPeer.preparePeerConnection block. Formerly, preparePeerConnection set up a callback that sent into a channel, and exchangeSDP waited until it could receive

[tor-commits] [snowflake/master] Have util.{Serialize, Deserialize}SessionDescription return an error

2020-04-27 Thread dcf
commit b48fb781ee15cf033efc61496746a295dc0d63c7 Author: David Fifield Date: Mon Apr 27 18:45:10 2020 -0600 Have util.{Serialize,Deserialize}SessionDescription return an error https://bugs.torproject.org/33897#comment:4 --- client/lib/lib_test.go | 11 ---

[tor-commits] [snowflake/master] Move establishDataChannel to after exchangeSDP.

2020-04-27 Thread dcf
commit e8c41650ae44e300aabe57e361c445808635fb4f Author: David Fifield Date: Fri Apr 24 11:44:40 2020 -0600 Move establishDataChannel to after exchangeSDP. --- client/lib/webrtc.go | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/client/lib/webrtc.go

[tor-commits] [snowflake/master] Make exchangeSDP into a standalone function.

2020-04-27 Thread dcf
commit 85277274fd3020819fe5c556b8164e7671bb799b Author: David Fifield Date: Thu Apr 23 22:33:38 2020 -0600 Make exchangeSDP into a standalone function. --- client/lib/webrtc.go | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git

[tor-commits] [snowflake/master] Eliminate separate WebRTCPeer.Connect method.

2020-04-27 Thread dcf
commit 32207d6f06c9254b3229f8e3161b80fd7f5df645 Author: David Fifield Date: Fri Apr 24 00:05:06 2020 -0600 Eliminate separate WebRTCPeer.Connect method. Do it as a side effect of NewWebRTCPeer. Remove WebRTCPeer tests as they currently require invasively modifying

[tor-commits] [snowflake/master] Simplify WebRTCPeer.exchangeSDP.

2020-04-27 Thread dcf
commit 5787d5b8b0a78a27a12385fbeea7bb12f5b11fb1 Author: David Fifield Date: Thu Apr 23 19:05:29 2020 -0600 Simplify WebRTCPeer.exchangeSDP. No need to run sendOfferToBroker in a goroutine. --- client/lib/webrtc.go | 45 ++--- 1 file

[tor-commits] [snowflake/master] Remove SnowflakeDataChannel interface.

2020-04-27 Thread dcf
commit 8caa737700d282dc7b174b4df3e514cc02bb0386 Author: David Fifield Date: Fri Apr 24 14:41:19 2020 -0600 Remove SnowflakeDataChannel interface. Use *webrtc.DataChannel directly. --- client/lib/interfaces.go | 7 --- client/lib/webrtc.go | 4 ++-- 2 files changed, 2

[tor-commits] [snowflake/master] Remove `Snowflake` interface, use `*WebRTCPeer` directly.

2020-04-27 Thread dcf
commit 76732155e7d730573b3ced62209e4e1e4ead511c Author: David Fifield Date: Fri Apr 24 14:21:08 2020 -0600 Remove `Snowflake` interface, use `*WebRTCPeer` directly. The other interfaces in client/lib/interfaces.go exist for the purpose of running tests, but not Snowflake.

[tor-commits] [snowflake/master] Don't do a separate check for a short write.

2020-04-27 Thread dcf
commit d9b076c32eed106a382a19bda973a9616cc44501 Author: David Fifield Date: Thu Apr 23 21:01:19 2020 -0600 Don't do a separate check for a short write. A short write will result in a non-nil error. It's an io.PipeWriter anyway, which blocks until all the data has been read or

[tor-commits] [snowflake/master] Move pc.CreateOffer/pc.SetLocalDescription out of a goroutine.

2020-04-27 Thread dcf
commit 51bb49fa6f4ac7e01b19fd3136411a54a67a4ff6 Author: David Fifield Date: Thu Apr 23 18:52:32 2020 -0600 Move pc.CreateOffer/pc.SetLocalDescription out of a goroutine. This allows us to remove the internal errorChannel. --- client/lib/webrtc.go | 47

[tor-commits] [snowflake/master] Simplify Peers.Pop.

2020-04-24 Thread dcf
commit 3520f4e8b96e05dfb30874ec2174457684269db6 Author: David Fifield Date: Thu Apr 23 18:14:27 2020 -0600 Simplify Peers.Pop. --- client/lib/peers.go | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/client/lib/peers.go b/client/lib/peers.go index

[tor-commits] [snowflake/master] Remove unused Resetter interface.

2020-04-24 Thread dcf
commit 17c0d0ff82ccc0fad077ceb8ff8b20d580c56a24 Author: David Fifield Date: Thu Apr 23 18:31:48 2020 -0600 Remove unused Resetter interface. WaitForReset is not used since 70126177fbdf5b1fa4977f2fc26f624641708098. --- client/lib/interfaces.go | 6 -- client/lib/webrtc.go

[tor-commits] [snowflake/master] Disable trickle ICE.

2020-04-24 Thread dcf
commit 6c2e3adc41c2c6d1ed794adac019a5a6eb069536 Author: David Fifield Date: Thu Apr 23 22:22:34 2020 -0600 Disable trickle ICE. https://bugs.torproject.org/33984 OnICEGatheringStateChange is no longer called when candidate gathering is complete. SetLocalDescription

[tor-commits] [snowflake/master] Make BytesSyncLogger's implementation details internal.

2020-04-24 Thread dcf
commit 2853fc93628bf997903de33cd7aebd1420e5975f Author: David Fifield Date: Thu Apr 23 21:20:16 2020 -0600 Make BytesSyncLogger's implementation details internal. Provide NewBytesSyncLogger that returns an opaque data structure. Automatically start up the logging loop

[tor-commits] [snowflake/master] Make WebRTCPeer and Peers not inherit the methods of BytesLogger.

2020-04-24 Thread dcf
commit d376d7036bdee70797dbda50af34d5930d45dadd Author: David Fifield Date: Thu Apr 23 21:08:01 2020 -0600 Make WebRTCPeer and Peers not inherit the methods of BytesLogger. You would have been able to do, for example, snowflake.(*WebRTCPeer).AddInbound(...). ---

[tor-commits] [snowflake/master] Simplify BytesSyncLogger.

2020-04-24 Thread dcf
commit 73173cb6987dbf26fdb1036e4b7710c200f87141 Author: David Fifield Date: Thu Apr 23 21:26:19 2020 -0600 Simplify BytesSyncLogger. --- client/lib/util.go | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/client/lib/util.go

[tor-commits] [snowflake/master] Remove unused BytesSyncLogger.IsLogging.

2020-04-24 Thread dcf
commit 9a4e3e7bd97ba87255453a005b2a3474d1914621 Author: David Fifield Date: Thu Apr 23 21:12:45 2020 -0600 Remove unused BytesSyncLogger.IsLogging. --- client/lib/util.go | 8 1 file changed, 8 deletions(-) diff --git a/client/lib/util.go b/client/lib/util.go index

[tor-commits] [snowflake/master] Update a comment (no signal pipe anymore).

2020-04-23 Thread dcf
commit 65ecb798ca8842a431214c2aa5133620e576c5f3 Author: David Fifield Date: Thu Apr 23 20:36:55 2020 -0600 Update a comment (no signal pipe anymore). --- client/lib/webrtc.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/lib/webrtc.go

[tor-commits] [snowflake/master] Restore `go 1.13` to go.mod, lost in the turbotunnel merge.

2020-04-23 Thread dcf
commit 2f52217d2f62e61a05ea265257d2229410f79732 Author: David Fifield Date: Thu Apr 23 17:08:49 2020 -0600 Restore `go 1.13` to go.mod, lost in the turbotunnel merge. --- go.mod | 2 ++ 1 file changed, 2 insertions(+) diff --git a/go.mod b/go.mod index 6502651..07c49a2 100644 ---

[tor-commits] [snowflake/master] Use a global RedialPacketConn and smux.Session.

2020-04-23 Thread dcf
commit 2022496d3b6fc76b7725135758c37d7d49546d3d Author: David Fifield Date: Wed Mar 18 18:00:44 2020 -0600 Use a global RedialPacketConn and smux.Session. This allows multiple SOCKS connections to share the available proxies, and in particular prevents a SOCKS connection from

[tor-commits] [snowflake/master] Turbo Tunnel client and server.

2020-04-23 Thread dcf
commit 70126177fbdf5b1fa4977f2fc26f624641708098 Author: David Fifield Date: Tue Jan 28 02:32:02 2020 -0700 Turbo Tunnel client and server. The client opts into turbotunnel mode by sending a magic token at the beginning of each WebSocket connection (before sending even the

[tor-commits] [snowflake/master] Import Turbo Tunnel support code.

2020-04-23 Thread dcf
=7eb94209f857fc71c2155907b0462cc587fc76cc https://github.com/net4people/bbs/issues/21 RedialPacketConn is adapted from clientPacketConn in https://dip.torproject.org/dcf/obfs4/blob/c64a61c6da3bf1c2f98221bb1e1af8a358f22b87/obfs4proxy/turbotunnel_client.go https://github.com/net4people/bbs/issues/14

[tor-commits] [snowflake/master] Immediately and unconditionally grant new SOCKS connections.

2020-04-23 Thread dcf
commit ee2fb42d33ea105995adfc84d2be47a9d6dfc97f Author: David Fifield Date: Thu Jan 30 23:49:41 2020 -0700 Immediately and unconditionally grant new SOCKS connections. --- client/lib/snowflake.go | 10 +- client/snowflake.go | 8 2 files changed, 9 insertions(+), 9

[tor-commits] [snowflake/master] USERADDR support for turbotunnel sessions.

2020-04-23 Thread dcf
commit 0790954020b550f5d5351d9e54b108c9d357fa50 Author: David Fifield Date: Tue Feb 4 22:27:58 2020 -0700 USERADDR support for turbotunnel sessions. The difficulty here is that the whole point of turbotunnel sessions is that they are not necessarily tied to a single WebSocket

[tor-commits] [snowflake/master] Let copyLoop exit when either direction finishes.

2020-04-23 Thread dcf
commit 904af9cb8aa6aa25e094da1c025c7afed55d46ea Author: David Fifield Date: Fri Feb 21 14:47:34 2020 -0700 Let copyLoop exit when either direction finishes. Formerly we waiting until *both* directions finished. What this meant in practice is that when the remote connection

[tor-commits] [snowflake/master] Remove uniuri dependency.

2020-04-03 Thread dcf
commit 8eef3b63482deb50d988e3703b7a718802cdd2f1 Author: David Fifield Date: Thu Apr 2 13:51:06 2020 -0600 Remove uniuri dependency. https://bugs.torproject.org/33800 --- client/lib/webrtc.go | 11 +-- go.mod | 1 - go.sum | 2 -- 3 files

[tor-commits] [snowflake/master] Update GitHub issue numbers to Trac ticket numbers.

2020-04-02 Thread dcf
commit 237fed1151f900c08edf83441cb2edebf8743978 Author: David Fifield Date: Thu Apr 2 12:36:09 2020 -0600 Update GitHub issue numbers to Trac ticket numbers. --- client/lib/rendezvous.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/lib/rendezvous.go

[tor-commits] [snowflake/master] Remove the now-unused appengine directory.

2020-02-29 Thread dcf
commit 125e71fa6ee27a929438dafc82bba1ddc0172814 Author: David Fifield Date: Sat Feb 29 17:29:28 2020 -0700 Remove the now-unused appengine directory. https://bugs.torproject.org/33429 --- .travis.yml | 1 - appengine/.gcloudignore | 25 --- appengine/README

[tor-commits] [snowflake/master] Update appengine for the Go 1.11 runtime.

2020-02-23 Thread dcf
commit c2a12c25d1dd740b055aff736379a4a0c45b51d6 Author: David Fifield Date: Mon Feb 24 00:15:54 2020 -0700 Update appengine for the Go 1.11 runtime. https://cloud.google.com/appengine/docs/standard/go111/go-differences This is untested, because I wasn't actually able to deploy

[tor-commits] [snowflake/master] In server, treat a client IP address of 0.0.0.0 as missing.

2020-02-22 Thread dcf
commit c124e8c643f2de5730af9079d326b9cabc3b264a Author: David Fifield Date: Wed Feb 19 10:44:35 2020 -0700 In server, treat a client IP address of 0.0.0.0 as missing. Some proxies currently send ?client_ip=0.0.0.0 because of an error in how they attempt to grep the address

[tor-commits] [snowflake/master] Close internal Pipes in websocketconn.Conn Close.

2020-02-18 Thread dcf
commit 380b133155ad725126bc418d0e66b3c550b4c555 Author: David Fifield Date: Tue Feb 18 14:10:47 2020 -0700 Close internal Pipes in websocketconn.Conn Close. Unless something externally called Write after Close, the writeLoop(ws, pr2) goroutine would run forever, because

[tor-commits] [snowflake/master] Simplify a conditional.

2020-02-04 Thread dcf
commit ca9ae12c383405bc9a755e1bc902e9755495c1f1 Author: David Fifield Date: Tue Feb 4 22:35:12 2020 -0700 Simplify a conditional. --- server/server.go | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/server/server.go b/server/server.go index 85bf4f5..c484a19 100644

[tor-commits] [snowflake/master] websocketconn tests.

2020-02-04 Thread dcf
commit 5708a1d57b53d6d586d0e98be9a0b5a964e7c6c3 Author: David Fifield Date: Mon Feb 3 12:06:08 2020 -0700 websocketconn tests. https://bugs.torproject.org/33144 --- common/websocketconn/websocketconn_test.go | 235 + 1 file changed, 235 insertions(+)

[tor-commits] [snowflake/master] Implement net.Conn for websocketconn.Conn.

2020-02-04 Thread dcf
commit 256959ca65949fe5b012680b4f0235401cd9 Author: David Fifield Date: Mon Feb 3 13:22:03 2020 -0700 Implement net.Conn for websocketconn.Conn. We had already implemented Read, Write, and Close. Pass RemoteAddr, LocalAddr, SetReadDeadline, and SetWriteDeadline through to

[tor-commits] [snowflake/master] Rewrite websocketconn with synchronous pipes.

2020-02-04 Thread dcf
commit 01e28aa4604fea7a2af0259c8b18be1bd5f9b3d7 Author: David Fifield Date: Mon Feb 3 12:31:00 2020 -0700 Rewrite websocketconn with synchronous pipes. Makes the following changes: * permits concurrent Read/Write/Close * converts certain CloseErrors into io.EOF

[tor-commits] [snowflake/master] Remove unused maxMessageSize constant.

2020-01-30 Thread dcf
commit 564d1c83634f26341c423815387e728f14c0e61d Author: David Fifield Date: Fri Jan 31 00:15:11 2020 -0700 Remove unused maxMessageSize constant. --- server/server.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/server/server.go b/server/server.go index 5d3bfc6..85bf4f5 100644 ---

[tor-commits] [snowflake/master] Make timeout constants into time.Duration values.

2020-01-30 Thread dcf
commit a2292ce35be6ba4b63e7c8dbac8b3c7bc220822a Author: David Fifield Date: Tue Dec 24 18:39:43 2019 -0700 Make timeout constants into time.Duration values. This slightly changes some log messages. --- client/lib/snowflake.go | 5 +++-- client/lib/webrtc.go| 10 +-

[tor-commits] [snowflake/master] Remove some redundancy in websocketconn naming.

2020-01-30 Thread dcf
commit e47dd5e2b44161b6699ca6560878ddc9730a63b1 Author: David Fifield Date: Tue Jan 28 00:54:26 2020 -0700 Remove some redundancy in websocketconn naming. Rename websocketconn.WebSocketConn to websocketconn.Conn, and websocketconn.NewWebSocketConn to websocketconn.New

[tor-commits] [snowflake/master] Initialize the global upgrader.CheckOrigin statically.

2020-01-30 Thread dcf
commit 5b01df903085fbba96e52277e598c395bce27d88 Author: David Fifield Date: Tue Jan 28 00:09:38 2020 -0700 Initialize the global upgrader.CheckOrigin statically. Only once, not again on every call to initServer. --- server/server.go | 6 +++--- 1 file changed, 3 insertions(+), 3

[tor-commits] [snowflake/master] Have websocketconn.New return a pointer.

2020-01-30 Thread dcf
commit 20ac2029fd671ccfa8af240fe9c91d9653715ebc Author: David Fifield Date: Tue Jan 28 02:37:10 2020 -0700 Have websocketconn.New return a pointer. This makes the return type satisfy the io.ReadWriteCloser interface directly. --- common/websocketconn/websocketconn.go | 4 ++--

[tor-commits] [snowflake/master] Allow handling multiple SOCKS connections simultaneously.

2020-01-30 Thread dcf
commit dfb83c6606fe129d57f101d837ebe32133d79c61 Author: David Fifield Date: Tue Jan 28 03:10:54 2020 -0700 Allow handling multiple SOCKS connections simultaneously. Close the SOCKS connection in the same function that opens it. --- client/lib/snowflake.go | 1 -

[tor-commits] [snowflake/master] Also show message in the "error copying WebSocket to ORPort" case.

2020-01-30 Thread dcf
commit a4287095c05addaa204c605c691f147da477c2f5 Author: David Fifield Date: Thu Jan 30 10:15:12 2020 -0700 Also show message in the "error copying WebSocket to ORPort" case. This was the only case out of the three not to show it. --- server/server.go | 2 +- 1 file changed, 1

[tor-commits] [snowflake/master] Remove client test with nil broker

2020-01-29 Thread dcf
commit 50673d49437c55aba2a5f7f31819bcae60406b07 Author: Cecylia Bocovich Date: Wed Jan 29 11:40:29 2020 -0500 Remove client test with nil broker We are no longer checking for nil BrokerChannels in Catch because this case is caught from the return values of NewBrokerChannel.

[tor-commits] [snowflake/master] Update client tests for NewBrokerChannel errors

2020-01-29 Thread dcf
commit 7682986a451deb3a4d28240fa7d8b06ed5d7a5dd Author: Cecylia Bocovich Date: Wed Jan 29 11:27:44 2020 -0500 Update client tests for NewBrokerChannel errors We changed NewBrokerChannel to return an error value on failure. This updates the tests to check that value. ---

  1   2   3   4   5   6   7   8   9   10   >