Re: [tor-dev] [patch] properly test for OPENSSL_NO_COMP

2014-07-13 Thread grarpamp
On Sun, Jul 13, 2014 at 7:23 PM, Ian Goldberg wrote: > On Sun, Jul 13, 2014 at 07:20:29PM -0400, grarpamp wrote: >> >/* Don't actually allow compression; it uses ram and time, but the data >> > * we transmit is all encrypted anyway. */ >> > result->ctx->comp_methods = NULL; >> >> This

Re: [tor-dev] [patch] properly test for OPENSSL_NO_COMP

2014-07-13 Thread Ian Goldberg
On Sun, Jul 13, 2014 at 07:20:29PM -0400, grarpamp wrote: > >/* Don't actually allow compression; it uses ram and time, but the data > > * we transmit is all encrypted anyway. */ > > result->ctx->comp_methods = NULL; > > This comment is confusing. Why are you asserting/mixing the two

Re: [tor-dev] [patch] properly test for OPENSSL_NO_COMP

2014-07-13 Thread grarpamp
>/* Don't actually allow compression; it uses ram and time, but the data > * we transmit is all encrypted anyway. */ > result->ctx->comp_methods = NULL; This comment is confusing. Why are you asserting/mixing the two with the ', but' that 'encryption anyway' is excuse to not compress

[tor-dev] [patch] properly test for OPENSSL_NO_COMP

2014-07-13 Thread Pascal Stumpf
LibreSSL has removed compression support. Tor should check for the OPENSSL_NO_COMP define before trying to disable compression at runtime. diff --git a/src/common/tortls.c b/src/common/tortls.c index e06a2ae..0f98968 100644 --- a/src/common/tortls.c +++ b/src/common/tortls.c @@ -1314,10 +1314,12

[tor-dev] [GSoC] BridgeDB Twitter Distributor report

2014-07-13 Thread Kostas Jakeliunas
Hi all, preferring existing code over shiny code and being mad late, I * (re)wrote a simple but working churn control mechanism[1], which uses * a general persistable storage system: * in particular, the bot now has a central storage controller which takes care of storage handlers which