Re: [tor-dev] Tor's default behavior for ed25519 identities

2015-08-05 Thread Nick Mathewson
On Tue, Aug 4, 2015 at 8:24 PM, s7r wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 8/4/2015 5:42 PM, Nick Mathewson wrote: >> Hi, s7r! >> >> This is an impressive writeup; thanks! >> >> One thing that makes it hard for me to follow this document is >> that I'm not sure which par

Re: [tor-dev] Relay Dashboard Code Review

2015-08-05 Thread Cristobal
On 05/08/15 15:21, meejah wrote: > > BTW, where is this code coming from? I looked on github but only see the > proposal stuf (which is using Tornado not Cyclone, so I'm guessing > that's not the right stuff?) > Hi! Thank you both Damian and meejah for your comments! I'll review your feedback a

Re: [tor-dev] Relay Dashboard Code Review

2015-08-05 Thread teor
> On 6 Aug 2015, at 02:53 , Damian Johnson wrote: > > > client/templates/index.html > > > 10 href="http://fonts.googleapis.com/css?family=Open+Sans:400italic,600italic,400,

Re: [tor-dev] Is anyone using tor-fw-helper? (Was Re: BOINC-based Tor wrapper)

2015-08-05 Thread Yawning Angel
Just to touch base on this, and to give a rough status of where things are. The tor codebase no longer includes the C tor-fw-helper as of: d2cb92332009567ae778b3570e8fd3420c207446 Closes https://trac.torproject.org/projects/tor/ticket/13338 The new (Go based code) now lives at: https://g

Re: [tor-dev] Relay Dashboard Code Review

2015-08-05 Thread meejah
Sorry for the noise, I found the code ("develop" branch of https://github.com/leivaburto/rwsd) and add a couple more comments: 1. The "WEBSOCKETS" global seems like it wants to be a class instead: you've basically got a bunch of static functions (add_websocket, etc) that manipulate a global vari

Re: [tor-dev] Relay Dashboard Code Review

2015-08-05 Thread meejah
BTW, where is this code coming from? I looked on github but only see the proposal stuf (which is using Tornado not Cyclone, so I'm guessing that's not the right stuff?) ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproject.org/cg

Re: [tor-dev] Relay Dashboard Code Review

2015-08-05 Thread Damian Johnson
>> def get_websockets(ws_type = None): >> websocket = WEBSOCKETS.get(ws_type, []) >> return websocket if websocket else None > > How about just: > > def get_websockets(ws_type=None): > return WEBSOCKETS.get(ws_type, None) Thanks meejah for the additional feedback! For this la

Re: [tor-dev] Relay Dashboard Code Review

2015-08-05 Thread meejah
Damian Johnson writes: > Very minor thing, but little odd using dict() that way. Personally, I don't find it that odd ;) and prefer it since braces can define sets or dicts in Python, and using dict(...) makes it a little more explicit. BTW, your counter-example is a syntax error; you need to q

[tor-dev] Relay Dashboard Code Review

2015-08-05 Thread Damian Johnson
Hi Cristobal, again apologies for the delay in getting you feedback. Just gave RWSD a whirl and worked great - nice work! >From a UI perspective only feedback on what we have so far is... * Both graphs just have the title of 'Graph component'. Better would be to say if it's inboud or outbou

[tor-dev] simple onionoo patch

2015-08-05 Thread firebrand
Hi, I have submitted a small patch some time ago to fix some issues in onionoo. Could someone have a look? https://trac.torproject.org/projects/tor/ticket/16626 ** firebrand ___ tor-dev mailing list tor-dev@lists.torproject.org https://lists.torproje