On Fri, Jun 23, 2017 at 10:00:28AM -0400, David Goulet wrote:
> Yes. Overlap period is between 00:00 and 12:00 UTC. This is the if condition
> being used:
>
> if (valid_after_tm.tm_hour > 0 && valid_after_tm.tm_hour < 12) { ...
Shouldn't that be
if (valid_after_tm.tm_hour >= 0 &&
On Fri, Jun 23, 2017 at 9:29 AM, Nick Mathewson wrote:
> On Thu, Jun 22, 2017 at 10:49 PM, wrote:
>> I noticed tor sometimes exits 0 on error
>> [...]
>> When to exit 0 on error?
>
> When the error is unrecoverable, and continuing would be worse then
On 21 Jun (11:40:39), teor wrote:
> Hi,
Hello teor!
Sorry for the delay!
>
> The time period overlap section 2.2.4 in prop224 is under-specified:
> https://gitweb.torproject.org/torspec.git/tree/proposals/224-rend-spec-ng.txt#n821
>
> 1. During the overlap period, does the service use the new
On Thu, Jun 22, 2017 at 10:49 PM, wrote:
> I noticed tor sometimes exits 0 on error, specifically in
> monitor_owning_controller_process in src/or/control.c:
>
> if (owning_controller_process_monitor == NULL) {
> log_err(LD_BUG, "Couldn't create process-termination
I noticed tor sometimes exits 0 on error, specifically in
monitor_owning_controller_process in src/or/control.c:
if (owning_controller_process_monitor == NULL) {
log_err(LD_BUG, "Couldn't create process-termination monitor for "
"owning controller: %s. Exiting.",