Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-15 Thread David Fifield
On Thu, Jan 15, 2015 at 02:29:28PM +0100, Philipp Winter wrote: > On Mon, Jan 12, 2015 at 08:24:58PM +0100, Tom van der Woerdt wrote: > > Interestingly, that paints a completely different picture. I added > > that line to two machines (guard+exit) and after a few minutes : > > > > # cat /var/lib/t

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-15 Thread Philipp Winter
On Mon, Jan 12, 2015 at 08:24:58PM +0100, Tom van der Woerdt wrote: > Interestingly, that paints a completely different picture. I added > that line to two machines (guard+exit) and after a few minutes : > > # cat /var/lib/tor/node*/infolog | grep Negotiated | awk '{ print $8 > }' | sort | uniq -d

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-12 Thread Tom van der Woerdt
Philipp Winter schreef op 12/01/15 om 20:14: On Mon, Jan 12, 2015 at 06:57:01PM +0100, Tom van der Woerdt wrote: 23% is a lot though - so high that I really doubt it's true. The ratios between handshakes and deduplicated handshakes is also rather strange. Is there anything we can do to the datas

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-12 Thread Philipp Winter
On Mon, Jan 12, 2015 at 06:57:01PM +0100, Tom van der Woerdt wrote: > 23% is a lot though - so high that I really doubt it's true. The > ratios between handshakes and deduplicated handshakes is also rather > strange. Is there anything we can do to the dataset to find out why > the amount is so high

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-12 Thread Tom van der Woerdt
David Fifield schreef op 12/01/15 om 18:46: On Mon, Jan 12, 2015 at 06:26:14PM +0100, Tom van der Woerdt wrote: On 12 Jan 2015, at 16:25, Philipp Winter wrote: Versions | Amount total | Amount w/o duplicate hosts -+---+--- 1 and 2 | 34,648 (

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-12 Thread David Fifield
On Mon, Jan 12, 2015 at 06:26:14PM +0100, Tom van der Woerdt wrote: > > On 12 Jan 2015, at 16:25, Philipp Winter wrote: > > Versions | Amount total | Amount w/o duplicate hosts > > -+---+--- > > 1 and 2 | 34,648 (9%) | 21,552 (23%) > > We debugge

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-12 Thread Tom van der Woerdt
> On 12 Jan 2015, at 16:25, Philipp Winter wrote: > >> On Sat, Dec 27, 2014 at 03:38:28PM +0100, Tom van der Woerdt wrote: >> After reading the Tor spec [1] I did some digging and realized that >> the old handshakes and link protocols (v1 (certs up-front) and v2 >> (renegotiation)) are not used

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-12 Thread David Fifield
On Mon, Jan 12, 2015 at 04:25:56PM +0100, Philipp Winter wrote: > On Sat, Dec 27, 2014 at 03:38:28PM +0100, Tom van der Woerdt wrote: > > After reading the Tor spec [1] I did some digging and realized that > > the old handshakes and link protocols (v1 (certs up-front) and v2 > > (renegotiation)) ar

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-12 Thread Philipp Winter
On Sat, Dec 27, 2014 at 03:38:28PM +0100, Tom van der Woerdt wrote: > After reading the Tor spec [1] I did some digging and realized that > the old handshakes and link protocols (v1 (certs up-front) and v2 > (renegotiation)) are not used anymore as of 0.2.3.6-alpha which > introduced link proto v3.

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-02 Thread grarpamp
On Fri, Jan 2, 2015 at 12:39 PM, Tom van der Woerdt wrote: >>Now, maybe we _should_ drop support for versions before >> 0.2.3.17-beta as well. If so, we can rip out even more code. (And >> that might be a good idea.) What do people on the list think? X Fabio: X The cleaner, the better! > I

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-02 Thread Tom van der Woerdt
Nick Mathewson schreef op 02/01/15 om 15:27: On Mon, Dec 29, 2014 at 3:33 PM, Tom van der Woerdt wrote: Sounds good! I spent some time writing a patch that removes v1 of the link protocol from both the server and client, and so far it seems to work nicely: the code compiles nicely, all test c

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-02 Thread Fabio Pietrosanti (naif) - lists
On 1/2/15 3:27 PM, Nick Mathewson wrote: > Now, maybe we _should_ drop support for versions before > 0.2.3.17-beta as well. If so, we can rip out even more code. (And > that might be a good idea.) What do people on the list think? The cleaner, the better! Fabio

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2015-01-02 Thread Nick Mathewson
On Mon, Dec 29, 2014 at 3:33 PM, Tom van der Woerdt wrote: > > Sounds good! > > I spent some time writing a patch that removes v1 of the link protocol from > both the server and client, and so far it seems to work nicely: the code > compiles nicely, all test cases pass, and the resulting binary ha

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2014-12-29 Thread Tom van der Woerdt
Nick Mathewson schreef op 29/12/14 om 00:50: On Sat, Dec 27, 2014 at 9:38 AM, Tom van der Woerdt wrote: Hi all, After reading the Tor spec [1] I did some digging and realized that the old handshakes and link protocols (v1 (certs up-front) and v2 (renegotiation)) are not used anymore as of 0.2.

Re: [tor-dev] Is it time to drop support for the v1/v2 protos?

2014-12-28 Thread Nick Mathewson
On Sat, Dec 27, 2014 at 9:38 AM, Tom van der Woerdt wrote: > Hi all, > > After reading the Tor spec [1] I did some digging and realized that the old > handshakes and link protocols (v1 (certs up-front) and v2 (renegotiation)) > are not used anymore as of 0.2.3.6-alpha which introduced link proto v

[tor-dev] Is it time to drop support for the v1/v2 protos?

2014-12-27 Thread Tom van der Woerdt
Hi all, After reading the Tor spec [1] I did some digging and realized that the old handshakes and link protocols (v1 (certs up-front) and v2 (renegotiation)) are not used anymore as of 0.2.3.6-alpha which introduced link proto v3. Supporting v1 and v2 requires (among other things) supportin