isis agora lovecruft wrote:
Thanks for the bug report and the patch! I've made #25479 [0] for this.
Can I ask what version of Windows you were running the benchmarks on?
Windows-10 (v1701). 64-bit.
It seems like it might possibly have been due to differences in behaviours
between
Gisle Vanem transcribed 1.0K bytes:
> I wrote:
>
> >Seems bench.c uses some mutex which is not initialised
> >with 'tor_mutex_init()'. I fail to see which that should
> >be.
>
> With this patch, I no longer get that crash:
>
> --- a/bench.c 2018-01-25 20:15:13
> +++ b/bench.c 2018-03-13
I wrote:
Seems bench.c uses some mutex which is not initialised
with 'tor_mutex_init()'. I fail to see which that should
be.
With this patch, I no longer get that crash:
--- a/bench.c 2018-01-25 20:15:13
+++ b/bench.c 2018-03-13 12:38:09
@@ -713,6 +713,8 @@
printf("Couldn't seed RNG;
There is a crash in bench.exe. Running 'cdb -c g bench.exe':
ntdll!RtlpWaitOnCriticalSection+0x6b:
77a9cfd6 ff4014 inc dword ptr [eax+14h] ds:002b:0014=
ChildEBP RetAddr
0137f750 77aba38a ntdll!RtlpWaitOnCriticalSection+0x6b
0137f770 77aba259
