Re: [tor-dev] PRELIMINARY: [PATCH 3/3] Replace 'TorDNSEL.System.Timeout' with 'System.Timeout'.

2013-07-26 Thread Lunar
Nikita Karetnikov: Using `git blame` or `git log -S` or `git log -G` will actually work better than a file by file summary. If you throw in the `-M` option, it'll work accross renames, for examples. OK. But that information will be lost if we decide to change a VCS for some reason.

Re: [tor-dev] PRELIMINARY: [PATCH 3/3] Replace 'TorDNSEL.System.Timeout' with 'System.Timeout'.

2013-07-25 Thread Nikita Karetnikov
Sorry for being slow to get to your patches. No problem. I'm glad that someone is actually interested in that. An overall comment: I am unconvinced about commit messages that details obvious changes for each impacted file. Well, I agree. However, even obvious changes might be useful in the

Re: [tor-dev] PRELIMINARY: [PATCH 3/3] Replace 'TorDNSEL.System.Timeout' with 'System.Timeout'.

2013-07-25 Thread Lunar
Nikita Karetnikov: Well, I agree. However, even obvious changes might be useful in the long term. The GNU Coding Standards, which I use as a guide, suggest the following: Subsequent maintainers will often search for a function name to find all the change log entries that pertain to it... [1]

Re: [tor-dev] PRELIMINARY: [PATCH 3/3] Replace 'TorDNSEL.System.Timeout' with 'System.Timeout'.

2013-07-25 Thread Nikita Karetnikov
Using `git blame` or `git log -S` or `git log -G` will actually work better than a file by file summary. If you throw in the `-M` option, it'll work accross renames, for examples. OK. But that information will be lost if we decide to change a VCS for some reason. Why not put what you wrote