[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

SRU proposal for Wily (extended with fix to bug #1532722) ** Patch added: "wily_ifupdown_0.7.54ubuntu3.debdiff" https://bugs.launchpad.net/ubuntu/+source/ifupdown/+bug/1337873/+attachment/4548423/+files/wily_ifupdown_0.7.54ubuntu3.debdiff -- You received this bug notification because you

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

SRU proposal for Trusty (extended with fix to bug #1532722) ** Patch added: "trusty_ifupdown_0.7.47.2ubuntu4.3.debdiff" https://bugs.launchpad.net/ubuntu/+source/ifupdown/+bug/1337873/+attachment/4548422/+files/trusty_ifupdown_0.7.47.2ubuntu4.3.debdiff -- You received this bug notification

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Since per-interface locking landed in Xenial, we've been getting crashes, see bug 1532722. Until this is fixed, I'm marking this as v-failed. We'll then need to update the SRU with this fix as well. ** Tags removed: verification-done ** Tags added: verification-failed -- You received this bug

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

I have verified both Trusty and Wily. The verification was automated cyclic rebooting of a VM containing 3 NICs - 2 of them were used in bonding in active-backup. Before the fix has been implemented this test failed with some interfaces uninitialized or the bonding mode being wrong (the default

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Changed in: ifupdown (Ubuntu Wily) Importance: Undecided => Medium ** Changed in: ifenslave (Ubuntu) Importance: Undecided => Medium ** Changed in: ifenslave (Ubuntu Precise) Importance: Undecided => Medium ** Changed in: ifenslave (Ubuntu Trusty) Importance: Undecided => Medium

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Hello Rafael, or anyone else affected, Accepted ifupdown into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ifupdown/0.7.54ubuntu1.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Hello Rafael, or anyone else affected, Accepted ifenslave into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ifenslave/2.4ubuntu1.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Hello Rafael, or anyone else affected, Accepted ifupdown into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ifupdown/0.7.47.2ubuntu4.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

I sponsored the trusty and wily patches. ** Also affects: ifupdown (Ubuntu Wily) Importance: Undecided Status: New ** Changed in: ifupdown (Ubuntu Vivid) Status: Confirmed => Won't Fix ** Changed in: ifupdown (Ubuntu Wily) Status: New => In Progress ** Changed in:

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Setting precise tasks to "wontfix", this is too complex to backport and the bug is not nearly important enough to risk regressions due to too invasive backports. ** Changed in: ifenslave (Ubuntu Precise) Status: New => Won't Fix ** Changed in: ifupdown (Ubuntu Precise) Status:

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Sponsored the patch for xenial. Let's give this some maturing there first. ** Changed in: ifupdown (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu.

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

(unsubscribing sponsors for now then, please subscribe them back after getting some feedback from the xenial update) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu. https://bugs.launchpad.net/bugs/1337873

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

This bug was fixed in the package ifupdown - 0.7.54ubuntu2 --- ifupdown (0.7.54ubuntu2) xenial; urgency=medium * Per-interface hierarchical locking. Backported from Debian git head. (LP: #1337873, Closes: #753755) -- Dariusz Gadomski Thu, 10

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Adding SRU proposal for Xenial. ** Patch added: "xenial_ifupdown_0.7.54ubuntu2.debdiff" https://bugs.launchpad.net/ubuntu/+source/ifupdown/+bug/1337873/+attachment/4515989/+files/xenial_ifupdown_0.7.54ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Changed in: ifupdown (Ubuntu) Importance: Undecided => Medium ** Changed in: ifupdown (Ubuntu Precise) Importance: Undecided => Medium ** Changed in: ifupdown (Ubuntu Trusty) Importance: Undecided => Medium ** Changed in: ifupdown (Ubuntu Vivid) Importance: Undecided => Medium

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Adding SRU proposal for wily. ** Description changed: + [Impact] + + * A lack of proper synchronization in ifupdown causes a race condition + resulting in occasional incorrect network interface initialization (e.g. + in bonding case - wrong bonding settings, network unavailable because +

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Adding SRU proposal for Vivid. ** Patch added: "vivid_ifupdown_0.7.48.1ubuntu11.debdiff" https://bugs.launchpad.net/ubuntu/+source/ifupdown/+bug/1337873/+attachment/4501798/+files/vivid_ifupdown_0.7.48.1ubuntu11.debdiff -- You received this bug notification because you are a member of

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Adding SRU proposal for Trusty (to make ifenslave compatible with ifupdown changes). ** Patch added: "trusty_ifenslave_2.4ubuntu1.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/ifupdown/+bug/1337873/+attachment/4501800/+files/trusty_ifenslave_2.4ubuntu1.2.debdiff -- You received this

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Adding SRU proposal for Trusty. ** Patch added: "trusty_ifupdown_0.7.47.2ubuntu4.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/ifupdown/+bug/1337873/+attachment/4501799/+files/trusty_ifupdown_0.7.47.2ubuntu4.2.debdiff -- You received this bug notification because you are a member of

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Description changed: [Impact] - * A lack of proper synchronization in ifupdown causes a race condition +  * Lack of proper synchronization in ifupdown causes a race condition resulting in occasional incorrect network interface initialization (e.g. in bonding case - wrong bonding

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ifupdown (Ubuntu Precise) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu.

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ifupdown (Ubuntu Vivid) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu.

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ifupdown (Ubuntu Trusty) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu.

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Also affects: ifupdown (Ubuntu Vivid) Importance: Undecided Status: New ** Also affects: ifupdown (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: ifupdown (Ubuntu Precise) Importance: Undecided Status: New -- You received this bug

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Changed in: ifupdown (Ubuntu) Assignee: (unassigned) => Dariusz Gadomski (dgadomski) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu. https://bugs.launchpad.net/bugs/1337873 Title: Precise,

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Changed in: ifupdown (Ubuntu) Assignee: Rafael David Tinoco (inaddy) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu. https://bugs.launchpad.net/bugs/1337873 Title: Precise,

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Im getting back to this after sometime. After the discussion was brought to upstream we did not get feedback regarding proposed changes but investigating further it is clear that ifupdown is suffering from race conditions that cannot be solved simply by creating: 1) big lock - since its

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Tags added: cts -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu. https://bugs.launchpad.net/bugs/1337873 Title: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

(unsubscribing ~ubuntu-sponsors per comment #13, please re-subscribe when patches are ready) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to ifupdown in Ubuntu. https://bugs.launchpad.net/bugs/1337873 Title: Precise,

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

I have introduced one big lock for ifupdown. The ifup, ifdown or ifquery commands cannot be run simultaneously. Since SEVERAL ifupdown pre/post scripts do need to make reentrant calls do these commands I created on environment variable that disabled the locking when reentrant calls are made to

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Let's try everything again from the beggining but now with a fixed ifupdown version (no race conditions between upstart and sysv scripts ). My interfaces file will be exactly the same as the one proposed for ifenslave examples: --- auto eth1 iface eth1 inet manual bond-master bond0 auto eth2

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

And you can check that upstart got deadlocked: --- root@provisioned:~# ps -ef | grep ifup root 618 1 0 10:21 ?00:00:00 ifup --allow auto eth2 root 619 1 0 10:21 ?00:00:00 ifup --allow auto eth1 root 620 1 0 10:21 ?00:00:00 ifup --allow auto

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

YES! --- root@provisioned:~# pstree -a ... ├─ifup --allow auto eth2 │ └─sh -c run-parts /etc/network/if-pre-up.d │ └─run-parts /etc/network/if-pre-up.d │ └─ifenslave /etc/network/if-pre-up.d/ifenslave │ └─sleep 0.1 --- One slave interface, eth2 in this case, got

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

Checking Ubuntu bzr tree... --- inaddy@trusty.00064811:/bugs/00064811/sources/bazaar/ubuntu/$ git clone bzr::lp:ubuntu/ifenslave Cloning into 'ifenslave'... Most recent Ubuntu version: 3 Packaging branch version: 2.5ubuntu1 Packaging branch status: OUT-OF-DATE Most recent Ubuntu version: 3

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

After talking to Stéphane Graber, from Ubuntu Core Foundations Team, we decided that I should implement independent locking for every interface (like I have already proposed to Debian upstream project) and to implement locking mechanisms for dependent interfaces inside the hooks. So: 1) ifupdown

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

** Description changed: - It was brought to my attention (by others) that ifupdown runs into race - conditions on some specific cases. - - [Impact] - - When trying to deploy many servers at once (higher chances of happening) - or from time-to-time, like any other intermittent race-condition. -

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

CORRECT WAY OF SETTING INTERFACES FILE FOR BONDING: 1) This model has race conditions. 2) YOU HAVE to have both scripts running (networking and network-interfaces) # /etc/network/interfaces auto lo iface lo inet loopback auto eth0 iface eth0 inet dhcp auto eth1 iface eth1 inet manual

[Touch-packages] [Bug 1337873] Re: Precise, Trusty, Utopic - ifupdown initialization problems caused by race condition

This bug is being fixed upstream together with the developer. I'll provide the fix here as soon as it gets accepted upstream: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753755 Thank you. ** Patch removed: ifupdown_0.7.47.2ubuntu4.2~lp1337873.diff